November 2016 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]
by GitHub Nov. 16, 2016

Nov. 16, 2016

Branch: refs/tags/60294 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 2b8615: 60294
by GitHub Nov. 16, 2016

Nov. 16, 2016

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 2b86153bbfb9d61f8f097609c911674c0aaf2135 https://github.com/pharo-project/pharo-core/commit/2b86153bbfb9d61f8f097609… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-11-16 (Wed, 16 Nov 2016) Changed paths: M Flashback-Decompiler.package/FBDDecompiler.class/instance/initialize/pragmasForMethod_.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60293.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60294.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60293.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60294.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M System-Settings.package/SettingBrowser.class/class/accessing/settingsKeywords.st M System-Settings.package/SettingTreeBuilder.class/instance/accessing/buildPragma_.st Log Message: ----------- 60294 19347 SettingBrowser>>#settingsKeywords uses #selector instead of #keyword in Pragma access https://pharo.fogbugz.com/f/cases/19347 19345 revert FBDDecompiler>>#pragmasForMethod: https://pharo.fogbugz.com/f/cases/19345 http://files.pharo.org/image/60/60294.zip

1 0

Re: [Pharo-dev] [squeak-dev] Pragma keyword / selector / methodSelector
by Tobias Pape Nov. 15, 2016

Nov. 15, 2016

On 15.11.2016, at 22:08, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > 2016-11-15 21:58 GMT+01:00 Tobias Pape <Das.Linux(a)gmx.de>: > Here's my 2ct: > > 1. Pragmas aren't actually pragmas. They do not instruct the compiler to do things (_except_ for primitive: and apicall:, but these are now outliers). > They rather add metadata to a (compiled) method. > 2. The 'thing' (ie, class) should probably be named > MethodAnnotation > 3. We can have the cake and eat it to: > > Rename Pragma -> MethodAnnotation. > Make Pragma a new subclass of MethodAnnotation. > Make MethodAnnotation implement > #methodSelector > #annotationSelector (or #selector, if it must be) > Make Pragma implement > #selector > #keywords > > I remember long discussion about Pragma vs Annotation name where Igor won completely :)). Conclusion was that Pragma is a right name. The German wiktionary is more on the compiler-side: * Pragma: eine Steueranweisung im Quellcode fÃ¼r einen Compiler oder einen Interpreter, die den Programmablauf nicht direkt beeinflusst, die aber Auswirkungen auf bestimmte ÃberprÃ¼fungen des Quellcodes hat (Control statment for compiler/interpreter that does not directly change control flow but has effect on code checking)â¦ Sources for this usage: * âEin Pragma - auch Pseudo-lnstruktion genannt - leitet einfach Informationen an den Compiler weiter und wird nicht zu einem Teil des ausfÃ¼hrbaren Programms.â [Steven Feuerstein, Bill Pribyl: Oracle PL/SQL Programmierung (Safari Books Online), 2. Auflage 2003, ISBN 389721184X, Seite 85] (a pragma - aka pseudo instruction - directs simple information to the compiler and _will not be part_ of the executable) (emphasis mine) English wiktionary likewise: â¢ (computing, programming) A compiler directive; data embedded in source code by programmers to indicate some intention to the compiler. This pragma stops the compiler from generating those warnings we don't care about. And also wikipedia: https://en.wikipedia.org/wiki/Directive_(programming) Â¯\_(ã)_/Â¯ Best regards -Tobias

1 0

Re: [Pharo-dev] [squeak-dev] Pragma keyword / selector / methodSelector
by Tobias Pape Nov. 15, 2016

Nov. 15, 2016

Here's my 2ct: 1. Pragmas aren't actually pragmas. They do not instruct the compiler to do things (_except_ for primitive: and apicall:, but these are now outliers). They rather add metadata to a (compiled) method. 2. The 'thing' (ie, class) should probably be named MethodAnnotation 3. We can have the cake and eat it to: Rename Pragma -> MethodAnnotation. Make Pragma a new subclass of MethodAnnotation. Make MethodAnnotation implement #methodSelector #annotationSelector (or #selector, if it must be) Make Pragma implement #selector #keywords That way, We can nuke Pragma (with its 'old' interface) when the time is right but already us the new variant without introducing problems. Best regards -Tobias On 15.11.2016, at 20:33, Dale Henrichs <dale.henrichs(a)gemtalksystems.com> wrote: > We are integrating Pragma into the GemStone base for GemStone 3.4.0, so when the dust settles over the changes I will integrate them into GemStone 3.4.0 ... > > Dale > > On 11/14/2016 11:18 AM, Torsten Bergmann wrote: >> I was hit by this today already as it made Catalog slow like hell (which I fixed): https://pharo.fogbugz.com/f/cases/19342/. >> >> +1 for the short-term revert >> +10 for aligning Squeak and Pharo with a more intention revealing name >> >> Thx >> T. >> >>> Gesendet: Montag, 14. November 2016 um 19:49 Uhr >>> Von: "Eliot Miranda" <eliot.miranda(a)gmail.com> >>> An: "Pharo Development List" <pharo-dev(a)lists.pharo.org> >>> Cc: squeak-dev(a)lists.squeakfoundation.org >>> Betreff: Re: [Pharo-dev] Pragma keyword / selector / methodSelector >>> >>> Hi All, >>> >>> can I suggest that Pharo and Squeak coordinate on a change. First, #selector is bad because it is ambiguous. As already determined #keyword is awful because it's false (it is a message selector, not just a keyword). So could we >>> >>> - use #methodSelector and #pragmaSelector for the next few years, and deprecate #selector and #keyword? >>> >>> - after a suitable time use #selector to mean #pragmaSelector because that's the most useful abbreviation (in my experience I most often access #pragmaSelector)? >>> >>> _,,,^..^,,,_ (phone) >>> >>>> On Nov 14, 2016, at 6:37 AM, Esteban A. Maringolo <emaringolo(a)gmail.com> wrote: >>>> >>>> 2016-11-14 11:27 GMT-03:00 phil(a)highoctane.be <phil(a)highoctane.be>: >>>>> Breaking Metacello in Pharo 6: Not good. Revert: +1 >>>> Breaking Metacello in any version = Not good. >>>> >>>> Metacello is very backward compatible but breaking pragma semantics >>>> would require a rewrite of many configurations that work okay today >>>> and would require a new version of Metacello that contemplates the new >>>> selectors based on some criteria. >>>> >>>> Regards! >>>> >>>> Esteban A. Maringolo >>>> >>> > >

1 0

Pragma keyword / selector / methodSelector
by Pavel Krivanek Nov. 15, 2016

Nov. 15, 2016

Hi, the API of Pragma was changed in quite dangerous way. In past we had: - #selector to access to method selector - #keyword to access to pragma selector now we have: - #methodSelector to access to method selector - #selector to access to pragma selector That means that the meaning of the message #selector was changed and it can cause some problems (like some currently failing tests [1]). The #selector message was deprecated in the middle of the transition process so most of usages should be already rewritten to #methodSelector but we need to be aware of it. [1] https://pharo.fogbugz.com/f/cases/19333/17-more-tests-failing-due-to- MockSettings-class-Object-doesNotUnderstand-mocksystemsettings- SettingTreeBuilder-mocksystemse Cheers -- Pavel

14 31

[pharo-project/pharo-core] dd72d4: 60293
by GitHub Nov. 15, 2016

Nov. 15, 2016

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: dd72d4a562f99b73199991a83ef0ba624cae6619 https://github.com/pharo-project/pharo-core/commit/dd72d4a562f99b73199991a8… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-11-15 (Tue, 15 Nov 2016) Changed paths: R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60292.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60293.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60292.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60293.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 60293 19348 apply automatic deprecation rewrite because of 19347 https://pharo.fogbugz.com/f/cases/19348 http://files.pharo.org/image/60/60293.zip

1 0

[pharo-project/pharo-core]
by GitHub Nov. 15, 2016

Nov. 15, 2016

Branch: refs/tags/60292 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 77e681: 60292
by GitHub Nov. 15, 2016

Nov. 15, 2016

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 77e681b15c8ec0f5dc2731f2ed2c86739b86ed23 https://github.com/pharo-project/pharo-core/commit/77e681b15c8ec0f5dc2731f2… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-11-15 (Tue, 15 Nov 2016) Changed paths: M Flashback-Decompiler.package/FBDDecompiler.class/instance/initialize/pragmasForMethod_.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60291.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60292.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60291.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60292.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M System-Settings-Tests.package/extension/SettingTreeBuilder/instance/mocksystemsettings.st Log Message: ----------- 60292 19333 17 more tests failing due to MockSettings class(Object)>>doesNotUnderstand: #mocksystemsettings SettingTreeBuilder>>mocksystemse https://pharo.fogbugz.com/f/cases/19333 http://files.pharo.org/image/60/60292.zip

1 0

[pharo-project/pharo-core]
by GitHub Nov. 15, 2016

Nov. 15, 2016

Branch: refs/tags/60291 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] ce3a55: 60291
by GitHub Nov. 15, 2016

Nov. 15, 2016

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: ce3a55990f8c20dd9a41831ca1ed67d6b229c29b https://github.com/pharo-project/pharo-core/commit/ce3a55990f8c20dd9a41831c… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-11-15 (Tue, 15 Nov 2016) Changed paths: R Deprecated60.package/extension/Pragma/instance/keyword.st M GT-Tests-Spotter.package/GTSpotterStepTest.class/instance/private-navigation/pragma_of_.st M GT-Tests-Spotter.package/GTSpotterStepTest.class/instance/private-navigation/pragmas_inPackages_.st M HelpSystem-Core.package/SystemHelp.class/class/private accessing/allSystemHelpPragmas.st M HelpSystem-Core.package/WikiStyleHelpBuilder.class/class/private accessing/allHelpPragmas.st M Kernel-Tests.package/PragmaTest.class/instance/tests/testCopy.st M Kernel.package/CompiledMethod.class/instance/accessing-pragmas %26 properties/hasPragmaNamed_.st M Kernel.package/Pragma.class/class/finding/allNamed_from_to_.st M Kernel.package/Pragma.class/class/finding/allNamed_in_.st M Kernel.package/Pragma.class/class/private/withPragmasIn_do_.st M Kernel.package/Pragma.class/definition.st R Kernel.package/Pragma.class/instance/accessing-method/methodSelector.st R Kernel.package/Pragma.class/instance/accessing-method/selector.st R Kernel.package/Pragma.class/instance/accessing-pragma/key.st R Kernel.package/Pragma.class/instance/accessing-pragma/message.st A Kernel.package/Pragma.class/instance/accessing/keyword.st A Kernel.package/Pragma.class/instance/accessing/message.st A Kernel.package/Pragma.class/instance/accessing/selector.st M Kernel.package/Pragma.class/instance/comparing/=.st M Kernel.package/Pragma.class/instance/comparing/analogousCodeTo_.st M Kernel.package/Pragma.class/instance/comparing/hash.st M Kernel.package/Pragma.class/instance/initialization/setKeyword_.st M Kernel.package/Pragma.class/instance/printing/printOn_.st R Kernel.package/Pragma.class/instance/processing/sendTo_.st A Kernel.package/Pragma.class/instance/querying/key.st A Kernel.package/Pragma.class/instance/sending/sendTo_.st M Kernel.package/Pragma.class/instance/testing/hasLiteralSuchThat_.st M Kernel.package/Pragma.class/instance/testing/hasLiteral_.st A Kernel.package/Pragma.class/instance/view/methodSelector.st M Keymapping-Core.package/extension/CompiledMethod/instance/isShortcutDeclaration.st M Keymapping-Pragmas.package/KMPragmaKeymapBuilder.class/instance/registrations handling/pragmaCollector.st M MenuRegistration.package/PragmaMenuBuilder.class/instance/registrations handling/pragmaCollector.st M Nautilus.package/MethodIsScriptAction.class/instance/testing/isActionHandled.st M Nautilus.package/MethodIsScriptWithArgumentAction.class/instance/testing/isActionHandled.st M Nautilus.package/MethodSampleInstanceAction.class/instance/order/isActionHandled.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60290.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60291.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60290.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60291.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M SmartSuggestions.package/SugsSuggestionFactory.class/class/private/createCollector_.st M Spec-Core.package/ComposableModel.class/class/protocol/specSelectors.st M Spec-Core.package/ComposableModel.class/instance/private/defaultSpecSelector.st M System-Settings.package/SettingBrowser.class/class/accessing/settingsKeywords.st M System-Settings.package/SettingTree.class/instance/accessing/acceptableKeywords_.st Log Message: ----------- 60291 19338 Revert 18233 (improving Pragma API) https://pharo.fogbugz.com/f/cases/19338 http://files.pharo.org/image/60/60291.zip

1 0