October 2015 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] 433393: 50407
by GitHub Oct. 27, 2015

Oct. 27, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 43339304094c660e251b06951a1e18b00b310103 https://github.com/pharo-project/pharo-core/commit/43339304094c660e251b0695… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-10-27 (Tue, 27 Oct 2015) Changed paths: M Morphic-Core.package/HandMorph.class/instance/caching/releaseCachedState.st M Morphic-Core.package/HandMorph.class/instance/focus handling/keyboardFocus_.st M Morphic-Core.package/HandMorph.class/instance/focus handling/newKeyboardFocus_.st R Morphic-Core.package/HandMorph.class/instance/focus handling/releaseAllFoci.st A Morphic-Core.package/HandMorph.class/instance/focus handling/releaseAllFocus.st M Morphic-Core.package/HandMorph.class/instance/initialization/interrupted.st M Refactoring-Critics.package/RBRefersToClassRule.class/instance/running/basicCheck_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50406.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50407.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50406.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50407.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50407 16874 RBRefersToClassRule should handle classes that are not in method dict https://pharo.fogbugz.com/f/cases/16874 16856 Any KeyboardFocus change in the HandMorph should be announced https://pharo.fogbugz.com/f/cases/16856 http://files.pharo.org/image/50/50407.zip

1 0

[pharo-project/pharo-core]
by GitHub Oct. 27, 2015

Oct. 27, 2015

Branch: refs/tags/50407 Home: https://github.com/pharo-project/pharo-core

1 0

Loading of Baselines from GitHub in Metacello using pattern matching not working on Windows
by Gabriel Cotelli Oct. 27, 2015

Oct. 27, 2015

When trying to load a baseline using the Metacello API and version pattern matching, using the gituhb:// scheme produces an error because it's trying to create a directory with a question mark (?). To reproduce try in a Pharo4/5 image: Metacello new baseline: 'RenoirSt'; repository: 'github://gcotelli/RenoirSt:v1.?/source'; load. Dale, Is this supposed to work? Tomorrow I will give it a try on Linux. Thanks, Gabriel

2 3

feedback from J Brant
by stepharo Oct. 26, 2015

Oct. 26, 2015

Hi guys here is some feedback from John. I share it with you. On 02 Sep 2015, at 16:05, John Brant <brant(a)refactoryworkers.com> wrote: I've been writing some automated scripts to port SmaCC to Pharo. I have it where I can file in the Dolphin .pac files directly into a Pharo 5 image. Most things are working, but I've had to fight some Pharo issues. Since I wasn't sure who should be notified, I thought I'd complain to you :) :) if you would see my list of complaints about Pharo you would laugh a lot because it is huge and diverse. I put thierry on CC because he is the guy maintaining and using SmaCC a lot. So may be you can help each others. *) The BIConfigurableFormatter (aka RBConfigurableFormatter) sends #asString to nodes. First, it should format the node if it wants them formatted instead of relying on asString to return a formatted string. Second, by sending #asString, formatting has become exponential in the nesting level of blocks. For example, Dolphin Smalltalk runs this in 4 milliseconds: | stream | stream := WriteStream on: String new. stream nextPutAll: 'foo ^true and: '. 40 timesRepeat: [stream nextPutAll: '[true and: ']. stream nextPutAll: 'false'. 40 timesRepeat: [stream nextPut: $]]. (RBParser parseMethod: stream contents) formattedCode I'm guessing that Pharo wouldn't finish in a day... It takes over 4 seconds to format 16 nested blocks. Thanks indeed we will fix it. https://pharo.fogbugz.com/f/cases/16462/BIConfigurableFormatter-should-not-… *) Also on the formatter, its default doesn't appear to be compliant with Kent's blocks should look like blocks/rectangles/box rule. The way I interpret the rule is that if I draw a rectangle around everything in the block including the brackets, it should not include any text of anything outside of the block. For example, this would fail that test: surroundedBy: aString ^ self class streamContents: [ :s | s nextPutAll: aString. s nextPutAll: self. s nextPutAll: aString ] yes Since the block starts at the end of the #streamContents: line, a rectangle around all the contents in the block contains part of the #streamContents: selector which isn't part of the block. I do not really like all the formattings of kent. Because sometimes it just does not work. But this is why we ask franck (an interns to start to have a look). For example I do not like self xxx ifTrue: [ self bla self foo. in the current default formatter. and I prefer self xxx ifTrue: [ self bla. self foo But here the problem is that the self foo is not tab aligned because ifTrue: [ self xxx ifTrue: [ self bla. self foo So may be this one is a nice compromise I think that we should change some settings. In fact in alpha things are there to evolve until the release :) *) If I fileout a package, it doesn't fileout the metaclass extension methods. The RPackage>>fileOut method needs to be updated with the metaclassExtensionSelectors. Oops this is a bug. Do you mean what I mean? the extensions done by the package on metaclass that are not in the package. https://pharo.fogbugz.com/f/cases/16460/I-fileout-a-package-does-not-fileou… *) On windows, it appears that while the menus say Ctrl+..., they really mean Ctrl+... or Alt+... -- you figure it out. Yes it sucks. We are in flux with the key essentially because the VM often does not even gives us the correct information. With the new OSWindow architecture we are putting in place we will have all the events and not just the one the VM does not eat (like shift pressed) and we can manage all at the image level not deep into arcane and old C- code. *) It appears that Pharo is removing subString: in favor of substring:. The ANSI standard defines subString:. I was not aware of it. In fact ANSI is bad and totally incomplete (for example we studies strings and this is a mess and totally incomplete). Now we should probably add it. I will send the mail to the mailing-list and let people decide. *) The ChunkFileFormatParser>>parseNextDeclaration is hard coded to handle only the Pharo format: | substrings | substrings := nextChunk parseLiterals. (substrings includes: 'methodsFor:') ifTrue: [ ^self parseMethodDeclarations: substrings ]. (substrings includes: 'commentStamp:') ifTrue: [ ^self parseCommentDeclaration: substrings ]. (substrings includes: 'reorganize') ifTrue: [ ^self parseClassOrganization: substrings ]. Due to the hard coded nature of the types of strings accepted, I have to overwrite this method to be able to file in Dolphin code. In the other Smalltalk's, I can write an extension method or two that I use to file in another dialect's code. https://pharo.fogbugz.com/f/cases/16461/ChunkFileParser If you have a solution please send it. Because we are focusing on the bootstrap and spur the new object format plus a new FFI. Plus a lot more. So this keeps us really busy and many people left the team and we are restarting to teach :) I personally hate this format and the hardcoding of these strings and selectors everywhere so this is why the ChunkFileFormatParser is already a big step forward. I have several other things that annoy me, me too :) But I tried that every couple of days I fix one. but this is enough for now. :) Tx john :) John Brant -------------------------------------------- StÃ©phane Ducasse http://stephane.ducasse.free.fr http://www.synectique.eu / http://www.pharo.org 03 59 35 87 52 Assistant: Julie Jonas 03 59 57 78 50 03 59 35 86 16 S. Ducasse - Inria 40, avenue Halley, Parc Scientifique de la Haute Borne, BÃ¢t.A, Park Plaza Villeneuve d'Ascq 59650 France

3 4

[pharo-project/pharo-core]
by GitHub Oct. 26, 2015

Oct. 26, 2015

Branch: refs/tags/50406 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] c8e490: 50406
by GitHub Oct. 26, 2015

Oct. 26, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: c8e490ae15abe6d84d84663db416779793a59e76 https://github.com/pharo-project/pharo-core/commit/c8e490ae15abe6d84d84663d… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-10-26 (Mon, 26 Oct 2015) Changed paths: M BlueInk-Core.package/BIConfigurableFormatter.class/instance/private/handleLineForArgument_.st M Collections-Strings.package/String.class/instance/formatting/expandMacrosWithArguments_.st A Collections-Tests.package/StringTest.class/instance/testing - formatting/testExpandMacros.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50405.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50406.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50405.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50406.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50406 16863 Make expandMacros more consistent with general use https://pharo.fogbugz.com/f/cases/16863 16462 BIConfigurableFormatter should not use asString https://pharo.fogbugz.com/f/cases/16462 http://files.pharo.org/image/50/50406.zip

1 0

FastTable question
by stepharo Oct. 26, 2015

Oct. 26, 2015

for the mooc videos I must use larger fonts. So I ended up hacking and changing the hardcoded number in default defaultRowHeight ^ 24 rowHeight "This is the row height your rows will have. Cells answered in dataSource will be forced to have this height number... We force it instead allowing lists to have any height because the logic to calculate rows becomes complicated. Possible, but complicated :)" ^ rowHeight ifNil: [ self class defaultRowHeight ] Esteban two questions: - when I read the code of FTmorph I was thinking that a lot of it has not much to do with UI but looks like a model :). - if I were about to manage the height of a row based on its actual contents where should I put it. FTTableContainerMorph is containing what is visible but I wonder why it was asking this to the FastTable and to the elements displayed? Why the ContainerMorph does not ask the FTTableRowMorph for its height and it could be computed based on the font. I still did not get where the strings built. may be here updateExposedRows ... | cell | cell := (self owner dataSource cellColumn: (columns at: columnIndex) row: rowIndex). cell width: (columnWidths at: columnIndex). We should add more comments to methods. Stef drawOn: canvas | x y cellWidth cellHeight rowsToDisplay rowSubviews highligtedRowIndexes primarySelectionIndex | self bounds ifNil: [ ^ self ]. "Nothing to show yet" self owner ifNil: [ ^ self ]. x := self left + self class rowLeftMargin. y := self top. cellWidth := self width - self class rowLeftMargin. cellHeight := self owner rowHeight. ^^^^^^^^^^^^^^^^^^^^^^^ highligtedRowIndexes := self owner selectedRowIndexes, self owner highlightedRowIndexes. primarySelectionIndex := self owner selectedRowIndex. "For some superweird reason, calling #calculateExposedRows here instead in #changed (where it should be called) is 10x faster. Since the whole purpose of this component is speed, for now I'm calling it here and adding the #setNeedRecalculateRows mechanism. History, please forgive me." self updateAllRows. rowsToDisplay := self exposedRows. rowSubviews := OrderedCollection new: rowsToDisplay size + 1. headerRow ifNotNil: [ headerRow bounds: (x@y extent: cellWidth@cellHeight). y := y + cellHeight + self owner intercellSpacing. rowSubviews add: headerRow ]. rowsToDisplay keysAndValuesDo: [ :rowIndex :row | | visibleHeight | visibleHeight := cellHeight min: (self bottom - y). row bounds: (x@y extent: cellWidth@visibleHeight). y := y + visibleHeight + self owner intercellSpacing. rowSubviews add: ((highligtedRowIndexes includes: rowIndex) ifTrue: [ "IMPORTANT: I need to set owner to nil because otherwise it will trigger an invalidation of the owner when adding morph to selectionMorph, causing an infinite loop" self toSelectionRow: (row privateOwner: nil) primary: primarySelectionIndex = rowIndex ] ifFalse: [ row ]) ]. submorphs := rowSubviews asArray. super drawOn: canvas. needsRefreshExposedRows := false

5 13

[pharo-project/pharo-core]
by GitHub Oct. 26, 2015

Oct. 26, 2015

Branch: refs/tags/40624 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 896641: 40624
by GitHub Oct. 26, 2015

Oct. 26, 2015

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 896641b25860fced7a3c39116a9128a702516d3a https://github.com/pharo-project/pharo-core/commit/896641b25860fced7a3c3911… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-10-26 (Mon, 26 Oct 2015) Changed paths: M Ring-Core-Kernel.package/RGMethodDefinition.class/instance/-- all --/basicAsMCMethodDefinition.st M Ring-Monticello.package/extension/RGMethodDefinition/instance/basicAsMCMethodDefinition.st M ScriptLoader40.package/ScriptLoader.class/instance/-- all --/commentForCurrentUpdate.st R ScriptLoader40.package/ScriptLoader.class/instance/-- all --/script623.st A ScriptLoader40.package/ScriptLoader.class/instance/-- all --/script624.st R ScriptLoader40.package/ScriptLoader.class/instance/-- all --/update40623.st A ScriptLoader40.package/ScriptLoader.class/instance/-- all --/update40624.st R ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script623.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script624.st R ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40623.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40624.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40624 16813 Unclosed file streams https://pharo.fogbugz.com/f/cases/16813 http://files.pharo.org/image/40/40624.zip

1 0

Help with a bug fix
by Ferlicot D. Cyril Oct. 26, 2015

Oct. 26, 2015

Hi, I begun to fix a bug, I have a working fix (I think). But I am not satisfy by a method I made. I think the method can be much better but I don't have the knowledge and time to improve it now. If someone wish to take a look: https://pharo.fogbugz.com/f/cases/11091/Ensure-the-current-extension-is-alw… -- Cyril Ferlicot http://www.synectique.eu 165 Avenue Bretagne Lille 59000 France

5 5