July 2014 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] c48491: 40123
by GitHub July 24, 2014

July 24, 2014

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: c4849128db83ff8b14df87f710c678eb11435dc3 https://github.com/pharo-project/pharo-core/commit/c4849128db83ff8b14df87f7… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-07-24 (Thu, 24 Jul 2014) Changed paths: A Deprecated40.package/extension/ToolRegistry/instance/shortcuts.st R Keymapping-Core.package/KMShortcutHandler.class/class/tools/registerToolsOn_.st A Morphic-Core.package/Morph.class/class/shortcuts/shortcutsHandler.st A Morphic-Core.package/Morph.class/class/shortcuts/shortcutsHandler_.st M Morphic-Core.package/Morph.class/definition.st M Morphic-Core.package/Morph.class/instance/event handling/handleKeystroke_.st A Morphic-Core.package/Morph.class/instance/shortcuts/shortcutsHandler.st M Morphic-Widgets-Tree.package/MorphTreeListManager.class/instance/selection change/noteRemovalOfAll_.st M Morphic-Widgets-Tree.package/MorphTreeMorph.class/instance/updating/noteRemovalOfAll_.st M Morphic-Widgets-Tree.package/MorphTreeNodeMorph.class/instance/initialization/initWithContents_prior_forList_indentLevel_.st M Morphic-Widgets-Tree.package/MorphTreeNodeMorph.class/instance/updating/toggleExpandedState.st M Nautilus.package/AbstractNautilusUI.class/class/menu/classesMenu_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/class/insertSubclass.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/class/insertSuperclass.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/inst var/moveInstVarToClass_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/method/moveMethodToClassFor_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/private-class/privateInsertSubclassFor_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/private-class/privateInsertSuperclassFor_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/private-inst var/privateMoveInstVarToClass_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/private-method/privateMoveMethodToClassFor_.st M NautilusRefactoring.package/extension/ClassDescription/instance/instVarRefactoring_.st M NautilusRefactoring.package/extension/ClassDescription/instance/methodRefactoring_.st M NautilusRefactoring.package/extension/ClassDescription/instance/refactoringSubmenu_.st A Refactoring-Core.package/RBAddClassRefactoringTest.class/README.md A Refactoring-Core.package/RBAddClassRefactoringTest.class/definition.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/README.md A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/class/as yet unclassified/model_variable_class_oldClass_.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/definition.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/instance/accessing/oldClass_.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/instance/preconditions/preconditions.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/instance/transforming/collectSendersOfInstVar.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/instance/transforming/transform.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/README.md A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/class/instance creation/method_class_.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/class/instance creation/model_method_class_.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/definition.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/instance/initialize-release/method_class_.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/instance/preconditions/preconditions.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/instance/printing/storeOn_.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/instance/transforming/transform.st M Refactoring-Tests-Core.package/RBFooLintRuleTest.class/README.md M Refactoring-Tests-Core.package/RBFooLintRuleTest.class/definition.st A Refactoring-Tests-Core.package/RBFooLintRuleTest.class/instance/as yet unclassified/foo.st A Refactoring-Tests-Core.package/RBMoveInstVarToClassTest.class/README.md A Refactoring-Tests-Core.package/RBMoveInstVarToClassTest.class/definition.st A Refactoring-Tests-Core.package/RBMoveInstVarToClassTest.class/instance/failure tests/testMoveInstVarToClassAlreadyDefined.st A Refactoring-Tests-Core.package/RBMoveMethodToClassTest.class/README.md A Refactoring-Tests-Core.package/RBMoveMethodToClassTest.class/definition.st A Refactoring-Tests-Core.package/RBMoveMethodToClassTest.class/instance/failure tests/testMethodAlreadyDefined.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script123.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40123.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40123 13539 receiver of "NodeModel" is Nil https://pharo.fogbugz.com/f/cases/13539 13681 replace Smalltalk tools shortcuts with Morph shortcutHandler https://pharo.fogbugz.com/f/cases/13681 13682 Pack of simple refactorings https://pharo.fogbugz.com/f/cases/13682 http://files.pharo.org/image/40/40123.zip

1 0

Context merge and external frameworks
by ClÃ©ment Bera July 24, 2014

July 24, 2014

Dear pharoers, As some of you may know, ContextPart and MethodContext have been merged into a single class Context for over a month in Pharo 4. The separation between these two classes was historical: back in the old times there was BlockContext as a second subclass of ContextPart for non closures images (images before 2009). This separation makes no sense any more. Now there may be some projects that have method extensions on the class MethodContext or ContextPart and that needs to be fixed. For example, when I try to load Seaside30 in Pharo 40, I get the warning that Seaside depends on ContextPart (probably for Continuations). Dependencies on ContextPart or on MethodContext should be moved to Context. If there is something clever we can do in the Pharo image to help for this migration, let us know. Regards, ClÃ©ment

1 0

Morphic Core dependencies
by stepharo July 24, 2014

July 24, 2014

Hi pavel this is related to your interrogations about system window Gofer it smalltalkhubUser: 'BaptisteQuide' project: 'PackageDependenciesAnalysis'; configuration; loadStable

3 4

ConfigurationOfMorphicCore
by Pavel Krivanek July 24, 2014

July 24, 2014

Hi, in latest update we integrated several patches needed for proper working of ConfiguratonOfMorphicCore. This simple configuration loads Morphic-Core package into the minimal image and initializes it so the result is a small standalone Morphic subset. But some issues that I would like to discuss with the community left: SystemWindows support ============================ SystemWindow is quite complex morph that requires many of other morph classes including text morphs, theming support etc. But in several situations the system windows play special role and the Morphic core classes need to be aware of them. So we have several options: - (current) do not have SystemWindow & co. in the image but let basic support of them. That will produce some unimplemented calls - create very simple SystemWindow superclass that will be part of the Morphic-Core but will not have look and possibilities of real SystemWindow - include SystemWindow and supporting classes Tools ============================ The current image generated by this configuraton will crash as soon as you try to press some keyboard button. The reason is in the method Morph>># handleKeystroke. This method contains this code to support Keymapping Smalltalk tools shortcuts handleKeystroke: anEvent inMorph: self. The #tools message is part of Tool-Base package and need to be there because it uses lazy evaluation that creates a ToolRegistry instance. Because Tool-Base is not loaded in the minimal nor Morphic-Core image, it raises DNU Solutions: - introduce some safer form like Smalltalk withToolsDo: [:tools | ...]. In this case it will not be able to look if the class variable "Tools" is nil (because of lazy evaluation) but it will need to do some ugly check of presence of ToolRegistry class or something similar. In this case we will produce more unimplemented calls (on several places in the image because withToolsDo: may be handy in other cases too) - something different :) Cheers, -- Pavel

4 7

[Pharo4] Weekend Project 1: Cleanup Low-Level animation code
by Marcus Denker July 24, 2014

July 24, 2014

Hi, Now with holidays comingâ¦ maybe someone wants to do a small Pharo related Project with impact on the future? Here is suggestion 1. Context: cleanup graphics. (so e.g. one could replace the canvas later). Details ====== Morphic has some very arcane code for animating moving morphs around that bypasses layers. DisplayObject has these methods: follow:while: follow:while:bitsBehind:startingLoc: slideFrom:to:nSteps:delay: slideWithFirstFrom:to:nSteps:delay: displayOnPort:at:rule: They are used by morphic for some not really important animation that for sure can be directly done by moving the morphs as morphs around. Bypassing and directly using low level (not even Canvas level) functionality is for sure not needed. On the Morph level the users are: slideBackToFormerSituation: vanishAfterSlidingTo:event: animationForMoveSuccess: What to do? -> rewrite the morphic level code to just move the morphs around. -> delete all the code from DisplayObject -> review âGrafPortâ usage, as this might have been the last client. Marcus

2 2

On my way to vacation
by Stephan Eggermont July 24, 2014

July 24, 2014

I drive past Lille, and would be interested in spending an afternoon the 29. doing some pair programming (and the evening preferably with some beer and a good diner). Would need to find a place to sleep for us (wife and 2 boys of 5 & 7) though. Stephan

2 1

Re: [Pharo-dev] Komitter in 30852?
by Stephan Eggermont July 24, 2014

July 24, 2014

Marcus wrote >https://pharo.fogbugz.com/f/cases/13539/receiver-of-NodeModel-is-Nil > >There is even a fix, but it needs to be reviewed and back ported. Thanks, I somehow missed that. I was a bit annoyed that I had just yesterday answered a question about closing lots of inspectors and then ran into the situation myself... Thierry wrote: >can you describe how you get it? I immediately had errors on 4.0 >when writing this fix (https://pharo.fogbugz.com/f/cases/13539/receiver-of-NodeModel-is-Nil) but it wasn't reproduced on 3.0. Open a fresh 30852 with 355 (Mac Mavericks 10.9.4). Open a Nautilus browser, create class Bla in category Bla. Open Komitter, 6 MNUs Close MNUs and Komitter add a class Blah in category Bla Open Komitter, 10 MNUs I tried it originally on an image that took over a minute to produce the MNUs... Stephan

2 1

Refactor Nautilus
by Nicolai Hess July 24, 2014

July 24, 2014

If no one raises objections, I would like to start on refactor / cleanup nautilus code. This includes: renaming / recategorizing solve code critics shown in Critics Browser split classes (AbstractNautilusUI has 427 methods 24 instvars ) stronger separation between the browser model, browser state and browser UI. review event handling and UI updating (sometimes there is a difference between what the UI shows as selected and the selection the model(s) holds maybe: create one package pane widget for package and groups (therefore move all that package vs groups handling from nautilus ui to that widget) merge Nautilus and PackageTreeNautilus (I don't consider all of Nautilus bad code, it has well designed parts, it just has grown meanwhile...) How to update the code? Working with slices makes it easier to find changes that introduces new bugs. Otherwise it takes time to do it in such small steps and I don't know if those changes are reviewed at all. So, I would try to group the changes. 1. code critics 2. renameing/ simple refactoring 3. .... nicolai

5 5

Komitter in 30852?
by Stephan Eggermont July 24, 2014

July 24, 2014

Anyone tried Komitter recently in Pharo 3? I get about 4 to 6 debugger windows per change. Don't try on an image with lots of open changes... Stephan

4 3

[pharo-project/pharo-core]
by GitHub July 24, 2014

July 24, 2014

Branch: refs/tags/40122 Home: https://github.com/pharo-project/pharo-core

1 0