April 2011 - Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3382 in pharo: BUG: Class variable creation behavior Inconsistent/incorrect
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: New Owner: ---- New issue 3382 by sean.p.denigris: BUG: Class variable creation behavior Inconsistent/incorrect http://code.google.com/p/pharo/issues/detail?id=3382 * Class>>canFindWithoutEnvironment: checks the environment, making the behavior like bindingOf: * changed Class>>declare: and Class>>addClassVarName: - check the environment (i.e. Class names) for class variable name conflicts - conflict error message confusing/inaccurate * above conflict error in #declare is resumable, same error in #addClassVarName: is not ClassTests * uses depreciated methods on Class * testHaSharedPools should be testHasSharedPools Pharo image: Pharo-core Pharo core version: Pharo1.2a Latest update: #12264

2 5

[Pharo-project] Issue 3549 in pharo: ChooseClassOrTrait
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: Accepted Owner: stephane...(a)gmail.com New issue 3549 by stephane...(a)gmail.com: ChooseClassOrTrait http://code.google.com/p/pharo/issues/detail?id=3549 ==================== Summary ==================== Name: ToolBuilder-Kernel-ul.39 Author: ul Time: 12 December 2010, 11:18:16.463 pm UUID: 68b3bc0b-91c7-8e4c-8ad1-1f9a1ae18f3a Ancestors: ToolBuilder-Kernel-ar.38 - added UIManager >> #chooseClassOrTrait:from: as a common way to select a class or trait from an environment (SystemDictionary) =============== Diff against ToolBuilder-Kernel-ar.38 =============== Item was added: + ----- Method: UIManager>>chooseClassOrTrait (in category 'ui requests') ----- + chooseClassOrTrait + "Let the user choose a Class or Trait" + + ^self chooseClassOrTrait: 'Class name or fragment?'! Item was added: + ----- Method: UIManager>>chooseClassOrTrait: (in category 'ui requests') ----- + chooseClassOrTrait: label + "Let the user choose a Class or Trait" + + ^self chooseClassOrTrait: label from: Smalltalk environment! Item was added: + ----- Method: UIManager>>chooseClassOrTrait:from: (in category 'ui requests') ----- + chooseClassOrTrait: label from: environment + "Let the user choose a Class or Trait." + + | pattern | + pattern := self request: label. + ^Utilities classOrTraitFrom: environment pattern: pattern label: label + ! Item was added: + ----- Method: Utilities class>>classFromPattern:withCaption: (in category '*ToolBuilder-Kernel') ----- + classFromPattern: pattern withCaption: aCaption + "If there is a class or trait whose name exactly given by pattern, return it. + If there is only one class or trait in the system whose name matches pattern, return it. + Otherwise, put up a menu offering the names of all classes that match pattern, and return the class chosen, else nil if nothing chosen. + This method ignores separator characters in the pattern" + + ^self classOrTraitFrom: Smalltalk environment pattern: pattern label: aCaption + " + self classFromPattern: 'CharRecog' withCaption: '' + self classFromPattern: 'rRecog' withCaption: '' + self classFromPattern: 'znak' withCaption: '' + self classFromPattern: 'orph' withCaption: '' + self classFromPattern: 'TCompil' withCaption: '' + " + ! Item was added: + ----- Method: Utilities class>>classOrTraitFrom:pattern:label: (in category '*ToolBuilder-Kernel') ----- + classOrTraitFrom: environment pattern: pattern label: label + "If there is a class or trait whose name exactly given by pattern, return it. + If there is only one class or trait in the given environment whose name matches pattern, return it. + Otherwise, put up a menu offering the names of all classes that match pattern, and return the class chosen, else nil if nothing chosen. + This method ignores separator characters in the pattern" + + | toMatch potentialNames names exactMatch lines reducedIdentifiers selectedIndex | + toMatch := pattern copyWithoutAll: Character separators. + toMatch ifEmpty: [ ^nil ]. + "If there's a class or trait named as pattern, then return it." + Symbol hasInterned: pattern ifTrue: [ :symbol | + environment at: symbol ifPresent: [ :maybeClassOrTrait | + ((maybeClassOrTrait isKindOf: Class) or: [ + maybeClassOrTrait isTrait ]) + ifTrue: [ ^maybeClassOrTrait ] ] ]. + "No exact match, look for potential matches." + toMatch := pattern asLowercase copyWithout: $.. + potentialNames := environment classAndTraitNames. + names := pattern last = $. "This is some old hack, using String>>#match: may be better." + ifTrue: [ potentialNames select: [ :each | each asLowercase = toMatch ] ] + ifFalse: [ + potentialNames select: [ :each | + each includesSubstring: toMatch caseSensitive: false ] ]. + exactMatch := names detect: [ :each | each asLowercase = toMatch ] ifNone: [ nil ]. + lines := OrderedCollection new. + exactMatch ifNotNil: [ lines add: 1 ]. + "Also try some fuzzy matching." + reducedIdentifiers := pattern suggestedTypeNames select: [ :each | + potentialNames includes: each ]. + reducedIdentifiers ifNotEmpty: [ + names addAll: reducedIdentifiers. + lines add: 1 + names size + reducedIdentifiers size ]. + "Let the user select if there's more than one possible match. This may give surprising results." + selectedIndex := names size = 1 + ifTrue: [ 1 ] + ifFalse: [ + exactMatch ifNotNil: [ names addFirst: exactMatch ]. + UIManager default chooseFrom: names lines: lines title: label ]. + selectedIndex = 0 ifTrue: [ ^nil ]. + ^environment at: (names at: selectedIndex) asSymbol!

1 3

[Pharo-project] Issue 3466 in pharo: Display the leading zero while printing the hexadecimal version of a Character
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: New Owner: ---- New issue 3466 by geo.couprie: Display the leading zero while printing the hexadecimal version of a Character http://code.google.com/p/pharo/issues/detail?id=3466 Pharo image: Pharo | Pharo-core Pharo core version: Pharo1.2beta Virtual machine used: pharo-vm-4.0.2-win32 Steps to reproduce: 1.(Character value:15) printStringHex -> 'F' it should return '0F'. Character>>hex returns '16rF' and should not be fixed, but printStringHex must display the leading zero, because the smallest representation of a Character is a byte. Additionally, String>>asHex should use Character>>printStringHex instead of Character>>hex.

1 5

[Pharo-project] Issue 3665 in pharo: asStringOrText should invoke asString
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3665 by stephane...(a)gmail.com: asStringOrText should invoke asString http://code.google.com/p/pharo/issues/detail?id=3665 to be discussed #asStringOrText should return the receiver #asString, not printString. This is the correct behavior to be able to render first-class objects in PluggableListMorphs without quotes around them. =============== Diff against Kernel-ul.540 =============== Item was changed: ----- Method: Object>>asStringOrText (in category 'converting') ----- asStringOrText "Answer a string that represents the receiver." + ^ self asString! - - ^ self printString !

1 1

[Pharo-project] Issue 3548 in pharo: Network changes from Etoy
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3548 by stephane...(a)gmail.com: Network changes from Etoy http://code.google.com/p/pharo/issues/detail?id=3548 A new version of Network was added to project The Inbox: http://source.squeak.org/inbox/Network-ul.100.mcz ==================== Summary ==================== Name: Network-ul.100 Author: ul Time: 12 December 2010, 4:49:19.894 am UUID: 81823263-c3d6-f949-a8b0-6a107dcb5322 Ancestors: Network-ul.99 Network changes from the EToys repository. We should really have a look at that. But this can be a bit boring.

1 1

[Pharo-project] [TODO 1.3] open issues tagged 1.3
by Marcus Denker April 7, 2011

April 7, 2011

Hello, So I went through the bug tracker and removed 1.3 tags from non-essential items. What is left are 45 issues: http://code.google.com/p/pharo/issues/list?can=2&q=milestone%3D1.3 among them all 25 failing tests of core: https://pharo-ic.lille.inria.fr/hudson/job/Pharo%20Core%201.3/lastCompleted… -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

1 0

[Pharo-project] Issue 3663 in pharo: XMLWriter and MultiByteFileStream
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3663 by stephane...(a)gmail.com: XMLWriter and MultiByteFileStream http://code.google.com/p/pharo/issues/detail?id=3663 Name: Collections-ul.422 Author: ul Time: 31 January 2011, 2:02:00.387 am UUID: 89c6854c-b6d1-1646-a22b-bbc47ce7522f Ancestors: Collections-ul.421 Introduced Stream >> #basicNext:putAll:startingAt: which will be used by MultiByteFileStream to fix http://bugs.squeak.org/view.php?id=7603 . =============== Diff against Collections-ul.421 =============== Item was added: + ----- Method: Stream>>basicNext:putAll:startingAt: (in category 'accessing') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^self next: anInteger putAll: aCollection startingAt: startIndex + ! A fix for http://bugs.squeak.org/view.php?id=7603 . Requires Collections-ul.422. Added TextConverter >> #next:putAll:startingAt:toStream: which is used by MultiByteFileStream and MultiByteBinaryOrTextStream to properly implement #next:putAll:startingAt:. =============== Diff against Multilingual-ul.133 =============== Item was added: + ----- Method: MultiByteBinaryOrTextStream>>basicNext:putAll:startingAt: (in category 'private basic') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^super next: anInteger putAll: aCollection startingAt: startIndex! Item was added: + ----- Method: MultiByteBinaryOrTextStream>>next:putAll:startingAt: (in category 'public') ----- + next: anInteger putAll: aCollection startingAt: startIndex + + (self isBinary or: [ aCollection class == ByteArray ]) ifTrue: [ + ^super next: anInteger putAll: aCollection startingAt: startIndex ]. + ^self converter next: anInteger putAll: aCollection startingAt: startIndex toStream: self + ! Item was added: + ----- Method: MultiByteFileStream>>basicNext:putAll:startingAt: (in category 'private basic') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^super next: anInteger putAll: aCollection startingAt: startIndex! Item was added: + ----- Method: MultiByteFileStream>>next:putAll:startingAt: (in category 'public') ----- + next: anInteger putAll: aCollection startingAt: startIndex + + (self isBinary or: [ aCollection class == ByteArray ]) ifTrue: [ + ^super next: anInteger putAll: aCollection startingAt: startIndex ]. + ^converter next: anInteger putAll: aCollection startingAt: startIndex toStream: self! Item was changed: ----- Method: MultiByteFileStream>>nextPutAll: (in category 'public') ----- nextPutAll: aCollection (self isBinary or: [aCollection class == ByteArray]) ifTrue: [ ^ super nextPutAll: aCollection. ]. + ^converter nextPutAll: aCollection toStream: self! - converter nextPutAll: aCollection toStream: self. - ^aCollection! Item was added: + ----- Method: TextConverter>>next:putAll:startingAt:toStream: (in category 'conversion') ----- + next: anInteger putAll: aString startingAt: startIndex toStream: aStream + "Handle fast conversion if ByteString" + + | lastIndex nextIndex | + aString class == ByteString ifFalse: [ + startIndex to: startIndex + anInteger - 1 do: [ :index | + self nextPut: (aString at: index) toStream: aStream ]. + ^aString ]. + aStream isBinary ifTrue: [ + aStream basicNext: anInteger putAll: aString startingAt: startIndex. + ^aString ]. + lastIndex := startIndex. + [ (nextIndex := ByteString + findFirstInString: aString + inSet: latin1Map + startingAt: lastIndex) = 0 or: [ nextIndex > anInteger ] ] whileFalse: [ + aStream + basicNext: nextIndex - lastIndex putAll: aString startingAt: lastIndex; + basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex) + 1). + lastIndex := nextIndex + 1 ]. + aStream basicNext: anInteger - lastIndex + 1 putAll: aString startingAt: lastIndex. + ^aString! Item was changed: ----- Method: TextConverter>>nextPutAll:toStream: (in category 'conversion') ----- nextPutAll: aString toStream: aStream "Handle fast conversion if ByteString" + ^self next: aString size putAll: aString startingAt: 1 toStream: aStream! - | lastIndex nextIndex | - aString class == ByteString ifFalse: [ - aString do: [:char | self nextPut: char toStream: aStream]. - ^self]. - - aStream isBinary ifTrue: [ - aStream basicNextPutAll: aString. - ^self]. - lastIndex := 1. - [nextIndex := ByteString findFirstInString: aString inSet: latin1Map startingAt: lastIndex. - nextIndex = 0] whileFalse: - [aStream next: nextIndex-lastIndex putAll: aString startingAt: lastIndex. - aStream basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex)+1). - lastIndex := nextIndex + 1]. - aStream next: aString size-lastIndex+1 putAll: aString startingAt: lastIndex. - ^self - !

1 4

[Pharo-project] 13135 open setting DNU
by stephane ducasse April 7, 2011

April 7, 2011

props layoutInset asPoint asPoint DNU on a rectangle. Stef

1 0

Re: [Pharo-project] Issue 2441 in pharo: Strange behavior of Rectangle
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Updates: Labels: -Milestone-1.3 Comment #9 on issue 2441 by marcus.d...(a)gmail.com: Strange behavior of Rectangle http://code.google.com/p/pharo/issues/detail?id=2441 (No comment was entered for this change.)

1 1

[Pharo-project] Issue 3424 in pharo: Improved class Tests
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 Difficulty-Easy New issue 3424 by stephane.ducasse: Improved class Tests http://code.google.com/p/pharo/issues/detail?id=3424 A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-spd.149.mcz ==================== Summary ==================== Name: KernelTests-spd.149 Author: spd Time: 4 December 2010, 1:33:50.265 pm UUID: 89c23bef-103f-4b9d-885c-bcf19d6b6fa9 Ancestors: KernelTests-cmm.148 * refactored and extended ClassTest, including adding a test for Class>>canFindWithoutEnvironment: (fixed in Kernel-spd.444 in inbox) n.b. no conflicts with trunk as of 12/4/2010 =============== Diff against KernelTests-cmm.148 =============== Item was changed: TestCase subclass: #ClassTest + instanceVariableNames: 'className renamedName subClassName anotherClassName class subclass anotherClass' - instanceVariableNames: 'className renamedName' classVariableNames: '' poolDictionaries: '' category: 'KernelTests-Classes'! Item was added: + ----- Method: ClassTest classSide>>deleteClassNamed: (in category 'setup') ----- + deleteClassNamed: aString + | cl | + cl := Smalltalk at: aString ifAbsent: [^self]. + cl removeFromChanges; removeFromSystemUnlogged + ! Item was removed: - ----- Method: ClassTest>>deleteClass (in category 'setup') ----- - deleteClass - | cl | - cl := Smalltalk at: className ifAbsent: [^self]. - cl removeFromChanges; removeFromSystemUnlogged - ! Item was removed: - ----- Method: ClassTest>>deleteRenamedClass (in category 'setup') ----- - deleteRenamedClass - | cl | - cl := Smalltalk at: renamedName ifAbsent: [^self]. - cl removeFromChanges; removeFromSystemUnlogged - ! Item was added: + ----- Method: ClassTest>>deleteTestClasses (in category 'setup') ----- + deleteTestClasses + + self class deleteClassNamed: class name. + self class deleteClassNamed: subclass name. + self class deleteClassNamed: renamedName. + self class deleteClassNamed: anotherClass name. + ! Item was changed: ----- Method: ClassTest>>setUp (in category 'setup') ----- setUp + - className := #TUTU. renamedName := #RenamedTUTU. + + self deleteTestClasses. + + class := Object subclass: #TUTU - self deleteClass. - self deleteRenamedClass. - Object subclass: className instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' + category: 'KernelTests-Classes'. + + subclass := class subclass: #SubTUTU + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Classes'. + + anotherClass := Object subclass: #AnotherClass + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Classes'.! - category: 'KernelTests-Classes'! Item was added: + ----- Method: ClassTest>>superclass (in category 'accessing') ----- + superclass + + ^ class.! Item was changed: ----- Method: ClassTest>>tearDown (in category 'setup') ----- tearDown + + self deleteTestClasses.! - self deleteClass. - self deleteRenamedClass! Item was added: + ----- Method: ClassTest>>testAddClassVarName (in category 'testing') ----- + testAddClassVarName + "self run: #testAddClassVarName" + + class addClassVarName: #MyShinyNewClassVar. + self assert: (class classVarNames anySatisfy: [ :name | name = #MyShinyNewClassVar ]). + + ! Item was added: + ----- Method: ClassTest>>testAddClassVarNameWithSameNameAsAGlobal (in category 'testing') ----- + testAddClassVarNameWithSameNameAsAGlobal + "self run: #testAddClassVarName" + + self shouldnt: [ class addClassVarName: anotherClass name ] raise: Exception. + self assert: (class classVarNames anySatisfy: [ :name | name = anotherClass name ]). + + ! Item was changed: ----- Method: ClassTest>>testAddInstVarName (in category 'testing') ----- testAddInstVarName "self run: #testAddInstVarName" + class addInstVarName: 'x'. + self assert: (class instVarNames = #('x')). + class addInstVarName: 'y'. + self assert: (class instVarNames = #('x' 'y')) - | tutu | - tutu := Smalltalk at: #TUTU. - tutu addInstVarName: 'x'. - self assert: (tutu instVarNames = #('x')). - tutu addInstVarName: 'y'. - self assert: (tutu instVarNames = #('x' 'y')) - ! Item was added: + ----- Method: ClassTest>>testCanFindWithoutEnvironment (in category 'testing') ----- + testCanFindWithoutEnvironment + "self debug: #testCanFindWithoutEnvironment" + "self run: #testCanFindWithoutEnvironment" + + self deny: (subclass canFindWithoutEnvironment: #ClassVarInSuperclass). + self deny: (subclass canFindWithoutEnvironment: #PoolVarInSuperclass). + self deny: (subclass canFindWithoutEnvironment: #ClassVar). + self deny: (subclass canFindWithoutEnvironment: #PoolVar). + + subclass addClassVarName: 'ClassVar'. + self assert: (subclass canFindWithoutEnvironment: #ClassVar). + + subclass addSharedPool: (Dictionary newFromPairs: #(PoolVar->5)). + self assert: (subclass canFindWithoutEnvironment: #PoolVar). + + self superclass addClassVarName: 'ClassVarInSupersubclass'. + self assert: (subclass canFindWithoutEnvironment: #ClassVarInSupersubclass). + + self superclass addSharedPool: (Dictionary newFromPairs: #(PoolVarInSupersubclass->5)). + self assert: (subclass canFindWithoutEnvironment: #PoolVarInSupersubclass).! Item was changed: ----- Method: ClassTest>>testRenaming (in category 'testing') ----- testRenaming "self debug: #testRenaming" "self run: #testRenaming" + | newMetaclassName | - | oldName newMetaclassName class | - oldName := className. newMetaclassName := (renamedName, #' class') asSymbol. - class := Smalltalk at: oldName. class class compile: 'dummyMeth'. class rename: renamedName. self assert: class name = renamedName. self assert: (ChangeSet current changedClassNames includes: renamedName). self assert: (ChangeSet current changedClassNames includes: newMetaclassName). !

1 1