February 2011 - Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3429 in pharo: Better Number performance
by pharo＠googlecode.com March 29, 2011

March 29, 2011

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 New issue 3429 by stephane.ducasse: Better Number performance http://code.google.com/p/pharo/issues/detail?id=3429 Name: Kernel-ul.522 Author: ul Time: 8 December 2010, 4:08:19.384 am UUID: 6927b03c-21df-1746-9a0d-115b717a5e40 Ancestors: Kernel-ul.521 - implemented Fraction >> #negative and ScaledDecimal >> #negative for better performance. These methods don't allocate new objects. - reimplemented SmallInteger printing methods (printOn:base:*) without String allocation. They are as fast as the previous versions were for base 10. - reimplemented ScaledDecimal printing. It avoids object allocations and has better performance than the previous version. ScaledDecimals can also be printed without the scale part by using #printFractionAsDecimalOn:. =============== Diff against Kernel-ul.521 =============== Item was added: + ----- Method: Fraction>>negative (in category 'testing') ----- + negative + + ^numerator negative! Item was added: + ----- Method: ScaledDecimal>>negative (in category 'testing') ----- + negative + + ^fraction negative! Item was added: + ----- Method: ScaledDecimal>>printFractionAsDecimalOn: (in category 'printing') ----- + printFractionAsDecimalOn: stream + + | aFraction integerPart fractionPart | + fraction negative + ifFalse: [ aFraction := fraction ] + ifTrue: [ + aFraction := fraction negated. + stream nextPut: $- ]. + integerPart := aFraction truncated. + integerPart printOn: stream. + scale = 0 ifTrue: [ ^self ]. + stream nextPut: $.. + fractionPart := ((aFraction - integerPart) * (10 raisedToInteger: scale)) truncated. + fractionPart + printOn: stream + base: 10 + length: scale + padded: true! Item was changed: ----- Method: ScaledDecimal>>printOn: (in category 'printing') ----- + printOn: stream + + self + printFractionAsDecimalOn: stream; + printScaleOn: stream! - printOn: aStream - "Reimplementation - Object 'printing' method." - | aFraction tmpFractionPart | - self < 0 ifTrue: [aStream nextPut: $-]. - aFraction := fraction abs. - aStream nextPutAll: aFraction truncated printString. - scale = 0 ifTrue: [^ aStream nextPutAll: 's0']. - aStream nextPut: $.. - tmpFractionPart := aFraction fractionPart. - 1 to: scale - do: - [:dummy | - tmpFractionPart := tmpFractionPart * 10. - aStream nextPut: (Character digitValue: tmpFractionPart truncated). - tmpFractionPart := tmpFractionPart fractionPart]. - aStream nextPut: $s. - scale printOn: aStream! Item was added: + ----- Method: ScaledDecimal>>printScaleOn: (in category 'printing') ----- + printScaleOn: stream + + stream nextPut: $s. + scale printOn: stream! Item was changed: ----- Method: SmallInteger>>printOn:base: (in category 'printing') ----- + printOn: stream base: base - printOn: aStream base: b "Append a representation of this number in base b on aStream." + self printOn: stream base: base length: 0 padded: false! - self < 0 - ifTrue: [aStream nextPut: $-. - aStream nextPutAll: (self negated printStringBase: b). - ^self]. - - "allocating a String seems faster than streaming for SmallInteger" - aStream nextPutAll: (self printStringBase: b)! Item was added: + ----- Method: SmallInteger>>printOn:base:length:padded: (in category 'printing') ----- + printOn: stream base: base length: minimumLength padded: padWithZeroes + + | n numberOfDigits totalLength divisor | + self < 0 + ifTrue: [ + n := self negated. + totalLength := 1 ] + ifFalse: [ + n := self. + totalLength := 0 ]. + numberOfDigits := n numberOfDigitsInBase: base. + totalLength := totalLength + numberOfDigits. + padWithZeroes ifFalse: [ + [ totalLength < minimumLength ] whileTrue: [ + stream space. + totalLength := totalLength + 1 ] ]. + n = self ifFalse: [ stream nextPut: $- ]. + padWithZeroes ifTrue: [ + [ totalLength < minimumLength ] whileTrue: [ + stream nextPut: $0. + totalLength := totalLength + 1 ] ]. + divisor := (base raisedToInteger: numberOfDigits - 1). + [ divisor > 0 ] whileTrue: [ + | digit | + digit := n // divisor. + stream nextPut: ('0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ' at: digit + 1). + n := n - (digit * divisor). + divisor := divisor // base ]! Item was changed: ----- Method: SmallInteger>>printOn:base:nDigits: (in category 'printing') ----- printOn: aStream base: b nDigits: n "Append a representation of this number in base b on aStream using nDigits. self must be positive." + self printOn: aStream base: b length: n padded: true! - "allocating a String seems faster than streaming for SmallInteger" - aStream nextPutAll: (self printStringBase: b nDigits: n)!

3 6

[Pharo-project] Issue 3713 in pharo: Additional obsolete methods in PharoCore-1.2.image (2/15/11 9:08am)
by pharo＠googlecode.com March 29, 2011

March 29, 2011

Status: New Owner: ---- New issue 3713 by DougEdmu...(a)gmail.com: Additional obsolete methods in PharoCore-1.2.image (2/15/11 9:08am) http://code.google.com/p/pharo/issues/detail?id=3713 I did a search through PharoV10.sources for comments which reported methods as 'obsolete'. I looked for them in Pharo, using the 2/15/11 9:08am image (from Pharo-1.2.zip). These methods are still in the 1.2 image: !Canvas methodsFor: 'drawing' stamp: 'ar 6/17/1999 01:30'! line: pt1 to: pt2 brushForm: brush "Obsolete - will be removed in the future"! ! !Canvas methodsFor: 'drawing' stamp: 'ar 6/17/1999 01:32'! point: p color: c "Obsolete - will be removed in the future"! ! !Canvas methodsFor: 'drawing-obsolete' stamp: 'ar 2/12/2000 18:11'! imageWithOpaqueWhite: aForm at: aPoint "Note: This protocol is deprecated. Use #drawImage: instead" self image: aForm at: aPoint sourceRect: (0@0 extent: aForm extent) rule: Form over. ! ! !Canvas methodsFor: 'drawing-text' stamp: 'ar 12/31/2001 02:40'! text: s at: pt font: fontOrNil color: c "OBSOLETE" ^ self drawString: s at: pt font: fontOrNil color: c! ! !Canvas methodsFor: 'drawing-text' stamp: 'ar 12/31/2001 02:40'! text: s bounds: boundsRect font: fontOrNil color: c "OBSOLETE" ^self drawString: s in: boundsRect font: fontOrNil color: c! ! !FontSet class methodsFor: 'installing' stamp: 'damiencassou 5/30/2008 14:51'! fontNamed: fontName fromLiteral: aString "NOTE -- THIS IS AN OBSOLETE METHOD THAT MAY CAUSE ERRORS. The old form of fileOut for FontSets produced binary literal strings which may not be accurately read in systems with support for international character sets. If possible, file the FontSet out again from a system that produces the newer MIME encoding (current def of compileFont:), and uses the corresponding altered version of this method. If this is not easy, then file the fontSet into an older system (3.7 or earlier), assume it is called FontSetZork... execute FontSetZork installAsTextStyle. copy the compileFont: method from this system into that older one. remove the class FontSetZork. Execute: FontSet convertTextStyleNamed: 'Zork', and see that it creates a new FontSetZork. FileOut the new class FontSetZork. The resulting file should be able to be read into this system. " ^ StrikeFont new name: fontName; readFromStrike2Stream: aString asByteArray readStream! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! classModified: anEvent "obsolete - remove this later"! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! classMoved: anEvent "obsolete - remove this later"! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! classRemoved: anEvent "obsolete - remove this later"! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! methodModified: anEvent "obsolete - remove this later"! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! methodMoved: anEvent "obsolete - remove this later"! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! methodRemoved: anEvent "obsolete - remove this later"! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! registerForNotifications "obsolete - remove this later"! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! registerForNotificationsFrom: aNotifier "obsolete - remove this later"! ! !MCPackageManager methodsFor: 'system changes' stamp: 'ar 4/26/2005 22:17'! systemChange: anEvent "obsolete - remove this later"! ! !Process methodsFor: 'accessing' stamp: 'ar 12/7/2007 17:06'! offList "OBSOLETE. Process>>suspend will atomically reset myList if the process is suspended. There should never be a need to send #offList but some older users may not be aware of the changed semantics to suspend and may try the old hickadidoo seen here: (suspendingList := process suspendingList) == nil ifTrue: [process == Processor activeProcess ifTrue: [process suspend]] ifFalse: [suspendingList remove: process ifAbsent:[]. process offList]. Usages like the above should be replaced by a simple 'process suspend' " myList := nil! !

1 5

[Pharo-project] ProgressDisplay package released
by Ralph Boland March 29, 2011

March 29, 2011

I recently released the first draft of my package ProgressDisplay to SqueakSource. It is like SystemProgressMorph et. al. but with a lot of bells and whistles added. It is not a suitable replacement for SystemProgressMorph though because it is too large and specific for that. SystemProgressMorph could be made a subclass of one of its classes though. It is designed largely to meet my specific needs but since it's MIT anyone may use it, steal components, or move components of it to Squeak/Pharo. It has a utility class category with useful classes for things like array permutation generation and array multiset permutation generation, numeric partitioning of a number, and a class RangeList (which I will be expanding upon later). All of these classes will be removed when the package meant to contain them is ready (not soon). There are also a number of utility methods that could be stolen or put into Squeak/Pharo proper. It probably has lots of bugs, so bug reports appreciated. Comments on its function, design, and implementation most welcome. Proposals for improvements or extensions will be considered but no promises. If you need access to make changes let me know. If Levente Uzonyi likes it but feels compelled to rewrite it completely from scratch, thats okay too. :-) ONE OF MY REASONS FOR RELEASING IT IS BECAUSE OF A BUG I COULD NOT FIX. It is supposed to be possible to turn on the ability to catch user interrupts but when this feature is turned on and an interrupt generated while the progress bar is displayed the interrupt is caught but not processed until the progress bar closes. :-( Of course the interrupt was meant to be processed immediately. If anyone can tell me how to fix this bug (or better still send me the code or add the code to the package) that would be great! Regards, Ralph Boland -- Quantum Theory cannot save us from the tyranny of a deterministic universe but it does give God something to do

6 5

[Pharo-project] Issue 3685 in pharo: #createUserSubclass:instVarNames:categoryName: no longer accepts an inst var array
by pharo＠googlecode.com March 29, 2011

March 29, 2011

Status: New Owner: ---- New issue 3685 by ya...(a)rogers.com: #createUserSubclass:instVarNames:categoryName: no longer accepts an inst var array http://code.google.com/p/pharo/issues/detail?id=3685 Pharo core version: Pharo1.2rc2 Latest update: #12324 In Pharo1.1 the instance variables could be passed as an array. See attached testcase, or, for example: SomeClass createUserSubclass: 'SomeSubclass' instVarNames: #(id varOne varTwo) categoryName: 'Test'. The code change here, looks to be the cause: ClassBuilder>>name: className inEnvironment: env subclassOf: newSuper type: type instanceVariableNames: instVarString classVariableNames: classVarString poolDictionaries: poolString category: category unsafe: unsafe < instVars := instVarString subStrings: ' '. < classVars := (classVarString subStrings: ' ') collect: [ :x | x asSymbol ]. "Validate the proposed name" -- > instVars := Scanner new scanFieldNames: instVarString. > classVars := (Scanner new scanFieldNames: classVarString) collect: [ :x > | x asSymbol ]. "Validate the proposed name" This issue came up in some code that was originally derived from some GemStone code. Maybe it was never intended that instVarNames could be passed in as an array. I've changed my code to pass an instVarString, but I thought I'd mention the changed behaviour here. Attachments: ClassBuilderFormatTests-testSubclassWithInstanceVariablesArray.st 565 bytes

1 5

[Pharo-project] Issue 3631 in pharo: ThreadSafeTranscript should inherit from Stream (WriteStream)
by pharo＠googlecode.com March 29, 2011

March 29, 2011

Status: New Owner: siguc...(a)gmail.com Labels: Milestone-1.3 New issue 3631 by siguc...(a)gmail.com: ThreadSafeTranscript should inherit from Stream (WriteStream) http://code.google.com/p/pharo/issues/detail?id=3631 Transcript role is a stream not a window. Window is just a view, which represents its model - the transcript stream.

1 2

[Pharo-project] Issue 3681 in pharo: [Failing Test] Tests.Release.ReleaseTest.testObsoleteClasses
by pharo＠googlecode.com March 28, 2011

March 28, 2011

Status: Accepted Owner: laurent....(a)gmail.com New issue 3681 by laurent....(a)gmail.com: [Failing Test] Tests.Release.ReleaseTest.testObsoleteClasses http://code.google.com/p/pharo/issues/detail?id=3681 Pharo 1.2 Remaining: AnObsoleteAutoGeneratedClassForTestingSystemChanges, AnObsoleteMCMockClassG For AnObsoleteAutoGeneratedClassForTestingSystemChanges, to reproduce: 1. Take Pharo 1.2 full from Hudson 2. run ReleaseTest testObsoleteClasses, green 3. run ChangeHooksTest testClassCommentedEvent, green 3. rerun ReleaseTest testObsoleteClasses, red

1 6

Re: [Pharo-project] Issue 453 in pharo: we need a way to fold a package into the system
by pharo＠googlecode.com March 27, 2011

March 27, 2011

Comment #4 on issue 453 by marianopeck: we need a way to fold a package into the system http://code.google.com/p/pharo/issues/detail?id=453 Actually, if you take a pharo dev 1.2, there are still 20 references to Preferences :(

1 5

[Pharo-project] Issue 3567 in pharo: FFI OpenGL doesn't load nor work
by pharo＠googlecode.com March 27, 2011

March 27, 2011

Status: New Owner: ---- New issue 3567 by elpochod...(a)gmail.com: FFI OpenGL doesn't load nor work http://code.google.com/p/pharo/issues/detail?id=3567 Pharo image: Pharo Pharo core version: Pharo1.2rc1. Latest update: #12317 Virtual machine used: 'Squeak3.10.2 of 11 February 2010 [latest update: #9314]' (windows) Steps to reproduce: 1. Try to load FFI OpenGL (as described in the book http://book.pharo-project.org/book/3DGraphicsAndOpenGL) There are problems with underscore assignments, a compiler error in OpenGLUnixQuartz class>>#test and some deprecations from going from SmalltalkImage current to Smalltalk.

1 3

[Pharo-project] Issue 3686 in pharo: Deprecate PseudoFileStream
by pharo＠googlecode.com March 27, 2011

March 27, 2011

Status: Accepted Owner: guillerm...(a)gmail.com New issue 3686 by guillerm...(a)gmail.com: Deprecate PseudoFileStream http://code.google.com/p/pharo/issues/detail?id=3686 No comment, not usages, deprecation for you :).

1 1

[Pharo-project] Issue 3480 in pharo: ToDo: Mac VM cleanup
by pharo＠googlecode.com March 27, 2011

March 27, 2011

Status: New Owner: siguctua Labels: Type-ToDo New issue 3480 by siguctua: ToDo: Mac VM cleanup http://code.google.com/p/pharo/issues/detail?id=3480 Some comments by John (simply to not get lost in mails): Oh and btw you'll need to look into the signing logic, I'm not quite sure where that gem of copy protection sits but don't be surprised if Apple pursues it a bit more aggressively... mmm other thoughts. The plugins *could* be just the raw binaries ala unix builds. The only reason they were bundles is because in early 2000 era we ran os-9 and os-x flavors. That could be all dropped, and maybe just forgo creating plugin bundles.

1 2