October 2010 - Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3061: ZipArchiveTest should be removed Compression package
by NicolÃ¡s Paez Oct. 5, 2010

Oct. 5, 2010

Code and Test should be in different packages, to execute your applications you don't need tests. Test should have their own package. http://code.google.com/p/pharo/issues/detail?id=3061 Regards, Saludos! Nico. blog: nicopaez.wordpress.com

1 0

Re: [Pharo-project] Another fixes to finalization (was Re: [update 1.2] #12161 - #12172)
by StÃ©phane Ducasse Oct. 5, 2010

Oct. 5, 2010

>>> > > Moreover, case (b) comes from the inability to dynamically add extra > slot(s) to object, > which you can easily do in Self or JavaScript, but can't do in smalltalk. > > > > It can be done better, with extra VM features, but without those, it's pretty close to best possible solution IMHO. > There are already two different classes for a) and b): WeakRegistry and WeakKeyDictionary (and subclasses). Igor Levente is right. Having dynamic slots to object is nearly a paradigm shift. So let us focus on what we can do now. Now is there a technical problem to apply the solution implemented by levente in Squeak? Because if not this is what we should do. Stef

1 0

Re: [Pharo-project] Another fixes to finalization (was Re: [update 1.2] #12161 - #12172)
by StÃ©phane Ducasse Oct. 4, 2010

Oct. 4, 2010

so let us know in the bug entry what is the conclusion :) > On 2 October 2010 19:47, StÃ©phane Ducasse<stephane.ducasse(a)inria.fr> >>>>>>> wrote: >>>>>>>> >>>>>>>> Hi igor >>>>>>>> >>>>>>>> do you understand why the previous definition was >>>>>>>> >>>>>>>> cachedDefinitions >>>>>>>> Definitions ifNil: [Definitions := WeakIdentityKeyDictionary >>>>>>>> new. >>>>>>>> WeakArray addWeakDependent: Definitions]. >>>>>>>> ^ Definitions >>>>>>>> >>>>>>> i don't. :) >>>>>>> >>>>>>> It just a way to free memory as fast as possible. >>>>>>> But its really not worth spending so much CPU in order to save few >>>>>>> bytes of memory. >>>>>> >>>>>> Without registering the dict for finalization, the values won't ever be >>>>>> removed with the current implementation. >>>>> >>>>> They are removed. After each package load/unload operation. >>>>> I don't see a reason to do this more often. >>>> >>>> If they are removed explicitly, then yes. But then again, if that's the >>>> case, why use a weak dictionary in the first place? >>> >>> i don't know much about MC to tell for sure. >>> >>>>>> Which can be somewhat hampering to performance once you have lots of >>>>>> nil-keyed elements all stashed from index 1 and onwards after a rehash. >>>>>> >>>>> In Pharo, weak dict knows how to reuse expired associations: >>>>> >>>> And when do they expire? Only when they are either finalized, or removed >>>> explicitly. >>>> So if you do neither, they will stay indefinately without being >>>> removed/reused. >>> >>> no. they expiring when key become nil. >>> >> You'd think so, yes. >> However, see implementor of WeakKeyAssociation>>#expired, and senders of >> #expire. >> > > Oh, you are right. They are not reused unless marked as expired > (associatin's value == association). > But concerning speed, then my benchmark should show an opposite results. :) > > cache holding a pairs of: > compiledmethod -> MCMethodDefinitions. > > Compiled methods usually gone when you either recompiling class or > removing it from system. > This is why i put #finalizeValues after package loading/unloading. > But if you think it worth adding it into some other places, then tell me where. > Still, putting it into FinalizationDependents is bad idea. > >> Cheers, >> Henry >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > -- > Best regards, > Igor Stasenko AKA sig. > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

4 10

Re: [Pharo-project] XMLRPC Project - Progress Report
by StÃ©phane Ducasse Oct. 4, 2010

Oct. 4, 2010

:) >> Tell us when pharo core can be a user. >> Because we want to clean the mess. > > I know you are anxious to do so, and it will happen one day, for sure. Not anxious :) Happily eager :) > > There is still some technical work to do, but the most important thing is that we need as much users as possible to shake out the bugs. The code has to prove itself for others (with different encodings/languages/networks). > > Sven > > PS: As I said before, I am using it myself everyday, working in a Pharo 1.1 image were all HTTPSocket stuff is routed to Zn, so far so good. I also replaced all my other HTTP client uses by using Zn directly, and that works well too. We're getting closer. Excellent. I want to have nice code so that I can learn something.

1 0

Re: [Pharo-project] Refactoring>checkPreconditions behaves funny about the errorBlock
by StÃ©phane Ducasse Oct. 4, 2010

Oct. 4, 2010

please clean. Use version management to control impact on other clients. Else we cannot move and this is agony. slow and painful. Stef >> Ok, let's summarize: If an error occurs, the handler block is not >> evaluated, but attached to a new exception, that exception is raised. >> Then, the caller catches that exception, retrieves the handler block, >> does some more ballyhoo, and then runs the handler block. > > Yes, the block mostly contains some code to that allows the user to > fix the problem (like to show all references of a class to be removed, > etc.). > >> And you get invited to this construction by these methods in >> RBAbstractCondition: >> >> errorBlock >> ^self errorBlockFor: false >> >> errorBlockFor: aBoolean >> ^nil > > These methods (and subclass implementations) are used to retrieve the > right block that caused the composite condition to fail. > >> We can clean it up on the next sprint, if you want :) > > The implementation in RBCondition is fine, the problem is more the way > how exceptions are used to pass the values. This mainly stems from the > fact that exceptions evolved over the past 15 years and are no longer > the same as the signals that were used when the refactoring code was > originally written. > > Now of course it is difficult to change this code because there are > various users out there that depend on it, e.g. OB, > RefactoringBrowser, SmaCC, ... > > Lukas > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

1 0

Re: [Pharo-project] CodeMorph >> text should return an instance of Text but return a String
by StÃ©phane Ducasse Oct. 4, 2010

Oct. 4, 2010

Excellent! On Oct 4, 2010, at 11:10 AM, Fernando olivero wrote: > ISSUE 2902: CodeMorph removal . > > Done, added the change set and set the issue to fixed. > > > Fernando > > On Oct 1, 2010, at 12:58 PM, Fernando olivero wrote: > >> Yes, i've been busy so i couldn't finish this issue. >> >> Because CodeMorph comes from Gaucho, and until now there was no need for it in the Pharo-Core. so i will remove it, and possibly when the need arises will propose its re-inclusion. >> >> Fernando >> pd: the idea behind CodeMorph is to have a specialized NewTextMorph for dealing with Methods sources, Class definitions. But now i have second thoughts, because i have the impression that having diferent Editors ( subclasses of TextEditor or SmalltalkEditor) should do the trick. >> >> On Oct 1, 2010, at 12:02 PM, Cyrille Delaunay wrote: >> >>> I just saw that there is propositions to remove CodeMorph: >>> >>> http://code.google.com/p/pharo/issues/detail?id=2902&q=CodeMorph&colspec=ID… >>> >>> So maybe the best fix will be to remove all the tests related ? :) >>> >>> 2010/10/1 Cyrille Delaunay <cy.delaunay(a)gmail.com> >>> In pharo 1.2, NewTextMorphTests>>#testFullMethodName raise an error. This error happen when calling: >>> >>> CodeMorph >> defaultStyledText >>> | text attribute | >>> text := self text. >>> text addAttribute: ( self newTextColorAttribute: Color black ). >>> ^ text. >>> >>> text is a string, and therefore it does not understand 'addAttribute'. The value return by 'text' depends on the value of the instance variable 'adapter'. adapter can have different values according the way we initialize the CodeMorph. One of them is: >>> >>> beFullMethodName >>> aspect := #selector. >>> adapter := [:selector| target methodClass name , '.' , self selectorWithArguments ]. >>> >>> The block return a String and I guess the right code should be >>> >>> beFullMethodName >>> aspect := #selector. >>> adapter := [:selector| (target methodClass name , '.' , self selectorWithArguments) asText ] >>> >>> ??. >>> >>> >>> I opened an Issue: http://code.google.com/p/pharo/issues/detail?id=3031 >>> >>> <ATT00001..txt> >> >> <ATT00001..txt> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

1 0

[Pharo-project] Senders
by Benjamin Van Ryseghem Oct. 4, 2010

Oct. 4, 2010

Hi guys Am I the only one who can't browse senders anymore ? I'm working on 1.2-12168 Benjamin

2 1

Oct. 4, 2010

12169 ----- - fixing showMenus. Thanks Gary Chambers

1 0

Oct. 4, 2010

Thanks this is my mistake.... I will integrate it now. On Oct 4, 2010, at 12:57 PM, Gary Chambers wrote: > Hi. > > Since the update to 12168 I am getting an MNU... > Tracked down to > > showMenuOf: selectorCollection withFirstItem: firstItem ifChosenDo: choiceBlock withCaption: aCaption > "Show a sorted menu of the given selectors, preceded by firstItem, and all abbreviated to 40 characters. Use aCaption as the menu title, if it is not nil. Evaluate choiceBlock if a message is chosen." > > | index menuLabels sortedList | > sortedList := selectorCollection asSortedCollection. > menuLabels := Array streamContents: > [:strm | strm nextPutAll: (firstItem contractTo: 40). > sortedList do: [:sel | strm nextPutAll: (sel contractTo: 40)]]. > index := UIManager default chooseFrom: (menuLabels substrings) lines: #(1). > index = 1 ifTrue: [choiceBlock value: firstItem]. > index > 1 ifTrue: [choiceBlock value: (sortedList at: index - 1)] > > The following revision seems to work ok... > > > showMenuOf: selectorCollection withFirstItem: firstItem ifChosenDo: choiceBlock withCaption: aCaption > "Show a sorted menu of the given selectors, preceded by firstItem, and all abbreviated to 40 characters. Use aCaption as the menu title, if it is not nil. Evaluate choiceBlock if a message is chosen." > > | index menuLabels sortedList | > sortedList := selectorCollection asSortedCollection. > menuLabels := Array streamContents: > [:strm | strm nextPut: (firstItem contractTo: 40). > sortedList do: [:sel | strm nextPut: (sel contractTo: 40)]]. > index := UIManager default chooseFrom: menuLabels lines: #(1). > index = 1 ifTrue: [choiceBlock value: firstItem]. > index > 1 ifTrue: [choiceBlock value: (sortedList at: index - 1)] > > Regards, Gary > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

1 0

[Pharo-project] Wrong fix: Issue 2947: SmalltalkEditor doesn't handle ESC key.
by Fernando olivero Oct. 4, 2010

Oct. 4, 2010

I argue that this fix is wrong, giving the morph logic to the Editor instead of the View ( the morph). this conceptual problem, leads to having to ask for the Global ActiveEvent in the Editor>>offerMenuFromEsc:. If you take a look at the already present method, which should be the one to be used. Editor>>escapePressed "The message is sent when the user hits esc" self announceEscape Which allows the Morph to take care of the view related behavior. So i propose reverting to this behavior: Editor>>escapePressed self morph escapePressed . ^ false Then adding TextMorph>>escapePressed self yellowButtonActivity: false. TextMorphForEditView>>escapePressed self editView yellowButtonActivity: false . Given that TextMorphForEditView is the only implementor of #editView, and following the logic in TextEditor>>raiseContextMenu: TextEditor>>offerMenuFromEsc: aKeyboardEvent The attached change set implements the fixes.

1 0