- Pharo-users - lists.pharo.org

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

by Marcus Denker

Hi, I had a look: this works nicely! I even found a way to automatically fall back to the method creation, so nil doSomething on create will create a method. I have merged your code and will do a PR with the improvement later. Marcus > On 30 Aug 2018, at 09:57, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Thanks! I will have a look at the sprint tomorrow. > > >> On 30 Aug 2018, at 07:11, Tim Mackinnon <tim(a)testit.works> wrote: >> >> Iâve submitted a PR for what I did, so at least it improves the situation (but potentially could get even more refined as you suggest) >> >> Tim >> >>> On 23 Aug 2018, at 11:26, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>> >>> >>> >>>> On 23 Aug 2018, at 15:56, Tim Mackinnon <tim(a)testit.works> wrote: >>>> >>>> Hi Marcus - thatâs actually what I do - and âcreateâ in this case, creates a class and then restarts like the method case does. >>>> >>> >>> Yes, that I saw. >>> >>> But I mean a different case: Imagine you do have code like >>> >>> nil doSomething >>> >>> or an expression that evaluates to nil, press âdefineâ and get a method definition dialog, not the error message? >>> (it is, as I mentioned, not that important as nobody ever wants to define a method in UndefinedObject, but for consistency it would be nice) >>> >>> >>>> I guess I was wondering if we can do it more cleanly and also improve the debugger message. >>>> >>>> If Iâve understood you guys correctly- you try to remove the ambiguity around operations. Looking up a class and getting nil - seems like one of these holes you keep sorting out. >>>> >>>> I think the flaw in my solution is understanding if that message was being sent to a class, or some other global? I dont think I got that bit right (but itâs certainly better than nothing). >>>> >>>> e.g. in the debugger I am doing (in DoesNotUnderstandDebugAction) >>>> >>>> msg := self interruptedContext tempAt: 1. >>>> (msg lookupClass == UndefinedObject ) ifTrue: [ >>>> ^self createMissingClassIn: self interruptedContext ]. >>>> >>>> >>>> Iâm not totally convinced that lookupClass has to be a class - although maybe its good enough. But really, at the time this happened - we probably knew better than to get a DNU debug action in the the first place - and equally the title in the debugger could be something more akin to the kind of action its supposed to be. >>>> >>>> Anyway - this is all musing on my part - and I will assemble a proper PR for review by you guys (and at least it advances us forward - and maybe opens the door to better changes further on). >>>> >>>> Iâm just juggling another change at the moment - so it will be a few days. >>>> >>>> Tim >>>> >>>> Sent from my iPhone >>>> >>>>> On 23 Aug 2018, at 05:33, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>> >>>>> >>>>> >>>>>> On 22 Aug 2018, at 16:24, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>> >>>>>> Hi - but I guess my question is (and excuse my basic knowledge in this area) - when a class isnât found - can we do better than return nil so that the debugger can give a better msg and presumably the code Iâve written could live on that undefined object? Or am thinking about this wrong? >>>>> >>>>> In pharo7 we could easily do that (due to the âbindingâ, the meta class of the variable) being different. We could return a nil subclass or add code into the method directly. But the problem with that is that nil checks >>>>> are always identity checksâ¦ >>>>> >>>>> Could you not in the case you now raise the error just fall back to the âdefine methodâ, the behaviour we have now? >>>>> >>>>> Marcus >>>>> >>>>>> >>>>>> I will also put together a pr for this in Pharo 7 if you think itâs a decent fix. >>>>>> >>>>>> Tim >>>>>> >>>>>> Sent from my iPhone >>>>>> >>>>>> >>>>>> >>>>>> Sent from my iPhone >>>>>>> On 22 Aug 2018, at 09:51, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I played with it, nice! >>>>>>> >>>>>>> I guess the case when you really get a DNU on nil (and want to create method there) does not really happenâ¦ extending nil is for special cases. >>>>>>> >>>>>>> Marcus >>>>>>> >>>>>>> >>>>>>>> On 22 Aug 2018, at 13:39, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>> >>>>>>>> Sorry Marcus - you needed to follow the exercism instructions and right click on the exercism package to get an exercism menu to fetch a new exercise (e.g. hello-world). The is then using the TonalReader to pull in code - and then you get a test class that can reference a class that isnât there yet. (But you need to have the exercism cli installed as per the instructions etc). >>>>>>>> >>>>>>>> In retrospect I think it might be simpler to download this 6.1 image that already has done that - https://www.dropbox.com/s/x2ot9f8arbbvlyb/PharoExercism.zip?dl=0 >>>>>>>> It has TwoFerTest that is in that state. If you click on the TestWithName orb, you will see "#new was sent to nilâ - can you can see how my Create button has been fixed per you suggestions to create a class. (The code I wrote is in ExercismTools:DoesNotUnderstandDebugAction>>createMissingClassIn:) >>>>>>>> >>>>>>>> Tim >>>>>>>> >>>>>>>> >>>>>>>>> On 22 Aug 2018, at 04:44, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> On 17 Aug 2018, at 14:20, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>>>> >>>>>>>>>> The direct link to instructions is here: https://exercism.io/tracks/pharo/installation (not sure if you have to be signed up to see it otherwise its in the repo here: https://github.com/exercism/pharo/blob/master/docs/INSTALLATION.md) >>>>>>>>> >>>>>>>>> Hmâ¦ AllExercismTests seems to not be there (just a green test in Welcome) >>>>>>>>> >>>>>>>>> Is this supposed to contain the code below (the createMissingClassActionFor:in:) ? >>>>>>>>> >>>>>>>>> It would be nice to have an image that shows exactly the problem (I do not have that much time sadly to work on it,but I do have some time to check if I have an image that is set up to the point where i can easily recreate the problem) >>>>>>>>> >>>>>>>>> Marcus >>>>>>>>> >>>>>>>>> >>>>>>>>>> Tim >>>>>>>>>> >>>>>>>>>>> On 17 Aug 2018, at 07:17, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On 17 Aug 2018, at 13:00, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Hi Marcus - I can put an image somewhere if that helps (do you just need the .image and .changes)? >>>>>>>>>>>> >>>>>>>>>>>> Or you can repro from a fresh 6.1 if you follow the exercism Pharo instructions (https://exercism.io/tracks/pharo) to load the first hello world-world example and run the tests. This has my code changes to make create work with a nil class - but maybe we can do better? >>>>>>>>>>> I will do that and have a look! >>>>>>>>>>> >>>>>>>>>>>> Tim >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Sent from my iPhone >>>>>>>>>>>> >>>>>>>>>>>>> On 17 Aug 2018, at 06:21, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> On 10 Aug 2018, at 23:16, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Actually I think I figured that bit out - a bit clumsily - (pointers appreciated) >>>>>>>>>>>>>> >>>>>>>>>>>>>> createMissingClassActionFor: aMessage in: aContext >>>>>>>>>>>>>> |errorNode senderContext newClass variableNode | >>>>>>>>>>>>>> senderContext := aContext sender. >>>>>>>>>>>>>> errorNode := senderContext method sourceNodeExecutedForPC: senderContext pc. >>>>>>>>>>>>>> variableNode := errorNode receiver receiver. >>>>>>>>>>>>>> >>>>>>>>>>>>>> newClass := OCUndeclaredVariableWarning new node: variableNode; defineClass: variableNode name. >>>>>>>>>>>>>> aContext restart. >>>>>>>>>>>>>> >>>>>>>>>>>>>> However that last line is wrong, as it doesnât restart with my newly defined class - I also tried >>>>>>>>>>>>>> >>>>>>>>>>>>>> aContext restartWithNewReceiver: newClass >>>>>>>>>>>>>> >>>>>>>>>>>>>> But again, I get a debugger where my class is still bound to nil. So whatâs the trick to re-evaluate with the new class Iâve created? Or maybe Iâm totally on the wrong track (still its very interestingâ¦) >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> what is a bit bad is that you catch the problem âtoo lateâ (that is, the DNU to nil, not the read of nil), so nil is already pushed on the stack at this point. >>>>>>>>>>>>> >>>>>>>>>>>>> I tried it in the inspector and at least the class binding was correct after defining the classâ¦ do you have an image with the whole code to try? >>>>>>>>>>>>> >>>>>>>>>>>>> Marcus >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>> >>> >>> >> >> >

Aug. 31, 2018

Re: [Pharo-users] Loading a dll usinf UFFI on Win32

by JesÃºs MarÃ

So nice! i have installed c++redistributable 2010 and everything works fine! Many thanks Marten! -- Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Aug. 30, 2018

Re: [Pharo-users] When we create a missing method in debugger - why does it end with a dot?

by Joachim Tuchel

Agreed, Marcus. In case of the trailing dot it is not only about beauty, however. Most people who favor the dot think about the poor developer who comes after them and needs to append new statements to existing methods. Some people would say: whatâs the deal here? The deal is that syntax highlighters and autoconpleters tend to fail for the new statements, and most certainly your method change will not compile just because of that missing dot. Again: oust a few seconds to understand whatâs wrong, easy to fix and no big deal. But it costs brain capacity that could be spent better. Not sure a âvirtual dotâ visually added by a pretty printer would help here. Iâm afraid it would make things worse, unless it is intelligent enough to know when to âmaterializeâ that virtual dot (I.e. add it to the method whenever somebody writes code after the last statement. Joachim ...ainât it funny this little dot is back in discussions decades after it was fought over and cost lives back in the 90ies? Seems weâre not over it yet > Am 30.08.2018 um 09:59 schrieb Marcus Denker <marcus.denker(a)inria.fr>: > > > >> On 30 Aug 2018, at 06:36, Tim Mackinnon <tim(a)testit.works> wrote: >> >> I am looking at porting my missing class creation code into Pharo 7, and I notice there is a DynamicMessageImplementor that does this for methods - but Iâm wondering why when we create a missing method with âself souldBeImplemented.â with a trailing â.â? >> >> The Smalltalk style guide normally says the last statement shouldnât have a dot - and I notice some recent cleanups removed some dots on methods (presumably the formatter). >> >> This is a bit of a special case as the intent is to replace that method - but shouldnât we create without the dot to set a good example anyway? >> >> If so, I can include that change in my pr. >> > > I think there are both schools aroundâ¦ with some preference of no . at the end. > > Sometimes I think that a system that would have a good pretty printer and *always* pretty print would be nice: you would configure this once, and all code > would be shown in your âbest readableâ styleâ¦ > > Marcus > > >

Aug. 30, 2018

Re: [Pharo-users] When we create a missing method in debugger - why does it end with a dot?

by Marcus Denker

> On 30 Aug 2018, at 06:36, Tim Mackinnon <tim(a)testit.works> wrote: > > I am looking at porting my missing class creation code into Pharo 7, and I notice there is a DynamicMessageImplementor that does this for methods - but Iâm wondering why when we create a missing method with âself souldBeImplemented.â with a trailing â.â? > > The Smalltalk style guide normally says the last statement shouldnât have a dot - and I notice some recent cleanups removed some dots on methods (presumably the formatter). > > This is a bit of a special case as the intent is to replace that method - but shouldnât we create without the dot to set a good example anyway? > > If so, I can include that change in my pr. > I think there are both schools aroundâ¦ with some preference of no . at the end. Sometimes I think that a system that would have a good pretty printer and *always* pretty print would be nice: you would configure this once, and all code would be shown in your âbest readableâ styleâ¦ Marcus

Aug. 30, 2018

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

by Marcus Denker

Thanks! I will have a look at the sprint tomorrow. > On 30 Aug 2018, at 07:11, Tim Mackinnon <tim(a)testit.works> wrote: > > Iâve submitted a PR for what I did, so at least it improves the situation (but potentially could get even more refined as you suggest) > > Tim > >> On 23 Aug 2018, at 11:26, Marcus Denker <marcus.denker(a)inria.fr> wrote: >> >> >> >>> On 23 Aug 2018, at 15:56, Tim Mackinnon <tim(a)testit.works> wrote: >>> >>> Hi Marcus - thatâs actually what I do - and âcreateâ in this case, creates a class and then restarts like the method case does. >>> >> >> Yes, that I saw. >> >> But I mean a different case: Imagine you do have code like >> >> nil doSomething >> >> or an expression that evaluates to nil, press âdefineâ and get a method definition dialog, not the error message? >> (it is, as I mentioned, not that important as nobody ever wants to define a method in UndefinedObject, but for consistency it would be nice) >> >> >>> I guess I was wondering if we can do it more cleanly and also improve the debugger message. >>> >>> If Iâve understood you guys correctly- you try to remove the ambiguity around operations. Looking up a class and getting nil - seems like one of these holes you keep sorting out. >>> >>> I think the flaw in my solution is understanding if that message was being sent to a class, or some other global? I dont think I got that bit right (but itâs certainly better than nothing). >>> >>> e.g. in the debugger I am doing (in DoesNotUnderstandDebugAction) >>> >>> msg := self interruptedContext tempAt: 1. >>> (msg lookupClass == UndefinedObject ) ifTrue: [ >>> ^self createMissingClassIn: self interruptedContext ]. >>> >>> >>> Iâm not totally convinced that lookupClass has to be a class - although maybe its good enough. But really, at the time this happened - we probably knew better than to get a DNU debug action in the the first place - and equally the title in the debugger could be something more akin to the kind of action its supposed to be. >>> >>> Anyway - this is all musing on my part - and I will assemble a proper PR for review by you guys (and at least it advances us forward - and maybe opens the door to better changes further on). >>> >>> Iâm just juggling another change at the moment - so it will be a few days. >>> >>> Tim >>> >>> Sent from my iPhone >>> >>>> On 23 Aug 2018, at 05:33, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>> >>>> >>>> >>>>> On 22 Aug 2018, at 16:24, Tim Mackinnon <tim(a)testit.works> wrote: >>>>> >>>>> Hi - but I guess my question is (and excuse my basic knowledge in this area) - when a class isnât found - can we do better than return nil so that the debugger can give a better msg and presumably the code Iâve written could live on that undefined object? Or am thinking about this wrong? >>>> >>>> In pharo7 we could easily do that (due to the âbindingâ, the meta class of the variable) being different. We could return a nil subclass or add code into the method directly. But the problem with that is that nil checks >>>> are always identity checksâ¦ >>>> >>>> Could you not in the case you now raise the error just fall back to the âdefine methodâ, the behaviour we have now? >>>> >>>> Marcus >>>> >>>>> >>>>> I will also put together a pr for this in Pharo 7 if you think itâs a decent fix. >>>>> >>>>> Tim >>>>> >>>>> Sent from my iPhone >>>>> >>>>> >>>>> >>>>> Sent from my iPhone >>>>>> On 22 Aug 2018, at 09:51, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I played with it, nice! >>>>>> >>>>>> I guess the case when you really get a DNU on nil (and want to create method there) does not really happenâ¦ extending nil is for special cases. >>>>>> >>>>>> Marcus >>>>>> >>>>>> >>>>>>> On 22 Aug 2018, at 13:39, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>> >>>>>>> Sorry Marcus - you needed to follow the exercism instructions and right click on the exercism package to get an exercism menu to fetch a new exercise (e.g. hello-world). The is then using the TonalReader to pull in code - and then you get a test class that can reference a class that isnât there yet. (But you need to have the exercism cli installed as per the instructions etc). >>>>>>> >>>>>>> In retrospect I think it might be simpler to download this 6.1 image that already has done that - https://www.dropbox.com/s/x2ot9f8arbbvlyb/PharoExercism.zip?dl=0 >>>>>>> It has TwoFerTest that is in that state. If you click on the TestWithName orb, you will see "#new was sent to nilâ - can you can see how my Create button has been fixed per you suggestions to create a class. (The code I wrote is in ExercismTools:DoesNotUnderstandDebugAction>>createMissingClassIn:) >>>>>>> >>>>>>> Tim >>>>>>> >>>>>>> >>>>>>>> On 22 Aug 2018, at 04:44, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> On 17 Aug 2018, at 14:20, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>>> >>>>>>>>> The direct link to instructions is here: https://exercism.io/tracks/pharo/installation (not sure if you have to be signed up to see it otherwise its in the repo here: https://github.com/exercism/pharo/blob/master/docs/INSTALLATION.md) >>>>>>>> >>>>>>>> Hmâ¦ AllExercismTests seems to not be there (just a green test in Welcome) >>>>>>>> >>>>>>>> Is this supposed to contain the code below (the createMissingClassActionFor:in:) ? >>>>>>>> >>>>>>>> It would be nice to have an image that shows exactly the problem (I do not have that much time sadly to work on it,but I do have some time to check if I have an image that is set up to the point where i can easily recreate the problem) >>>>>>>> >>>>>>>> Marcus >>>>>>>> >>>>>>>> >>>>>>>>> Tim >>>>>>>>> >>>>>>>>>> On 17 Aug 2018, at 07:17, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On 17 Aug 2018, at 13:00, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hi Marcus - I can put an image somewhere if that helps (do you just need the .image and .changes)? >>>>>>>>>>> >>>>>>>>>>> Or you can repro from a fresh 6.1 if you follow the exercism Pharo instructions (https://exercism.io/tracks/pharo) to load the first hello world-world example and run the tests. This has my code changes to make create work with a nil class - but maybe we can do better? >>>>>>>>>> I will do that and have a look! >>>>>>>>>> >>>>>>>>>>> Tim >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Sent from my iPhone >>>>>>>>>>> >>>>>>>>>>>> On 17 Aug 2018, at 06:21, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> On 10 Aug 2018, at 23:16, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Actually I think I figured that bit out - a bit clumsily - (pointers appreciated) >>>>>>>>>>>>> >>>>>>>>>>>>> createMissingClassActionFor: aMessage in: aContext >>>>>>>>>>>>> |errorNode senderContext newClass variableNode | >>>>>>>>>>>>> senderContext := aContext sender. >>>>>>>>>>>>> errorNode := senderContext method sourceNodeExecutedForPC: senderContext pc. >>>>>>>>>>>>> variableNode := errorNode receiver receiver. >>>>>>>>>>>>> >>>>>>>>>>>>> newClass := OCUndeclaredVariableWarning new node: variableNode; defineClass: variableNode name. >>>>>>>>>>>>> aContext restart. >>>>>>>>>>>>> >>>>>>>>>>>>> However that last line is wrong, as it doesnât restart with my newly defined class - I also tried >>>>>>>>>>>>> >>>>>>>>>>>>> aContext restartWithNewReceiver: newClass >>>>>>>>>>>>> >>>>>>>>>>>>> But again, I get a debugger where my class is still bound to nil. So whatâs the trick to re-evaluate with the new class Iâve created? Or maybe Iâm totally on the wrong track (still its very interestingâ¦) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> what is a bit bad is that you catch the problem âtoo lateâ (that is, the DNU to nil, not the read of nil), so nil is already pushed on the stack at this point. >>>>>>>>>>>> >>>>>>>>>>>> I tried it in the inspector and at least the class binding was correct after defining the classâ¦ do you have an image with the whole code to try? >>>>>>>>>>>> >>>>>>>>>>>> Marcus >>>>>> >>>>>> >>>>> >>>>> >>>> >>>> >>> >> >> > >

Aug. 30, 2018

Re: [Pharo-users] Loading a dll usinf UFFI on Win32

by Marten Feldtmann

Perhaps you are missing the Microsoft runtime (v100) ? Marten Am 29.08.2018 um 22:45 schrieb JesÃºs MarÃ: > I'm trying to make zeromq work on win 32. zeromq lib is in C:\Program Files > (x86)\ZeroMQ 4.0.4\bin\libzmq-v100-mt-4_0_4.dll . > > My Api #win32ModuleName returns exactly 'C:\Program Files (x86)\ZeroMQ > 4.0.4\bin\libzmq-v100-mt-4_0_4.dll' but when I try lo execute any call it > returns "module not found" error. > > Any suggestion? > > > > > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html > -- Marten Feldtmann

Aug. 30, 2018

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

by Tim Mackinnon

Iâve submitted a PR for what I did, so at least it improves the situation (but potentially could get even more refined as you suggest) Tim > On 23 Aug 2018, at 11:26, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > > >> On 23 Aug 2018, at 15:56, Tim Mackinnon <tim(a)testit.works> wrote: >> >> Hi Marcus - thatâs actually what I do - and âcreateâ in this case, creates a class and then restarts like the method case does. >> > > Yes, that I saw. > > But I mean a different case: Imagine you do have code like > > nil doSomething > > or an expression that evaluates to nil, press âdefineâ and get a method definition dialog, not the error message? > (it is, as I mentioned, not that important as nobody ever wants to define a method in UndefinedObject, but for consistency it would be nice) > > >> I guess I was wondering if we can do it more cleanly and also improve the debugger message. >> >> If Iâve understood you guys correctly- you try to remove the ambiguity around operations. Looking up a class and getting nil - seems like one of these holes you keep sorting out. >> >> I think the flaw in my solution is understanding if that message was being sent to a class, or some other global? I dont think I got that bit right (but itâs certainly better than nothing). >> >> e.g. in the debugger I am doing (in DoesNotUnderstandDebugAction) >> >> msg := self interruptedContext tempAt: 1. >> (msg lookupClass == UndefinedObject ) ifTrue: [ >> ^self createMissingClassIn: self interruptedContext ]. >> >> >> Iâm not totally convinced that lookupClass has to be a class - although maybe its good enough. But really, at the time this happened - we probably knew better than to get a DNU debug action in the the first place - and equally the title in the debugger could be something more akin to the kind of action its supposed to be. >> >> Anyway - this is all musing on my part - and I will assemble a proper PR for review by you guys (and at least it advances us forward - and maybe opens the door to better changes further on). >> >> Iâm just juggling another change at the moment - so it will be a few days. >> >> Tim >> >> Sent from my iPhone >> >>> On 23 Aug 2018, at 05:33, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>> >>> >>> >>>> On 22 Aug 2018, at 16:24, Tim Mackinnon <tim(a)testit.works> wrote: >>>> >>>> Hi - but I guess my question is (and excuse my basic knowledge in this area) - when a class isnât found - can we do better than return nil so that the debugger can give a better msg and presumably the code Iâve written could live on that undefined object? Or am thinking about this wrong? >>> >>> In pharo7 we could easily do that (due to the âbindingâ, the meta class of the variable) being different. We could return a nil subclass or add code into the method directly. But the problem with that is that nil checks >>> are always identity checksâ¦ >>> >>> Could you not in the case you now raise the error just fall back to the âdefine methodâ, the behaviour we have now? >>> >>> Marcus >>> >>>> >>>> I will also put together a pr for this in Pharo 7 if you think itâs a decent fix. >>>> >>>> Tim >>>> >>>> Sent from my iPhone >>>> >>>> >>>> >>>> Sent from my iPhone >>>>> On 22 Aug 2018, at 09:51, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>> >>>>> Hi, >>>>> >>>>> I played with it, nice! >>>>> >>>>> I guess the case when you really get a DNU on nil (and want to create method there) does not really happenâ¦ extending nil is for special cases. >>>>> >>>>> Marcus >>>>> >>>>> >>>>>> On 22 Aug 2018, at 13:39, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>> >>>>>> Sorry Marcus - you needed to follow the exercism instructions and right click on the exercism package to get an exercism menu to fetch a new exercise (e.g. hello-world). The is then using the TonalReader to pull in code - and then you get a test class that can reference a class that isnât there yet. (But you need to have the exercism cli installed as per the instructions etc). >>>>>> >>>>>> In retrospect I think it might be simpler to download this 6.1 image that already has done that - https://www.dropbox.com/s/x2ot9f8arbbvlyb/PharoExercism.zip?dl=0 >>>>>> It has TwoFerTest that is in that state. If you click on the TestWithName orb, you will see "#new was sent to nilâ - can you can see how my Create button has been fixed per you suggestions to create a class. (The code I wrote is in ExercismTools:DoesNotUnderstandDebugAction>>createMissingClassIn:) >>>>>> >>>>>> Tim >>>>>> >>>>>> >>>>>>> On 22 Aug 2018, at 04:44, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>> On 17 Aug 2018, at 14:20, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>> >>>>>>>> The direct link to instructions is here: https://exercism.io/tracks/pharo/installation (not sure if you have to be signed up to see it otherwise its in the repo here: https://github.com/exercism/pharo/blob/master/docs/INSTALLATION.md) >>>>>>> >>>>>>> Hmâ¦ AllExercismTests seems to not be there (just a green test in Welcome) >>>>>>> >>>>>>> Is this supposed to contain the code below (the createMissingClassActionFor:in:) ? >>>>>>> >>>>>>> It would be nice to have an image that shows exactly the problem (I do not have that much time sadly to work on it,but I do have some time to check if I have an image that is set up to the point where i can easily recreate the problem) >>>>>>> >>>>>>> Marcus >>>>>>> >>>>>>> >>>>>>>> Tim >>>>>>>> >>>>>>>>> On 17 Aug 2018, at 07:17, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> On 17 Aug 2018, at 13:00, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Hi Marcus - I can put an image somewhere if that helps (do you just need the .image and .changes)? >>>>>>>>>> >>>>>>>>>> Or you can repro from a fresh 6.1 if you follow the exercism Pharo instructions (https://exercism.io/tracks/pharo) to load the first hello world-world example and run the tests. This has my code changes to make create work with a nil class - but maybe we can do better? >>>>>>>>> I will do that and have a look! >>>>>>>>> >>>>>>>>>> Tim >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Sent from my iPhone >>>>>>>>>> >>>>>>>>>>> On 17 Aug 2018, at 06:21, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On 10 Aug 2018, at 23:16, Tim Mackinnon <tim(a)testit.works> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Actually I think I figured that bit out - a bit clumsily - (pointers appreciated) >>>>>>>>>>>> >>>>>>>>>>>> createMissingClassActionFor: aMessage in: aContext >>>>>>>>>>>> |errorNode senderContext newClass variableNode | >>>>>>>>>>>> senderContext := aContext sender. >>>>>>>>>>>> errorNode := senderContext method sourceNodeExecutedForPC: senderContext pc. >>>>>>>>>>>> variableNode := errorNode receiver receiver. >>>>>>>>>>>> >>>>>>>>>>>> newClass := OCUndeclaredVariableWarning new node: variableNode; defineClass: variableNode name. >>>>>>>>>>>> aContext restart. >>>>>>>>>>>> >>>>>>>>>>>> However that last line is wrong, as it doesnât restart with my newly defined class - I also tried >>>>>>>>>>>> >>>>>>>>>>>> aContext restartWithNewReceiver: newClass >>>>>>>>>>>> >>>>>>>>>>>> But again, I get a debugger where my class is still bound to nil. So whatâs the trick to re-evaluate with the new class Iâve created? Or maybe Iâm totally on the wrong track (still its very interestingâ¦) >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> what is a bit bad is that you catch the problem âtoo lateâ (that is, the DNU to nil, not the read of nil), so nil is already pushed on the stack at this point. >>>>>>>>>>> >>>>>>>>>>> I tried it in the inspector and at least the class binding was correct after defining the classâ¦ do you have an image with the whole code to try? >>>>>>>>>>> >>>>>>>>>>> Marcus >>>>> >>>>> >>>> >>>> >>> >>> >> > >

Aug. 30, 2018

When we create a missing method in debugger - why does it end with a dot?

by Tim Mackinnon

I am looking at porting my missing class creation code into Pharo 7, and I notice there is a DynamicMessageImplementor that does this for methods - but Iâm wondering why when we create a missing method with âself souldBeImplemented.â with a trailing â.â? The Smalltalk style guide normally says the last statement shouldnât have a dot - and I notice some recent cleanups removed some dots on methods (presumably the formatter). This is a bit of a special case as the intent is to replace that method - but shouldnât we create without the dot to set a good example anyway? If so, I can include that change in my pr. Tim

Aug. 30, 2018

Re: [Pharo-users] Latest Pharo 7 image doesn't give normal debugger on a method with undefined class method - get System Error

by Tim Mackinnon

Excuse the noise - this was user error, I synchronised my Pharo repository with an out of date local copy, so I must have brought in some incompatible changes with the new VM. Phew ! Tim > On 29 Aug 2018, at 23:42, Tim Mackinnon <tim(a)testit.works> wrote: > > I was going to look at testing my Create class in the debugger fixes however the latest image behaves in a manner Iâve not seen before. > > In a fresh P7 image - build 1198 64bit osx (with latest vm downloaded by launcher) - I have created a new class in a new package > > TimTest:TimTest>>testMethod > "self new testMethod" > FooObject new someMethod > > Where FooObject and someMethod are undefined and when I saved the method I left them as undefined. > > I then evaluated - TimeTest new testMethod in a playground and I get a white screen with *** System error handling failed *** (screenshot below) > > In an earlier image (build 1167) this wasnât the case? > > Has something been broken? > > Tim > > <PastedGraphic-1.png>

Aug. 30, 2018

Latest Pharo 7 image doesn't give normal debugger on a method with undefined class method - get System Error

by Tim Mackinnon

I was going to look at testing my Create class in the debugger fixes however the latest image behaves in a manner Iâve not seen before. In a fresh P7 image - build 1198 64bit osx (with latest vm downloaded by launcher) - I have created a new class in a new package TimTest:TimTest>>testMethod "self new testMethod" FooObject new someMethod Where FooObject and someMethod are undefined and when I saved the method I left them as undefined. I then evaluated - TimeTest new testMethod in a playground and I get a white screen with *** System error handling failed *** (screenshot below) In an earlier image (build 1167) this wasnât the case? Has something been broken? Tim

Aug. 30, 2018