- Pharo-users - lists.pharo.org

Re: [Pharo-users] Examples of bad code

by webwarrior

In old Pharo code (Morphic, etc.) there's a lot of wierd stuff. My favourite is DockingBarMorph>>#predominantDockingBarsOfChastes: Though it explains what "predominant" means in a long comment, it's absolutely unclear what the heck "chaste" is. -- Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Nov. 12, 2018

Examples of bad code

by Oleksandr Zaytsev

Hello, Do you know of some good examples of code that is unreadable because of the bad and inconsistent naming? I want to show some motivating example in my thesis about the aspects of software naturalness through the generation of identifier names. I'm sure that Pharo has many bad code inside, but this has to be something 1. From the real project written by experienced developers or a nice community (not some toy example or a code of bad developers) 2. With identifier names so bad that 2-3 chunks of code are enough to demonstrate how incomprehensible this code is. I need it to prove the point that 1. Bad naming can really harm the readability 2. Bad naming is not just a result of carelessness and lack of experience. Bad names often appear in successful projects and are introduced by experienced developers as a result of software evolution (many people write and rewrite the same code many times introducing inconsistencies and failing to understand each other's intentions and different parts of the system). Do you know some good examples of bad code from PolyMath, Seaside, Moose etc.? Oleks

Nov. 12, 2018

Re: [Pharo-users] ToManyRelationSlot variant with an ordered collection?

by Marcus Denker

> On 10 Nov 2018, at 22:52, Tudor Girba <tudor(a)tudorgirba.com> wrote: > > Hi, > > The current implementation of ToManyRelationSlot is based on a RelationSet which holds the items in a Set. > > Is there an implementation that holds the items in an ordered collection? Not that I know, but it would be interesting to experiment with this! Marcus

Nov. 12, 2018

ToManyRelationSlot variant with an ordered collection?

by Tudor Girba

Hi, The current implementation of ToManyRelationSlot is based on a RelationSet which holds the items in a Set. Is there an implementation that holds the items in an ordered collection? Cheers, Doru -- www.feenk.com "Some battles are better lost than fought."

Nov. 10, 2018

Re: [Pharo-users] what must be instead of the ??

by Richard O'Keefe

We are talking to a beginner here. One of the important things for a beginner to understand is the idea of hiding stuff and thinking in terms of asking objects to do things for you. For example, in Java you historically did final int n = aString.length(); for (int i = 0; i < n; i++) { final char c = aString.charAt(i); ... } Here all the loop control is *outside* the string, and if you wanted to use some other data structure you would have to change the code. But in Smalltalk, you ask the *object* to manage the iteration. For collections in general, we have aCollection do: [:anElement | ... ] For sequences we also have aSequence withIndexDo: [:anElement :itsIndex | ...] where the sequence need not be a stored sequence and need not be efficiently indexable. (And indeed, in Java these days, Strings *aren't* efficiently indexable, thanks to using UTF-16 internally.) Using enumeration methods (a) makes your code easier to read (b) makes your code easier to write (as there is lots of fiddly detail you don't write at all, it's there once and for all in the class) (c) makes your code more adaptable (the object needs to support #withIndexDo: and that is *all* you demand of it). indexWhereBasementFirstReached: input "The input is a sequence in which the character ( means to go up a floor and the character ) means to go down a floor. Answer the index of the character where the floor below the initial floor is first reached. If that floor is not reached, e.g., if the input is empty, answer 0. This is the same convention as #indexOf:." |floor| floor := 0. input withIndexDo: [:char :index | char = $( ifTrue: [floor := floor + 1]. char = $) ifTrue: [floor := floor - 1]. floor = -1 ifTrue: [^index]]. ^0 For example, we could add the #withIndexDo: method to Stream, which already has #do: withIndexDo: elementAndIndexBlock "Iterate over the 'future values' remaining in this stream, passing each in turn to the block argument, together with an index starting at 1 for the first value passed to the block." |index| index := 0. self do: [:each | elementAndIndexBlock value: each value: (index := index + 1)]. Now the #indexWhereBasementFirstReached: method will work on input streams as well as strings, so it could, for example, handle a terabyte long sequence held in a file. On Sat, 10 Nov 2018 at 06:17, Roelof Wobben <r.wobben(a)home.nl> wrote: > hmm. > > When I try this on P7 > > |input stepChanges floor| > input := '((('. > floor := 0. > stepChanges := input collect: [ :c | > floor := floor + (c = '(' ifTrue: [ 1 ] ifFalse: [ -1 ]). > floor > ]. > > stepChanges detectIndex: [ :each | each = -1 ] ifNone: [ 'invalid input > yo' ]. > > then I see this error message : Improper store to indexable object. > > Roelof > > > Op 9-11-2018 om 17:39 schreef Roelof Wobben: > > stepChanges := input collect: [ :c | > floor := floor + (c = '(' ifTrue: [ 1 ] ifFalse: [ -1 ]). > floor > ]. > > stepChanges detectIndex: [ :each | each = -1 ] ifNone: [ 'invalid input > yo' ]. > > >

Nov. 10, 2018

Re: [Pharo-users] what must be instead of the ??

by Roelof Wobben

Given up for today I have this : calculateFloors | stepChanges floor| floor := 0. stepChanges := input asArray collect: [ :c | floor := floor+ (c = $( ifTrue: [ 1 ] ifFalse: [ -1 ]). ]. floors addFloor: floor. but now I see this error message : temp values not written or read. floors and input are instance variables where input is the input the user wants to use and floors is a Collection new. Roelof Op 9-11-2018 om 20:07 schreef Roelof Wobben: > hmm, got a idea > > I could use this part : > > |input floor stepChanges| > input := '))((((('. > floor := 0. > stepChanges := input asArray collect: [ :c | > floor := floor + (c = $( ifTrue: [ 1 ] ifFalse: [ -1 ]). > Â ]. > > > two times if the outcome would be a collection. > The challenge is 2 parts. > > 1) find out where santa stops. that would be the last number in the > collection.. > 2) find out when santa enters the basement. That could be the function > that is mentioned here. > > Time to experiment with this idea. > > Roelof > > > Op 9-11-2018 om 19:13 schreef Alistair Grant: >> Hi Peter, >> >> On Fri, 9 Nov 2018 at 19:00, Alistair Grant <akgrant0710(a)gmail.com> >> wrote: >>> Hi Peter, >>> >>> On Fri, 9 Nov 2018 at 18:51, Peter Uhnak <i.uhnak(a)gmail.com> wrote: >>>>> but how do I find now the answer do I have to do something likeÂ Â >>>>> puzzle1Â stepChanges detectIndex ? >>>> >>>> How do you mean? It would be the same >>>> >>>> santaFloorOnBasement >>>> Â Â Â Â "calculates which step take Santa to the basement" >>>> >>>> Â Â Â Â stepChanges := input collect: [ :c | >>>> floor := floor + (c = '(' ifTrue: [ 1 ] ifFalse: [ -1 ]). >>>> floor >>>> Â Â Â Â ]. >>>> >>>> Â Â Â Â stepChanges detectIndex: [ :each | each = -1 ] ifNone: [ >>>> 'invalid input yo' ]. >>>> >>>>> then I see this error message : Improper store to indexable object. >>>> >>>> Because earlier you were comparing strings and not characters, I >>>> assumed your input was an array of strings like #('(' '(' '('). but >>>> you can fix that by changing `input collect:` -> `input asArray >>>> collect:` and `c = '('` -> `c = $(`. >>> Using '(' instead of $( is indeed an error, but it isn't the cause of >>> the Improper store error. >> I was too quick to respond here, I didn't look at the #asArray. Sorry! >> >> But still suggest Roelof looks at the debugger... >> >>> Roelof, I really suggest you trigger this error again, start the >>> debugger and then take a look in the call stack (I'm assuming you're >>> familiar with at least one other programming language, so should be >>> able to figure out the debugger). >> Cheers, >> Alistair >> >> > > >

Nov. 9, 2018

Re: [Pharo-users] what must be instead of the ??

by Roelof Wobben

hmm, got a idea I could use this part : |input floor stepChanges| input := '))((((('. floor := 0. stepChanges := input asArray collect: [ :c | floor := floor + (c = $( ifTrue: [ 1 ] ifFalse: [ -1 ]). Â ]. two times if the outcome would be a collection. The challenge is 2 parts. 1) find out where santa stops. that would be the last number in the collection.. 2) find out when santa enters the basement. That could be the function that is mentioned here. Time to experiment with this idea. Roelof Op 9-11-2018 om 19:13 schreef Alistair Grant: > Hi Peter, > > On Fri, 9 Nov 2018 at 19:00, Alistair Grant <akgrant0710(a)gmail.com> wrote: >> Hi Peter, >> >> On Fri, 9 Nov 2018 at 18:51, Peter Uhnak <i.uhnak(a)gmail.com> wrote: >>>> but how do I find now the answer do I have to do something like puzzle1 stepChanges detectIndex ? >>> >>> How do you mean? It would be the same >>> >>> santaFloorOnBasement >>> "calculates which step take Santa to the basement" >>> >>> stepChanges := input collect: [ :c | >>> floor := floor + (c = '(' ifTrue: [ 1 ] ifFalse: [ -1 ]). >>> floor >>> ]. >>> >>> stepChanges detectIndex: [ :each | each = -1 ] ifNone: [ 'invalid input yo' ]. >>> >>>> then I see this error message : Improper store to indexable object. >>> >>> Because earlier you were comparing strings and not characters, I assumed your input was an array of strings like #('(' '(' '('). but you can fix that by changing `input collect:` -> `input asArray collect:` and `c = '('` -> `c = $(`. >> Using '(' instead of $( is indeed an error, but it isn't the cause of >> the Improper store error. > I was too quick to respond here, I didn't look at the #asArray. Sorry! > > But still suggest Roelof looks at the debugger... > >> Roelof, I really suggest you trigger this error again, start the >> debugger and then take a look in the call stack (I'm assuming you're >> familiar with at least one other programming language, so should be >> able to figure out the debugger). > Cheers, > Alistair > >

Nov. 9, 2018

Re: [Pharo-users] what must be instead of the ??

by Roelof Wobben

Nov. 9, 2018

Re: [Pharo-users] what must be instead of the ??

by Alistair Grant

Hi Peter, On Fri, 9 Nov 2018 at 19:00, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > Hi Peter, > > On Fri, 9 Nov 2018 at 18:51, Peter Uhnak <i.uhnak(a)gmail.com> wrote: > >> > >> but how do I find now the answer do I have to do something like puzzle1 stepChanges detectIndex ? > > > > > > How do you mean? It would be the same > > > > santaFloorOnBasement > > "calculates which step take Santa to the basement" > > > > stepChanges := input collect: [ :c | > > floor := floor + (c = '(' ifTrue: [ 1 ] ifFalse: [ -1 ]). > > floor > > ]. > > > > stepChanges detectIndex: [ :each | each = -1 ] ifNone: [ 'invalid input yo' ]. > > > >> then I see this error message : Improper store to indexable object. > > > > > > Because earlier you were comparing strings and not characters, I assumed your input was an array of strings like #('(' '(' '('). but you can fix that by changing `input collect:` -> `input asArray collect:` and `c = '('` -> `c = $(`. > > Using '(' instead of $( is indeed an error, but it isn't the cause of > the Improper store error. I was too quick to respond here, I didn't look at the #asArray. Sorry! But still suggest Roelof looks at the debugger... > Roelof, I really suggest you trigger this error again, start the > debugger and then take a look in the call stack (I'm assuming you're > familiar with at least one other programming language, so should be > able to figure out the debugger). Cheers, Alistair

Nov. 9, 2018

Re: [Pharo-users] what must be instead of the ??

by Alistair Grant

Hi Peter, On Fri, 9 Nov 2018 at 18:51, Peter Uhnak <i.uhnak(a)gmail.com> wrote: >> >> but how do I find now the answer do I have to do something like puzzle1 stepChanges detectIndex ? > > > How do you mean? It would be the same > > santaFloorOnBasement > "calculates which step take Santa to the basement" > > stepChanges := input collect: [ :c | > floor := floor + (c = '(' ifTrue: [ 1 ] ifFalse: [ -1 ]). > floor > ]. > > stepChanges detectIndex: [ :each | each = -1 ] ifNone: [ 'invalid input yo' ]. > >> then I see this error message : Improper store to indexable object. > > > Because earlier you were comparing strings and not characters, I assumed your input was an array of strings like #('(' '(' '('). but you can fix that by changing `input collect:` -> `input asArray collect:` and `c = '('` -> `c = $(`. Using '(' instead of $( is indeed an error, but it isn't the cause of the Improper store error. Roelof, I really suggest you trigger this error again, start the debugger and then take a look in the call stack (I'm assuming you're familiar with at least one other programming language, so should be able to figure out the debugger). Cheers, Alistair

Nov. 9, 2018