- Pharo-users - lists.pharo.org

Re: [Pharo-users] [GSoC blog post] Binary Search Trees

by ducasse

> On 8 Jul 2019, at 05:57, ducasse <stepharo(a)netcourrier.com> wrote: > > More feedback :) > > Do not return nil > Check the last lecture of the mooc > > Did you read Pharo with Style? > > I do not know if LinkedList is the one of the system used by Process but in that case use the alternate implementation. Sorry Iâ still jet lagged and sleepy But - bfs: is a bad name. - Also why not having a block to specify what we are looking for? > > > bfs: info > "Breadth fisrt search for an information. If there is no key containing given infomration returns nil. If the info is found returns a node containing it" > | queue | > self isEmpty > ifTrue: [ ^nil ]. > queue := LinkedList new. > queue addLast: self root. > > [ queue isNotEmpty ] whileTrue: [ > | node | > node := queue removeFirst. > node key == info > ifTrue: [ ^node ]. > node leftChild isNotNil > ifTrue: [ queue addLast: node leftChild ]. > node rightChild isNotNil > ifTrue: [ queue addLast: node rightChild ]. > ]. > ^nil. > > => > > bfs: info > "Breadth fisrt search for an information. If there is no key containing given infomration returns nil. If the info is found returns a node containing it" > | queue | > self isEmpty ifTrue: [ ^ self ]. > queue := LinkedList new. > queue addLast: self root. > > [ queue isNotEmpty ] whileTrue: [ > | node | > node := queue removeFirst. > node key == info > ifTrue: [ ^node ]. > node leftChild isNotNil > ifTrue: [ queue addLast: node leftChild ]. > node rightChild isNotNil > ifTrue: [ queue addLast: node rightChild ]. > ]

July 8, 2019

Re: [Pharo-users] [GSoC blog post] Binary Search Trees

by ducasse

More feedback :) Do not return nil Check the last lecture of the mooc Did you read Pharo with Style? I do not know if LinkedList is the one of the system used by Process but in that case use the alternate implementation. bfs: info "Breadth fisrt search for an information. If there is no key containing given infomration returns nil. If the info is found returns a node containing it" | queue | self isEmpty ifTrue: [ ^nil ]. queue := LinkedList new. queue addLast: self root. [ queue isNotEmpty ] whileTrue: [ | node | node := queue removeFirst. node key == info ifTrue: [ ^node ]. node leftChild isNotNil ifTrue: [ queue addLast: node leftChild ]. node rightChild isNotNil ifTrue: [ queue addLast: node rightChild ]. ]. ^nil. => bfs: info "Breadth fisrt search for an information. If there is no key containing given infomration returns nil. If the info is found returns a node containing it" | queue | self isEmpty ifTrue: [ ^ self ]. queue := LinkedList new. queue addLast: self root. [ queue isNotEmpty ] whileTrue: [ | node | node := queue removeFirst. node key == info ifTrue: [ ^node ]. node leftChild isNotNil ifTrue: [ queue addLast: node leftChild ]. node rightChild isNotNil ifTrue: [ queue addLast: node rightChild ]. ]

July 8, 2019

Re: [Pharo-users] [GSoC blog post] Binary Search Trees

by ducasse

> On 8 Jul 2019, at 05:51, ducasse <stepharo(a)netcourrier.com> wrote: > > > >> On 7 Jul 2019, at 23:12, Smiljana Knezev <smilja.knezev(a)gmail.com <mailto:smilja.knezev@gmail.com>> wrote: >> >> Dear all, >> >> I've written about implementing binary search trees: https://pharokeepers.github.io/pharo/2019/07/07/SmiljanaBinarySearchTreeinP… <https://pharokeepers.github.io/pharo/2019/07/07/SmiljanaBinarySearchTreeinP…> >> >> Feedback and opinions is always welcome :) > > pay attention to the formatting of your code. > It makes is difficult to read (I do not know if this is wordpress effect or not). > > Once you have your tree implementation and tests I would really like to see if you can get another implementation and measure > the impact of introducing a NullNode to remove all the isNil checks. Also no need of extra parentheses between binary and keywords depth:aNode "Returns depth of a tree starting from the given node" | leftDepth rightDepth | leftDepth := -1. aNode leftChild isNotNil ifTrue: [ leftDepth := self depth: aNode leftChild ]. rightDepth := -1. aNode rightChild isNotNil ifTrue: [ rightDepth := self depth: aNode rightChild ]. ( leftDepth > rightDepth ) ifTrue: [ ^ (1 + leftDepth) ] ifFalse: [^ (1 + rightDepth ) ]. => leftDepth > rightDepth ifTrue: [ ^ 1 + leftDepth ] ifFalse: [^ 1 + rightDepth ]. And even better move out of block returns when possible ^ leftDepth > rightDepth ifTrue: [ 1 + leftDepth ] ifFalse: [ 1 + rightDepth ]. With a nullNode the code should look like depth:aNode "Returns depth of a tree starting from the given nodeâ | leftDepth rightDepth | leftDepth := self depth: aNode leftChild. rightDepth := self depth: aNode rightChild. ^ leftDepth > rightDepth ifTrue: [ 1 + leftDepth ] ifFalse: [1 + rightDepth ] > > >> >> Best regards, >> Smiljana Knezev >

July 8, 2019

Re: [Pharo-users] [GSoC blog post] Binary Search Trees

by ducasse

> On 7 Jul 2019, at 23:12, Smiljana Knezev <smilja.knezev(a)gmail.com> wrote: > > Dear all, > > I've written about implementing binary search trees: https://pharokeepers.github.io/pharo/2019/07/07/SmiljanaBinarySearchTreeinP… <https://pharokeepers.github.io/pharo/2019/07/07/SmiljanaBinarySearchTreeinP…> > > Feedback and opinions is always welcome :) pay attention to the formatting of your code. It makes is difficult to read (I do not know if this is wordpress effect or not). Once you have your tree implementation and tests I would really like to see if you can get another implementation and measure the impact of introducing a NullNode to remove all the isNil checks. > > Best regards, > Smiljana Knezev

July 8, 2019

[GSoC blog post] Binary Search Trees

by Smiljana Knezev

Dear all, I've written about implementing binary search trees: https://pharokeepers.github.io/pharo/2019/07/07/SmiljanaBinarySearchTreeinP… Feedback and opinions is always welcome :) Best regards, Smiljana Knezev

July 7, 2019

Re: [Pharo-users] Cryptography decrufted

by Esteban Maringolo

Thank you Norbert! Esteban A. Maringolo On Fri, Jul 5, 2019 at 11:06 AM CÃ©drick BÃ©ler <cdrick65(a)gmail.com> wrote: > > Excellent job Norbert ! > > Thx, > > CÃ©drik > > > Le 5 juil. 2019 Ã 13:04, Norbert Hartl <norbert(a)hartl.name> a Ã©crit : > > > > I cannot remember how many years Iâm suffering with the poor quality of the Cryptography package. As people were complaining that voyage cannot be loaded in windows because cryptography contains old code that produces filenames with 311 charactern I decided to stop that. I changed the Cryptography repo in a way that: > > > > - all packages that are old squeak related have been removed > > - packages that could not be loaded into a pharo7 because of dependencies I donât know have been removed > > - loadable packages have been added in the baseline in the all group so everything is loaded and tested in travis > > - tests have been fixed where I could do that easily > > - tests that were failing and I donât know why have been added (with a comment) to expectFailures > > - after the removal I did a new version 0.4 for those who are interested in the cleaned old version > > - then I converted the source into tonel format > > - then I retired pharo4 and pharo5 for the travis builds because 3 yearsis enough for such a package > > - finally I did a version 0.5 with that state > > > > There were also packages removed like PasswordHashingFFI and CryptographyPlugins. Not sure if the FFI variant is recent or the CryptographyPlugins realtes to the vm. I removed every package in its own commit. So resurrecting a package should be easy as reverting a commit if someone needs it. > > > > Now Iâm udpating mongotalk and voyage. > > > > FYI, > > > > Norbert > >

July 5, 2019

Re: [Pharo-users] Cryptography decrufted

by CÃ©drick BÃ©ler

Excellent job Norbert ! Thx, CÃ©drik > Le 5 juil. 2019 Ã 13:04, Norbert Hartl <norbert(a)hartl.name> a Ã©crit : > > I cannot remember how many years Iâm suffering with the poor quality of the Cryptography package. As people were complaining that voyage cannot be loaded in windows because cryptography contains old code that produces filenames with 311 charactern I decided to stop that. I changed the Cryptography repo in a way that: > > - all packages that are old squeak related have been removed > - packages that could not be loaded into a pharo7 because of dependencies I donât know have been removed > - loadable packages have been added in the baseline in the all group so everything is loaded and tested in travis > - tests have been fixed where I could do that easily > - tests that were failing and I donât know why have been added (with a comment) to expectFailures > - after the removal I did a new version 0.4 for those who are interested in the cleaned old version > - then I converted the source into tonel format > - then I retired pharo4 and pharo5 for the travis builds because 3 yearsis enough for such a package > - finally I did a version 0.5 with that state > > There were also packages removed like PasswordHashingFFI and CryptographyPlugins. Not sure if the FFI variant is recent or the CryptographyPlugins realtes to the vm. I removed every package in its own commit. So resurrecting a package should be easy as reverting a commit if someone needs it. > > Now Iâm udpating mongotalk and voyage. > > FYI, > > Norbert

July 5, 2019

Cryptography decrufted

by Norbert Hartl

I cannot remember how many years Iâm suffering with the poor quality of the Cryptography package. As people were complaining that voyage cannot be loaded in windows because cryptography contains old code that produces filenames with 311 charactern I decided to stop that. I changed the Cryptography repo in a way that: - all packages that are old squeak related have been removed - packages that could not be loaded into a pharo7 because of dependencies I donât know have been removed - loadable packages have been added in the baseline in the all group so everything is loaded and tested in travis - tests have been fixed where I could do that easily - tests that were failing and I donât know why have been added (with a comment) to expectFailures - after the removal I did a new version 0.4 for those who are interested in the cleaned old version - then I converted the source into tonel format - then I retired pharo4 and pharo5 for the travis builds because 3 yearsis enough for such a package - finally I did a version 0.5 with that state There were also packages removed like PasswordHashingFFI and CryptographyPlugins. Not sure if the FFI variant is recent or the CryptographyPlugins realtes to the vm. I removed every package in its own commit. So resurrecting a package should be easy as reverting a commit if someone needs it. Now Iâm udpating mongotalk and voyage. FYI, Norbert

July 5, 2019

Re: Test Completion has been added to Pharo 8 - please test!

by Myroslava Romaniuk

Hi Stef So the more detailed instruction with the screenshot is in the blog post : https://medium.com/@myroslavarm/test-code-completion-has-been-added-to-phar…, but simply put: if you go to settings, type in 'completion' in the search bar, and where it says 'controller' change it to 'TestCompletionController', you will have it. It will be inside the environment instead of the regular completion, so any time you type something in playground or editor, it will be the test completion that is triggered. Basically to test it you only need to be coding something in Pharo :) So if you use it and it breaks somewhere, let us know. Best regards, Myroslava On Wed, 3 Jul 2019 at 15:27, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi miroslava > > how can we test it? > > Stef > > On 3 Jul 2019, at 01:11, Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> wrote: > > > *From: *Myroslava Romaniuk <romaniuk(a)ucu.edu.ua> > *Subject: **Test Completion has been added to Pharo 8 - please test!* > *Date: *3 July 2019 at 01:11:51 GMT+9 > *To: *Pharo Development List <pharo-dev(a)lists.pharo.org>, Any question > about pharo is welcome <pharo-users(a)lists.pharo.org> > > > Hi all, > > we added an intermediate version of the upcoming test completion to Pharo > 8, it would be cool if you tested it and let us know the results. Here's a > blog post about it - link > <https://medium.com/@myroslavarm/test-code-completion-has-been-added-to-phar…>, > and here's a tweet I'd be grateful if you shared - link > <https://twitter.com/myroslavarm/status/1146013653067587584> so perhaps > people who don't read the mailing list would also see it. In the blog post > you can find more info how to enable the completion in the settings and > details about the whole thing in general. If something doesn't work, or if > something works differently than it used to in the old completion (both if > you don't like it or perhaps if you prefer it) let me know either replying > here, on twitter, or submitting an issue request directly for the github > repository here - link > <https://github.com/myroslavarm/Experimental-Completion/issues>. > > Thanks very much, > Myroslava > > > > -------------------------------------------- > StÃ©phane Ducasse > http://stephane.ducasse.free.fr > http://www.synectique.eu / http://www.pharo.org > 03 59 35 87 52 > Assistant: Julie Jonas > FAX 03 59 57 78 50 > TEL 03 59 35 86 16 > S. Ducasse - Inria > 40, avenue Halley, > Parc Scientifique de la Haute Borne, BÃ¢t.A, Park Plaza > Villeneuve d'Ascq 59650 > France > > -- Ð Ð¿Ð¾Ð²Ð°Ð³Ð¾Ñ, ÐÐ¸ÑÐ¾ÑÐ»Ð°Ð²Ð° Ð Ð¾Ð¼Ð°Ð½ÑÐº.

July 3, 2019

Test Completion has been added to Pharo 8 - please test!

by Myroslava Romaniuk

Hi all, we added an intermediate version of the upcoming test completion to Pharo 8, it would be cool if you tested it and let us know the results. Here's a blog post about it - link <https://medium.com/@myroslavarm/test-code-completion-has-been-added-to-phar…>, and here's a tweet I'd be grateful if you shared - link <https://twitter.com/myroslavarm/status/1146013653067587584> so perhaps people who don't read the mailing list would also see it. In the blog post you can find more info how to enable the completion in the settings and details about the whole thing in general. If something doesn't work, or if something works differently than it used to in the old completion (both if you don't like it or perhaps if you prefer it) let me know either replying here, on twitter, or submitting an issue request directly for the github repository here - link <https://github.com/myroslavarm/Experimental-Completion/issues>. Thanks very much, Myroslava

July 2, 2019