- Pharo-users - lists.pharo.org

Re: [Pharo-users] OrderedCollection as an instance variable

by Richard Sargent

I will add that I prefer the static model to tell the truth about its data types. So, I prefer having an #initialize method which ensures the new object is created in a self-consistent way and anyone looking at it in an inspector will see useful and correct information. Leaving instance variables uninitialized is a excellent way to generate Does Not Understand errors (perhaps not in the short-term, but definitely in the long-term). On Wed, Jul 24, 2019 at 8:39 AM sergio ruiz <sergio.rrd(a)gmail.com> wrote: > > tracks > ^tracks ifNil: [ tracks := OrderedCollection new ]. > > - one line > - does not mix using accusers and not using accessors. > > > Okay, I totally get the subtlety now. I donât even need an accessor. > > Thanks! > > ---- > peace, > sergio > photographer, journalist, visionary > > Public Key: http://bit.ly/29z9fG0 > #BitMessage BM-NBaswViL21xqgg9STRJjaJaUoyiNe2dV > http://www.codeandmusic.com > http://www.twitter.com/sergio_101 > http://www.facebook.com/sergio101 > >

July 24, 2019

Re: [Pharo-users] OrderedCollection as an instance variable

by sergio ruiz

> > tracks > ^tracks ifNil: [ tracks := OrderedCollection new ]. > > - one line > - does not mix using accusers and not using accessors. Okay, I totally get the subtlety now. I donât even need an accessor. Thanks! ---- peace, sergio photographer, journalist, visionary Public Key: http://bit.ly/29z9fG0 #BitMessage BM-NBaswViL21xqgg9STRJjaJaUoyiNe2dV http://www.codeandmusic.com http://www.twitter.com/sergio_101 http://www.facebook.com/sergio101

July 24, 2019

Re: [Pharo-users] P7 regression

by Hilaire

Hi Sven, Le 24/07/2019 Ã 17:05, Sven Van Caekenberghe a Ã©critÂ : > Can you include the file that you are trying to load ? Attached. It looks like issue come when saving the file. The UTF8 characters are not saved properly. The unix file command was indicating it is an utf8 but Emacs shows it was different. > > Also, the stack trace is very short. Yes, I saw that... I don't know why. I did not cut it. I got a longer one this time. But it is likely not the cause. > Are you sure XML parser is ready for Pharo 8 (i.e. are its tests green) ? My bad, I am using P7. But I don't know either about the full compatibility of the XMLParser version I am using, the one before compatibility break. It is now clear the is issue when saving. To write, I use WriteStream on String. Should it be different? Hilaire -- Dr. Geo http://drgeo.eu

July 24, 2019

Re: [Pharo-users] OrderedCollection as an instance variable

by Marcus Denker

> On 24 Jul 2019, at 17:30, sergio ruiz <sergio.rrd(a)gmail.com> wrote: > > hmmâ¦ > > maybe this is cleaner.. > > tracks > tracks ifNil: [ self tracks: OrderedCollection new ]. > ^ tracks > I write these methods as tracks ^tracks ifNil: [ tracks := OrderedCollection new ]. - one line - does not mix using accusers and not using accessors. Marcus

July 24, 2019

Re: [Pharo-users] OrderedCollection as an instance variable

by Paul DeBruicker

You should change your #tracks method to tracks ^tracks ifNil:[tracks:=OrderedCollection new] or tracks tracks ifNil:[self initializeTracks] ^tracks initializeTracks tracks:=OrderedCollection new. Then you don't have to worry about the implementation of #tracks: changing in the future if you want to do something else with/in it. -- Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

July 24, 2019

Re: [Pharo-users] OrderedCollection as an instance variable

by sergio ruiz

hmmâ¦ maybe this is cleaner.. tracks tracks ifNil: [ self tracks: OrderedCollection new ]. ^ tracks > > > because your #tracks: returns self, not the collection value ---- peace, sergio photographer, journalist, visionary Public Key: http://bit.ly/29z9fG0 #BitMessage BM-NBaswViL21xqgg9STRJjaJaUoyiNe2dV http://www.codeandmusic.com http://www.twitter.com/sergio_101 http://www.facebook.com/sergio101

July 24, 2019

Re: [Pharo-users] OrderedCollection as an instance variable

by sergio ruiz

Oh! how about this: tracks: anObject tracks := anObject. ^ tracks ? > On Jul 24, 2019, at 10:48 AM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > because your #tracks: returns self, not the collection value ---- peace, sergio photographer, journalist, visionary Public Key: http://bit.ly/29z9fG0 #BitMessage BM-NBaswViL21xqgg9STRJjaJaUoyiNe2dV http://www.codeandmusic.com http://www.twitter.com/sergio_101 http://www.facebook.com/sergio101

July 24, 2019

Re: [Pharo-users] P8 regression

by Sven Van Caekenberghe

Can you include the file that you are trying to load ? Also, the stack trace is very short. Are you sure XML parser is ready for Pharo 8 (i.e. are its tests green) ? > On 24 Jul 2019, at 16:59, Hilaire <hilaire(a)drgeo.eu> wrote: > > Hi, > > We have been hit in DrGeo by another regression in Pharo8 (it is not > present in DrGeo versions based on previous Pharo). > > When loading a Sketch with accentuated Latin characters (same occurs > with Chinese but I have so far not enough information to assert it is > the same error) there is a ZnInvalidUTF8 error. > > Attached Pharo8 > > See details https://bugs.launchpad.net/drgeo/+bug/1837745 > > For the record the stream passed to the XML parser (an old version but I > don't think it is the problem) is from readStream message send to > FileReference. > > Do you want a bug ticket? > > Hilaire > > -- > Dr. Geo > http://drgeo.eu > > <PharoDebug.log>

July 24, 2019

P8 regression

by Hilaire

Hi, We have been hit in DrGeo by another regression in Pharo8 (it is not present in DrGeo versions based on previous Pharo). When loading a Sketch with accentuated Latin characters (same occurs with Chinese but I have so far not enough information to assert it is the same error) there is a ZnInvalidUTF8 error. Attached Pharo8 See details https://bugs.launchpad.net/drgeo/+bug/1837745 For the record the stream passed to the XML parser (an old version but I don't think it is the problem) is from readStream message send to FileReference. Do you want a bug ticket? Hilaire -- Dr. Geo http://drgeo.eu

July 24, 2019

Re: [Pharo-users] OrderedCollection as an instance variable

by Sven Van Caekenberghe

because your #tracks: returns self, not the collection value > On 24 Jul 2019, at 16:46, sergio ruiz <sergio.rrd(a)gmail.com> wrote: > > I'm implementing an instance variable as an OrderedCollection, and am doing something idiotic. > > I have an Artist class. > > An Artist can have many tracks: > > tracks > ^ tracks ifNil: [ self tracks: OrderedCollection new ] > > tracks: anObject > tracks := anObject > > Doing something like: > > a := Artist new. > t := Track new. > a tracks add: t > > Gives me the error: > > Artist(Object)>>doesNotUnderstand: #add: > > Once I get past that error, which will evaluate `a tracks`, I can run this. > > I get why it works the second time, but I don't get why it thinks the instance of Artist is the receiver of add: on the first run. > > Thanks! > ---- > peace, > sergio > photographer, journalist, visionary > > Public Key: http://bit.ly/29z9fG0 > #BitMessage BM-NBaswViL21xqgg9STRJjaJaUoyiNe2dV > http://www.codeandmusic.com > http://www.twitter.com/sergio_101 > http://www.facebook.com/sergio101 >

July 24, 2019