- Pharo-users - lists.pharo.org

Re: [Pharo-users] RecentMessageList

by StÃ©phane Ducasse

On Aug 11, 2010, at 11:05 PM, Guillermo Polito wrote: > Hi! > > I submitted a little fix where the UI is updated and the example is working. How? Because the model should not rely on the UI as it was before > I expect you don't get upset for touching it. > > By the way, I have some extra comments: > > -Why there are MessageList and RecentMessageList? Why not only one of them? Because you can reuse MessageList in other circumstances > -Why MethodReferenceWithSource is called like that? It can contain also Class references... Otherwise, maybe there is a better name for that class. Maybe something like RecentChangeNotification or something like that... This has nothing to do with notification. This is just an extension of MethodReference > -There is no RecentMessageList example or similar!!!! I had to browse the code and guess that "RecentMessageList new openInWorld" should open it :). > - All the asDictionaryByXXX are very similar... Maybe you can build a asDictionaryBy (or groupedBy: as Stephane said) parametrized like: > > groupBy: groupBlock valueBy: valueBlock > | result tempList | > result := Dictionary new. > tempList := self methodReferenceList copy sort: [:m1 :m2 | m2 timeStamp <= m1 timeStamp]. > tempList do: [:each | > | key value | > key := groupBlock value each. > value := valueBlock value: each. > (result includesKey: key) > ifFalse: [result at: key put: OrderedCollection new]. > (result at: key) add: value]. > ^(Association key: result value: tempList) probably > - And that reminds me: Why does that method return an association? So you can return multiple values? :( Thats not nice.. Maybe you can make the RecentMessageList stateful and let it have a sorted collection with the sorted elements. Maybe playing with that let you manage the speed problems. > > - And maybe you should look at SettingBrowser>>treeMorphIn:. There's the way to build a MorphTreeMorph binded to a list, so you can update the view sending the message #changed to the model. Yes that part I do not know > > Cheers, > Guille > > On Tue, Aug 10, 2010 at 8:11 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi benjamin > > Thanks for your code!!!! > > I did a review of your latest code: Here are some points that it would be nice to address > I fixed what I saw and republished > > > 0 - all the classes should have comments > > MessageList > ---------- > 1- MessageList example does not work > Can you create some Unit tests to cover the expected behavior of the MessageList > > 2- MessageList>>browsers > I removed it > > 3- recategorized the methods > > 4- I removed all the "comment10" > > 5- what I level > Can you comment it? > > 6- for asDictionaryByClass > why don't you use groupedBy: or similar methods? > I'm not sure that I would call them asDictionaryBy.... since you return an association? > > > Why don't you call them groupedBySelectors, groupedByClasses, groupedByPackages > then why do you return an Association and not a dictionary. > > 7- Can you add oneline method comments to method? > > > 8- Could you introduce an explicit instance variable representing the environment in use and initialize > it with Smalltalk globals because like that we can specify in which environment the set is working. > > 9- openInWorldWithADictionarySelector: sucks :) > the name is not really cool > then you bind the core with the UI > so you should define this method as an extension of RecentSubmission-UI and may be > > 10- You update all the browsers open but this should not be your role. > As a core domain object you should not do this kind of behavior. The UI widget should register to event > or notification and update themselves when you change. > > updateView > browsers ifNotNilDo: [:collection | collection do: [:each | each updateView]] > > > MessageListAssociation > -------------------- > why do you need this guy? > Just to print the elements? > This is a UI concerns. The UI should wrap the model and provide a specific printed version > or the MessageListAssociation should be explained in the class comment > > > MethodReferenceWithSource > ------------------------ > We should probably move some behavior to MethodReference > > > NullTextStyler > ------------ > I categorized all the methods following SHStyler categories > > RecentMessageList > ---------------- > I cleaned the singleton part. > You do not need > UniqueInstance ifNotNil: [:u | UniqueInstance releaseAll]. > > Again the model should not be referencing the ui > releaseAll > super initialize. > MessageListBrowser allInstancesDo: [:each | each messageList = self ifTrue:[each delete]]. > browser:= nil. > self methodReferenceList: OrderedCollection new. > > > Why the setting is registration is done in the core and not at the level of the widget? > > > - at startUp: you should not create the instance since uniqueInstance is lazzily accessed. > However you should register to the SystemChangeNotifier to get the notification. > > > > > MessageListBrowser > ----------------- > Instead of having > > MessageListBrowser >>byDateAscendingOn: aMessageList > > ^self > on: aMessageList > withADictionarySelector: #asDictionaryByDateAscending. > > > MessageListBrowser >>byDateAscendingOn: aMessageList > > ^self > on: aMessageList > withADictionarySelector: aMessageList asDictionaryByDateAscendingSelector > > and > > MessageList>> asDictionaryByDateAscendingSelector > ^ #asDictionaryByDateAscending > > => encapsulate information from model to UI. > => I did it > > > > So for now this is enough :) > > > Stef > > On Aug 1, 2010, at 3:00 AM, Benjamin Van Ryseghem wrote: > > > Gofer new > > squeaksource: 'PharoTaskForces'; > > package: 'RecentSubmissions'; > > load. > > > _______________________________________________ > Pharo-users mailing list > Pharo-users(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users > > _______________________________________________ > Pharo-users mailing list > Pharo-users(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users

Aug. 13, 2010

WebClient-Core port to Pharo 1.1 final

by Sven Van Caekenberghe

Hi Andreas, I made some changes to the latest WebClient-Core in order to run it on Pharo 1.1: Sven Van Caekenberghe uploaded a new version of WebClient-Core to project A Day At The Beach: http://www.squeaksource.com/ADayAtTheBeach/WebClient-Core-SvenVanCaekenberg… ==================== Summary ==================== Name: WebClient-Core-SvenVanCaekenberghe.63 Author: SvenVanCaekenberghe Time: 12 August 2010, 10:46:11 am UUID: 149d44b2-138b-4d63-a158-f587b2bd391d Ancestors: WebClient-Core-ar.62 added some more #asString's where needed to deal with the different semantics of #, in Squeak vs Pharo; removed usage of #and:and:and:and: with a composition of #and: in WebClient>>connect ================================================ I still have some tests that fail, but I can't find the problem: 39 run, 34 passes, 0 expected failures, 0 failures, 5 errors, 0 unexpected passes Failures: Errors: WebClientServerTest>>#testMultipartFiles WebClientServerTest>>#testMultipartFiles2 WebClientServerTest>>#testServerError WebClientServerTest>>#testWebSockets WebClientServerTest>>#testWebSocketsFraming The #testServerError bothers me most. I am posting this to a Pharo list as well so that maybe others can help. Maybe I'll find the problems myself later on. Sven

Aug. 12, 2010

Re: [Pharo-users] RecentMessageList

by Guillermo Polito

Hi! I submitted a little fix where the UI is updated and the example is working. I expect you don't get upset for touching it. By the way, I have some extra comments: -Why there are MessageList and RecentMessageList? Why not only one of them? -Why MethodReferenceWithSource is called like that? It can contain also Class references... Otherwise, maybe there is a better name for that class. Maybe something like RecentChangeNotification or something like that... -There is no RecentMessageList example or similar!!!! I had to browse the code and guess that "RecentMessageList new openInWorld" should open it :). - All the asDictionaryByXXX are very similar... Maybe you can build a asDictionaryBy (or groupedBy: as Stephane said) parametrized like: groupBy: groupBlock valueBy: valueBlock | result tempList | result := Dictionary new. tempList := self methodReferenceList copy sort: [:m1 :m2 | m2 timeStamp <= m1 timeStamp]. tempList do: [:each | | key value | key := groupBlock value each. value := valueBlock value: each. (result includesKey: key) ifFalse: [result at: key put: OrderedCollection new]. (result at: key) add: value]. ^(Association key: result value: tempList) - And that reminds me: Why does that method return an association? So you can return multiple values? :( Thats not nice.. Maybe you can make the RecentMessageList stateful and let it have a sorted collection with the sorted elements. Maybe playing with that let you manage the speed problems. - And maybe you should look at SettingBrowser>>treeMorphIn:. There's the way to build a MorphTreeMorph binded to a list, so you can update the view sending the message #changed to the model. Cheers, Guille On Tue, Aug 10, 2010 at 8:11 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr > wrote: > Hi benjamin > > Thanks for your code!!!! > > I did a review of your latest code: Here are some points that it would be > nice to address > I fixed what I saw and republished > > > 0 - all the classes should have comments > > MessageList > ---------- > 1- MessageList example does not work > Can you create some Unit tests to cover the expected behavior of the > MessageList > > 2- MessageList>>browsers > I removed it > > 3- recategorized the methods > > 4- I removed all the "comment10" > > 5- what I level > Can you comment it? > > 6- for asDictionaryByClass > why don't you use groupedBy: or similar methods? > I'm not sure that I would call them asDictionaryBy.... since you > return an association? > > > Why don't you call them groupedBySelectors, groupedByClasses, > groupedByPackages > then why do you return an Association and not a dictionary. > > 7- Can you add oneline method comments to method? > > > 8- Could you introduce an explicit instance variable representing the > environment in use and initialize > it with Smalltalk globals because like that we can specify in which > environment the set is working. > > 9- openInWorldWithADictionarySelector: sucks :) > the name is not really cool > then you bind the core with the UI > so you should define this method as an extension of > RecentSubmission-UI and may be > > 10- You update all the browsers open but this should not be your role. > As a core domain object you should not do this kind of behavior. The UI > widget should register to event > or notification and update themselves when you change. > > updateView > browsers ifNotNilDo: [:collection | collection do: [:each | > each updateView]] > > > MessageListAssociation > -------------------- > why do you need this guy? > Just to print the elements? > This is a UI concerns. The UI should wrap the model and provide a > specific printed version > or the MessageListAssociation should be explained in the class > comment > > > MethodReferenceWithSource > ------------------------ > We should probably move some behavior to MethodReference > > > NullTextStyler > ------------ > I categorized all the methods following SHStyler categories > > RecentMessageList > ---------------- > I cleaned the singleton part. > You do not need > UniqueInstance ifNotNil: [:u | UniqueInstance releaseAll]. > > Again the model should not be referencing the ui > releaseAll > super initialize. > MessageListBrowser allInstancesDo: [:each | each > messageList = self ifTrue:[each delete]]. > browser:= nil. > self methodReferenceList: OrderedCollection new. > > > Why the setting is registration is done in the core and not at the > level of the widget? > > > - at startUp: you should not create the instance since > uniqueInstance is lazzily accessed. > However you should register to the SystemChangeNotifier to get the > notification. > > > > > MessageListBrowser > ----------------- > Instead of having > > MessageListBrowser >>byDateAscendingOn: aMessageList > > ^self > on: aMessageList > withADictionarySelector: #asDictionaryByDateAscending. > > > MessageListBrowser >>byDateAscendingOn: aMessageList > > ^self > on: aMessageList > withADictionarySelector: aMessageList > asDictionaryByDateAscendingSelector > > and > > MessageList>> asDictionaryByDateAscendingSelector > ^ #asDictionaryByDateAscending > > => encapsulate information from model to UI. > => I did it > > > > So for now this is enough :) > > > Stef > > On Aug 1, 2010, at 3:00 AM, Benjamin Van Ryseghem wrote: > > > Gofer new > > squeaksource: 'PharoTaskForces'; > > package: 'RecentSubmissions'; > > load. > > > _______________________________________________ > Pharo-users mailing list > Pharo-users(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users >

Aug. 11, 2010

Re: [Pharo-users] RecentMessageList

by StÃ©phane Ducasse

Hi benjamin Thanks for your code!!!! I did a review of your latest code: Here are some points that it would be nice to address I fixed what I saw and republished 0 - all the classes should have comments MessageList ---------- 1- MessageList example does not work Can you create some Unit tests to cover the expected behavior of the MessageList 2- MessageList>>browsers I removed it 3- recategorized the methods 4- I removed all the "comment10" 5- what I level Can you comment it? 6- for asDictionaryByClass why don't you use groupedBy: or similar methods? I'm not sure that I would call them asDictionaryBy.... since you return an association? Why don't you call them groupedBySelectors, groupedByClasses, groupedByPackages then why do you return an Association and not a dictionary. 7- Can you add oneline method comments to method? 8- Could you introduce an explicit instance variable representing the environment in use and initialize it with Smalltalk globals because like that we can specify in which environment the set is working. 9- openInWorldWithADictionarySelector: sucks :) the name is not really cool then you bind the core with the UI so you should define this method as an extension of RecentSubmission-UI and may be 10- You update all the browsers open but this should not be your role. As a core domain object you should not do this kind of behavior. The UI widget should register to event or notification and update themselves when you change. updateView browsers ifNotNilDo: [:collection | collection do: [:each | each updateView]] MessageListAssociation -------------------- why do you need this guy? Just to print the elements? This is a UI concerns. The UI should wrap the model and provide a specific printed version or the MessageListAssociation should be explained in the class comment MethodReferenceWithSource ------------------------ We should probably move some behavior to MethodReference NullTextStyler ------------ I categorized all the methods following SHStyler categories RecentMessageList ---------------- I cleaned the singleton part. You do not need UniqueInstance ifNotNil: [:u | UniqueInstance releaseAll]. Again the model should not be referencing the ui releaseAll super initialize. MessageListBrowser allInstancesDo: [:each | each messageList = self ifTrue:[each delete]]. browser:= nil. self methodReferenceList: OrderedCollection new. Why the setting is registration is done in the core and not at the level of the widget? - at startUp: you should not create the instance since uniqueInstance is lazzily accessed. However you should register to the SystemChangeNotifier to get the notification. MessageListBrowser ----------------- Instead of having MessageListBrowser >>byDateAscendingOn: aMessageList ^self on: aMessageList withADictionarySelector: #asDictionaryByDateAscending. MessageListBrowser >>byDateAscendingOn: aMessageList ^self on: aMessageList withADictionarySelector: aMessageList asDictionaryByDateAscendingSelector and MessageList>> asDictionaryByDateAscendingSelector ^ #asDictionaryByDateAscending => encapsulate information from model to UI. => I did it So for now this is enough :) Stef On Aug 1, 2010, at 3:00 AM, Benjamin Van Ryseghem wrote: > Gofer new > squeaksource: 'PharoTaskForces'; > package: 'RecentSubmissions'; > load.

Aug. 10, 2010

Re: [Pharo-users] Starting a new ancestry from an MC package

by Sean P. DeNigris

StÃ©phane Ducasse wrote: > > normally yes. > Ha, ha. When I wrote that, I thought, "I wonder if someone is going to respond with 'yes|no'." Sean -- View this message in context: http://forum.world.st/Starting-a-new-ancestry-from-an-MC-package-tp2318679p… Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

Aug. 9, 2010

Re: [Pharo-users] Starting a new ancestry from an MC package

by Adrian Lienhard

On Aug 9, 2010, at 18:36 , StÃ©phane Ducasse wrote: > normally yes. Although you didn't ask for how to do this, I'll try to give an answer ;) In the MC browser select the package in the left pane and in the context menu select "delete working copy". Then create a new package (with the button "+Package") and save it to your repository. The new version should not know about the previous one. HTH, Adrian > > Stef > > On Aug 9, 2010, at 5:44 PM, Sean P. DeNigris wrote: > >> >> Can I save a MC package without its ancestor info? I made changes to a >> package, but the new and old packages are not logically related. I would >> like the new package to appear as the first in its ancestry. >> >> Thanks. >> Sean >> -- >> View this message in context: http://forum.world.st/Starting-a-new-ancestry-from-an-MC-package-tp2318679p… >> Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com. >> >> _______________________________________________ >> Pharo-users mailing list >> Pharo-users(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users > > > _______________________________________________ > Pharo-users mailing list > Pharo-users(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users

Aug. 9, 2010

Re: [Pharo-users] Starting a new ancestry from an MC package

by StÃ©phane Ducasse

normally yes. Stef On Aug 9, 2010, at 5:44 PM, Sean P. DeNigris wrote: > > Can I save a MC package without its ancestor info? I made changes to a > package, but the new and old packages are not logically related. I would > like the new package to appear as the first in its ancestry. > > Thanks. > Sean > -- > View this message in context: http://forum.world.st/Starting-a-new-ancestry-from-an-MC-package-tp2318679p… > Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com. > > _______________________________________________ > Pharo-users mailing list > Pharo-users(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users

Aug. 9, 2010

Starting a new ancestry from an MC package

by Sean P. DeNigris

Can I save a MC package without its ancestor info? I made changes to a package, but the new and old packages are not logically related. I would like the new package to appear as the first in its ancestry. Thanks. Sean -- View this message in context: http://forum.world.st/Starting-a-new-ancestry-from-an-MC-package-tp2318679p… Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

Aug. 9, 2010

Re: [Pharo-users] is there an unique URL to the latest pharo core or dev release?

by StÃ©phane Ducasse

We requested that for the inria forge. Now the pharo-project web site should shield us from inria and provide such link. Stef On Aug 8, 2010, at 10:50 PM, Lukas Renggli wrote: > Having such an URL would be great indeed. > > Right now I always have to specify it manually as a parameter to the > root image in Hudson. With a constant URL Hudson could automatically > detect a new image and perform the complete build chain. > > Lukas > > On 8 August 2010 20:45, Bernardo Ezequiel Contreras > <vonbecmann(a)gmail.com> wrote: >> Hi All, >> >> is there a unique URL to the latest pharo core or dev release? >> For example(it just an example to express my idea, it could be >> different), >> if i want the latest Pharo Core release, i would like to access the >> following URL >> www.pharo-project.org/PharoCore/latestRelease/ >> | >> -> >> a Zip file with the latest release >> >> The same applies to Pharo Dev, it could be >> www.pharo-project.org/Pharo/latestRelease/ >> | >> -> a Zip >> file with the latest release >> >> Therefore, i could write a script to download the latest release when you >> announce a new one. >> The truth is that i am too lazy to access the web browser and navigate to >> the download page. >> Perhaps, i am missing something here. >> Could you help me? >> >> thanks in advance >> >> _______________________________________________ >> Pharo-users mailing list >> Pharo-users(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users >> >> > > > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-users mailing list > Pharo-users(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users

Aug. 9, 2010

Re: [Pharo-users] is there an unique URL to the latest pharo core or dev release?

by Bernardo Ezequiel Contreras

my scenario is similar but different, imagine im coding for fun at pharo and suddenly i found a MDNU or whatever ..., maybe a possible bug therefore i would like to * create a clean environment from the latest version * start that environment * then i could try to reproduce that possible bug. * if it exists then report it * otherwise, discard that environment quick hack idea!: maybe i could build my own latest version path in my PC,..... maybe Thanks On Sun, Aug 8, 2010 at 5:50 PM, Lukas Renggli <renggli(a)gmail.com> wrote: > Having such an URL would be great indeed. > > Right now I always have to specify it manually as a parameter to the > root image in Hudson. With a constant URL Hudson could automatically > detect a new image and perform the complete build chain. > > Lukas > > On 8 August 2010 20:45, Bernardo Ezequiel Contreras > <vonbecmann(a)gmail.com> wrote: > > Hi All, > > > > is there a unique URL to the latest pharo core or dev release? > > For example(it just an example to express my idea, it could be > > different), > > if i want the latest Pharo Core release, i would like to access the > > following URL > > www.pharo-project.org/PharoCore/latestRelease/ > > > | > > > -> > > a Zip file with the latest release > > > > The same applies to Pharo Dev, it could be > > www.pharo-project.org/Pharo/latestRelease/ > > | > > -> a Zip > > file with the latest release > > > > Therefore, i could write a script to download the latest release when > you > > announce a new one. > > The truth is that i am too lazy to access the web browser and navigate > to > > the download page. > > Perhaps, i am missing something here. > > Could you help me? > > > > thanks in advance > > > > _______________________________________________ > > Pharo-users mailing list > > Pharo-users(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users > > > > > > > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-users mailing list > Pharo-users(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-users >

Aug. 8, 2010