- Pharo-users - lists.pharo.org

Re: [Pharo-users] Method Calling Inside Nested Blocks

by Mohammad Al Houssami (Alumni)

Probably because I am not using dots except at the end of blocks which I think is wrong. This is a sample of what I had earlier: currentCharacter = CHARACTERTABULATION ifTrue: [anythingElseBoolean:= false AfterDOCTYPENameState value: currentCharacter ]. There should be a dot after false right ? Once I add the dot I get a complain. From: pharo-users-bounces(a)lists.gforge.inria.fr [mailto:pharo-users-bounces@lists.gforge.inria.fr] On Behalf Of Esteban Lorenzano Sent: Saturday, March 23, 2013 3:09 PM To: A friendly place where any question about pharo is welcome Subject: Re: [Pharo-users] Method Calling Inside Nested Blocks if it is a method, it needs the receiver, in this case "self" (remember, any call in smalltalk is: receiver+message). If for some weird reason you did not need it before (like some chained call effect), that was just by chance... you just were lucky before :) Esteban On Mar 23, 2013, at 1:58 PM, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu<mailto:mha53@mail.aub.edu>> wrote: So the method declaration should be self afterDOCTYPEPublicKeywordState: currentCharacter. ? But I have been doing the same for quite some time and I wasn't getting any complains. This is the first time and the only thing that changed is that I have two blocks in this case. As I said earlier if I move the method call outside the block it works with no complains :) I'll change the names of all my methods to camel case. Thanks for that From: pharo-users-bounces(a)lists.gforge.inria.fr<mailto:pharo-users-bounces@lists.gforge.inria.fr> [mailto:pharo-users-bounces@lists.gforge.inria.fr<mailto:users-bounces@lists.gforge.inria.fr>] On Behalf Of Esteban Lorenzano Sent: Saturday, March 23, 2013 2:52 PM To: A friendly place where any question about pharo is welcome Subject: Re: [Pharo-users] Method Calling Inside Nested Blocks On Mar 23, 2013, at 12:31 PM, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu<mailto:mha53@mail.aub.edu>> wrote: Hello everyone I was trying to save my method which has the below piece of code anythingElseBoolean = false ifFalse: [ doctypeString := reader next: 6 doctypeString asLowercase = 'public' ifTrue: [ AfterDOCTYPEPublicKeywordState value: currentCharacter ] I get a complain that the AfterDOCTYPEPublicKeywordState is unknown even though I have a method with this name. AfterDOCTYPEPublicKeywordState is a METHOD???? then, you are missing some points: 1) it does not conforms conventions (it should start with lowercase) 2) you need a self call so, it would be like this: self afterDOCTYPEPublicKeywordState value: currentCharacter. but that is also wrong from a design point of view (anti demeters law). So, you better create a (perhaps private) method who does the assignment. And then you have something like this: self afterDOCTYPEPublicKeywordState: currentCharacter. Esteban If I move the method call outside outside the ifTrue block to the ifFalse block it doesn't complain. Is the problem because of nested blocks ? If that's the case then what would be a good work around ? Thanks Mohammad

March 23, 2013

Re: [Pharo-users] Method Calling Inside Nested Blocks

by Esteban Lorenzano

if it is a method, it needs the receiver, in this case "self" (remember, any call in smalltalk is: receiver+message). If for some weird reason you did not need it before (like some chained call effect), that was just by chance... you just were lucky before :) Esteban On Mar 23, 2013, at 1:58 PM, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu> wrote: > So the method declaration should be self afterDOCTYPEPublicKeywordState: currentCharacter. ? > > But I have been doing the same for quite some time and I wasnât getting any complains. This is the first time and the only thing that changed is that I have two blocks in this case. As I said earlier if I move the method call outside the block it works with no complains J > > I'll change the names of all my methods to camel case. Thanks for that > > > From: pharo-users-bounces(a)lists.gforge.inria.fr [mailto:pharo-users-bounces@lists.gforge.inria.fr] On Behalf Of Esteban Lorenzano > Sent: Saturday, March 23, 2013 2:52 PM > To: A friendly place where any question about pharo is welcome > Subject: Re: [Pharo-users] Method Calling Inside Nested Blocks > > > On Mar 23, 2013, at 12:31 PM, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu> wrote: > > > Hello everyone > > I was trying to save my method which has the below piece of code > > anythingElseBoolean = false ifFalse: [ > doctypeString := reader next: 6 > doctypeString asLowercase = 'public' ifTrue: [ > AfterDOCTYPEPublicKeywordState value: currentCharacter > ] > > I get a complain that the AfterDOCTYPEPublicKeywordState is unknown even though I have a method with this name. > > AfterDOCTYPEPublicKeywordState is a METHOD???? > then, you are missing some points: > > 1) it does not conforms conventions (it should start with lowercase) > 2) you need a self call > > so, it would be like this: > > self afterDOCTYPEPublicKeywordState value: currentCharacter. > > but that is also wrong from a design point of view (anti demeters law). So, you better create a (perhaps private) method who does the assignment. And then you have something like this: > > self afterDOCTYPEPublicKeywordState: currentCharacter. > > Esteban > > > If I move the method call outside outside the ifTrue block to the ifFalse block it doesnât complain. > > Is the problem because of nested blocks ? If thatâs the case then what would be a good work around ? > > > > Thanks > Mohammad

March 23, 2013

Re: [Pharo-users] Method Calling Inside Nested Blocks

by Mohammad Al Houssami (Alumni)

I will be using petit parser at some point. Im currently doing it by hand to learn smalltalk and to get used to the requirements and all the things that come up. I think when I have a good grip on these I can move on to PetitParser. I made sure no weird characters are there but still doesn't work. Attached is the whole thing. -----Original Message----- From: pharo-users-bounces(a)lists.gforge.inria.fr [mailto:pharo-users-bounces@lists.gforge.inria.fr] On Behalf Of stephane ducasse Sent: Saturday, March 23, 2013 2:51 PM To: A friendly place where any question about pharo is welcome Subject: Re: [Pharo-users] Method Calling Inside Nested Blocks the following in syntactically valid. May be you pasted a strange character in your method. > anythingElseBoolean = false ifFalse: [ > doctypeString := reader next: 6. > doctypeString asLowercase = 'public' ifTrue: [ > AfterDOCTYPEPublicKeywordState value: currentCharacter > ] ] Now I think that building a HTML parser by hand in 2012 is a strange exercise when there are compiler compiler or cool framework for parsing like PetitParser. Stef

March 23, 2013

Re: [Pharo-users] Method Calling Inside Nested Blocks

by Mohammad Al Houssami (Alumni)

So the method declaration should be self afterDOCTYPEPublicKeywordState: currentCharacter. ? But I have been doing the same for quite some time and I wasn't getting any complains. This is the first time and the only thing that changed is that I have two blocks in this case. As I said earlier if I move the method call outside the block it works with no complains :) I'll change the names of all my methods to camel case. Thanks for that From: pharo-users-bounces(a)lists.gforge.inria.fr [mailto:pharo-users-bounces@lists.gforge.inria.fr] On Behalf Of Esteban Lorenzano Sent: Saturday, March 23, 2013 2:52 PM To: A friendly place where any question about pharo is welcome Subject: Re: [Pharo-users] Method Calling Inside Nested Blocks On Mar 23, 2013, at 12:31 PM, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu<mailto:mha53@mail.aub.edu>> wrote: Hello everyone I was trying to save my method which has the below piece of code anythingElseBoolean = false ifFalse: [ doctypeString := reader next: 6 doctypeString asLowercase = 'public' ifTrue: [ AfterDOCTYPEPublicKeywordState value: currentCharacter ] I get a complain that the AfterDOCTYPEPublicKeywordState is unknown even though I have a method with this name. AfterDOCTYPEPublicKeywordState is a METHOD???? then, you are missing some points: 1) it does not conforms conventions (it should start with lowercase) 2) you need a self call so, it would be like this: self afterDOCTYPEPublicKeywordState value: currentCharacter. but that is also wrong from a design point of view (anti demeters law). So, you better create a (perhaps private) method who does the assignment. And then you have something like this: self afterDOCTYPEPublicKeywordState: currentCharacter. Esteban If I move the method call outside outside the ifTrue block to the ifFalse block it doesn't complain. Is the problem because of nested blocks ? If that's the case then what would be a good work around ? Thanks Mohammad

March 23, 2013

Re: [Pharo-users] Method Calling Inside Nested Blocks

by Esteban Lorenzano

On Mar 23, 2013, at 12:31 PM, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu> wrote: > Hello everyone > > I was trying to save my method which has the below piece of code > > anythingElseBoolean = false ifFalse: [ > doctypeString := reader next: 6 > doctypeString asLowercase = 'public' ifTrue: [ > AfterDOCTYPEPublicKeywordState value: currentCharacter > ] > > I get a complain that the AfterDOCTYPEPublicKeywordState is unknown even though I have a method with this name. AfterDOCTYPEPublicKeywordState is a METHOD???? then, you are missing some points: 1) it does not conforms conventions (it should start with lowercase) 2) you need a self call so, it would be like this: self afterDOCTYPEPublicKeywordState value: currentCharacter. but that is also wrong from a design point of view (anti demeters law). So, you better create a (perhaps private) method who does the assignment. And then you have something like this: self afterDOCTYPEPublicKeywordState: currentCharacter. Esteban > If I move the method call outside outside the ifTrue block to the ifFalse block it doesnât complain. > > Is the problem because of nested blocks ? If thatâs the case then what would be a good work around ? > > > Thanks > Mohammad

March 23, 2013

Re: [Pharo-users] Method Calling Inside Nested Blocks

by stephane ducasse

the following in syntactically valid. May be you pasted a strange character in your method. > anythingElseBoolean = false ifFalse: [ > doctypeString := reader next: 6. > doctypeString asLowercase = 'public' ifTrue: [ > AfterDOCTYPEPublicKeywordState value: currentCharacter > ] ] Now I think that building a HTML parser by hand in 2012 is a strange exercise when there are compiler compiler or cool framework for parsing like PetitParser. Stef

March 23, 2013

Re: [Pharo-users] Method Calling Inside Nested Blocks

by Esteban Lorenzano

you miss a dot: On Mar 23, 2013, at 12:31 PM, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu> wrote: > anythingElseBoolean = false ifFalse: [ > doctypeString := reader next: 6. "Your dot HERE" > doctypeString asLowercase = 'public' ifTrue: [ > AfterDOCTYPEPublicKeywordState value: currentCharacter > ] >

March 23, 2013

Re: [Pharo-users] Method Calling Inside Nested Blocks

by Mohammad Al Houssami (Alumni)

I only use dots at the end of blocks usually but I tried it and it still doesn't work. :/ Its weird.. -----Original Message----- From: pharo-users-bounces(a)lists.gforge.inria.fr [mailto:pharo-users-bounces@lists.gforge.inria.fr] On Behalf Of Camillo Bruni Sent: Saturday, March 23, 2013 1:38 PM To: A friendly place where any question about pharo is welcome Subject: Re: [Pharo-users] Method Calling Inside Nested Blocks I think you just have a missing dot (.) after `reader next: 6`? ;) On 2013-03-23, at 12:31, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu> wrote: > Hello everyone > > I was trying to save my method which has the below piece of code > > anythingElseBoolean = false ifFalse: [ > doctypeString := reader next: 6 > doctypeString asLowercase = 'public' ifTrue: [ > AfterDOCTYPEPublicKeywordState value: currentCharacter > ] > > I get a complain that the AfterDOCTYPEPublicKeywordState is unknown even though I have a method with this name. > If I move the method call outside outside the ifTrue block to the ifFalse block it doesn't complain. > > Is the problem because of nested blocks ? If that's the case then what would be a good work around ? > > > Thanks > Mohammad

March 23, 2013

Re: [Pharo-users] Method Calling Inside Nested Blocks

by Camillo Bruni

I think you just have a missing dot (.) after `reader next: 6`? ;) On 2013-03-23, at 12:31, "Mohammad Al Houssami (Alumni)" <mha53(a)mail.aub.edu> wrote: > Hello everyone > > I was trying to save my method which has the below piece of code > > anythingElseBoolean = false ifFalse: [ > doctypeString := reader next: 6 > doctypeString asLowercase = 'public' ifTrue: [ > AfterDOCTYPEPublicKeywordState value: currentCharacter > ] > > I get a complain that the AfterDOCTYPEPublicKeywordState is unknown even though I have a method with this name. > If I move the method call outside outside the ifTrue block to the ifFalse block it doesn't complain. > > Is the problem because of nested blocks ? If that's the case then what would be a good work around ? > > > Thanks > Mohammad

March 23, 2013

Method Calling Inside Nested Blocks

by Mohammad Al Houssami (Alumni)

Hello everyone I was trying to save my method which has the below piece of code anythingElseBoolean = false ifFalse: [ doctypeString := reader next: 6 doctypeString asLowercase = 'public' ifTrue: [ AfterDOCTYPEPublicKeywordState value: currentCharacter ] I get a complain that the AfterDOCTYPEPublicKeywordState is unknown even though I have a method with this name. If I move the method call outside outside the ifTrue block to the ifFalse block it doesn't complain. Is the problem because of nested blocks ? If that's the case then what would be a good work around ? Thanks Mohammad

March 23, 2013