- Pharo-users - lists.pharo.org

Re: [Pharo-users] moving to git and preserving monticello history

by Thierry Goubier

Hi Peter, thanks for raising all those issues. A few comments inlined... 2015-02-20 11:14 GMT+01:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com>: > Hi, > > thank you both, I've semi-successfully managed to convert it to git. > However there were some problems I've encountered (mostly because I wanted > more than was provided :)). > So there are some changes that might be worth considering for integration. > > 1) it will NOT recreate a commit for each mcz from oldest to newest > In fact the order seems to be random (just like all Pharo directory > operations) > Oups. Last time I did it, it was in order :( > > I ended up sorting it manually; it is not perfect because it groups by > packages; but the alternative (by ancestry) is much more work. > ===================================================================== > sortBlock := [ :x : y | > (x second = y second) ifTrue: [ x fourth asNumber <= y fourth asNumber ] > ifFalse: [ x second < y second ]. > ]. > > "My-Package-Author.Number" > re := '^(.+)-([^-]+)\.(\d+)$' asRegex. > fileBlocks := source allVersionNames collect: [ :each | > re search: each. > { > re subexpression: 1. "first - full string" > re subexpression: 2. "second - package name" > re subexpression: 3. "third - author name" > re subexpression: 4. "fourth - commit name" > } > ]. > filesSorted := fileBlocks asSortedCollection: sortBlock. > > files := (filesSorted collect: [ :x | x first ]) asArray. > ===================================================================== > > 2) Git by default doesn't accept empty messages > While Monticello does so I ran into a trouble. (Not sure how we ended up > with empty message but whatever). > This can be easily remedied with --allow-empty-message (see further down) > Good point. Bad programmers do commits without messages :):) > > 3) The author and date is not preserved. > Obviously for collaborated project I can't just appropriate someone else's > code. Also having the original date is nice. > With author there's an issue that git requires an email, this can be > solved with having external mapping class (or having something on > MCFileTreeGitRepository class-side). > Well, original history and author name is still there (if you reread the monticello.meta/version file), it does not appear in the git history. But, yes, some mapping may be usefull (or an automatic, fetch name from version) and a differentiation between the author name and the commiter name (I remember seeing both in git). > 4) Ignored .class directories > If you are dummy like me, use Java and have *.class in your system-wide > ignore file... there's a nasty surprise waiting. :) > :) Try .package in the .ignore file :) > > 2+3 code) > in "MCFileTreeGitRepository>>basicStoreVersion: aVersion" I moved the > command to separate methods > ===================================================================== > c := PipeableOSProcess > command: > self cdCommand, > (self gitAddCommand: packageDirectoryString), > (self gitCommitCommand: aVersion directory: packageDirectoryString). > ===================================================================== > > and new methods > > ===================================================================== > MCFileTreeGitRepository>>cdCommand > ^ 'cd "{1}";' format: {(self fileUtils directoryPathString: directory)} > > MCFileTreeGitRepository>>gitAddCommand: packageDirectoryString > ^ 'git add ' , packageDirectoryString , ';' > > MCFileTreeGitRepository>>gitCommitCommand: aVersion directory: > packageDirectoryString > ^ 'git commit --allow-empty-message -m "{1}" --author="{2}" --date="{3}" > -- {4};' > format: > {(self escapeForShell: aVersion info message convertToSystemString). > (self escapeForShell: (GitAuthorConverter gitNameFor: aVersion info > author)). > (self escapeForShell: aVersion info timeStamp truncated asString > convertToSystemString). > packageDirectoryString} > ===================================================================== > > GitAuthorConverter is just a dummy class to map Monticello author (so a > global Dictionary). > > ===================================================================== > GitAuthorConverter map: 'PeterUhnak' to: 'Peter Uhnak <i.uhnak(a)gmail.com > >'. > GitAuthorConverter gitNameFor: 'PeterUhnak' "--> returns Peter Uhnak < > i.uhnak(a)gmail.com>'. > ===================================================================== > > Peter > I rewrote all the git command subsystems to solve two issues, so the structure is a lot nicer now. It doesn't cd anymore, instead it uses git -C <target-working-directory>which should help getting it to work on windows (and you can also set a different git executable path in a setting). I'll add issues for the points you raise in the filetree repository; for now, the very latest code is available this way, if you want to experiment: Metacello new baseline: 'FileTree'; repository: 'github://dalehenrich/filetree:issue_142/repository'; load: 'Git' Thanks, Thierry

Feb. 20, 2015

Re: [Pharo-users] moving to git and preserving monticello history

by Peter UhnÃ¡k

Hi, thank you both, I've semi-successfully managed to convert it to git. However there were some problems I've encountered (mostly because I wanted more than was provided :)). So there are some changes that might be worth considering for integration. 1) it will NOT recreate a commit for each mcz from oldest to newest In fact the order seems to be random (just like all Pharo directory operations) I ended up sorting it manually; it is not perfect because it groups by packages; but the alternative (by ancestry) is much more work. ===================================================================== sortBlock := [ :x : y | (x second = y second) ifTrue: [ x fourth asNumber <= y fourth asNumber ] ifFalse: [ x second < y second ]. ]. "My-Package-Author.Number" re := '^(.+)-([^-]+)\.(\d+)$' asRegex. fileBlocks := source allVersionNames collect: [ :each | re search: each. { re subexpression: 1. "first - full string" re subexpression: 2. "second - package name" re subexpression: 3. "third - author name" re subexpression: 4. "fourth - commit name" } ]. filesSorted := fileBlocks asSortedCollection: sortBlock. files := (filesSorted collect: [ :x | x first ]) asArray. ===================================================================== 2) Git by default doesn't accept empty messages While Monticello does so I ran into a trouble. (Not sure how we ended up with empty message but whatever). This can be easily remedied with --allow-empty-message (see further down) 3) The author and date is not preserved. Obviously for collaborated project I can't just appropriate someone else's code. Also having the original date is nice. With author there's an issue that git requires an email, this can be solved with having external mapping class (or having something on MCFileTreeGitRepository class-side). 4) Ignored .class directories If you are dummy like me, use Java and have *.class in your system-wide ignore file... there's a nasty surprise waiting. :) 2+3 code) in "MCFileTreeGitRepository>>basicStoreVersion: aVersion" I moved the command to separate methods ===================================================================== c := PipeableOSProcess command: self cdCommand, (self gitAddCommand: packageDirectoryString), (self gitCommitCommand: aVersion directory: packageDirectoryString). ===================================================================== and new methods ===================================================================== MCFileTreeGitRepository>>cdCommand ^ 'cd "{1}";' format: {(self fileUtils directoryPathString: directory)} MCFileTreeGitRepository>>gitAddCommand: packageDirectoryString ^ 'git add ' , packageDirectoryString , ';' MCFileTreeGitRepository>>gitCommitCommand: aVersion directory: packageDirectoryString ^ 'git commit --allow-empty-message -m "{1}" --author="{2}" --date="{3}" -- {4};' format: {(self escapeForShell: aVersion info message convertToSystemString). (self escapeForShell: (GitAuthorConverter gitNameFor: aVersion info author)). (self escapeForShell: aVersion info timeStamp truncated asString convertToSystemString). packageDirectoryString} ===================================================================== GitAuthorConverter is just a dummy class to map Monticello author (so a global Dictionary). ===================================================================== GitAuthorConverter map: 'PeterUhnak' to: 'Peter Uhnak <i.uhnak(a)gmail.com>'. GitAuthorConverter gitNameFor: 'PeterUhnak' "--> returns Peter Uhnak < i.uhnak(a)gmail.com>'. ===================================================================== Peter

Feb. 20, 2015

Re: [Pharo-users] Pharo and Docker

by S Krish

Not so much Pharo on Docker, but a complete stack on Docker based on Pharo: * Seaside or any web framework.. * Multi module that can be fabric like be brought up for scaling * Moose ... On Fri, Feb 20, 2015 at 2:22 PM, Torsten Bergmann <astares(a)gmx.de> wrote: > Docker is on hype these days: > https://www.docker.com/whatisdocker/ > > Would it make sense to provide Pharo as preconfigured environment > (Pharo/Seaside stack) or other environments like the PharoNOS > project in the Docker registry? > > > > > >

Feb. 20, 2015

Pharo and Docker

by Torsten Bergmann

Docker is on hype these days: https://www.docker.com/whatisdocker/ Would it make sense to provide Pharo as preconfigured environment (Pharo/Seaside stack) or other environments like the PharoNOS project in the Docker registry?

Feb. 20, 2015

Re: [Pharo-users] i feel dumb / Pharo3 > OrderedCollection >> do:

by ClÃ©ment Bera

It depends on your OrderedCollection implementation. OrderedCollection has a variable size in memory. When instantiated, it has for example 10 slots, and if you have more than 10 objects, it needs to change its size to hold more slots. The current implementation relies on an indirection to an array, when the array overflows, the orderedCollection allocates a new bigger array and copy the slots from the existing array. There are some heuristics on array size to avoid having to grow the array too often. If you want the shallowCopy to work, you have to use the old implementation of OrderedCollection, which encodes in its field directly the values it holds. In this case however when the collection overflows you create a new orderedCollection so you need to use #become: to migrate references to the old orderedCollection to the new one. This used to be a bad idea because the become primitive was slow, but since we have Spur, it may be relevant to look at it again. This old implementation is more memory efficient too. 2015-02-20 8:05 GMT+01:00 Marcus Denker <marcus.denker(a)inria.fr>: > > On 20 Feb 2015, at 06:23, S Krish <krishnamachari.sudhakar(a)gmail.com> > wrote: > > > I presumed shallowCopy for literal arrays / OrderedCollection should have > been a true copy. Perhaps need to understand this.. > > > OrderdCollection is not just one object, but it holds on to an Array that > has itâs content. You copy the outside collection object, but share > the Array. > > shallowCopy > "Answer a copy of the receiver which shares the receiver's instance > variables. It should never be overridden. I'm invoked from the copy > template method. Subclasses that need to specialize the copy should > specialize the postCopy hook method." > ... > <primitive: 148> > class := self class. > class isVariable > ifTrue: > [... newObject :=* class basicNew: index*. ....] > ifFalse: [newObject := *class basicNew*]. > .. > whileTrue: > [newObject instVarAt: index put: (self instVarAt: index). > ... > ^ newObject > > On Wed, Feb 18, 2015 at 10:52 PM, Marcus Denker <marcus.denker(a)inria.fr> > wrote: > >> >> On 18 Feb 2015, at 18:13, Cameron Sanders via Pharo-users < >> pharo-users(a)lists.pharo.org> wrote: >> >> >> *Date: *18 Feb 2015 18:12:33 CET >> *Subject: **i feel dumb / Pharo3 > OrderedCollection >> do:* >> *From: *Cameron Sanders <camsanders(a)aol.com> >> *To: *Any question about pharo is welcome <pharo-users(a)lists.pharo.org> >> >> >> I must be making some silly error here that i cannot see clearly. Why >> does the following leave anything in the list 'a'? Run it in a workspace. >> With or without the shallowCopy, i am left with a list with half of the >> elements in it. Always half. >> >> This version of Pharo3 (21.0) was downloaded last week. I am running on a >> Mac. >> >> Thanks in advance. ... Maybe I just need more coffee. >> -Cam >> >> | a | >> a := { #a. #b. #c. #d. } asOrderedCollection. >> a shallowCopy do: [ :item | (a includes: item) ifTrue: [ a remove: item >> ]]. >> a size >> >> >> shallowCopy is not enoughâ¦ OrderedCollection is made up of an internal >> array. >> >> #copy does the right thing, just copies the array: >> >> postCopy >> array := array copy >> >> and for Array, copy is a shallowCopy. >> >> Marcus >> >> >> >> > >

Feb. 20, 2015

Re: [Pharo-users] i feel dumb / Pharo3 > OrderedCollection >> do:

by Marcus Denker

> On 20 Feb 2015, at 06:23, S Krish <krishnamachari.sudhakar(a)gmail.com> wrote: > > > I presumed shallowCopy for literal arrays / OrderedCollection should have been a true copy. Perhaps need to understand this.. > OrderdCollection is not just one object, but it holds on to an Array that has itâs content. You copy the outside collection object, but share the Array. > shallowCopy > "Answer a copy of the receiver which shares the receiver's instance variables. It should never be overridden. I'm invoked from the copy template method. Subclasses that need to specialize the copy should specialize the postCopy hook method." > ... > <primitive: 148> > class := self class. > class isVariable > ifTrue: > [... newObject := class basicNew: index. ....] > ifFalse: [newObject := class basicNew]. > .. > whileTrue: > [newObject instVarAt: index put: (self instVarAt: index). > ... > ^ newObject > > On Wed, Feb 18, 2015 at 10:52 PM, Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>> wrote: > >> On 18 Feb 2015, at 18:13, Cameron Sanders via Pharo-users <pharo-users(a)lists.pharo.org <mailto:pharo-users@lists.pharo.org>> wrote: >> >> >> Date: 18 Feb 2015 18:12:33 CET >> Subject: i feel dumb / Pharo3 > OrderedCollection >> do: >> From: Cameron Sanders <camsanders(a)aol.com <mailto:camsanders@aol.com>> >> To: Any question about pharo is welcome <pharo-users(a)lists.pharo.org <mailto:pharo-users@lists.pharo.org>> >> >> >> I must be making some silly error here that i cannot see clearly. Why does the following leave anything in the list 'a'? Run it in a workspace. With or without the shallowCopy, i am left with a list with half of the elements in it. Always half. >> >> This version of Pharo3 (21.0) was downloaded last week. I am running on a Mac. >> >> Thanks in advance. ... Maybe I just need more coffee. >> -Cam >> >> | a | >> a := { #a. #b. #c. #d. } asOrderedCollection. >> a shallowCopy do: [ :item | (a includes: item) ifTrue: [ a remove: item ]]. >> a size >> > > shallowCopy is not enoughâ¦ OrderedCollection is made up of an internal array. > > #copy does the right thing, just copies the array: > > postCopy > array := array copy > > and for Array, copy is a shallowCopy. > > Marcus > > > >

Feb. 20, 2015

Re: [Pharo-users] i feel dumb / Pharo3 > OrderedCollection >> do:

by S Krish

I presumed shallowCopy for literal arrays / OrderedCollection should have been a true copy. Perhaps need to understand this.. shallowCopy "Answer a copy of the receiver which shares the receiver's instance variables. It should never be overridden. I'm invoked from the copy template method. Subclasses that need to specialize the copy should specialize the postCopy hook method." ... <primitive: 148> class := self class. class isVariable ifTrue: [... newObject :=* class basicNew: index*. ....] ifFalse: [newObject := *class basicNew*]. .. whileTrue: [newObject instVarAt: index put: (self instVarAt: index). ... ^ newObject On Wed, Feb 18, 2015 at 10:52 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 18 Feb 2015, at 18:13, Cameron Sanders via Pharo-users < > pharo-users(a)lists.pharo.org> wrote: > > > *Date: *18 Feb 2015 18:12:33 CET > *Subject: **i feel dumb / Pharo3 > OrderedCollection >> do:* > *From: *Cameron Sanders <camsanders(a)aol.com> > *To: *Any question about pharo is welcome <pharo-users(a)lists.pharo.org> > > > I must be making some silly error here that i cannot see clearly. Why does > the following leave anything in the list 'a'? Run it in a workspace. With > or without the shallowCopy, i am left with a list with half of the elements > in it. Always half. > > This version of Pharo3 (21.0) was downloaded last week. I am running on a > Mac. > > Thanks in advance. ... Maybe I just need more coffee. > -Cam > > | a | > a := { #a. #b. #c. #d. } asOrderedCollection. > a shallowCopy do: [ :item | (a includes: item) ifTrue: [ a remove: item ]]. > a size > > > shallowCopy is not enoughâ¦ OrderedCollection is made up of an internal > array. > > #copy does the right thing, just copies the array: > > postCopy > array := array copy > > and for Array, copy is a shallowCopy. > > Marcus > > > >

Feb. 20, 2015

Re: [Pharo-users] Send message on pharo open/close?

by Paul DeBruicker

use #startUp: and #shutDown: on the class side of your class. check implementors of those methods for examples. David Carlos Manuelda wrote > I need for my application to register its main class somehow, that pharo > will send a message (class side) to it whenever image is started/finished, > for example, to reconfigure database connections as they get invalid when > image closes and opens again. > > Is there any hook for pharo to be able to send a message to my class on > image open and close? > > Thanks. -- View this message in context: http://forum.world.st/Send-message-on-pharo-open-close-tp4806562p4806565.ht… Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

Feb. 19, 2015

Send message on pharo open/close?

by David Carlos Manuelda

I need for my application to register its main class somehow, that pharo will send a message (class side) to it whenever image is started/finished, for example, to reconfigure database connections as they get invalid when image closes and opens again. Is there any hook for pharo to be able to send a message to my class on image open and close? Thanks.

Feb. 19, 2015

Using the ~pharo/stable PPA

by Markus Fritsche

Hello list, it looks to me that old and new packages have different dependencies. If you're *not* using pillar or phratch, and have problems updating the pharo packages, please execute dpkg -l | grep -i pharo | awk ' { print $2 } ' | xargs sudo apt-get -y purge ; sudo apt-get update && sudo apt-get install pharo-launcher "dpkg -l | grep -i pharo | awk ' { print $2 } '" will list all installed pharo-packages, xargs will give that result to apt-get for the packages to be purged (that is, remove all their data and metadata - the images that you have in your home directory will NOT be affected). Kind regards, Markus

Feb. 19, 2015