- Pharo-users - lists.pharo.org

Improving comments cool action

by stepharo

Hi guys I would like to see how we could build a concerted action to improve the class and method comments in Pharo. Now we have package comments :) so we should take also advantage of them. I would love that a newbie is highlithed by class comments. So I would like to start to comment key core classes. I'm sure that if we all spend 30 min per week we can really have a huge impact. I was planning to start with collection classes. Now let me know if you want to help. Stef

Nov. 20, 2016

Re: [Pharo-users] [UFFI] Dealing with Windows types

by Dimitris Chloupis

Once more I got lost in the the spaghetti called "Pharo code". I am referring to OSWindows. Ironically its easier to read Windows header files and disassemble memory than actually read pharo code :D Fortunately void pointers is not an issue since I already used them on Linux and Macos with UFFI without using FFIConstanthandle. By the way the comment in that class wonder whether handles in Linux and Macos are the same , they are not, in Window a handle is a void pointer , in Linux and Macos they are just regular integers (int). So far I have drawn the following conclusions Unicode means 2 bytes char , windows names it wchar_t , the equivelant on pharo must be long char , it stores unicode strings which VS C++ defines as L"my text", first byte is a hex number for the character itself, second byte in most cases is 0 except for special characters. Numbers 0-9 are 48 (hex: 30) to 57 (hex: 39) Characters A-Z are 65(hex: 41) to 90(hex: 5A) Characters a-z are 97(hex: 61) to 122(hex: 7A) So either I use Unicode as it is or use Unicode as a 1 byte char chaining 2 bytes together instead of 1 at a time. Which will result in exact same memory value for all OS (Windows /Linux / Maco) either solution could work. windows PVOID(void pointer) and *wchar_t ( pointer to TCHAR [Unicode- 2 bytes]) are 4 bytes like Linux and MacOS equivalent pointers. So it seems the differences are not as massive as I feared , apart from Unicode text the rest appears to be more or less the same. But I will be sure as soon as I use UFFI to test these assumptions which I am about to do. On Sun, Nov 20, 2016 at 10:51 AM Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > Hi, > > > On 20 Nov 2016, at 00:52, Mark Bestley <st(a)bestley.co.uk> wrote: > > > > > > Sorry I have not got a Windows machine here but MSDN should provide all > the documentation you need. Some of these types are not translatable and > have to be treated as opaque on the Smalltalk side ie just pass as data > > > > All are defined in Windows.h and MSDN provides documentation - for types > see > https://msdn.microsoft.com/en-us/library/windows/desktop/aa383751(v=vs.85).… > > > > Note the naming of many of these comes from Windows 2 or earlier so was > used on 16 bit programs > > > > handle_t / HANDLE is a pseudo pointer that Windows has created and > Windows system calls understand. They will dereference it to find something > useful - This is similar to a POSIX file handle that you can only use as a > parameter to system calls. > > and these are handled by UFFI by FFIConstantHandle (read the comment) > > > > > PVOID is a pointer to a void ie just a pointer to something > > > > LPCTSTR and TCHAR depend on Unicode > > yepâ¦ maybe you want to see OSWindows from Torsten, he already aliased many > of this types. > > Esteban > > > > > In Wnndows C API there are usually two forms of many systems call they > either take 8 bit ANSI strings or 16 bit ones which MS says is Unicode > (unfortuneatly for us now MS made the decision of 16 bit when all Unicode > points fitted into 16 bits so not now a simple mapping. See > https://msdn.microsoft.com/en-us/library/vs/alm/dd183415(v=vs.85).aspx > and https://msdn.microsoft.com/en-us/library/2dax2h36.aspx > > > > I'll assume you want Unicode > > > > TCHAR is then a 16 bit Unicode character > > LPCTSTR is a const long pointer to a 16 bit Unicode string > > > > I would suggest finding a book or long tutorial :( and sorry I can't > suggest any as I read this from Petzold books over 25 years ago > > > > Mark > > > > > > On 19/11/2016 18:51, Dimitris Chloupis wrote: > >> So now I need to port my CPPBridge to Windows and I have to deal with > >> this monster. And it would not be Windows if it did not make life a lot > >> harder , so it defines its own types. > >> > >> Such types are > >> > >> handle_t / HANDLE > >> TCHAR > >> LPCTSTR > >> PVOID > >> > >> also I will have to deal with Unicode , I have no clue how to proceed, > >> any help is greatly appreciated. > >> > > > > > > -- > > Mark > > > > > > >

Nov. 20, 2016

Re: [Pharo-users] [UFFI] Dealing with Windows types

by Esteban Lorenzano

Hi, > On 20 Nov 2016, at 00:52, Mark Bestley <st(a)bestley.co.uk> wrote: > > > Sorry I have not got a Windows machine here but MSDN should provide all the documentation you need. Some of these types are not translatable and have to be treated as opaque on the Smalltalk side ie just pass as data > > All are defined in Windows.h and MSDN provides documentation - for types see https://msdn.microsoft.com/en-us/library/windows/desktop/aa383751(v=vs.85).… > > Note the naming of many of these comes from Windows 2 or earlier so was used on 16 bit programs > > handle_t / HANDLE is a pseudo pointer that Windows has created and Windows system calls understand. They will dereference it to find something useful - This is similar to a POSIX file handle that you can only use as a parameter to system calls. and these are handled by UFFI by FFIConstantHandle (read the comment) > > PVOID is a pointer to a void ie just a pointer to something > > LPCTSTR and TCHAR depend on Unicode yepâ¦ maybe you want to see OSWindows from Torsten, he already aliased many of this types. Esteban > > In Wnndows C API there are usually two forms of many systems call they either take 8 bit ANSI strings or 16 bit ones which MS says is Unicode (unfortuneatly for us now MS made the decision of 16 bit when all Unicode points fitted into 16 bits so not now a simple mapping. See https://msdn.microsoft.com/en-us/library/vs/alm/dd183415(v=vs.85).aspx and https://msdn.microsoft.com/en-us/library/2dax2h36.aspx > > I'll assume you want Unicode > > TCHAR is then a 16 bit Unicode character > LPCTSTR is a const long pointer to a 16 bit Unicode string > > I would suggest finding a book or long tutorial :( and sorry I can't suggest any as I read this from Petzold books over 25 years ago > > Mark > > > On 19/11/2016 18:51, Dimitris Chloupis wrote: >> So now I need to port my CPPBridge to Windows and I have to deal with >> this monster. And it would not be Windows if it did not make life a lot >> harder , so it defines its own types. >> >> Such types are >> >> handle_t / HANDLE >> TCHAR >> LPCTSTR >> PVOID >> >> also I will have to deal with Unicode , I have no clue how to proceed, >> any help is greatly appreciated. >> > > > -- > Mark > >

Nov. 20, 2016

Re: [Pharo-users] [UFFI] Dealing with Windows types

by Dimitris Chloupis

Actually that was very helpful and there is no need to apologise at all. I just wanted a push towards the right direction , you practically teleported me there. Don't worry I am not lazy (not claiming that you imply that I am ) , I actually enjoy investigating code so diving inside header files is not a problem at all. I dont really want or need unicode , since unicode is useful only if you want to type or print in specific languages, but even my native language Greek only needs ANSI / ASCII , not that I ever use greek in any of my code mind you , I am 100% English speaking and typing when it comes to coding. I have some things figured out that I did not mention for example I knew that TCHAR is 2 bytes when char is 1 byte because of Unicode support . However your advise just revealed to me that it was a mistake to compile my C++ code for 64 bit since that would affect those types as well. Another question I have is about const char / const long pointer , I know that const here means "not able to change value/ content" is there anything more to it ? Again thank you very much , things are much more clear now :) On Sun, Nov 20, 2016 at 1:59 AM Mark Bestley <st(a)bestley.co.uk> wrote: > > Sorry I have not got a Windows machine here but MSDN should provide all > the documentation you need. Some of these types are not translatable and > have to be treated as opaque on the Smalltalk side ie just pass as data > > All are defined in Windows.h and MSDN provides documentation - for types > see > > https://msdn.microsoft.com/en-us/library/windows/desktop/aa383751(v=vs.85).… > > Note the naming of many of these comes from Windows 2 or earlier so was > used on 16 bit programs > > handle_t / HANDLE is a pseudo pointer that Windows has created and > Windows system calls understand. They will dereference it to find > something useful - This is similar to a POSIX file handle that you can > only use as a parameter to system calls. > > PVOID is a pointer to a void ie just a pointer to something > > LPCTSTR and TCHAR depend on Unicode > > In Wnndows C API there are usually two forms of many systems call they > either take 8 bit ANSI strings or 16 bit ones which MS says is Unicode > (unfortuneatly for us now MS made the decision of 16 bit when all > Unicode points fitted into 16 bits so not now a simple mapping. See > https://msdn.microsoft.com/en-us/library/vs/alm/dd183415(v=vs.85).aspx > and https://msdn.microsoft.com/en-us/library/2dax2h36.aspx > > I'll assume you want Unicode > > TCHAR is then a 16 bit Unicode character > LPCTSTR is a const long pointer to a 16 bit Unicode string > > I would suggest finding a book or long tutorial :( and sorry I can't > suggest any as I read this from Petzold books over 25 years ago > > Mark > > > On 19/11/2016 18:51, Dimitris Chloupis wrote: > > So now I need to port my CPPBridge to Windows and I have to deal with > > this monster. And it would not be Windows if it did not make life a lot > > harder , so it defines its own types. > > > > Such types are > > > > handle_t / HANDLE > > TCHAR > > LPCTSTR > > PVOID > > > > also I will have to deal with Unicode , I have no clue how to proceed, > > any help is greatly appreciated. > > > > > -- > Mark > > >

Nov. 20, 2016

Re: [Pharo-users] [UFFI] Dealing with Windows types

by Mark Bestley

Sorry I have not got a Windows machine here but MSDN should provide all the documentation you need. Some of these types are not translatable and have to be treated as opaque on the Smalltalk side ie just pass as data All are defined in Windows.h and MSDN provides documentation - for types see https://msdn.microsoft.com/en-us/library/windows/desktop/aa383751(v=vs.85).… Note the naming of many of these comes from Windows 2 or earlier so was used on 16 bit programs handle_t / HANDLE is a pseudo pointer that Windows has created and Windows system calls understand. They will dereference it to find something useful - This is similar to a POSIX file handle that you can only use as a parameter to system calls. PVOID is a pointer to a void ie just a pointer to something LPCTSTR and TCHAR depend on Unicode In Wnndows C API there are usually two forms of many systems call they either take 8 bit ANSI strings or 16 bit ones which MS says is Unicode (unfortuneatly for us now MS made the decision of 16 bit when all Unicode points fitted into 16 bits so not now a simple mapping. See https://msdn.microsoft.com/en-us/library/vs/alm/dd183415(v=vs.85).aspx and https://msdn.microsoft.com/en-us/library/2dax2h36.aspx I'll assume you want Unicode TCHAR is then a 16 bit Unicode character LPCTSTR is a const long pointer to a 16 bit Unicode string I would suggest finding a book or long tutorial :( and sorry I can't suggest any as I read this from Petzold books over 25 years ago Mark On 19/11/2016 18:51, Dimitris Chloupis wrote: > So now I need to port my CPPBridge to Windows and I have to deal with > this monster. And it would not be Windows if it did not make life a lot > harder , so it defines its own types. > > Such types are > > handle_t / HANDLE > TCHAR > LPCTSTR > PVOID > > also I will have to deal with Unicode , I have no clue how to proceed, > any help is greatly appreciated. > -- Mark

Nov. 20, 2016

Re: Pharo-users Digest, Vol 43, Issue 109

by Asbath Sama biyalou

Thanks kmo. It works. But I have to modify my response content type in order to make it work fine. When I take WAMimeType It doesn't work. On 19/11/2016 18:00, pharo-users-request(a)lists.pharo.org wrote: > Send Pharo-users mailing list submissions to > pharo-users(a)lists.pharo.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.pharo.org/mailman/listinfo/pharo-users_lists.pharo.org > or, via email, send a message with subject or body 'help' to > pharo-users-request(a)lists.pharo.org > > You can reach the person managing the list at > pharo-users-owner(a)lists.pharo.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Pharo-users digest..." > > > Today's Topics: > > 1. Re: NeoJSON with Rest (kmo) > 2. Re: NeoJSON with Rest (Asbath Sama biyalou) > 3. Re: NeoJSON with Rest (Sven Van Caekenberghe) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Sat, 19 Nov 2016 01:36:54 -0800 (PST) > From: kmo <voxkmp(a)gmail.com> > To: pharo-users(a)lists.pharo.org > Subject: Re: [Pharo-users] NeoJSON with Rest > Message-ID: <1479548214757-4923762.post(a)n4.nabble.com> > Content-Type: text/plain; charset=us-ascii > > This works for me: > > Say you have a class called MyObject and you want a JSON representation of > it. > > On the *class *side of MyObject add this method: > > neoJsonMapping: mapper > "For inheritance mapping to work, the schema/classname must be self, > but the instance variables have to be enumerated manually per class" > > mapper for: self do: [ :mapping | > mapping mapAllInstVars ]. > > > On the* instance *side of MyObject add: > > asJson > ^NeoJSONWriter toString: self. > > Now you can return JSON for any instance of MyObject with a simple: > > myobjectinstance asJson. > > This code gives you all the instance variables of MyObject as a JSON string, > but you can change the mapping statement to tailor it to include exactly > what you want. > > Hope this helps. > > > > > > -- > View this message in context: http://forum.world.st/NeoJSON-with-Rest-tp4923754p4923762.html > Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com. > > > > ------------------------------ > > Message: 2 > Date: Sat, 19 Nov 2016 15:32:36 +0100 > From: Asbath Sama biyalou <asamabiyalou(a)yahoo.com> > To: Sven Van Caekenberghe <sven(a)stfx.eu>, Any question about pharo is > welcome <pharo-users(a)lists.pharo.org> > Subject: Re: [Pharo-users] NeoJSON with Rest > Message-ID: <9a86fe55-2dae-9a59-35b1-495b9b732072(a)yahoo.com> > Content-Type: text/plain; charset="windows-1252" > > Thank you Sven. I check those example. very helpfull. > > But I use this method toJson to convert the stream to json and I get : > > PrimitiveFailed: primitive #basicNew: in ByteString class failed > > toJson > ^ String streamContents: [ :stream | > (NeoJSONWriter on: stream) > for: Date > customDo: [ :mapping | mapping encoder: [ :value | value asDateAndTime printString ] ]; > nextPut: data ] > > Did you see some errors. > > > > On 19/11/2016 09:52, Sven Van Caekenberghe wrote: >> Did you read https://ci.inria.fr/pharo-contribution/job/EnterprisePharoBook/lastSuccessf… ? >> >> Did you check out the unit tests ? Some of them serve as examples. Checkout NeoJSONTestObject1 2 3 and the tests #testObject1 2 3 for example. >> >>> On 19 Nov 2016, at 08:24, Asbath Sama biyalou via Pharo-users <pharo-users(a)lists.pharo.org> wrote: >>> >>> >>> From: Asbath Sama biyalou <asamabiyalou(a)yahoo.com> >>> Subject: NeoJSON with Rest >>> Date: 19 November 2016 at 08:24:13 GMT+1 >>> To: Pharo users users <pharo-users(a)lists.pharo.org> >>> >>> >>> Hello. >>> >>> I want an example of implementation of neojson on a pharo object. >>> >>> I am trying to implement neoJsonOn: method on a pharo object but when I >>> test I get a Character mapping not found >>> >>> in NeoJSONWriter. >>> >>> Thanks. >>> >>> >>> >>> >

Nov. 19, 2016

[UFFI] Dealing with Windows types

by Dimitris Chloupis

So now I need to port my CPPBridge to Windows and I have to deal with this monster. And it would not be Windows if it did not make life a lot harder , so it defines its own types. Such types are handle_t / HANDLE TCHAR LPCTSTR PVOID also I will have to deal with Unicode , I have no clue how to proceed, any help is greatly appreciated.

Nov. 19, 2016

Re: [Pharo-users] NeoJSON with Rest

by Sven Van Caekenberghe

This works for me: String streamContents: [ :out | (NeoJSONWriter on: out) for: Date customDo: [ :mapping | mapping encoder: [ :value | value asDateAndTime printString ] ]; nextPut: { #date -> Date today } asDictionary ]. "'{""date"":""2016-11-19T00:00:00+01:00""}'" String streamContents: [ :out | (NeoJSONWriter on: out) for: Date customDo: [ :mapping | mapping encoder: [ :value | value yyyymmdd ] ]; nextPut: { #date -> Date today } asDictionary ]. "'{""date"":""2016-11-19""}'" > On 19 Nov 2016, at 15:32, Asbath Sama biyalou <asamabiyalou(a)yahoo.com> wrote: > > Thank you Sven. I check those example. very helpfull. > > But I use this method toJson to convert the stream to json and I get : > > PrimitiveFailed: primitive #basicNew: in ByteString class failed > > toJson > ^ String streamContents: [ :stream | > (NeoJSONWriter on: stream) > for: Date > customDo: [ :mapping | mapping encoder: [ :value | value asDateAndTime printString ] ]; > nextPut: data ] > > Did you see some errors. > > > > On 19/11/2016 09:52, Sven Van Caekenberghe wrote: >> Did you read https://ci.inria.fr/pharo-contribution/job/EnterprisePharoBook/lastSuccessf… >> ? >> >> Did you check out the unit tests ? Some of them serve as examples. Checkout NeoJSONTestObject1 2 3 and the tests #testObject1 2 3 for example. >> >> >>> On 19 Nov 2016, at 08:24, Asbath Sama biyalou via Pharo-users <pharo-users(a)lists.pharo.org> >>> wrote: >>> >>> >>> From: Asbath Sama biyalou >>> <asamabiyalou(a)yahoo.com> >>> >>> Subject: NeoJSON with Rest >>> Date: 19 November 2016 at 08:24:13 GMT+1 >>> To: Pharo users users >>> <pharo-users(a)lists.pharo.org> >>> >>> >>> >>> Hello. >>> >>> I want an example of implementation of neojson on a pharo object. >>> >>> I am trying to implement neoJsonOn: method on a pharo object but when I >>> test I get a Character mapping not found >>> >>> in NeoJSONWriter. >>> >>> Thanks. >>> >>> >>> >>> >>> >

Nov. 19, 2016

Re: [Pharo-users] NeoJSON with Rest

by Asbath Sama biyalou

Thank you Sven. I check those example. very helpfull. But I use this method toJson to convert the stream to json and I get : PrimitiveFailed: primitive #basicNew: in ByteString class failed toJson ^ String streamContents: [ :stream | (NeoJSONWriter on: stream) for: Date customDo: [ :mapping | mapping encoder: [ :value | value asDateAndTime printString ] ]; nextPut: data ] Did you see some errors. On 19/11/2016 09:52, Sven Van Caekenberghe wrote: > Did you read https://ci.inria.fr/pharo-contribution/job/EnterprisePharoBook/lastSuccessf… ? > > Did you check out the unit tests ? Some of them serve as examples. Checkout NeoJSONTestObject1 2 3 and the tests #testObject1 2 3 for example. > >> On 19 Nov 2016, at 08:24, Asbath Sama biyalou via Pharo-users <pharo-users(a)lists.pharo.org> wrote: >> >> >> From: Asbath Sama biyalou <asamabiyalou(a)yahoo.com> >> Subject: NeoJSON with Rest >> Date: 19 November 2016 at 08:24:13 GMT+1 >> To: Pharo users users <pharo-users(a)lists.pharo.org> >> >> >> Hello. >> >> I want an example of implementation of neojson on a pharo object. >> >> I am trying to implement neoJsonOn: method on a pharo object but when I >> test I get a Character mapping not found >> >> in NeoJSONWriter. >> >> Thanks. >> >> >> >>

Nov. 19, 2016

Re: [Pharo-users] NeoJSON with Rest

by kmo

This works for me: Say you have a class called MyObject and you want a JSON representation of it. On the *class *side of MyObject add this method: neoJsonMapping: mapper "For inheritance mapping to work, the schema/classname must be self, but the instance variables have to be enumerated manually per class" mapper for: self do: [ :mapping | mapping mapAllInstVars ]. On the* instance *side of MyObject add: asJson ^NeoJSONWriter toString: self. Now you can return JSON for any instance of MyObject with a simple: myobjectinstance asJson. This code gives you all the instance variables of MyObject as a JSON string, but you can change the mapping statement to tailor it to include exactly what you want. Hope this helps. -- View this message in context: http://forum.world.st/NeoJSON-with-Rest-tp4923754p4923762.html Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

Nov. 19, 2016