July 2018 - Pharo-users - lists.pharo.org

Re: [Pharo-users] Pharo 7 file streams guideline

by Richard O'Keefe

I am a little confused by Filestreams.MD #position and #position: report and set the number of past items. So when you open a stream, #position is 0. So why does the first "Positionable streams" example use ... position: 4 ... while the second one skips 3 characters? ... position: 3 ... would be just as broken. Oh, I think a clarification is needed when talking about UTF-8. To the best of my knowledge you don't need a Byte-Order-Mark at the beginning of a UTF-8 stream because there is no byte order issue to result, but apparently many Windows programs like to add one. Does/will Pharo add one when writing a UTF-8 file? Does/will it skip one when reading a UTF-8 file? I find the new approach produces unattractive code. I can do all of the examples simply in a system that (a) implements the ANSI Smalltalk FileStream class methods (b) supports '/dev/stdin' and '/dev/stdout' as file names (c) interprets the external type #'text' either as #'utf8' or as "whatever $LC_CTYPE says" and also supports #'utf8' and #'cp1250' as external types. Oh, and defines Object>>bindOwn: aBlock ^(self respondsTo: #close) ifTrue: [aBlock ensure: [self close]] ifFalse: [aBlock value] What document should I read to get a mental model of the new system and understand its rationale? On 23 July 2018 at 19:38, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > Hello, > > I've prepared a draft of a short document that should help you with the > transition to the "new" file streams API in Pharo 7. > > https://github.com/pavel-krivanek/pharoMaterials/blob/ > master/Filestreams.MD > > Pull requests are welcome. > > Cheers, > -- Pavel > > > >

July 23, 2018

Re: [Pharo-users] Changing a BaselineOf... to include one more package

by Sean P. DeNigris

Andrew Black-2 wrote >> spec >> baseline: 'SmaCC' with: [ spec loads: #('Reification' ) ] > > Can you tell me what this line actually means. That is, what does the > #baseline:with: method actually declare? It means load the 'Reification' group of the SmaCC project, as specified in BaselineOfSmaCC. The 'Reification' group includes the SmaCC-Reification package, and by extension its dependencies as specified by the baseline. Andrew Black-2 wrote > Where should I put this statement? In baselineOfSmaCC, or > baselineOfGrace? Why? baselineOfGrace. You're saying that SmaCC (specifically the Reification group) is a dependency of Grace. You should probably also add Smacc the the #requires: list of whatever (e.g. package(s)) requires it. Deep into Pharo (http://books.pharo.org/deep-into-pharo/) Chapter 9 gives a pretty good explanation of much of Metacello. Ignore the gopher stuff which has been replaced by the Metacello scripting API. Also, the book was written when baseline methods were in Configuration classes, whereas now for git they are reified into BaselineOf classes, but the API of the actual method is still the same so it should help clarify. ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

July 23, 2018

Re: [Pharo-users] Grease stream tests failing on Pharo7

by Richard O'Keefe

(ReadWriteStream on: 'abc') contents ==> 'abc' in GNU Smalltalk and Dolphin ==> '' in Squeak 6.0 and ST/X Here I think we see why ANSI Smalltalk defined #with: for {Read,}WriteStreams but not #on:. When you recall that ReadWriteStream is a subclass of WriteStream in most Smalltalks, and that (WriteStream on: (String new: 20)) or whatever is normally used with the argument of #on: expected to provide *workspace*, not *content*, why on earth would you expect (ReadWriteStream on: 'abc') contents to be different from (WriteStream on: 'abc') contents which is ''? On 23 July 2018 at 21:50, Johan Brichau <johan(a)inceptive.be> wrote: > Hi, > > As Iâm diving into the changes and why it fails: > > (ReadWriteStream on: âabcâ) contents > -> = âabcâ on Pharo 6 > -> = ââ on Pharo 7 > > That seems wrong to me. > > (Iâve also sent this question via github on the commit itself > https://github.com/pharo-project/pharo/commit/ > 9e442addff3790af0c78dbc73f1f349de8a4ad03#diff- > ba7cc7962a4a22468a18b31fe75ada04 ) > > cheers > Johan > > On 22 Jul 2018, at 10:52, Johan Brichau <johan(a)inceptive.be> wrote: > > Hi, > > I am taking a look at making Grease and Seaside work correctly on Pharo7. > > There have been a number of changes to the ReadWriteStream implementation > in Pharo that break Grease tests: https://travis-ci.org/ > SeasideSt/Grease/jobs/406766720 > It seems ReadWriteStream is broken: the readLimit is almost always wrong > meaning that the stream `atEnd`, `contents` etc.. return wrong values > > Before I dive into this, I wanted to inquire if anyone is working on this > as I cannot seem to find any open cases on this on the issue tracker. > > cheers > Johan > > > >

July 23, 2018

Re: [Pharo-users] [ANN] Cryptography package on github

by Sean P. DeNigris

Esteban A. Maringolo wrote > Good work Norbert. Thanks! +1 ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

July 23, 2018

Re: [Pharo-users] [ANN] Cryptography package on github

by Esteban A. Maringolo

Good work Norbert. Thanks! Esteban A. Maringolo El lun., 23 jul. 2018 a las 8:59, Norbert Hartl (<norbert(a)hartl.name>) escribiÃ³: > > After several attempts to solve the Cryptography package problems over the years I decided to move it on my own to github. > > What I did: > > - researched all authors and used the git migration tool to get the package from smalltalkhub to github > - released a version 0.1 that should be exactly the same as the code on smalltalkhub for people that want to change > - fixed an occurrence of IfNotNilDo: in the Cryptography package to make it load in pharo7 > - added a metacello baseline > - added a group âall" that loads everything like it is now with one package > - added travis files and enable travis checks for pull requests > - released a version 0.2 that contains the original code plus travis and metacello > - Started to cut off the ASN1, PKCS12 and X509 classes in separate packages > - Added to each new package a -Tests package containing tests > - constructed all dependencies in the baseline > - added a core group that loads the now slimmed down package solely > > I must say this was really great with the help of promote-demote package tag functionality and the dependency browser. The only thing missing is kind of a tool to construct the metacello baseline. I miss Versionner here. > > What I didnât do: > > - checking all the other packages in the repo. There are packages with old style ffi calls and things that seem to be squeak dependent. > > I hope with the time and peopleâs complaints we can figure out what is obsolete and what needs to be adjusted. > > The repository is now at > > https://github.com/zweidenker/Cryptography > > but Iâm happy to move it to a better place if someone has an idea. > > Pull requests and tickets are welcome. > > Hope you like it, > > Norbert >

July 23, 2018

[ANN] Cryptography package on github

by Norbert Hartl

After several attempts to solve the Cryptography package problems over the years I decided to move it on my own to github. What I did: - researched all authors and used the git migration tool to get the package from smalltalkhub to github - released a version 0.1 that should be exactly the same as the code on smalltalkhub for people that want to change - fixed an occurrence of IfNotNilDo: in the Cryptography package to make it load in pharo7 - added a metacello baseline - added a group âall" that loads everything like it is now with one package - added travis files and enable travis checks for pull requests - released a version 0.2 that contains the original code plus travis and metacello - Started to cut off the ASN1, PKCS12 and X509 classes in separate packages - Added to each new package a -Tests package containing tests - constructed all dependencies in the baseline - added a core group that loads the now slimmed down package solely I must say this was really great with the help of promote-demote package tag functionality and the dependency browser. The only thing missing is kind of a tool to construct the metacello baseline. I miss Versionner here. What I didnât do: - checking all the other packages in the repo. There are packages with old style ffi calls and things that seem to be squeak dependent. I hope with the time and peopleâs complaints we can figure out what is obsolete and what needs to be adjusted. The repository is now at https://github.com/zweidenker/Cryptography <https://github.com/zweidenker/Cryptography> but Iâm happy to move it to a better place if someone has an idea. Pull requests and tickets are welcome. Hope you like it, Norbert

July 23, 2018

Re: [Pharo-users] Pharo 7 file streams guideline

by Sven Van Caekenberghe

> On 23 Jul 2018, at 09:38, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > > Hello, > > I've prepared a draft of a short document that should help you with the transition to the "new" file streams API in Pharo 7. > > https://github.com/pavel-krivanek/pharoMaterials/blob/master/Filestreams.MD > > Pull requests are welcome. > > Cheers, > -- Pavel Great contribution, thanks ! I see no factual errors, everything is clear, cookbook style. The last two sections might be more confusing than helpful. I would go more for 'all streams are buffered, don't worry' and 'beware positioning is byte based'. Regarding positioning, some additional points that might no be so well known. - Positioning in a variable length encoded stream is plain hard (and basically comes down to linear searching) - All ZnCharacterEncoders understand #backOnStream: that does the right thing - There is also ZnPositionableReadStream that can help (read the class comment) Sven

July 23, 2018

Re: [Pharo-users] Pharo 7 file streams guideline

by Sven Van Caekenberghe

> On 23 Jul 2018, at 11:13, Ben Coman <btc(a)openinworld.com> wrote: > > On 23 July 2018 at 15:38, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: >> Hello, >> >> I've prepared a draft of a short document that should help you with the >> transition to the "new" file streams API in Pharo 7. >> >> https://github.com/pavel-krivanek/pharoMaterials/blob/master/Filestreams.MD >> >> Pull requests are welcome. >> >> Cheers, >> -- Pavel >> >> >> > > Some discussion prior to any pull request (and while I'm away from > Pharo machine) > > I like all the new code examples until "Write a UTF-8 text to STDOUT" > and I wonder "Stdio stdout writeStreamDo: [ :stream | stream > nextPutAll: 'a â b' ]" would better fit the pattern of the other new > code. > (presuming "Stdio stdout" returns a FileReference, oherwise maybe > "Stdio stdoutRef" or "Stdio stdout asFileReference") Stdio stdout and friends just return a binary stream, hence they need wrapping for encoding. Maybe Stdio stdoutAsText might be an idea, but this is so uncommon that I am not sure this is a good idea. > Under "Positionable streams", rather than needing "3 timesRepeat: [ > stream next ]" > would it be worth having #utf8position: to more intention revealing? no more new API, please. Positioning in a variable length encoded stream is plain hard - see my other mail. > cheers -ben >

July 23, 2018

Re: [Pharo-users] Grease stream tests failing on Pharo7

by Johan Brichau

Hi, As Iâm diving into the changes and why it fails: (ReadWriteStream on: âabcâ) contents -> = âabcâ on Pharo 6 -> = ââ on Pharo 7 That seems wrong to me. (Iâve also sent this question via github on the commit itself https://github.com/pharo-project/pharo/commit/9e442addff3790af0c78dbc73f1f3… <https://github.com/pharo-project/pharo/commit/9e442addff3790af0c78dbc73f1f3…> ) cheers Johan > On 22 Jul 2018, at 10:52, Johan Brichau <johan(a)inceptive.be> wrote: > > Hi, > > I am taking a look at making Grease and Seaside work correctly on Pharo7. > > There have been a number of changes to the ReadWriteStream implementation in Pharo that break Grease tests: https://travis-ci.org/SeasideSt/Grease/jobs/406766720 <https://travis-ci.org/SeasideSt/Grease/jobs/406766720> > It seems ReadWriteStream is broken: the readLimit is almost always wrong meaning that the stream `atEnd`, `contents` etc.. return wrong values > > Before I dive into this, I wanted to inquire if anyone is working on this as I cannot seem to find any open cases on this on the issue tracker. > > cheers > Johan > >

July 23, 2018

Re: [Pharo-users] Pharo 7 file streams guideline

by Ben Coman

On 23 July 2018 at 15:38, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > Hello, > > I've prepared a draft of a short document that should help you with the > transition to the "new" file streams API in Pharo 7. > > https://github.com/pavel-krivanek/pharoMaterials/blob/master/Filestreams.MD > > Pull requests are welcome. > > Cheers, > -- Pavel > > > Some discussion prior to any pull request (and while I'm away from Pharo machine) I like all the new code examples until "Write a UTF-8 text to STDOUT" and I wonder "Stdio stdout writeStreamDo: [ :stream | stream nextPutAll: 'a â b' ]" would better fit the pattern of the other new code. (presuming "Stdio stdout" returns a FileReference, oherwise maybe "Stdio stdoutRef" or "Stdio stdout asFileReference") Under "Positionable streams", rather than needing "3 timesRepeat: [ stream next ]" would it be worth having #utf8position: to more intention revealing? cheers -ben

July 23, 2018