July 2015 - Pharo-users - lists.pharo.org

Re: [Pharo-users] gitfiletree metadata

by Peter UhnÃ¡k

On Fri, Jul 24, 2015 at 1:13 PM, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > > > 2015-07-24 13:04 GMT+02:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com>: > >> >> Alex, would you be able to show something with Roassal? It would be >>> really nice to see the overall git history graph overlaid with the graph of >>> the history of the selected package. >>> >> >> Interesting that if someone else needs it I have no problem writing >> Roassal scripts etc, but when I need it I don't even think of using Roassal >> to actually solve my problems... >> > > :) > > >> >> Anyway I ran into similar issue I had before, that >> McFileTreeGitRepository is returning GitFileTreePackageEntry instead of >> filenames, so this fails. >> > >> ~~~~~~~~~~~~~~~~ >> mc := MCFileTreeGitRepository allInstances detect: [ :m | m name >> includesSubstring: 'dynacase/repository' ]. >> >> root := mc versionInfoFromFileNamed: mc readableFileNames first. "<-- mc >> readableFileNames doesn't return file names" >> ~~~~~~~~~~~~~~~ >> (The above for SmalltalkHub repos works just fine.) >> > > Yes. I spent a lot of time try to guess what was the repository API used > by Monticello, and I failed for part of it ;) > > With git, I couldn't work with something as primitive as a file name to > refer to a git commit :) so had to work at a higher level and try to patch > all the places where Monticello was forcing strings on me. > Ok, so should I work around this because it's unfixable, or is it a bug? > > >> >> This is the previous issue you've already fixed >> http://forum.world.st/GitFileTree-browsing-changes-doesn-t-work-in-Pharo-5-… >> , it seems related. >> > > Ok. It is present in Pharo 4 as well, then. > I'm not sure how is Pharo 4 related (I do all dev in 5 now). > > Thanks, > > Thierry > >> >

July 24, 2015

Re: [Pharo-users] gitfiletree metadata

by Thierry Goubier

2015-07-24 13:04 GMT+02:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com>: > > Alex, would you be able to show something with Roassal? It would be really >> nice to see the overall git history graph overlaid with the graph of the >> history of the selected package. >> > > Interesting that if someone else needs it I have no problem writing > Roassal scripts etc, but when I need it I don't even think of using Roassal > to actually solve my problems... > :) > > Anyway I ran into similar issue I had before, that McFileTreeGitRepository > is returning GitFileTreePackageEntry instead of filenames, so this fails. > > ~~~~~~~~~~~~~~~~ > mc := MCFileTreeGitRepository allInstances detect: [ :m | m name > includesSubstring: 'dynacase/repository' ]. > > root := mc versionInfoFromFileNamed: mc readableFileNames first. "<-- mc > readableFileNames doesn't return file names" > ~~~~~~~~~~~~~~~ > (The above for SmalltalkHub repos works just fine.) > Yes. I spent a lot of time try to guess what was the repository API used by Monticello, and I failed for part of it ;) With git, I couldn't work with something as primitive as a file name to refer to a git commit :) so had to work at a higher level and try to patch all the places where Monticello was forcing strings on me. > > This is the previous issue you've already fixed > http://forum.world.st/GitFileTree-browsing-changes-doesn-t-work-in-Pharo-5-… > , it seems related. > Ok. It is present in Pharo 4 as well, then. Thanks, Thierry >

July 24, 2015

Re: [Pharo-users] gitfiletree metadata

by Peter UhnÃ¡k

> Alex, would you be able to show something with Roassal? It would be really > nice to see the overall git history graph overlaid with the graph of the > history of the selected package. > Interesting that if someone else needs it I have no problem writing Roassal scripts etc, but when I need it I don't even think of using Roassal to actually solve my problems... Anyway I ran into similar issue I had before, that McFileTreeGitRepository is returning GitFileTreePackageEntry instead of filenames, so this fails. ~~~~~~~~~~~~~~~~ mc := MCFileTreeGitRepository allInstances detect: [ :m | m name includesSubstring: 'dynacase/repository' ]. root := mc versionInfoFromFileNamed: mc readableFileNames first. "<-- mc readableFileNames doesn't return file names" ~~~~~~~~~~~~~~~ (The above for SmalltalkHub repos works just fine.) This is the previous issue you've already fixed http://forum.world.st/GitFileTree-browsing-changes-doesn-t-work-in-Pharo-5-… , it seems related. Peter

July 24, 2015

Re: [Pharo-users] gitfiletree metadata

by Thierry Goubier

Hi Peter, here is my analysis on DynaCASE-PeterUhnak.147. When going through the history on git, many of the merges do not register as belonging to the DynaCASE package (a git commit belongs to a package when it modify something inside the package directory or modify the version file, I don't remember which indicator I used...). So, to be able to recover all the parents of DynaCASE-PeterUhnak.147, the algorithm (one) has to go through thoses merges transitively until all the branches it has so followed ends with a commit belonging to DynaCASE. Sometimes, drawing this as a graph in the repository inspector would help immensely... Alex, would you be able to show something with Roassal? It would be really nice to see the overall git history graph overlaid with the graph of the history of the selected package. By the way, if you want to explore some of the issues you have to tackle when reading metadata in a git repository, I suggest trying gitg on the dynacase repository... and wait :) Makes Pharo look like a speedy beast :) Thierry 2015-07-24 11:05 GMT+02:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com>: > >>> Sorry for the lack of support on windows. You'll have to wait for >>>> libcgit. >>> >>> >>> Is there an estimated timeline when this will be? (weeks, months, years, >>> ...?) >>> >> >> I don't know; the lib has been included in the Pharo vm for a long time, >> and I remember talks about having it for Pharo5. Stef, what is the Pharo >> consortium plans on that? >> > > CCed Stef :) ^^ > > >> >> >>> Yes, this also happens to me, but it is different. >>> Actually this is what I was expecting would happen in the issue >>> described originally... that when I check changes (and it was already >>> committed) that it would just disappear as false positive... but nope, it >>> still claimed it's new and only actual git history have shown that it was a >>> false positive. >>> >>> Anyway, it doesn't seem there will be resolution for this until it can >>> be reproduced consistently... so I'll try be more observant. :) >>> >> >> Well, it may be an issue in the way diffs are built, so it would be good >> to see it confirmed. Thanks for volunteering, by the way :) >> > > As I'm the only one experiencing this apparently, I don't have a choice > but to volunteer. :) >

July 24, 2015

Re: [Pharo-users] gitfiletree metadata

by Peter UhnÃ¡k

> > >> Sorry for the lack of support on windows. You'll have to wait for >>> libcgit. >> >> >> Is there an estimated timeline when this will be? (weeks, months, years, >> ...?) >> > > I don't know; the lib has been included in the Pharo vm for a long time, > and I remember talks about having it for Pharo5. Stef, what is the Pharo > consortium plans on that? > CCed Stef :) ^^ > > >> Yes, this also happens to me, but it is different. >> Actually this is what I was expecting would happen in the issue described >> originally... that when I check changes (and it was already committed) that >> it would just disappear as false positive... but nope, it still claimed >> it's new and only actual git history have shown that it was a false >> positive. >> >> Anyway, it doesn't seem there will be resolution for this until it can be >> reproduced consistently... so I'll try be more observant. :) >> > > Well, it may be an issue in the way diffs are built, so it would be good > to see it confirmed. Thanks for volunteering, by the way :) > As I'm the only one experiencing this apparently, I don't have a choice but to volunteer. :)

July 24, 2015

Re: [Pharo-users] gitfiletree metadata

by Thierry Goubier

Hi Peter, 2015-07-24 10:47 GMT+02:00 Peter UhnÃ¡k <i.uhnak(a)gmail.com>: > Check which versions are bold when you open the package. Because when I >> use gitfiletree it usually shows me that the latest few versions are not >> loaded (they are in bold) but I am anyway on the latest one. > > > As I've said, it shows me that I am on the latest version. > > I'm looking at DynaCASE-PeterUhnak.147, the one with the interesting history... > Maybe this happens to you because you load it from github and only after > you add gitfiletree? (At least from what I remember what you've shown me > (and you are using GitFileTree from MetaRepo30?)) > > Understood. So this means all commits you've done (the -bliznjan) were >> done with filetree? >> > > He suffered through with git on Windows for some time, so maybe the later > half? > Again, sorry for that poor Windows support... GitFileTree is an excellent bench for the robustness of the external process support, and I only barely touch the underlying plugin on Unix-like platform. I'll write for professional reasons another possibility for support on Windows, but it won't be available. > > Sorry for the lack of support on windows. You'll have to wait for >> libcgit. > > > Is there an estimated timeline when this will be? (weeks, months, years, > ...?) > I don't know; the lib has been included in the Pharo vm for a long time, and I remember talks about having it for Pharo5. Stef, what is the Pharo consortium plans on that? > Yes, this also happens to me, but it is different. > Actually this is what I was expecting would happen in the issue described > originally... that when I check changes (and it was already committed) that > it would just disappear as false positive... but nope, it still claimed > it's new and only actual git history have shown that it was a false > positive. > > Anyway, it doesn't seem there will be resolution for this until it can be > reproduced consistently... so I'll try be more observant. :) > Well, it may be an issue in the way diffs are built, so it would be good to see it confirmed. Thanks for volunteering, by the way :) Thierry

July 24, 2015

Re: [Pharo-users] Semantics of #resignalAs:

by Norbert Hartl

Joachim, thanks for looking into it. The text is the one from ANSI. I'm also puzzled about the last sentence "Control does not return from this message to the currently active exception action." I think it means after the resignalling has been done it does not return after the invocation of the #resignalAs: call. As the original signalling context is restored and only the exception is exchanged it could indeed mean that it only works if the resignalled exception does not share the same class hierarchy as the excpetion the original #on:do: catch. If the resignalled exception is the same class or a subclass of the original one it would loop. In this case I need to fix Voyage :) Norbert > Am 24.07.2015 um 08:38 schrieb jtuchel(a)objektfabrik.de: > > Hi again, > > okay, trying in VAST didn't shed much light, because resignalAs: is implemented as > > ^self error: 'Not yet implemented'. > > ;-))) > > But here is an excerpt from the method's comment: > > Synopsis: > Signal an alternative exception in place of the receiver. > > Definition: <signaledException> > The active exception action is aborted and the exception environment and the evaluation context > are restored to the same states that were in effect when the receiver was originally signaled. > > Restoring the evaluation context may result in the execution of #ensure: or #ifCurtailed: > termination blocks. > > After the restoration, signal the replacementException and execute the exception action as > determined by the restored exception environment. > > This message causes the replacementException to be treated as if it had been originally > signaled instead of the receiver. > > If the replacementException is resumable and its exception action resumes, control will > ultimately return from the message that signaled the original exception. > > Control does not return from this message to the currently active exception action. > > > If I understand correctly, the [1/0] should only be run once and never again, and you should get a NotFound error. > > ....But: > > In VisualWorks, I also get a Halt instead of a MustBeBoolean (I had to Replace NotFound with something available in VW, so I used MustBeBoolen). > > > So I am puzzled... Hoping for someone to shed some light on this... > > Joachim > > > > Am 24.07.15 um 08:25 schrieb jtuchel(a)objektfabrik.de: >> Definitely looks wrong to me... The catching block shouldn't catch exceptions in itself, and a resignal should never run the block again... >> >> I'll try this in VAST. >> >> >> Am 23.07.15 um 20:05 schrieb Norbert Hartl: >>> You get a debugger at the position if the halt in the code. Meaning the exception block run more than once. And it would run forever. >>> >>> Norbert >>> >>> >>> >>>> Am 23.07.2015 um 18:46 schrieb Joachim Tuchel <jtuchel(a)objektfabrik.de>: >>>> >>>> Norbert, >>>> >>>> Sorry if this is a stupid question: what does the debugger say? >>>> >>>> I mean, assuming NotFound is an Exception, I'd expect a debugger showing a NotFound Error... >>>> >>>> Joachim >>>> >>>> Am 23.07.2015 18:34 schrieb Norbert Hartl <norbert(a)hartl.name>: >>>>> >>>>>> Am 23.07.2015 um 17:54 schrieb Joachim Tuchel <jtuchel(a)objektfabrik.de>: >>>>>> >>>>>> Norbert, >>>>>> >>>>>> I'd say you get a NotFound Exception. >>>>> In pharo you get a debugger. Meaning this piece of code is actively an endless loop. >>>>> >>>>> Norbert >>>>> >>>>>> Joachim >>>>>> >>>>>> >>>>>> >>>>>>> Am 23.07.2015 um 16:20 schrieb Norbert Hartl <norbert(a)hartl.name>: >>>>>>> >>>>>>> What are the semantics of Exception>>#resignalAs: regarding active exception handler? Isn't the active exception handler excluded from being treated again? Taking the example >>>>>>> >>>>>>> | counter | >>>>>>> counter := 0. >>>>>>> [ 1/0 ] >>>>>>> on: Error >>>>>>> do: [ :e | >>>>>>> counter := counter + 1. >>>>>>> counter > 1 ifTrue: [ self halt ]. >>>>>>> e resignalAs: NotFound new ]. >>>>>>> >>>>>>> should it just run and end? Or should the debugger pop up? >>>>>>> >>>>>>> thanks, >>>>>>> >>>>>>> Norbert >>>>> >>>>> >> >> > > > -- > ----------------------------------------------------------------------- > Objektfabrik Joachim Tuchel mailto:jtuchel@objektfabrik.de > Fliederweg 1 http://www.objektfabrik.de > D-71640 Ludwigsburg http://joachimtuchel.wordpress.com > Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1 > >

July 24, 2015

Re: [Pharo-users] gitfiletree metadata

by Peter UhnÃ¡k

> > Check which versions are bold when you open the package. Because when I > use gitfiletree it usually shows me that the latest few versions are not > loaded (they are in bold) but I am anyway on the latest one. As I've said, it shows me that I am on the latest version. Maybe this happens to you because you load it from github and only after you add gitfiletree? (At least from what I remember what you've shown me (and you are using GitFileTree from MetaRepo30?)) Understood. So this means all commits you've done (the -bliznjan) were done > with filetree? > He suffered through with git on Windows for some time, so maybe the later half? Sorry for the lack of support on windows. You'll have to wait for libcgit. Is there an estimated timeline when this will be? (weeks, months, years, ...?) > Barely similar behavior to ghost changes is that when I finish my loading > script, DynaCASE package is marked as changed, but when I try to get diff > (changes) with (git)filetree, it says nothing has changed and this > "changed" > mark disappears. When you look at the way the changed flag is set in Monticello, it is > obvious false positives are the order of the day. So nothing really > significant there ;) Yes, this also happens to me, but it is different. Actually this is what I was expecting would happen in the issue described originally... that when I check changes (and it was already committed) that it would just disappear as false positive... but nope, it still claimed it's new and only actual git history have shown that it was a false positive. Anyway, it doesn't seem there will be resolution for this until it can be reproduced consistently... so I'll try be more observant. :) Thanks, Peter

July 24, 2015

Re: [Pharo-users] gitfiletree metadata

by Thierry Goubier

2015-07-24 9:21 GMT+02:00 Jan BlizniÄenko <bliznjan(a)fit.cvut.cz>: > Yes it is. > > I personally never ran into such ghost changes when I was using > gitfiletree. > This might be also useful information: We are two contributors and Peter > uses GitFileTree but I use FileTree because GitFileTree crashes all the > time > on Win 7 ( > http://forum.world.st/Gitfiletree-unstable-on-Windows-td4816354.html ). > Understood. So this means all commits you've done (the -bliznjan) were done with filetree? Sorry for the lack of support on windows. You'll have to wait for libcgit. > > Barely similar behavior to ghost changes is that when I finish my loading > script, DynaCASE package is marked as changed, but when I try to get diff > (changes) with (git)filetree, it says nothing has changed and this > "changed" > mark disappears. > When you look at the way the changed flag is set in Monticello, it is obvious false positives are the order of the day. So nothing really significant there ;) Thierry > > Jan > > > Thierry Goubier wrote > > Peter, is this the dynacase at https://github.com/dynacase/dynacase ? > > > > Thierry > > > > > > -- > View this message in context: > http://forum.world.st/gitfiletree-metadata-tp4838970p4839019.html > Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com. > >

July 24, 2015

Re: [Pharo-users] gitfiletree metadata

by Jan BlizniÄenko

Yes it is. I personally never ran into such ghost changes when I was using gitfiletree. This might be also useful information: We are two contributors and Peter uses GitFileTree but I use FileTree because GitFileTree crashes all the time on Win 7 ( http://forum.world.st/Gitfiletree-unstable-on-Windows-td4816354.html ). Barely similar behavior to ghost changes is that when I finish my loading script, DynaCASE package is marked as changed, but when I try to get diff (changes) with (git)filetree, it says nothing has changed and this "changed" mark disappears. Jan Thierry Goubier wrote > Peter, is this the dynacase at https://github.com/dynacase/dynacase ? > > Thierry -- View this message in context: http://forum.world.st/gitfiletree-metadata-tp4838970p4839019.html Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

July 24, 2015