August 2014 - Pharo-users - lists.pharo.org

Re: [Pharo-users] Code formatting - preserving newlines and comments

by Peter UhnÃ¡k

actually it should be: ------------- formatStatementCommentsFor: aStatementNode originalSource isNil ifTrue: [ ^ self ]. FormatCommentWithStatements ifFalse: [ ^ self ]. aStatementNode statementComments do: [ :each | | count | count := self newLinesBeforeStartingAt: each first. (count) > 0 ifTrue: [ self newLines: count ] ifFalse: [ codeStream tab ]. codeStream nextPutAll: (originalSource copyFrom: each first to: each last) ] -------------- to allow having comments on top of sections of code. On Wed, Aug 20, 2014 at 10:20 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > Ah! > > RBConfigurableFormatter class>>settingsOn: is missing one setting > ---- > (aBuilder setting: #retainBlankLinesBetweenStatements) > label: 'Retain blank lines between statements'. > ---- > > > As for the comments, I looked at > RBConfigurableFormatter>>formatStatementCommentsFor: > one idea might be to look at the space between end of the statement and > beginning of the comment and if there is newline present then preserve it. > > something like > -------------------------- > formatStatementCommentsFor: aStatementNode > originalSource isNil > ifTrue: [ ^ self ]. > FormatCommentWithStatements > ifFalse: [ ^ self ]. > aStatementNode statementComments > do: [ :each | > (self newLinesBeforeStartingAt: each first) > 0 > ifTrue: [ self newLine ] > ifFalse: [ codeStream tab ]. > > codeStream nextPutAll: (originalSource copyFrom: each first to: each last) > ] > --------------------------- > > There should be also an accompanying setting > #retainBlankLineBeforeComments. > > Peter > > > On Wed, Aug 20, 2014 at 7:45 PM, stepharo <stepharo(a)free.fr> wrote: > >> Hi peter >> >> >> Is it possible to configure formatter to preserve empty lines and line >> comments? >> >> >> I do not know :) >> >> >> >> e.g. >> -------------- >> myMethod >> someCode. >> < empty line that I would like to preserve > >> moreCode. >> --------------- >> >> But I think that should be customizable. >> >> >> >> the formatter also automatically puts comments on the end of the >> previous statement. >> e.g. >> ------ >> someCode. >> "a comment" >> moreCode. >> >> >> If I recall, the problem is that comments are not a node but an attribute >> of a node. >> We should try to fix that. It is not clear where you always want to put >> them. >> >> >> ---- >> ends up as >> ---- >> someCode. "a comment" >> moreCode. >> ----- >> >> Both those behaviors seems odd to me. >> >> I've seen empty newlines and line comments in Pharo code... so either I >> missed some setting or people just don't use the formatter? >> >> I use the formatter and I would like to use it much more systemaitcally. >> >> >> Thanks, >> Peter >> >> >> >

Aug. 20, 2014

Re: [Pharo-users] Code formatting - preserving newlines and comments

by Peter UhnÃ¡k

Ah! RBConfigurableFormatter class>>settingsOn: is missing one setting ---- (aBuilder setting: #retainBlankLinesBetweenStatements) label: 'Retain blank lines between statements'. ---- As for the comments, I looked at RBConfigurableFormatter>>formatStatementCommentsFor: one idea might be to look at the space between end of the statement and beginning of the comment and if there is newline present then preserve it. something like -------------------------- formatStatementCommentsFor: aStatementNode originalSource isNil ifTrue: [ ^ self ]. FormatCommentWithStatements ifFalse: [ ^ self ]. aStatementNode statementComments do: [ :each | (self newLinesBeforeStartingAt: each first) > 0 ifTrue: [ self newLine ] ifFalse: [ codeStream tab ]. codeStream nextPutAll: (originalSource copyFrom: each first to: each last) ] --------------------------- There should be also an accompanying setting #retainBlankLineBeforeComments. Peter On Wed, Aug 20, 2014 at 7:45 PM, stepharo <stepharo(a)free.fr> wrote: > Hi peter > > > Is it possible to configure formatter to preserve empty lines and line > comments? > > > I do not know :) > > > > e.g. > -------------- > myMethod > someCode. > < empty line that I would like to preserve > > moreCode. > --------------- > > But I think that should be customizable. > > > > the formatter also automatically puts comments on the end of the > previous statement. > e.g. > ------ > someCode. > "a comment" > moreCode. > > > If I recall, the problem is that comments are not a node but an attribute > of a node. > We should try to fix that. It is not clear where you always want to put > them. > > > ---- > ends up as > ---- > someCode. "a comment" > moreCode. > ----- > > Both those behaviors seems odd to me. > > I've seen empty newlines and line comments in Pharo code... so either I > missed some setting or people just don't use the formatter? > > I use the formatter and I would like to use it much more systemaitcally. > > > Thanks, > Peter > > >

Aug. 20, 2014

Re: [Pharo-users] Code formatting - preserving newlines and comments

by stepharo

Hi peter > Is it possible to configure formatter to preserve empty lines and line > comments? I do not know :) > > e.g. > -------------- > myMethod > someCode. > < empty line that I would like to preserve > > moreCode. > --------------- But I think that should be customizable. > the formatter also automatically puts comments on the end of the > previous statement. > e.g. > ------ > someCode. > "a comment" > moreCode. If I recall, the problem is that comments are not a node but an attribute of a node. We should try to fix that. It is not clear where you always want to put them. > ---- > ends up as > ---- > someCode. "a comment" > moreCode. > ----- > > Both those behaviors seems odd to me. > > I've seen empty newlines and line comments in Pharo code... so either > I missed some setting or people just don't use the formatter? I use the formatter and I would like to use it much more systemaitcally. > > Thanks, > Peter

Aug. 20, 2014

Code formatting - preserving newlines and comments

by Peter UhnÃ¡k

Is it possible to configure formatter to preserve empty lines and line comments? e.g. -------------- myMethod someCode. < empty line that I would like to preserve > moreCode. --------------- the formatter also automatically puts comments on the end of the previous statement. e.g. ------ someCode. "a comment" moreCode. ---- ends up as ---- someCode. "a comment" moreCode. ----- Both those behaviors seems odd to me. I've seen empty newlines and line comments in Pharo code... so either I missed some setting or people just don't use the formatter? Thanks, Peter

Aug. 20, 2014

Re: [Pharo-users] Importing a city map in dxf/svg format to Roassal

by Offray Vladimir Luna CÃ¡rdenas

Hi, I have found another source of cities geo-info here, taken from OSM and under an open license: https://mapzen.com/metro-extracts/ I don't know if formats there (OSM-PBF, OSM-XML OSM-PGSQL SHP, OSM2PGSQL GEOJSON, IMPOSM SHP IMPOSM GEOJSON) are better candidates to importing maps of cities to Roassal, but same question applies. Cheers, Offray On 08/20/2014 09:40 AM, Offray Vladimir Luna CÃ¡rdenas wrote: > Hi, > > There is a project which collects maps of cities under a open licensed > (AFAIK derived from OpenStreetMap) and release them as dxf files. As a > first thought I believe is possible to export dxf to a svg or other open > format and try to open it on Roassal, but I wonder is there is a better > way. If fact the author says that this svg to dxf was the path he > followed to get his layers working. > > This are some project links: > > [1] http://bdon.org/2014/08/03/osm-cad-experiment/ > [2] http://bdon.org/cad/ > > Cheers, > > Offray > >

Aug. 20, 2014

Importing a city map in dxf/svg format to Roassal

by Offray Vladimir Luna CÃ¡rdenas

Hi, There is a project which collects maps of cities under a open licensed (AFAIK derived from OpenStreetMap) and release them as dxf files. As a first thought I believe is possible to export dxf to a svg or other open format and try to open it on Roassal, but I wonder is there is a better way. If fact the author says that this svg to dxf was the path he followed to get his layers working. This are some project links: [1] http://bdon.org/2014/08/03/osm-cad-experiment/ [2] http://bdon.org/cad/ Cheers, Offray

Aug. 20, 2014

Re: [Pharo-users] Does RoelTyper works?

by Juraj Kubelka

Thank you Camille! Juraj El 20-08-2014, a las 5:43, Camille Teruel <camille.teruel(a)gmail.com> escribiÃ³: > Hello Juraj, > > RoelTyper guesses types from message sends mainly. > In your example, there is no message sent to the iv 'color' so it has not enough information to guess it's type. > The rule of thumb is the more code you have the more precise the type inference is. > RoelTyper can also guess types from assignments but it's limited. > It can guess the type of the right-hand expression of an assignment: > - if it's a global or a literal the type is known statically. > - if it's a message send to a class and if the corresponding method is classified under 'instance-creation' it assumes that the type is the class. In your example it doesn't do that assumption since #black is categorized under 'defaults'. > There is maybe some other cases that I don't remember. > > Cheers, > Camille > > On 19 aoÃ»t 2014, at 21:42, Juraj Kubelka <juraj.kubelka(a)gmail.com> wrote: > >> Hi, >> >> I play with RoelTyper, but it does not work as I expect. I have a simple class: >> >> -=-=-=- >> Object subclass: #AMock >> instanceVariableNames: 'color' >> classVariableNames: '' >> poolDictionaries: '' >> category: 'JK-Mocksâ >> -=-=-=- >> >> with method: >> >> -=-=-=- >> initialize >> super initialize. >> color := Color black. >> -=-=-=- >> >> When the following command is evaluated: (TypeCollector typeInstvar: #color ofClass: AMock) types >> RoelTyper returns "an OrderedCollection(Object)â >> >> I expected Color. >> >> Do I miss something? >> Thanks, >> Juraj > >

Aug. 20, 2014

Re: [Pharo-users] Does RoelTyper works?

by Camille Teruel

Hello Juraj, RoelTyper guesses types from message sends mainly. In your example, there is no message sent to the iv 'color' so it has not enough information to guess it's type. The rule of thumb is the more code you have the more precise the type inference is. RoelTyper can also guess types from assignments but it's limited. It can guess the type of the right-hand expression of an assignment: - if it's a global or a literal the type is known statically. - if it's a message send to a class and if the corresponding method is classified under 'instance-creation' it assumes that the type is the class. In your example it doesn't do that assumption since #black is categorized under 'defaults'. There is maybe some other cases that I don't remember. Cheers, Camille On 19 aoÃ»t 2014, at 21:42, Juraj Kubelka <juraj.kubelka(a)gmail.com> wrote: > Hi, > > I play with RoelTyper, but it does not work as I expect. I have a simple class: > > -=-=-=- > Object subclass: #AMock > instanceVariableNames: 'color' > classVariableNames: '' > poolDictionaries: '' > category: 'JK-Mocksâ > -=-=-=- > > with method: > > -=-=-=- > initialize > super initialize. > color := Color black. > -=-=-=- > > When the following command is evaluated: (TypeCollector typeInstvar: #color ofClass: AMock) types > RoelTyper returns "an OrderedCollection(Object)â > > I expected Color. > > Do I miss something? > Thanks, > Juraj

Aug. 20, 2014

Re: [Pharo-users] Does RoelTyper works?

by Stephan Eggermont

Aren't you supposed to have an instance of AMock around? Stephan

Aug. 20, 2014

Re: [Pharo-users] Persistence on Moose browsers, showing always a selection in trees and making tree labels editable.

by Tudor Girba

Hi, On Wed, Aug 20, 2014 at 5:38 AM, Offray Vladimir Luna CÃ¡rdenas < offray(a)riseup.net> wrote: > Hi, > > With the valuable help of the community and the GLMBasicExamples I have > been able to build basic outlining interface and functionality. Here is a > screenshot: > > http://www.enlightenment.org/ss/e-53f4243a4dc127.49773492.jpg > > There are some issues: > > 1. Now I would like to make the nodes in the tree persistent in the sense > that if I wrote something in the node body (left upper part of the browser) > and I select another node, when I visit the previous node, the text in the > body still is there. How can I do this? > I believe you refer to some sort of automatic saving. This is not possible at the moment, but it would certainly cool to get added :( > 2. I would like to make the current node always selected by this blue > highlighting. With some operations like moving nodes to the left or to the > right, the current node gets out of focus, despite of the operations being > done over it. There is any way to say Moose browsers where to put the > selections, besides of explicit selection with the mouse. > You can just set the #selection or the #selectionPath ports. > 3. Some time ago I asked about how to make tree labels (headers), at the > left of the browsers editable. There is any way to make this? > No :(. But, again, it would be cool to get this support. Cheers, Doru > Thanks a lot, > > Offray > > -- www.tudorgirba.com "Every thing has its own flow"

Aug. 20, 2014