April 2011 - Pharo-users - lists.pharo.org

Re: [Pharo-users] Code Critics for unloaded projects

by Lukas Renggli

>> It is still one of the todo items for the refactoring engine to make >> Code Critics completely runnable on the refactoring code model. As the >> Pharo code model is diverging more and more from the refactoring code >> model this is more likely to happen anytime soon. > > Lukas what do you say that. Fixing the API of the RB code model should be simple to do. > Especially since the code model does not have to run on all the smalltalk dialect so we are > free to fix it. That is not entirely true, Slime and Magritte Critics rules (at least used to) run on other dialects too. Also there is external code that depends on it, such as Helvetia, Opal, ST2JS, SmaCC, ... The reason for moving Code Critics to use the refactoring model is that there will be only a single interaction point with the base system (Pharo). This will make maintenance simpler as only a single place needs to be updated (BrowserEnvironment for read-reflection, RefactoryChange for write-reflection). I don't know why Code Critics does not use the refactoring code model? It probably has historical reasons: Maybe it was a separate codebase at some point? Maybe it was done for performance reasons? > In addition the RB code model has always been a wrapper on top of other. No, the refactoring code model is not a wrapper: it doesn't necessarily wrap something. Lukas -- Lukas Renggli www.lukas-renggli.ch

April 4, 2011

Re: [Pharo-users] Writing to the std output

by David T. Lewis

On Mon, Apr 04, 2011 at 02:46:01PM +0200, Mariano Martinez Peck wrote: > On Mon, Apr 4, 2011 at 2:02 PM, Igor Stasenko <siguctua(a)gmail.com> wrote: > > > On 4 April 2011 13:55, Benjamin <benjamin.vanryseghem.pharo(a)gmail.com> > > wrote: > > > You have to add a new primitive I think ... > > > > > > > there was a discussion about adding it to Cog VMs.. but i don't know > > details. > > It could be there out of the box... just need to find it :) > > > > > I don't know why I remember some Cog extensions in StandardFileStream or > something like that that could directly write to the standard output...but > maybe I am just dreaming. > > Anyway wouldn't OSProcess do the job? Yes of course. Specifically for debugging support, see the #trace, #trace: and #debug: methods. Handy if you are trying to debug something that might drop you into an emergency evaluator. It also is running from the VM, so it avoids timing confusion related to Smalltalk process scheduling and flushing the ouput stream. Dave

April 4, 2011

Re: [Pharo-users] Code Critics for unloaded projects

by Mariano Martinez Peck

Sorry, I am useless then. I just cc'ed Dave to see if he can help. Cheers mariano On Mon, Apr 4, 2011 at 5:02 PM, AxiNat <tibabenfortlapalanca(a)gmail.com>wrote: > Hi Mariano, thanks, but I had already checked that discussion. The bundle > that Esteban provided didn't work, quoting Stef: > > > Thanks a lot > I copied in the resources folder of 5.7.4 > It crashes. > > > Also, the thread was about it not working on MacOS (it made sense, it's an > X11 control plugin), but I'm on Debian Linux. The only XDisplayControlPlugin > I can find around is provided by the squeaksource pagage XDCP, but loading > it fixes nothing either... > > > 2011/4/4 Mariano Martinez Peck <marianopeck(a)gmail.com> > >> >> http://forum.world.st/template/NamlServlet.jtp?macro=search_page&node=12948… >> >> >> On Mon, Apr 4, 2011 at 4:34 PM, AxiNat <tibabenfortlapalanca(a)gmail.com>wrote: >> >>> Hi again, >>> >>> when trying Mariano's idea I get the following error: >>> >>> *forkSqueak requires XDisplayControlPlugin* >>> * >>> * >>> *Select Proceed to continue, or close this window to cancel the >>> operation.* >>> >>> >>> Do I need to recompile the VM to add support for this plugin? If so, are >>> there any guidelines around on how to do it? >>> >>> Thanks! >>> >>> Bernat. >>> >>> 2011/4/4 AxiNat <tibabenfortlapalanca(a)gmail.com> >>> >>>> Lukas, if that happened anytime soon it would make my life much easier >>>> hehe >>>> >>>> Is there a way I could help to give it a boost? >>>> >>>> Mariano, the reason I cannot load the package is that it may contain >>>> (either intentionally or not) harmful code. An .st file can contain >>>> arbitrary code that is going to be executed at load time, so it'd be really >>>> easy to hack the image: "Object compile: 'new'!", for instance ;) >>>> >>>> The solution you propose looks interesting, but I'm not sure I've >>>> completely understood it. Do you mean to run a new image, send it the >>>> project file to be filed in, have it run the critics on the loaded package, >>>> and get the output back to the original image? If so, that's a solution I've >>>> been thinking of, but it would spend too many resources. Even though I could >>>> always use a very light image, if only 5 users were to be working on the app >>>> at the same time I'm afraid the system would begin to suffer :( >>>> >>>> On a second thought, is there some smaller, simpler implementation of >>>> the SmallLint package? I wouldn't need to run all the tests, just a couple >>>> of them: Bugs, Intention Revealing, Miscelaneous and Unnecessary Code, and >>>> actually not even all the tests in these categories. >>>> >>>> Thanks a lot, I'm all ears :) >>>> >>>> Bernat. >>>> >>>> 2011/4/4 Mariano Martinez Peck <marianopeck(a)gmail.com> >>>> >>>>> Is not enough loading the classes but not showing them in the browser ? >>>>> or maybe not putting them in Smalltalk ? >>>>> >>>>> can you do kind of a fork (using OSProcess) of the proccess running >>>>> image which receives a .st file and in the new forked image you pass the .st >>>>> in startup, do a file in and then run code-critics? >>>>> >>>>> I am curious why you cannot load them hehehehhe >>>>> >>>>> >>>>> On Mon, Apr 4, 2011 at 11:41 AM, AxiNat < >>>>> tibabenfortlapalanca(a)gmail.com> wrote: >>>>> >>>>>> Hi list, >>>>>> >>>>>> I have a pretty special need, which is to be able to run code critics >>>>>> on projects that have not yet been loaded into the image. For example, I >>>>>> need to browse an st file -or a squeaksource project- and before loading it >>>>>> I want to run critics on it, would this be possible somehow? >>>>>> >>>>>> If it looks like something noone would need to do, I understand. It's >>>>>> just that the project I'm working on is pretty particular... I've been >>>>>> exploring other possibilities but I'm afraid this is one of the few left for >>>>>> me to think of :( >>>>>> >>>>>> Thanks a lot in advance! >>>>>> >>>>>> Bernat Romagosa. >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Mariano >>>>> http://marianopeck.wordpress.com >>>>> >>>>> >>>> >>> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com >> >> > -- Mariano http://marianopeck.wordpress.com

April 4, 2011

Re: [Pharo-users] Code Critics for unloaded projects

by StÃ©phane Ducasse

> Being able to run Code Critics on not loaded code would be a very nice > thing, unfortunately it is not supported right now. We wanted to do > the same in SqueakSource when we originally wrote the software, but we > had to realize that a lot of the rules unnecessarily depend on the > fact that the code is installed. > > It is still one of the todo items for the refactoring engine to make > Code Critics completely runnable on the refactoring code model. As the > Pharo code model is diverging more and more from the refactoring code > model this is more likely to happen anytime soon. Lukas what do you say that. Fixing the API of the RB code model should be simple to do. Especially since the code model does not have to run on all the smalltalk dialect so we are free to fix it. In addition the RB code model has always been a wrapper on top of other. We are working on Ring and the point is to use it to manage the source code and off-line source code model and the one of RB too -- may be you do not believe it but if we do not try we will not move and we should have an infrastructure that enable us to move. Now finally I do not see why changing is a problem, especially since the runtime system does not have to be the same everything. Stef

April 4, 2011

Re: [Pharo-users] Last pending things for Pharo 1.2

by Marcus Denker

On Apr 4, 2011, at 5:05 PM, Mariano Martinez Peck wrote: > > > On Sat, Mar 12, 2011 at 8:19 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > So....here is the list of things I guess are pending: > In general, for all pending things adding entries in the bug tracker is the only way ti make sure they are not forgotten. > 1) "Release" all configurations included in Pharo (this is, ConfigurationOfPharo and all it dependencies). I mean, we should NOT use or depend on #development versions. > > so...can someone check this is done? GUillermo and me did it once...but it seems a lot of stuff was updated once again I just gave up and took the image yesterday. Like you did for 1.1: Just build it once, don't care that it is repeatable. > > 2) Update the one click image to use latest cog images and "pharo prepared vms". There are some issues regarding this... > > Marcus, which is the status of this one ? I updated the one-click image with the last cog VM. For the one-click, it is identical to 1.1 with the only change that I put the windows VM I got from Torsten. > > 3) Write down all the things/summary done in Pharo 1.2 > > consider as done in nobody else comes with something better, > > 5) Update SystemVersion current -->> Pharo1.2rc2 of 27 January 2011 update 12340 > > > SystemVersion current ->> Pharo1.2.1 of 2 April 2011 update 12345 > > so..it is ok, isn't it ? can we forget this item ? > > 6) Condense sources? condense changes? #cleanUpForRelease > > Marcus, is that necessary ? > > DEVImageCreator >> cleanUps > > ScriptLoader new cleanUpForRelease. > "In Pharo 1.1 condenseChanges is VERY slow because of the new method trailers. So condensingChanges each time even when it is not needed is not a good idea anymore. So in case a condenseChanges is needed it should be done explicitly. > Smalltalk condenseChanges." > Smalltalk garbageCollect. > > I did that and I put that comment. Now that they are faster and that we have Hudson, should I put back the Smalltalk condenseChanges ? is there anything else needed? do we need a condenseSources ? > CondenseChange and CondenseSource is broken right now. Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

April 4, 2011

Re: [Pharo-users] Last pending things for Pharo 1.2

by Mariano Martinez Peck

On Sat, Mar 12, 2011 at 8:19 PM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > So....here is the list of things I guess are pending: > > 1) "Release" all configurations included in Pharo (this is, > ConfigurationOfPharo and all it dependencies). I mean, we should NOT use or > depend on #development versions. > so...can someone check this is done? GUillermo and me did it once...but it seems a lot of stuff was updated once again > 2) Update the one click image to use latest cog images and "pharo prepared > vms". There are some issues regarding this... > Marcus, which is the status of this one ? > 3) Write down all the things/summary done in Pharo 1.2 > consider as done in nobody else comes with something better, > 5) Update SystemVersion current -->> Pharo1.2rc2 of 27 January 2011 update > 12340 > SystemVersion current ->> Pharo1.2.1 of 2 April 2011 update 12345 so..it is ok, isn't it ? can we forget this item ? > 6) Condense sources? condense changes? #cleanUpForRelease > > Marcus, is that necessary ? DEVImageCreator >> cleanUps ScriptLoader new cleanUpForRelease. "In Pharo 1.1 condenseChanges is VERY slow because of the new method trailers. So condensingChanges each time even when it is not needed is not a good idea anymore. So in case a condenseChanges is needed it should be done explicitly. Smalltalk condenseChanges." Smalltalk garbageCollect. I did that and I put that comment. Now that they are faster and that we have Hudson, should I put back the Smalltalk condenseChanges ? is there anything else needed? do we need a condenseSources ? -- Mariano http://marianopeck.wordpress.com

April 4, 2011

Re: [Pharo-users] Code Critics for unloaded projects

by AxiNat

Hi Mariano, thanks, but I had already checked that discussion. The bundle that Esteban provided didn't work, quoting Stef: Thanks a lot I copied in the resources folder of 5.7.4 It crashes. Also, the thread was about it not working on MacOS (it made sense, it's an X11 control plugin), but I'm on Debian Linux. The only XDisplayControlPlugin I can find around is provided by the squeaksource pagage XDCP, but loading it fixes nothing either... 2011/4/4 Mariano Martinez Peck <marianopeck(a)gmail.com> > > http://forum.world.st/template/NamlServlet.jtp?macro=search_page&node=12948… > > > On Mon, Apr 4, 2011 at 4:34 PM, AxiNat <tibabenfortlapalanca(a)gmail.com>wrote: > >> Hi again, >> >> when trying Mariano's idea I get the following error: >> >> *forkSqueak requires XDisplayControlPlugin* >> * >> * >> *Select Proceed to continue, or close this window to cancel the >> operation.* >> >> >> Do I need to recompile the VM to add support for this plugin? If so, are >> there any guidelines around on how to do it? >> >> Thanks! >> >> Bernat. >> >> 2011/4/4 AxiNat <tibabenfortlapalanca(a)gmail.com> >> >>> Lukas, if that happened anytime soon it would make my life much easier >>> hehe >>> >>> Is there a way I could help to give it a boost? >>> >>> Mariano, the reason I cannot load the package is that it may contain >>> (either intentionally or not) harmful code. An .st file can contain >>> arbitrary code that is going to be executed at load time, so it'd be really >>> easy to hack the image: "Object compile: 'new'!", for instance ;) >>> >>> The solution you propose looks interesting, but I'm not sure I've >>> completely understood it. Do you mean to run a new image, send it the >>> project file to be filed in, have it run the critics on the loaded package, >>> and get the output back to the original image? If so, that's a solution I've >>> been thinking of, but it would spend too many resources. Even though I could >>> always use a very light image, if only 5 users were to be working on the app >>> at the same time I'm afraid the system would begin to suffer :( >>> >>> On a second thought, is there some smaller, simpler implementation of the >>> SmallLint package? I wouldn't need to run all the tests, just a couple of >>> them: Bugs, Intention Revealing, Miscelaneous and Unnecessary Code, and >>> actually not even all the tests in these categories. >>> >>> Thanks a lot, I'm all ears :) >>> >>> Bernat. >>> >>> 2011/4/4 Mariano Martinez Peck <marianopeck(a)gmail.com> >>> >>>> Is not enough loading the classes but not showing them in the browser ? >>>> or maybe not putting them in Smalltalk ? >>>> >>>> can you do kind of a fork (using OSProcess) of the proccess running >>>> image which receives a .st file and in the new forked image you pass the .st >>>> in startup, do a file in and then run code-critics? >>>> >>>> I am curious why you cannot load them hehehehhe >>>> >>>> >>>> On Mon, Apr 4, 2011 at 11:41 AM, AxiNat <tibabenfortlapalanca(a)gmail.com >>>> > wrote: >>>> >>>>> Hi list, >>>>> >>>>> I have a pretty special need, which is to be able to run code critics >>>>> on projects that have not yet been loaded into the image. For example, I >>>>> need to browse an st file -or a squeaksource project- and before loading it >>>>> I want to run critics on it, would this be possible somehow? >>>>> >>>>> If it looks like something noone would need to do, I understand. It's >>>>> just that the project I'm working on is pretty particular... I've been >>>>> exploring other possibilities but I'm afraid this is one of the few left for >>>>> me to think of :( >>>>> >>>>> Thanks a lot in advance! >>>>> >>>>> Bernat Romagosa. >>>>> >>>> >>>> >>>> >>>> -- >>>> Mariano >>>> http://marianopeck.wordpress.com >>>> >>>> >>> >> > > > -- > Mariano > http://marianopeck.wordpress.com > >

April 4, 2011

Re: [Pharo-users] Do we want this for Pharo 1.2 and futures?

by Mariano Martinez Peck

Discussion finished. Marcus, can we add in the PharoDev images a installScript.st with the code that was executed to generate the image? yes, the ConfigurationOfPharo load.... On Sun, Mar 13, 2011 at 6:52 PM, Miguel CobÃ¡ <miguel.coba(a)gmail.com> wrote: > installScript definitely yes. > > changelog is useful if it is accurate and maintained else better avoid > it. Packages I never found a reason for it to be in the zip. not very > useful for newbies because they don't now what a package is based only > in the name and for a experimented user, they can find the packages > directly in the image. > > So, I think that they won't be missing. > > Cheers > > El sÃ¡b, 12-03-2011 a las 20:13 +0100, Mariano Martinez Peck escribiÃ³: > > In Pharo 1.0 and 1.1 I used to include certain files in addition to > > the .image and .changes. These files were: changelog.txt, > > installScript.st and packages.txt > > So...what do you think? are they (still) useful ? if true, then we > > should add it to hudson. If not, we just ignore it. > > > > Thanks > > > > Mariano > > -- > Miguel CobÃ¡ > http://twitter.com/MiguelCobaMtz > http://miguel.leugim.com.mx > > > > > -- Mariano http://marianopeck.wordpress.com

April 4, 2011

Re: [Pharo-users] Code Critics for unloaded projects

by Mariano Martinez Peck

http://forum.world.st/template/NamlServlet.jtp?macro=search_page&node=12948… On Mon, Apr 4, 2011 at 4:34 PM, AxiNat <tibabenfortlapalanca(a)gmail.com>wrote: > Hi again, > > when trying Mariano's idea I get the following error: > > *forkSqueak requires XDisplayControlPlugin* > * > * > *Select Proceed to continue, or close this window to cancel the operation. > * > > > Do I need to recompile the VM to add support for this plugin? If so, are > there any guidelines around on how to do it? > > Thanks! > > Bernat. > > 2011/4/4 AxiNat <tibabenfortlapalanca(a)gmail.com> > >> Lukas, if that happened anytime soon it would make my life much easier >> hehe >> >> Is there a way I could help to give it a boost? >> >> Mariano, the reason I cannot load the package is that it may contain >> (either intentionally or not) harmful code. An .st file can contain >> arbitrary code that is going to be executed at load time, so it'd be really >> easy to hack the image: "Object compile: 'new'!", for instance ;) >> >> The solution you propose looks interesting, but I'm not sure I've >> completely understood it. Do you mean to run a new image, send it the >> project file to be filed in, have it run the critics on the loaded package, >> and get the output back to the original image? If so, that's a solution I've >> been thinking of, but it would spend too many resources. Even though I could >> always use a very light image, if only 5 users were to be working on the app >> at the same time I'm afraid the system would begin to suffer :( >> >> On a second thought, is there some smaller, simpler implementation of the >> SmallLint package? I wouldn't need to run all the tests, just a couple of >> them: Bugs, Intention Revealing, Miscelaneous and Unnecessary Code, and >> actually not even all the tests in these categories. >> >> Thanks a lot, I'm all ears :) >> >> Bernat. >> >> 2011/4/4 Mariano Martinez Peck <marianopeck(a)gmail.com> >> >>> Is not enough loading the classes but not showing them in the browser ? >>> or maybe not putting them in Smalltalk ? >>> >>> can you do kind of a fork (using OSProcess) of the proccess running >>> image which receives a .st file and in the new forked image you pass the .st >>> in startup, do a file in and then run code-critics? >>> >>> I am curious why you cannot load them hehehehhe >>> >>> >>> On Mon, Apr 4, 2011 at 11:41 AM, AxiNat <tibabenfortlapalanca(a)gmail.com>wrote: >>> >>>> Hi list, >>>> >>>> I have a pretty special need, which is to be able to run code critics on >>>> projects that have not yet been loaded into the image. For example, I need >>>> to browse an st file -or a squeaksource project- and before loading it I >>>> want to run critics on it, would this be possible somehow? >>>> >>>> If it looks like something noone would need to do, I understand. It's >>>> just that the project I'm working on is pretty particular... I've been >>>> exploring other possibilities but I'm afraid this is one of the few left for >>>> me to think of :( >>>> >>>> Thanks a lot in advance! >>>> >>>> Bernat Romagosa. >>>> >>> >>> >>> >>> -- >>> Mariano >>> http://marianopeck.wordpress.com >>> >>> >> > -- Mariano http://marianopeck.wordpress.com

April 4, 2011

Re: [Pharo-users] Code Critics for unloaded projects

by AxiNat

Hi again, when trying Mariano's idea I get the following error: *forkSqueak requires XDisplayControlPlugin* * * *Select Proceed to continue, or close this window to cancel the operation.* Do I need to recompile the VM to add support for this plugin? If so, are there any guidelines around on how to do it? Thanks! Bernat. 2011/4/4 AxiNat <tibabenfortlapalanca(a)gmail.com> > Lukas, if that happened anytime soon it would make my life much easier hehe > > Is there a way I could help to give it a boost? > > Mariano, the reason I cannot load the package is that it may contain > (either intentionally or not) harmful code. An .st file can contain > arbitrary code that is going to be executed at load time, so it'd be really > easy to hack the image: "Object compile: 'new'!", for instance ;) > > The solution you propose looks interesting, but I'm not sure I've > completely understood it. Do you mean to run a new image, send it the > project file to be filed in, have it run the critics on the loaded package, > and get the output back to the original image? If so, that's a solution I've > been thinking of, but it would spend too many resources. Even though I could > always use a very light image, if only 5 users were to be working on the app > at the same time I'm afraid the system would begin to suffer :( > > On a second thought, is there some smaller, simpler implementation of the > SmallLint package? I wouldn't need to run all the tests, just a couple of > them: Bugs, Intention Revealing, Miscelaneous and Unnecessary Code, and > actually not even all the tests in these categories. > > Thanks a lot, I'm all ears :) > > Bernat. > > 2011/4/4 Mariano Martinez Peck <marianopeck(a)gmail.com> > >> Is not enough loading the classes but not showing them in the browser ? or >> maybe not putting them in Smalltalk ? >> >> can you do kind of a fork (using OSProcess) of the proccess running image >> which receives a .st file and in the new forked image you pass the .st in >> startup, do a file in and then run code-critics? >> >> I am curious why you cannot load them hehehehhe >> >> >> On Mon, Apr 4, 2011 at 11:41 AM, AxiNat <tibabenfortlapalanca(a)gmail.com>wrote: >> >>> Hi list, >>> >>> I have a pretty special need, which is to be able to run code critics on >>> projects that have not yet been loaded into the image. For example, I need >>> to browse an st file -or a squeaksource project- and before loading it I >>> want to run critics on it, would this be possible somehow? >>> >>> If it looks like something noone would need to do, I understand. It's >>> just that the project I'm working on is pretty particular... I've been >>> exploring other possibilities but I'm afraid this is one of the few left for >>> me to think of :( >>> >>> Thanks a lot in advance! >>> >>> Bernat Romagosa. >>> >> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com >> >> >

April 4, 2011