January 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Contributing to Pharo

by Nicolai Hess

2016-01-15 23:33 GMT+01:00 David Allouche <david(a)allouche.net>: > > On 15 Jan 2016, at 23:23, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > 2016-01-15 23:16 GMT+01:00 David Allouche <david(a)allouche.net>: >> >> On 15 Jan 2016, at 21:01, stepharo <stepharo(a)free.fr> wrote: >> Le 15/1/16 20:45, David Allouche a Ã©crit : >> >> >> 1. it does not show the package that contains my fix (Spec-Tools) >> >> This is strange. And MC shows the package as dirty? Then this is a bug. >> >> >> I do not know how MC shows a package as dirty. >> > > This is how it should look in slice maker (left side) and monticello > browser (right side). > The " * " marks dirty packages. > > > Okay, got that. > > So yes, it's broken, but maybe it's something else entirely, I get new > reproducible errors every few minutes: errors when activating pretty > printing in the diff viewer in Monticello, > this is a known error from the "recent" change for rubric text component > unexpected contextual menu showing up when I do Cmd-T in the debugger, > known ( from the recent changes for debugger :) ) > infinite recursions when trying to debug through the > MonticelloRepositoryBrowser... > I don't know this error. But I don't think "this" MonticelloRepositoryBrowser is actually used. > All things that are so obvious that I have trouble believing they are > actual bugs. Maybe there was something wrong in how my image was generated. > I will try building another image. > > I also wonderâ¦ so this "list of dirty packages" is actually a list of > every package where some of them are marked dirty? I mean, why is it not > just the list of dirty package, as the name implies? >

Jan. 15, 2016

Re: [Pharo-dev] Contributing to Pharo

by David Allouche

> On 15 Jan 2016, at 23:33, David Allouche <david(a)allouche.net> wrote: > > So yes, it's broken, but maybe it's something else entirely, I get new reproducible errors every few minutes: errors when activating pretty printing in the diff viewer in Monticello, unexpected contextual menu showing up when I do Cmd-T in the debugger, infinite recursions when trying to debug through the MonticelloRepositoryBrowser... All things that are so obvious that I have trouble believing they are actual bugs. Maybe there was something wrong in how my image was generated. I will try building another image. Built a new latest image. Now I no longer have any syntax highlighting in the debuggers or class browserâ¦ Now, people should use the latest image for dev. But apparently the latest image is more often broken than not. What is the trick? Sorry for the unpleasant messages, but I am getting incredibly frustrated.

Jan. 15, 2016

Re: [Pharo-dev] Growl setting name

by Ferlicot D. Cyril

Le 15/01/2016 22:51, Mariano Martinez Peck a Ã©crit : > I clearly would use Notification as part of the name, and not Growl. > NotificationPopup? > I love this one! > -- > Mariano > http://marianopeck.wordpress.com -- Cyril Ferlicot http://www.synectique.eu 165 Avenue Bretagne Lille 59000 France

Jan. 15, 2016

Re: [Pharo-dev] Contributing to Pharo

by David Allouche

> On 15 Jan 2016, at 23:23, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > 2016-01-15 23:16 GMT+01:00 David Allouche <david(a)allouche.net <mailto:david@allouche.net>>: >> On 15 Jan 2016, at 21:01, stepharo <stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >> Le 15/1/16 20:45, David Allouche a Ã©crit : >>> it does not show the package that contains my fix (Spec-Tools) >> This is strange. And MC shows the package as dirty? Then this is a bug. > > I do not know how MC shows a package as dirty. > > This is how it should look in slice maker (left side) and monticello browser (right side). > The " * " marks dirty packages. Okay, got that. So yes, it's broken, but maybe it's something else entirely, I get new reproducible errors every few minutes: errors when activating pretty printing in the diff viewer in Monticello, unexpected contextual menu showing up when I do Cmd-T in the debugger, infinite recursions when trying to debug through the MonticelloRepositoryBrowser... All things that are so obvious that I have trouble believing they are actual bugs. Maybe there was something wrong in how my image was generated. I will try building another image. I also wonderâ¦ so this "list of dirty packages" is actually a list of every package where some of them are marked dirty? I mean, why is it not just the list of dirty package, as the name implies?

Jan. 15, 2016

Re: [Pharo-dev] Contributing to Pharo

by Ferlicot D. Cyril

Le 15/01/2016 23:24, Nicolai Hess a Ã©crit : > > Maybe, we should include some screenshots on the "Contribute to Pharo" page. > > And maybe a screencast :) -- Cyril Ferlicot http://www.synectique.eu 165 Avenue Bretagne Lille 59000 France

Jan. 15, 2016

Re: [Pharo-dev] Contributing to Pharo

by Nicolai Hess

2016-01-15 23:23 GMT+01:00 Nicolai Hess <nicolaihess(a)gmail.com>: > > > 2016-01-15 23:16 GMT+01:00 David Allouche <david(a)allouche.net>: > >> >> On 15 Jan 2016, at 21:01, stepharo <stepharo(a)free.fr> wrote: >> >> Le 15/1/16 20:45, David Allouche a Ã©crit : >> >> >> 1. it does not show the package that contains my fix (Spec-Tools) >> >> This is strange. And MC shows the package as dirty? Then this is a bug. >> >> >> I do not know how MC shows a package as dirty. >> > > This is how it should look in slice maker (left side) and monticello > browser (right side). > The " * " marks dirty packages. > > > Maybe, we should include some screenshots on the "Contribute to Pharo" page.

Jan. 15, 2016

Re: [Pharo-dev] Contributing to Pharo

by Nicolai Hess

2016-01-15 23:16 GMT+01:00 David Allouche <david(a)allouche.net>: > > On 15 Jan 2016, at 21:01, stepharo <stepharo(a)free.fr> wrote: > > Le 15/1/16 20:45, David Allouche a Ã©crit : > > > 1. it does not show the package that contains my fix (Spec-Tools) > > This is strange. And MC shows the package as dirty? Then this is a bug. > > > I do not know how MC shows a package as dirty. > This is how it should look in slice maker (left side) and monticello browser (right side). The " * " marks dirty packages.

Jan. 15, 2016

Re: [Pharo-dev] Contributing to Pharo

by Nicolai Hess

2016-01-15 21:01 GMT+01:00 stepharo <stepharo(a)free.fr>: > > > Le 15/1/16 20:45, David Allouche a Ã©crit : > > Hello, > > I believe the Contributing to Pharo page > <http://pharo.org/contribute-propose-fix> > http://pharo.org/contribute-propose-fix > is out of date. > > Certainly. Time passes so fast. > Hm, I do this on a daily basis and it works for me. > > I found a bug > > https://pharo.fogbugz.com/f/cases/17396/MonticelloRepositoryBrowser-example… > > and a made a fix in in a clean image (50525), created by the newly fixed > PharoLauncher. > > Then I followed the instruction on the page. > > > - Create a slice (group of packages): > - Open the Monticello Browser. > - Open the Slice Maker by clicking the "Slice" button. > - In Slice Maker enter the Fogbugz issue number and "grab" the > issue summary. > - Select all dirty packages affected by your bug fix. > > I have no idea how the "list of dirty packages" is generated, but > > 1. it shows a bunch of packages I have not touched > > Sometimes MC is confused and some packages get dirty while they are not. > we had fixed a couple of bugs on how the repository version is searched and loaded. Sometimes it still loads (or compares against) the wrong version. Deleting the package-cache (package-cache folder) may help > > > 1. it does not show the package that contains my fix (Spec-Tools) > > This is strange. And MC shows the package as dirty? Then this is a bug. > > > > I looked in the world menu, and I found this menu item called "Komitter". > That sounded like a good candidate. > > > Now, I guess I should select Pharo50Inbox as the Remote, write a commit > message, click Ok and hope for the best. > > Sounds correct. > I'm not sure that I understand Komitter :). > > Is that right? > > I don't use komitter, I find it easier with the step described on the how-to-contribute page > > I guess contributors are expected to use a recent image. > > Yes it is always better and also to only publish one change at a time > (which is annoying when you have sequences of changes but > nice to track down changes). > > So I think it would be good that someone updates the documentation. Or fix > the slice maker. Or both. > > Can you reproduce the bug? > > BTW it would be nice that you print and sign the pharo license, then you > send us a scanned or surface mail version > and we will archive it. > > We ask that to every contributors. > > Stef > > > >

Jan. 15, 2016

Re: [Pharo-dev] Contributing to Pharo

by David Allouche

> On 15 Jan 2016, at 21:01, stepharo <stepharo(a)free.fr> wrote: > > Le 15/1/16 20:45, David Allouche a Ã©crit : > >> it does not show the package that contains my fix (Spec-Tools) > This is strange. And MC shows the package as dirty? Then this is a bug. I do not know how MC shows a package as dirty. And anyway, I ended up fiddling my way into uploading the version to smalltalkhub (I think I just clicked Save in Monticello Browser). So it no longer shows as dirty. But apparently that did not provide the fogzbugz issue metadataâ¦ So it might be not dirty anymore. But then I have no idea what to do now to upload it correctly. >> So I think it would be good that someone updates the documentation. Or fix the slice maker. Or both. > Can you reproduce the bug? I cannot not reproduce it. I have no idea at all how people actually manage to use Slice Maker in a recent image. Have you tried with a recent > BTW it would be nice that you print and sign the pharo license, then you send us a scanned or surface mail version > and we will archive it. Surface mail, is that a kind of new social network thing? I'm afraid I got a bit behind the times those past few years. > > We ask that to every contributors. No problem, I'll do that. Copyright paperwork is important.

Jan. 15, 2016

Re: [Pharo-dev] Growl setting name

by Mariano Martinez Peck

I clearly would use Notification as part of the name, and not Growl. NotificationPopup? On Fri, Jan 15, 2016 at 6:42 PM, Henrik Nergaard <henrik.nergaard(a)uia.no> wrote: > The underlying class and implementation relies on Morph and since it is > also a subclass of Morph, should end with the Morph postfix. > Had the implementation used Bloc or similar I would expect it to be named > ...Bloc or ...Brick to signal this. > > Best regards, > Henrik > > -----Original Message----- > From: Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] On Behalf Of > Ferlicot D. Cyril > Sent: Friday, January 15, 2016 10:32 PM > To: pharo-dev(a)lists.pharo.org > Subject: Re: [Pharo-dev] Growl setting name > > Le 15/01/2016 22:25, Henrik Nergaard a Ã©crit : > > NotificationMorph | NotifierMorph | InformationMorph ? > > > > Best regards, > > Henrik > > > > Since Morph will be replace by Bloc I don't know if it's wise to name > things with "Morph". > > -- > Cyril Ferlicot > > http://www.synectique.eu > > 165 Avenue Bretagne > Lille 59000 France > > -- Mariano http://marianopeck.wordpress.com

Jan. 15, 2016