2016-01-15 21:01 GMT+01:00 stepharo <stepharo@free.fr>:
Le 15/1/16 20:45, David Allouche a écrit :
Hello,
I believe the Contributing to Pharo page <http://pharo.org/contribute-propose-fix> http://pharo.org/contribute-propose-fix is out of date.
Certainly. Time passes so fast.
Hm, I do this on a daily basis and it works for me.
I found a bug
https://pharo.fogbugz.com/f/cases/17396/MonticelloRepositoryBrowser-example-...
and a made a fix in in a clean image (50525), created by the newly fixed PharoLauncher.
Then I followed the instruction on the page.
- Create a slice (group of packages): - Open the Monticello Browser. - Open the Slice Maker by clicking the "Slice" button. - In Slice Maker enter the Fogbugz issue number and "grab" the issue summary. - Select all dirty packages affected by your bug fix.
I have no idea how the "list of dirty packages" is generated, but
1. it shows a bunch of packages I have not touched
Sometimes MC is confused and some packages get dirty while they are not.
we had fixed a couple of bugs on how the repository version is searched and loaded. Sometimes it still loads (or compares against) the wrong version. Deleting the package-cache (package-cache folder) may help
1. it does not show the package that contains my fix (Spec-Tools)
This is strange. And MC shows the package as dirty? Then this is a bug.
I looked in the world menu, and I found this menu item called "Komitter". That sounded like a good candidate.
Now, I guess I should select Pharo50Inbox as the Remote, write a commit message, click Ok and hope for the best.
Sounds correct. I'm not sure that I understand Komitter :).
Is that right?
I don't use komitter, I find it easier with the step described on the how-to-contribute page
I guess contributors are expected to use a recent image.
Yes it is always better and also to only publish one change at a time (which is annoying when you have sequences of changes but nice to track down changes).
So I think it would be good that someone updates the documentation. Or fix the slice maker. Or both.
Can you reproduce the bug?
BTW it would be nice that you print and sign the pharo license, then you send us a scanned or surface mail version and we will archive it.
We ask that to every contributors.
Stef
