Epicea import+revert instead of redo+undo changes? (Was: Re: [pharo-project/pharo-core] f57843: 60163)
Hi Stef, I come back to your observation about the words Redo and Undo used in Epicea menu. You proposed to use Import and Revert instead. Originally I chose redo/undo because they are very well known terms in text editing UIs, but it is true that they are different: in regular UIs you can't select an arbitrary operation in the history and redo or undo it, like in Epicea. So other names can be more adequate... any other opinion? Martin ps: other alternative is apply+"apply inverse" ps2: I'm preparing a major update in Epicea's UIs, which already has some renames. â El 7/8/2016 3:16, "stepharo" <stepharo@free.fr> escribió: Le 5/8/16 à 05:28, Martin Dias a écrit : Hi Stef, good, I take note. I improved filters in the recent releases and will continue improving. Thanks Martin I have problems with the menu item names :) To me redo looks strange when I get a crash I want to import the changes not redo them. Then I do not get what undo means (yes I know this is probably revert) May be some pharoers have better names than mine. Stef Martin On Wed, Aug 3, 2016 at 5:30 PM, stepharo <stepharo@free.fr> wrote:
Thanks Martin.
We missed yesterday: show only the latest version of every entities. :)
Setf
Le 3/8/16 à 11:23, Marcus Denker a écrit :
On 03 Aug 2016, at 11:07, GitHub <noreply@github.com> wrote:
Log Message: ----------- 60163 18831 Integrate new Epicea version https://pharo.fogbugz.com/f/cases/18831
ChangeLog for this:
- Case 18813: Implement redo and undo of protocol addition and removal.
- Case 18612: disable drag&drop until TreeModel supports it correctly.
- Case 18384: Redo and undo: show on any selection (not only when all selected entries are code changes).
- Enhancement: Improve lost changes detection; show only the events actually lost.
- Enhancement: Pass on filters.
- Clean up: Do not show the "absent entry" item anymore since it was not useful at all.
- Clean up: Remove unused "commit tags" in log browser.
- Clean up: Remove unused tests. They were good idea, we can re-introduce them but working and covering more cases.
- Clean up: Rename #displayWidget to #asMorph in EpLogBrowserItem''s hierarchy. It is more meaningful.
- Workaround: Hide "Open in Sorter" menu action since it is useless until Treemodel drag&drop is fixed.
18768 Inlined method const could be implemented by metalinks
https://pharo.fogbugz.com/f/cases/18768
18835 Update RBParser-Nodes class comments https://pharo.fogbugz.com/f/cases/18835
good to me. Import is good. Apply to. After I'm not sure I understand redo :) Tx for the new release Le 19/8/16 à 04:13, Martin Dias a écrit :
Hi Stef, I come back to your observation about the words Redo and Undo used in Epicea menu. You proposed to use Import and Revert instead.
Originally I chose redo/undo because they are very well known terms in text editing UIs, but it is true that they are different: in regular UIs you can't select an arbitrary operation in the history and redo or undo it, like in Epicea. So other names can be more adequate...
any other opinion?
Martin
ps: other alternative is apply+"apply inverse"
ps2: I'm preparing a major update in Epicea's UIs, which already has some renames.
â
El 7/8/2016 3:16, "stepharo" <stepharo@free.fr <mailto:stepharo@free.fr>> escribió:
Le 5/8/16 à 05:28, Martin Dias a écrit :
Hi Stef, good, I take note. I improved filters in the recent releases and will continue improving.
Thanks Martin
I have problems with the menu item names :) To me redo looks strange when I get a crash I want to import the changes not redo them. Then I do not get what undo means (yes I know this is probably revert) May be some pharoers have better names than mine.
Stef
Martin
On Wed, Aug 3, 2016 at 5:30 PM, stepharo <stepharo@free.fr <mailto:stepharo@free.fr>> wrote:
Thanks Martin.
We missed yesterday: show only the latest version of every entities. :)
Setf
Le 3/8/16 à 11:23, Marcus Denker a écrit :
On 03 Aug 2016, at 11:07, GitHub <noreply@github.com <mailto:noreply@github.com>> wrote:
Log Message: ----------- 60163 18831 Integrate new Epicea version https://pharo.fogbugz.com/f/cases/18831 <https://pharo.fogbugz.com/f/cases/18831>
ChangeLog for this:
- Case 18813: Implement redo and undo of protocol addition and removal.
- Case 18612: disable drag&drop until TreeModel supports it correctly.
- Case 18384: Redo and undo: show on any selection (not only when all selected entries are code changes).
- Enhancement: Improve lost changes detection; show only the events actually lost.
- Enhancement: Pass on filters.
- Clean up: Do not show the "absent entry" item anymore since it was not useful at all.
- Clean up: Remove unused "commit tags" in log browser.
- Clean up: Remove unused tests. They were good idea, we can re-introduce them but working and covering more cases.
- Clean up: Rename #displayWidget to #asMorph in EpLogBrowserItem''s hierarchy. It is more meaningful.
- Workaround: Hide "Open in Sorter" menu action since it is useless until Treemodel drag&drop is fixed.
18768 Inlined method const could be implemented by metalinks https://pharo.fogbugz.com/f/cases/18768 <https://pharo.fogbugz.com/f/cases/18768>
18835 Update RBParser-Nodes class comments https://pharo.fogbugz.com/f/cases/18835 <https://pharo.fogbugz.com/f/cases/18835>
http://files.pharo.org/image/60/60163.zip <http://files.pharo.org/image/60/60163.zip>
apply / revert sounds good to me. Esteban
On 19 Aug 2016, at 09:37, stepharo <stepharo@free.fr> wrote:
good to me. Import is good. Apply to.
After I'm not sure I understand redo :)
Tx for the new release Le 19/8/16 à 04:13, Martin Dias a écrit :
Hi Stef, I come back to your observation about the words Redo and Undo used in Epicea menu. You proposed to use Import and Revert instead.
Originally I chose redo/undo because they are very well known terms in text editing UIs, but it is true that they are different: in regular UIs you can't select an arbitrary operation in the history and redo or undo it, like in Epicea. So other names can be more adequate...
any other opinion?
Martin
ps: other alternative is apply+"apply inverse"
ps2: I'm preparing a major update in Epicea's UIs, which already has some renames.
<Mail Attachment.png> â
El 7/8/2016 3:16, "stepharo" <stepharo@free.fr <mailto:stepharo@free.fr>> escribió:
Le 5/8/16 à 05:28, Martin Dias a écrit :
Hi Stef, good, I take note. I improved filters in the recent releases and will continue improving.
Thanks Martin
I have problems with the menu item names :) To me redo looks strange when I get a crash I want to import the changes not redo them. Then I do not get what undo means (yes I know this is probably revert) May be some pharoers have better names than mine.
Stef
Martin
On Wed, Aug 3, 2016 at 5:30 PM, stepharo <stepharo@free.fr <mailto:stepharo@free.fr>> wrote: Thanks Martin.
We missed yesterday: show only the latest version of every entities. :)
Setf
Le 3/8/16 à 11:23, Marcus Denker a écrit :
On 03 Aug 2016, at 11:07, GitHub <noreply@github.com <mailto:noreply@github.com>> wrote:
Log Message: ----------- 60163 18831 Integrate new Epicea version https://pharo.fogbugz.com/f/cases/18831 <https://pharo.fogbugz.com/f/cases/18831>
ChangeLog for this:
- Case 18813: Implement redo and undo of protocol addition and removal.
- Case 18612: disable drag&drop until TreeModel supports it correctly.
- Case 18384: Redo and undo: show on any selection (not only when all selected entries are code changes).
- Enhancement: Improve lost changes detection; show only the events actually lost.
- Enhancement: Pass on filters.
- Clean up: Do not show the "absent entry" item anymore since it was not useful at all.
- Clean up: Remove unused "commit tags" in log browser.
- Clean up: Remove unused tests. They were good idea, we can re-introduce them but working and covering more cases.
- Clean up: Rename #displayWidget to #asMorph in EpLogBrowserItem''s hierarchy. It is more meaningful.
- Workaround: Hide "Open in Sorter" menu action since it is useless until Treemodel drag&drop is fixed.
18768 Inlined method const could be implemented by metalinks https://pharo.fogbugz.com/f/cases/18768 <https://pharo.fogbugz.com/f/cases/18768>
18835 Update RBParser-Nodes class comments https://pharo.fogbugz.com/f/cases/18835 <https://pharo.fogbugz.com/f/cases/18835>
http://files.pharo.org/image/60/60163.zip <http://files.pharo.org/image/60/60163.zip>
I prefer import/revert 2016-08-19 10:27 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
apply / revert sounds good to me.
Esteban
On 19 Aug 2016, at 09:37, stepharo <stepharo@free.fr> wrote:
good to me.
Import is good. Apply to.
After I'm not sure I understand redo :)
Tx for the new release Le 19/8/16 à 04:13, Martin Dias a écrit :
Hi Stef, I come back to your observation about the words Redo and Undo used in Epicea menu. You proposed to use Import and Revert instead.
Originally I chose redo/undo because they are very well known terms in text editing UIs, but it is true that they are different: in regular UIs you can't select an arbitrary operation in the history and redo or undo it, like in Epicea. So other names can be more adequate...
any other opinion?
Martin
ps: other alternative is apply+"apply inverse"
ps2: I'm preparing a major update in Epicea's UIs, which already has some renames.
<Mail Attachment.png> â
El 7/8/2016 3:16, "stepharo" <stepharo@free.fr> escribió:
Le 5/8/16 à 05:28, Martin Dias a écrit :
Hi Stef, good, I take note. I improved filters in the recent releases and will continue improving.
Thanks Martin
I have problems with the menu item names :) To me redo looks strange when I get a crash I want to import the changes not redo them. Then I do not get what undo means (yes I know this is probably revert) May be some pharoers have better names than mine.
Stef
Martin
On Wed, Aug 3, 2016 at 5:30 PM, stepharo <stepharo@free.fr> wrote:
Thanks Martin.
We missed yesterday: show only the latest version of every entities. :)
Setf
Le 3/8/16 à 11:23, Marcus Denker a écrit :
On 03 Aug 2016, at 11:07, GitHub <noreply@github.com> wrote:
Log Message: ----------- 60163 18831 Integrate new Epicea version https://pharo.fogbugz.com/f/cases/18831
ChangeLog for this:
- Case 18813: Implement redo and undo of protocol addition and removal.
- Case 18612: disable drag&drop until TreeModel supports it correctly.
- Case 18384: Redo and undo: show on any selection (not only when all selected entries are code changes).
- Enhancement: Improve lost changes detection; show only the events actually lost.
- Enhancement: Pass on filters.
- Clean up: Do not show the "absent entry" item anymore since it was not useful at all.
- Clean up: Remove unused "commit tags" in log browser.
- Clean up: Remove unused tests. They were good idea, we can re-introduce them but working and covering more cases.
- Clean up: Rename #displayWidget to #asMorph in EpLogBrowserItem''s hierarchy. It is more meaningful.
- Workaround: Hide "Open in Sorter" menu action since it is useless until Treemodel drag&drop is fixed.
18768 Inlined method const could be implemented by metalinks
https://pharo.fogbugz.com/f/cases/18768
18835 Update RBParser-Nodes class comments https://pharo.fogbugz.com/f/cases/18835
Hi 2016-08-19 4:13 GMT+02:00 Martin Dias <tinchodias@gmail.com>:
Hi Stef, I come back to your observation about the words Redo and Undo used in Epicea menu. You proposed to use Import and Revert instead.
Originally I chose redo/undo because they are very well known terms in text editing UIs, but it is true that they are different: in regular UIs you can't select an arbitrary operation in the history and redo or undo it, like in Epicea.
Does it always work? I could rename class A to B. Then I will rename B to C. After that how first change could be reverted?
I think âapplyâ is better. âimportâ sounds too specific to me. I donât want to care where the entries come from and âimportâ implies that there may be something else going on (also: if thereâs an import whereâs the export?). But thatâs just an opinion. Cheers, Max
On 19 Aug 2016, at 04:13, Martin Dias <tinchodias@gmail.com> wrote:
Hi Stef, I come back to your observation about the words Redo and Undo used in Epicea menu. You proposed to use Import and Revert instead.
Originally I chose redo/undo because they are very well known terms in text editing UIs, but it is true that they are different: in regular UIs you can't select an arbitrary operation in the history and redo or undo it, like in Epicea. So other names can be more adequate...
any other opinion?
Martin
ps: other alternative is apply+"apply inverse"
ps2: I'm preparing a major update in Epicea's UIs, which already has some renames.
<PharoScreenshot.1.png> â
El 7/8/2016 3:16, "stepharo" <stepharo@free.fr <mailto:stepharo@free.fr>> escribió:
Le 5/8/16 à 05:28, Martin Dias a écrit :
Hi Stef, good, I take note. I improved filters in the recent releases and will continue improving.
Thanks Martin
I have problems with the menu item names :) To me redo looks strange when I get a crash I want to import the changes not redo them. Then I do not get what undo means (yes I know this is probably revert) May be some pharoers have better names than mine.
Stef
Martin
On Wed, Aug 3, 2016 at 5:30 PM, stepharo <stepharo@free.fr <mailto:stepharo@free.fr>> wrote: Thanks Martin.
We missed yesterday: show only the latest version of every entities. :)
Setf
Le 3/8/16 à 11:23, Marcus Denker a écrit :
On 03 Aug 2016, at 11:07, GitHub <noreply@github.com <mailto:noreply@github.com>> wrote:
Log Message: ----------- 60163 18831 Integrate new Epicea version https://pharo.fogbugz.com/f/cases/18831 <https://pharo.fogbugz.com/f/cases/18831>
ChangeLog for this:
- Case 18813: Implement redo and undo of protocol addition and removal.
- Case 18612: disable drag&drop until TreeModel supports it correctly.
- Case 18384: Redo and undo: show on any selection (not only when all selected entries are code changes).
- Enhancement: Improve lost changes detection; show only the events actually lost.
- Enhancement: Pass on filters.
- Clean up: Do not show the "absent entry" item anymore since it was not useful at all.
- Clean up: Remove unused "commit tags" in log browser.
- Clean up: Remove unused tests. They were good idea, we can re-introduce them but working and covering more cases.
- Clean up: Rename #displayWidget to #asMorph in EpLogBrowserItem''s hierarchy. It is more meaningful.
- Workaround: Hide "Open in Sorter" menu action since it is useless until Treemodel drag&drop is fixed.
18768 Inlined method const could be implemented by metalinks https://pharo.fogbugz.com/f/cases/18768 <https://pharo.fogbugz.com/f/cases/18768>
18835 Update RBParser-Nodes class comments https://pharo.fogbugz.com/f/cases/18835 <https://pharo.fogbugz.com/f/cases/18835>
http://files.pharo.org/image/60/60163.zip <http://files.pharo.org/image/60/60163.zip>
On 19 Aug 2016, at 10:43, Max Leske <maxleske@gmail.com> wrote:
I think âapplyâ is better. âimportâ sounds too specific to me. I donât want to care where the entries come from and âimportâ implies that there may be something else going on (also: if thereâs an import whereâs the export?).
+1 :)
But thatâs just an opinion.
Cheers, Max
On 19 Aug 2016, at 04:13, Martin Dias <tinchodias@gmail.com <mailto:tinchodias@gmail.com>> wrote:
Hi Stef, I come back to your observation about the words Redo and Undo used in Epicea menu. You proposed to use Import and Revert instead.
Originally I chose redo/undo because they are very well known terms in text editing UIs, but it is true that they are different: in regular UIs you can't select an arbitrary operation in the history and redo or undo it, like in Epicea. So other names can be more adequate...
any other opinion?
Martin
ps: other alternative is apply+"apply inverse"
ps2: I'm preparing a major update in Epicea's UIs, which already has some renames.
<PharoScreenshot.1.png> â
El 7/8/2016 3:16, "stepharo" <stepharo@free.fr <mailto:stepharo@free.fr>> escribió:
Le 5/8/16 à 05:28, Martin Dias a écrit :
Hi Stef, good, I take note. I improved filters in the recent releases and will continue improving.
Thanks Martin
I have problems with the menu item names :) To me redo looks strange when I get a crash I want to import the changes not redo them. Then I do not get what undo means (yes I know this is probably revert) May be some pharoers have better names than mine.
Stef
Martin
On Wed, Aug 3, 2016 at 5:30 PM, stepharo <stepharo@free.fr <mailto:stepharo@free.fr>> wrote: Thanks Martin.
We missed yesterday: show only the latest version of every entities. :)
Setf
Le 3/8/16 à 11:23, Marcus Denker a écrit :
On 03 Aug 2016, at 11:07, GitHub <noreply@github.com <mailto:noreply@github.com>> wrote:
Log Message: ----------- 60163 18831 Integrate new Epicea version https://pharo.fogbugz.com/f/cases/18831 <https://pharo.fogbugz.com/f/cases/18831>
ChangeLog for this:
- Case 18813: Implement redo and undo of protocol addition and removal.
- Case 18612: disable drag&drop until TreeModel supports it correctly.
- Case 18384: Redo and undo: show on any selection (not only when all selected entries are code changes).
- Enhancement: Improve lost changes detection; show only the events actually lost.
- Enhancement: Pass on filters.
- Clean up: Do not show the "absent entry" item anymore since it was not useful at all.
- Clean up: Remove unused "commit tags" in log browser.
- Clean up: Remove unused tests. They were good idea, we can re-introduce them but working and covering more cases.
- Clean up: Rename #displayWidget to #asMorph in EpLogBrowserItem''s hierarchy. It is more meaningful.
- Workaround: Hide "Open in Sorter" menu action since it is useless until Treemodel drag&drop is fixed.
18768 Inlined method const could be implemented by metalinks https://pharo.fogbugz.com/f/cases/18768 <https://pharo.fogbugz.com/f/cases/18768>
18835 Update RBParser-Nodes class comments https://pharo.fogbugz.com/f/cases/18835 <https://pharo.fogbugz.com/f/cases/18835>
http://files.pharo.org/image/60/60163.zip <http://files.pharo.org/image/60/60163.zip>
2016-08-19 5:47 GMT-03:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 19 Aug 2016, at 10:43, Max Leske <maxleske@gmail.com> wrote:
I think âapplyâ is better. âimportâ sounds too specific to me. I donât want to care where the entries come from and âimportâ implies that there may be something else going on (also: if thereâs an import whereâs the export?).
+1 :)
+1 here I was thinking about apply/revert as well. If you use git-cherry-pick its description says: "Apply the changes introduced by some existing commits" I prefer it. Esteban A. Maringolo
Esteban A. Maringolo wrote
I think âapplyâ is better. âimportâ sounds too specific to me. I donât want to care where the entries come from and âimportâ implies that there may be something else going on (also: if thereâs an import whereâs the export?).
+1. Apply/revert sound right to me also. ----- Cheers, Sean -- View this message in context: http://forum.world.st/Epicea-import-revert-instead-of-redo-undo-changes-Was-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Fri, Aug 19, 2016 at 12:14 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
Esteban A. Maringolo wrote
I think âapplyâ is better. âimportâ sounds too specific to me. I donât want to care where the entries come from and âimportâ implies that there may be something else going on (also: if thereâs an import whereâs the export?).
+1. Apply/revert sound right to me also.
Good! thanks; next release will have apply / revert Martin
2016-08-19 10:43 GMT+02:00 Max Leske <maxleske@gmail.com>:
I think âapplyâ is better. âimportâ sounds too specific to me. I donât want to care where the entries come from and âimportâ implies that there may be something else going on (also: if thereâs an import whereâs the export?).
But we support to open and import changes from any image (not only owner). Anyway we need to choose most intuitive name because undo/redo are always raise questions (also after many times I use it). "apply" could be good too.
participants (7)
-
Denis Kudriashov -
Esteban A. Maringolo -
Esteban Lorenzano -
Martin Dias -
Max Leske -
Sean P. DeNigris -
stepharo