Hi, So⦠summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time. First issue: the tab morph we have is horrible (and makes horrible anything with it). Iâve been working on it to fix that âchromish-but-badâ style we had and to fix some (a lot) hardcoded colors there. Now, for example, Calypso looks like this: which is IMHO a lot better :) some remarks: 1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system. So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :) Esteban
I'm waiting your pull request here :) On Mon, Aug 7, 2017 at 5:47 PM, Esteban Lorenzano <estebanlm@gmail.com> wrote:
Hi,
So⦠summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.
First issue: the tab morph we have is horrible (and makes horrible anything with it). Iâve been working on it to fix that âchromish-but-badâ style we had and to fix some (a lot) hardcoded colors there. Now, for example, Calypso looks like this:
which is IMHO a lot better :)
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Esteban
-- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13
Hi Esteban Did you check white theme? 2017-08-07 17:47 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
These morphs are used for window tabs.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Yes and many internal things can be improved and cleaned. I want lazy behaviour where tab content is built only when tab is selected. It will improve performance (especially in remote case).
Esteban
On 7 Aug 2017, at 17:59, Denis Kudriashov <dionisiydk@gmail.com> wrote:
Hi Esteban
Did you check white theme?
Yes
2017-08-07 17:47 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
These morphs are used for window tabs.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Yes and many internal things can be improved and cleaned. I want lazy behaviour where tab content is built only when tab is selected. It will improve performance (especially in remote case).
Esteban
Le 07/08/2017 à 17:47, Esteban Lorenzano a écrit :
Hi,
So⦠summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.
First issue: the tab morph we have is horrible (and makes horrible anything with it). Iâve been working on it to fix that âchromish-but-badâ style we had and to fix some (a lot) hardcoded colors there. Now, for example, Calypso looks like this:
which is IMHO a lot better :)
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Esteban
Hi, I find those tabs too big. Am I the only one with this impression? But nice job, those are really better :) -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
Would be nice to have autosized tabs 2017-08-07 19:18 GMT+02:00 Cyril Ferlicot D. <cyril.ferlicot@gmail.com>:
Le 07/08/2017 à 17:47, Esteban Lorenzano a écrit :
Hi,
So⦠summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.
First issue: the tab morph we have is horrible (and makes horrible anything with it). Iâve been working on it to fix that âchromish-but-badâ style we had and to fix some (a lot) hardcoded colors there. Now, for example, Calypso looks like this:
which is IMHO a lot better :)
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Esteban
Hi,
I find those tabs too big. Am I the only one with this impression?
But nice job, those are really better :)
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
I liked the original trapezoid shape more than the squared version, and if there is going to be a variable length (autosized) it should have a maximum width setting, and leave the "variable width" tab for the end. There's some "muscle memory" in any UI, and having tabs (or any UI component) that change size depending on the content can mislead you, plus it can alter the UI "harmony". It's no surprise web browsers "shrink" the width keeping a proportional width, but never go full width, even when there is screen state available. Regards, Esteban A. Maringolo 2017-08-07 15:18 GMT-03:00 Denis Kudriashov <dionisiydk@gmail.com>:
Would be nice to have autosized tabs
2017-08-07 19:18 GMT+02:00 Cyril Ferlicot D. <cyril.ferlicot@gmail.com>:
Le 07/08/2017 à 17:47, Esteban Lorenzano a écrit :
Hi,
So⦠summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.
First issue: the tab morph we have is horrible (and makes horrible anything with it). Iâve been working on it to fix that âchromish-but-badâ style we had and to fix some (a lot) hardcoded colors there. Now, for example, Calypso looks like this:
which is IMHO a lot better :)
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Esteban
Hi,
I find those tabs too big. Am I the only one with this impression?
But nice job, those are really better :)
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
I personally think that the tabs in TabGroupMorph look more like tabs :-) -- Pavel 2017-08-07 17:47 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
Hi,
So⦠summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.
First issue: the tab morph we have is horrible (and makes horrible anything with it). Iâve been working on it to fix that âchromish-but-badâ style we had and to fix some (a lot) hardcoded colors there. Now, for example, Calypso looks like this:
which is IMHO a lot better :)
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Esteban
[image: Vložený obrázek 1] 2017-08-08 15:01 GMT+02:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
I personally think that the tabs in TabGroupMorph look more like tabs :-)
-- Pavel
2017-08-07 17:47 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
Hi,
So⦠summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.
First issue: the tab morph we have is horrible (and makes horrible anything with it). Iâve been working on it to fix that âchromish-but-badâ style we had and to fix some (a lot) hardcoded colors there. Now, for example, Calypso looks like this:
which is IMHO a lot better :)
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Esteban
participants (6)
-
Cyril Ferlicot D. -
Denis Kudriashov -
Esteban A. Maringolo -
Esteban Lorenzano -
Guillermo Polito -
Pavel Krivanek