I'm waiting your pull request here :) On Mon, Aug 7, 2017 at 5:47 PM, Esteban Lorenzano <estebanlm@gmail.com> wrote:
Hi,
So⦠summer project (to do when there is too much hot to go outside): fix some minor things that are inside the image that annoys me since some time.
First issue: the tab morph we have is horrible (and makes horrible anything with it). Iâve been working on it to fix that âchromish-but-badâ style we had and to fix some (a lot) hardcoded colors there. Now, for example, Calypso looks like this:
which is IMHO a lot better :)
some remarks:
1) I find TabManagerMorph an ugly name. Do you think we should change it? (I tend to think anything called *Manager, *Controller, etc. as a bad naming chose and probably the mark of a smell). 2) much more important: we should deprecate TabGroupMorph and LazyTabGroupMorph family⦠there should not be more than one widget to do the same in the system.
So well, as usual with old things: you fix a little thing and you uncover a lot of new problems :)
Esteban
-- Guille Polito Research Engineer French National Center for Scientific Research - *http://www.cnrs.fr* <http://www.cnrs.fr> *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13
