Hi everyone! Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter. Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects. Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code. Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues Have a nice week! Uko
this is so good. what about integrate it to Pharo? cheers, Esteban
On 22 Apr 2015, at 08:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
Have a nice week! Uko
<critics.jpg>
Good job ! :D Really usefull On 22 April 2015 at 12:23, Esteban Lorenzano <estebanlm@gmail.com> wrote:
this is so good. what about integrate it to Pharo?
cheers, Esteban
On 22 Apr 2015, at 08:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta-. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues
Have a nice week! Uko
<critics.jpg>
-- Cheers Cyril Ferlicot
I am definitely interested in it. Let me know what I should do for this. I havenât got a lot of feedback from users, but I fixed problems reported by my group and Alex Bergel. The remaining reported issues are quite minor and related to how SmallLint works. Changes to SmallLint will arrive later after I figure out what the rules are about and what is the way to improve them. Cheers, Uko
On 22 Apr 2015, at 12:23, Esteban Lorenzano <estebanlm@gmail.com> wrote:
this is so good. what about integrate it to Pharo?
cheers, Esteban
On 22 Apr 2015, at 08:58, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote:
Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
Have a nice week! Uko
<critics.jpg>
_______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
you definetly got feedback from me with one feature request you did not reply ;) On Wed, Apr 22, 2015 at 2:00 PM Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
I am definitely interested in it. Let me know what I should do for this.
I havenât got a lot of feedback from users, but I fixed problems reported by my group and Alex Bergel. The remaining reported issues are quite minor and related to how SmallLint works. Changes to SmallLint will arrive later after I figure out what the rules are about and what is the way to improve them.
Cheers, Uko
On 22 Apr 2015, at 12:23, Esteban Lorenzano <estebanlm@gmail.com> wrote:
this is so good. what about integrate it to Pharo?
cheers, Esteban
On 22 Apr 2015, at 08:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta-. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues
Have a nice week! Uko
<critics.jpg>
_______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
kilon alios <kilon.alios@gmail.com> writes:
you definetly got feedback from me with one feature request you did not reply ;)
same from me: in my opinion, the notifications should not be part of the code browser because we can also code in the inspector and the debugger. I think they should appear at the bottom of the Pharo window. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill
I think that feedback should be as close as possible to the place it relates to :) Doru On Wed, Apr 22, 2015 at 2:19 PM, Damien Cassou <damien.cassou@inria.fr> wrote:
kilon alios <kilon.alios@gmail.com> writes:
you definetly got feedback from me with one feature request you did not reply ;)
same from me: in my opinion, the notifications should not be part of the code browser because we can also code in the inspector and the debugger. I think they should appear at the bottom of the Pharo window.
-- Damien Cassou http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill
-- www.tudorgirba.com "Every thing has its own flow"
On 22 Apr 2015, at 14:19, Damien Cassou <damien.cassou@inria.fr> wrote:
kilon alios <kilon.alios@gmail.com> writes:
you definetly got feedback from me with one feature request you did not reply ;)
same from me: in my opinion, the notifications should not be part of the code browser because we can also code in the inspector and the debugger. I think they should appear at the bottom of the Pharo window.
I remember this request, Damien. After it Iâve added also information about critics in the inspector and spotter. At the moment I havenât done anything with debugger, but I will definitely look into it. QualityAssitant was showing global notifications at the beginning, but this imposes other kind of problem: how do you deal with many entities that change simultaneously? Another example is when you load package with Monticello, as code is in fact modified, and you are spammed with notifications. This is why I decided to step down and now the main goal of QualityAssistant is to assure that you can ask each entity about itâs quality and receive the critics. Then tools like SystemBrowser, Inspector or Debugger can implement a view section that displays this property of an entity. Current approach does not forbid the creation of global notification system and I will work on it, as soon as Iâm done with higher priority tasks, or we can hack something together during ESUG. Your feedback is very important, and while you donât see the requested feature available yet, it has influenced the design decisions taken during the development :) Cheers. Uko
-- Damien Cassou http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill
Yuriy Tymchuk <yuriy.tymchuk@me.com> writes:
Current approach does not forbid the creation of global notification system and I will work on it, as soon as Iâm done with higher priority tasks, or we can hack something together during ESUG. Your feedback is very important, and while you donât see the requested feature available yet, it has influenced the design decisions taken during the development :)
:-) -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill
Iâm terribly sorry Kilon, because I can not recall it, neither can I find it. Can you please tell it again? Uko
On 22 Apr 2015, at 13:29, kilon alios <kilon.alios@gmail.com> wrote:
you definetly got feedback from me with one feature request you did not reply ;)
On Wed, Apr 22, 2015 at 2:00 PM Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote: I am definitely interested in it. Let me know what I should do for this.
I havenât got a lot of feedback from users, but I fixed problems reported by my group and Alex Bergel. The remaining reported issues are quite minor and related to how SmallLint works. Changes to SmallLint will arrive later after I figure out what the rules are about and what is the way to improve them.
Cheers, Uko
On 22 Apr 2015, at 12:23, Esteban Lorenzano <estebanlm@gmail.com <mailto:estebanlm@gmail.com>> wrote:
this is so good. what about integrate it to Pharo?
cheers, Esteban
On 22 Apr 2015, at 08:58, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote:
Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
Have a nice week! Uko
<critics.jpg>
_______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> https://www.iam.unibe.ch/mailman/listinfo/moose-dev <https://www.iam.unibe.ch/mailman/listinfo/moose-dev>
Hi, I only took a brief look, but I think that reaching the no-input-required situation is a major step forward. Nice job. Keep it up. Cheers, Doru On Wed, Apr 22, 2015 at 8:58 AM, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta-. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues
Have a nice week! Uko
-- www.tudorgirba.com "Every thing has its own flow"
Thank you Doru.
On 22 Apr 2015, at 15:00, Tudor Girba <tudor@tudorgirba.com> wrote:
Hi,
I only took a brief look, but I think that reaching the no-input-required situation is a major step forward.
Nice job. Keep it up.
Cheers, Doru
On Wed, Apr 22, 2015 at 8:58 AM, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote: Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
Have a nice week! Uko
<critics.jpg>
-- www.tudorgirba.com <http://www.tudorgirba.com/>
"Every thing has its own flow"
Uko2 wrote
I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Holy crap - this tool is /Amazing/! It highlights the offending code and even has a button to fix automatically if possible!!! +1 to integration ----- Cheers, Sean -- View this message in context: http://forum.world.st/QualityAssistant-v0-4-tp4821070p4821143.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
NO NO NO integration in the image. NO external tools to talk to. NO NO NO Change your mindset. ConfigurationBrowser is your friend. One click and load. Or a startup preference. The configurationBrowser could have button: "add to my startupPreference." Stef Le 22/4/15 16:43, Sean P. DeNigris a écrit :
Uko2 wrote
I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter. Holy crap - this tool is /Amazing/! It highlights the offending code and even has a button to fix automatically if possible!!! +1 to integration
----- Cheers, Sean -- View this message in context: http://forum.world.st/QualityAssistant-v0-4-tp4821070p4821143.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On 22 Apr 2015, at 20:08, stepharo <stepharo@free.fr> wrote:
NO NO NO integration in the image. NO external tools to talk to. NO NO NO Change your mindset.
But that will get quite hard: If we improve and people create more tools, then the âPharo that could beâ (with the tools loaded) will be very different from the âPharo that isâ. And nobody who downloads pharo will load additional tools. Nobody. Our goal of a modular and minimal image should not mean that Pharo itself does not come with those tools that we want people to use by default. Marcus
stepharo wrote
NO NO NO integration in the image. NO external tools to talk to. NO NO NO Change your mindset.
I was actually thinking specifically of new users. I already know how to load it and make extensive use of startup preferences so it doesn't really matter to me. But it's taken me 5 years to find all the cool extensions I use routinely. How will a new user appreciate our Ferrari when we give it to them without paint, headlights, or seats? Maybe we can have something like Edgar's FunSqueak, with all the cool IDE features, be the default download, but then, if we're not all using that image, we may commit a sin similar Marcus' repeated warning that "the artefact on the build server needs to be the artefact of release" of using a different image than we release... ----- Cheers, Sean -- View this message in context: http://forum.world.st/QualityAssistant-v0-4-tp4821070p4821265.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
There is a solution that I was thinking when I was imagining implementing my own Configuration Browser than I named "Tartara". One of the ideas I had was the introduction of packages, which is basically something that would trigger the installation of multiple projects at the same time. So I was imaging "Core" package that will contain all the core IDEs, "GT" package all the GT tools , "Games" where there will be multiple games etc. This way the user would not need to install those tools one by one. Ideally I was also imagining a detailed description per package with even the ability to rate the quality of the package or even review it .
From the looks of it this is already possible with Configuration Browser but it does not provide this separation yet.
On Wed, Apr 22, 2015 at 11:18 PM Sean P. DeNigris <sean@clipperadams.com> wrote:
stepharo wrote
NO NO NO integration in the image. NO external tools to talk to. NO NO NO Change your mindset.
I was actually thinking specifically of new users. I already know how to load it and make extensive use of startup preferences so it doesn't really matter to me. But it's taken me 5 years to find all the cool extensions I use routinely. How will a new user appreciate our Ferrari when we give it to them without paint, headlights, or seats? Maybe we can have something like Edgar's FunSqueak, with all the cool IDE features, be the default download, but then, if we're not all using that image, we may commit a sin similar Marcus' repeated warning that "the artefact on the build server needs to be the artefact of release" of using a different image than we release...
----- Cheers, Sean -- View this message in context: http://forum.world.st/QualityAssistant-v0-4-tp4821070p4821265.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Hola, It looks like a really cool tool! I just added it to my LRP development image and I plan on using it full time. I am always interested in writing cleaner code. So expect comments from me :-) Actually I already have one: For one class I got the critic âReferences an abstract classâ and 'Subclass responsibility not definedâ. Excellent that you found it, but now I have to go through all the methods of the class to see where the first critic comes from, and through all methods of all leaf classes for the second one. :-( :-( :-( Thatâs a lot of work for me to rescue some information which apparently the tool already knows. Please add more information on where the issue is on these kinds of errors, so I can fix them more easily ... Thanks and keep up the good work!
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
Have a nice week! Uko
<critics.jpg> _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
---> Save our in-boxes! http://emailcharter.org <--- Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile
On 22 Apr 2015, at 15:59, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
Hola,
It looks like a really cool tool! I just added it to my LRP development image and I plan on using it full time. I am always interested in writing cleaner code.
Thanks :)
So expect comments from me :-) Actually I already have one:
For one class I got the critic âReferences an abstract classâ and 'Subclass responsibility not definedâ. Excellent that you found it, but now I have to go through all the methods of the class to see where the first critic comes from, and through all methods of all leaf classes for the second one. :-( :-( :-( Thatâs a lot of work for me to rescue some information which apparently the tool already knows. Please add more information on where the issue is on these kinds of errors, so I can fix them more easily â¦
Yes, this is the major issue with SmallLint. If you are interested in details here it goes: for example "References an abstract classâ is defined to work on a class, and itâs definitely easier to check whether the class is abstract and has any references than taking a method getting all class references and checking is any class is abstract. But as the result you get a critic about the class and not about the methods that access it. Right now Iâm analyzing Small Lint rules to see what issues they have and understanding how to approach the problem. Maybe some temporary hack will be possible for certain rules, otherwise it will be fixed when I get to improving the Small Lint. Nevertheless your feedback is very important, as I get to know what the real issues are. Cheers, Uko
Thanks and keep up the good work!
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote:
Hi everyone!
Probably most of you know, that I am developing a tool called QualityAssistant, which displays current critics about your code in SystemBrowser, Inspector and Spotter.
Iâm happy to tell you that there is a new release v0.4 which does not require you to do any previous setup! Just load it from configuration browser (pharo 4 & 5) and it will start giving you feedback. More details can be found here: https://github.com/Uko/QualityAssistant#quality-assistant-beta- <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you are upgrading from older version, it is recommended to load QualityAssistant into a fresh image, because multiple announcement and process changes may cause exceptions in old objects.
Even if you are an experienced programmer you can find QualityAssistant useful for instantly spotting typos or making sure that you didnât forget some details about your code.
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
Have a nice week! Uko
<critics.jpg> _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch <mailto:Moose-dev@iam.unibe.ch> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
---> Save our in-boxes! http://emailcharter.org <http://emailcharter.org/> <---
Johan Fabry - http://pleiad.cl/~jfabry <http://pleiad.cl/~jfabry> PLEIAD lab - Computer Science Department (DCC) - University of Chile
Yuriy this is excellent because it will force us to have - better rules - rules with as many as automatic transformations as possible :) Excellent job. Stef
Some weird behavior in quality assistant. Have a look at this method: duplicateVar: aVarName self show: 'Var: ', aVarName, ' redefinition ignored'. This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result: duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored' Needless to say, thatâs not a behavior preserving transformation.
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
---> Save our in-boxes! http://emailcharter.org <--- Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile
Good point, this brings up two problems. 1) The rule can improve detection by checking the type is the message is sent to self 2) Automatic fixing should display the changes and letting you decide whether you want to apply them. 1st will take some time. 2nd will be soon in QA :) Uko
On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
Some weird behavior in quality assistant. Have a look at this method:
duplicateVar: aVarName
self show: 'Var: ', aVarName, ' redefinition ignored'.
This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result:
duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored'
Needless to say, thatâs not a behavior preserving transformation.
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote:
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
---> Save our in-boxes! http://emailcharter.org <http://emailcharter.org/> <---
Johan Fabry - http://pleiad.cl/~jfabry <http://pleiad.cl/~jfabry> PLEIAD lab - Computer Science Department (DCC) - University of Chile
Hi ! Your quality assistant say to me "repeated method in the superclass" (If a class is overriding a method, it should use a different code. Is meaningless to have a method in a class and in its superclass) but i've 3 methods into my class and all overrides a method with "^ shouldBeImplemented" in the superclass. I think something is wrong with this warning :) On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Good point, this brings up two problems.
1) The rule can improve detection by checking the type is the message is sent to self 2) Automatic fixing should display the changes and letting you decide whether you want to apply them.
1st will take some time. 2nd will be soon in QA :)
Uko
On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
Some weird behavior in quality assistant. Have a look at this method:
duplicateVar: aVarName
self show: 'Var: ', aVarName, ' redefinition ignored'.
This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result:
duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored'
Needless to say, thatâs not a behavior preserving transformation.
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues
---> Save our in-boxes! http://emailcharter.org <---
Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile
-- Cheers Cyril Ferlicot
Hi, thank you for reporting. Can you tell me on which project are you running it, or file out the hierarchy so I can reproduce it? Uko
On 22 Apr 2015, at 18:06, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
Hi ! Your quality assistant say to me "repeated method in the superclass" (If a class is overriding a method, it should use a different code. Is meaningless to have a method in a class and in its superclass) but i've 3 methods into my class and all overrides a method with "^ shouldBeImplemented" in the superclass. I think something is wrong with this warning :)
On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Good point, this brings up two problems.
1) The rule can improve detection by checking the type is the message is sent to self 2) Automatic fixing should display the changes and letting you decide whether you want to apply them.
1st will take some time. 2nd will be soon in QA :)
Uko
On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
Some weird behavior in quality assistant. Have a look at this method:
duplicateVar: aVarName
self show: 'Var: ', aVarName, ' redefinition ignored'.
This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result:
duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored'
Needless to say, thatâs not a behavior preserving transformation.
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues
---> Save our in-boxes! http://emailcharter.org <---
Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile
-- Cheers Cyril Ferlicot
I lose the class but i found an other one with that problem :D Into Pillar, inside the Pillar-Model package you have the class PRFileInclusion with only 3 methods: PRFileInclusion>>#aboutClass ^ PRInputFileAnnotation PRTransformerWithoutUselessParagraph>>#aboutClass ^ self shouldBeImplemented ____________________________________ PRFileInclusion>>#specificVisitor: anInputFileAnnotation ^ self visitInputFileAnnotation: anInputFileAnnotation PRTransformerWithoutUselessParagraph>>#specificVisitor: something ^ self shouldBeImplemented _____________________________________ PRFileInclusion>>#visitInputFileAnnotation: anInputFileAnnotation "I load the file and if the file exist I replace the node of the annotation by the content of the file." | file | file := anInputFileAnnotation fileWithConfiguration: self configuration. file exists ifTrue: [ | parsedFile | parsedFile := anInputFileAnnotation parseFile: file withConfiguration: self configuration. self replace: parsedFile children] ifFalse: [ anInputFileAnnotation errorFileNotFound: file ] PRVisitor>>#visitInputFileAnnotation: anInputFileAnnotation self visitAnnotation: anInputFileAnnotation http://puu.sh/hnODJ/6595a1cdb6.jpg On 23 April 2015 at 08:40, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Hi,
thank you for reporting. Can you tell me on which project are you running it, or file out the hierarchy so I can reproduce it?
Uko
On 22 Apr 2015, at 18:06, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
Hi ! Your quality assistant say to me "repeated method in the superclass" (If a class is overriding a method, it should use a different code. Is meaningless to have a method in a class and in its superclass) but i've 3 methods into my class and all overrides a method with "^ shouldBeImplemented" in the superclass. I think something is wrong with this warning :)
On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Good point, this brings up two problems.
1) The rule can improve detection by checking the type is the message is sent to self 2) Automatic fixing should display the changes and letting you decide whether you want to apply them.
1st will take some time. 2nd will be soon in QA :)
Uko
On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
Some weird behavior in quality assistant. Have a look at this method:
duplicateVar: aVarName
self show: 'Var: ', aVarName, ' redefinition ignored'.
This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result:
duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored'
Needless to say, thatâs not a behavior preserving transformation.
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues
---> Save our in-boxes! http://emailcharter.org <---
Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile
-- Cheers Cyril Ferlicot
-- Cheers Cyril Ferlicot
Making code critics more visible --> expect a flood of opinions about the usefulness of rules and what they mean, and Uko should not be responsible for all of them :) This is an area where gathering usage statistics (similar to Spotter) might be very useful - if there was some way to record which rules people have issues with. cheers -ben On Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
Hi ! Your quality assistant say to me "repeated method in the superclass" (If a class is overriding a method, it should use a different code. Is meaningless to have a method in a class and in its superclass) but i've 3 methods into my class and all overrides a method with "^ shouldBeImplemented" in the superclass. I think something is wrong with this warning :)
On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Good point, this brings up two problems.
1) The rule can improve detection by checking the type is the message is sent to self 2) Automatic fixing should display the changes and letting you decide whether you want to apply them.
1st will take some time. 2nd will be soon in QA :)
Uko
On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
Some weird behavior in quality assistant. Have a look at this method:
duplicateVar: aVarName
self show: 'Var: ', aVarName, ' redefinition ignored'.
This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result:
duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored'
Needless to say, thatâs not a behavior preserving transformation.
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues
---> Save our in-boxes! http://emailcharter.org <---
Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile
-- Cheers Cyril Ferlicot
It is coming ;)
On 23 Apr 2015, at 18:57, Ben Coman <btc@openinworld.com> wrote:
Making code critics more visible --> expect a flood of opinions about the usefulness of rules and what they mean, and Uko should not be responsible for all of them :) This is an area where gathering usage statistics (similar to Spotter) might be very useful - if there was some way to record which rules people have issues with. cheers -ben
On Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot <cyril.ferlicot@gmail.com <mailto:cyril.ferlicot@gmail.com>> wrote: Hi ! Your quality assistant say to me "repeated method in the superclass" (If a class is overriding a method, it should use a different code. Is meaningless to have a method in a class and in its superclass) but i've 3 methods into my class and all overrides a method with "^ shouldBeImplemented" in the superclass. I think something is wrong with this warning :)
On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote:
Good point, this brings up two problems.
1) The rule can improve detection by checking the type is the message is sent to self 2) Automatic fixing should display the changes and letting you decide whether you want to apply them.
1st will take some time. 2nd will be soon in QA :)
Uko
On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl <mailto:jfabry@dcc.uchile.cl>> wrote:
Some weird behavior in quality assistant. Have a look at this method:
duplicateVar: aVarName
self show: 'Var: ', aVarName, ' redefinition ignored'.
This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result:
duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored'
Needless to say, thatâs not a behavior preserving transformation.
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote:
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues>
---> Save our in-boxes! http://emailcharter.org <http://emailcharter.org/> <---
Johan Fabry - http://pleiad.cl/~jfabry <http://pleiad.cl/~jfabry> PLEIAD lab - Computer Science Department (DCC) - University of Chile
-- Cheers Cyril Ferlicot
Thank you Yuiry. Super cool. I have just start migrating my client app to 4.0 and start using it full day long. And the first thing I did (after setting dark theme) is to load this tool. I also agree with the rest that I don't see much of a difference regarding modularity whether this tool is loaded in the image by default or not. On the contrary, whether it can be cleanly unloaded or not, which are and how managed are the dependencies etc, does refer to modularity. But that's my opinion only. Cheers, On Thu, Apr 23, 2015 at 2:51 PM, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
It is coming ;)
On 23 Apr 2015, at 18:57, Ben Coman <btc@openinworld.com> wrote:
Making code critics more visible --> expect a flood of opinions about the usefulness of rules and what they mean, and Uko should not be responsible for all of them :) This is an area where gathering usage statistics (similar to Spotter) might be very useful - if there was some way to record which rules people have issues with. cheers -ben
On Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot <cyril.ferlicot@gmail.com
wrote:
Hi ! Your quality assistant say to me "repeated method in the superclass" (If a class is overriding a method, it should use a different code. Is meaningless to have a method in a class and in its superclass) but i've 3 methods into my class and all overrides a method with "^ shouldBeImplemented" in the superclass. I think something is wrong with this warning :)
On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Good point, this brings up two problems.
1) The rule can improve detection by checking the type is the message is sent to self 2) Automatic fixing should display the changes and letting you decide whether you want to apply them.
1st will take some time. 2nd will be soon in QA :)
Uko
On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
Some weird behavior in quality assistant. Have a look at this method:
duplicateVar: aVarName
self show: 'Var: ', aVarName, ' redefinition ignored'.
This raises the issue: âUse cascaded nextPutAll:âs instead of #, in nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result:
duplicateVar: aVarName self show: 'Var: ' , aVarName; show: ' redefinition ignored'
Needless to say, thatâs not a behavior preserving transformation.
On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues
---> Save our in-boxes! http://emailcharter.org <---
Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile
-- Cheers Cyril Ferlicot
-- Mariano http://marianopeck.wordpress.com
Le 23/4/15 19:57, Ben Coman a écrit :
Making code critics more visible --> expect a flood of opinions about the usefulness of rules and what they mean, and Uko should not be responsible for all of them :) This is an area where gathering usage statistics (similar to Spotter) might be very useful - if there was some way to record which rules people have issues with. This was planned :) I envisioned that and we brainstorm with Yko around 8 months ago :).
Stef
cheers -ben
On Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot <cyril.ferlicot@gmail.com <mailto:cyril.ferlicot@gmail.com>> wrote:
Hi ! Your quality assistant say to me "repeated method in the superclass" (If a class is overriding a method, it should use a different code. Is meaningless to have a method in a class and in its superclass) but i've 3 methods into my class and all overrides a method with "^ shouldBeImplemented" in the superclass. I think something is wrong with this warning :)
On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote: > Good point, this brings up two problems. > > 1) The rule can improve detection by checking the type is the message is > sent to self > 2) Automatic fixing should display the changes and letting you decide > whether you want to apply them. > > 1st will take some time. 2nd will be soon in QA :) > > Uko > > > On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl <mailto:jfabry@dcc.uchile.cl>> wrote: > > Some weird behavior in quality assistant. Have a look at this method: > > duplicateVar: aVarName > > self show: 'Var: ', aVarName, ' redefinition ignored'. > > This raises the issue: âUse cascaded nextPutAll:âs instead of #, in > nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it > to see how it would transform the code. Result: > > duplicateVar: aVarName > self > show: 'Var: ' , aVarName; > show: ' redefinition ignored' > > Needless to say, thatâs not a behavior preserving transformation. > > > On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com <mailto:yuriy.tymchuk@me.com>> wrote: > > Please give me a feedback about your experience, as I want to make it even > more useful. Either write me an email, or open an entry at: > https://github.com/Uko/QualityAssistant/issues > > > > > ---> Save our in-boxes! http://emailcharter.org <--- > > Johan Fabry - http://pleiad.cl/~jfabry <http://pleiad.cl/%7Ejfabry> > PLEIAD lab - Computer Science Department (DCC) - University of Chile > >
-- Cheers Cyril Ferlicot
participants (13)
-
Ben Coman -
Cyril Ferlicot -
Damien Cassou -
Esteban Lorenzano -
Fabrizio Perin -
Johan Fabry -
kilon alios -
Marcus Denker -
Mariano Martinez Peck -
Sean P. DeNigris -
stepharo -
Tudor Girba -
Yuriy Tymchuk