On 23 Apr 2015, at 18:57, Ben Coman <btc@openinworld.com> wrote:Making code critics more visible --> expect a flood of opinions about the usefulness of rules and what they mean, and Uko should not be responsible for all of them :) This is an area where gathering usage statistics (similar to Spotter) might be very useful - if there was some way to record which rules people have issues with.cheers -benOn Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:Hi !
Your quality assistant say to me "repeated method in the superclass"
(If a class is overriding a method, it should use a different code. Is
meaningless to have a method in a class and in its superclass) but
i've 3 methods into my class and all overrides a method with "^
shouldBeImplemented" in the superclass.
I think something is wrong with this warning :)
--
On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
> Good point, this brings up two problems.
>
> 1) The rule can improve detection by checking the type is the message is
> sent to self
> 2) Automatic fixing should display the changes and letting you decide
> whether you want to apply them.
>
> 1st will take some time. 2nd will be soon in QA :)
>
> Uko
>
>
> On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
>
> Some weird behavior in quality assistant. Have a look at this method:
>
> duplicateVar: aVarName
>
> self show: 'Var: ', aVarName, ' redefinition ignored'.
>
> This raises the issue: ���Use cascaded nextPutAll:���s instead of #, in
> nextPutAll:��� It also pops up the automatic rewrite icon, so I clicked on it
> to see how it would transform the code. Result:
>
> duplicateVar: aVarName
> self
> show: 'Var: ' , aVarName;
> show: ' redefinition ignored'
>
> Needless to say, that���s not a behavior preserving transformation.
>
>
> On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
>
> Please give me a feedback about your experience, as I want to make it even
> more useful. Either write me an email, or open an entry at:
> https://github.com/Uko/QualityAssistant/issues
>
>
>
>
> ---> Save our in-boxes! http://emailcharter.org <---
>
> Johan Fabry - http://pleiad.cl/~jfabry
> PLEIAD lab - Computer Science Department (DCC) - University of Chile
>
>
Cheers
Cyril Ferlicot