Good point, this brings up two problems.

1) The rule can improve detection by checking the type is the message is sent to self
2) Automatic fixing should display the changes and letting you decide whether you want to apply them.

1st will take some time. 2nd will be soon in QA :)

Uko

On 22 Apr 2015, at 16:33, Johan Fabry <jfabry@dcc.uchile.cl> wrote:

Some weird behavior in quality assistant. Have a look at this method:

duplicateVar: aVarName 

self show: 'Var: ', aVarName, ' redefinition ignored'.

This raises the issue: ���Use cascaded nextPutAll:���s instead of #, in nextPutAll:��� It also pops up the automatic rewrite icon, so I clicked on it to see how it would transform the code. Result:

duplicateVar: aVarName
self
show: 'Var: ' , aVarName;
show: ' redefinition ignored'

Needless to say, that���s not a behavior preserving transformation.


On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:

Please give me a feedback about your experience, as I want to make it even more useful. Either write me an email, or open an entry at: https://github.com/Uko/QualityAssistant/issues



---> Save our in-boxes! http://emailcharter.org <---

Johan Fabry   -   http://pleiad.cl/~jfabry
PLEIAD lab  -  Computer Science Department (DCC)  -  University of Chile