Re: [Pharo-dev] Call for test: Dark Theme now ready (?) for integration

May 15, 2014


      no, noâ¦ is the same. You still need to merge :)
But if we have a âgood to goâ the idea is to integrate it.

Esteban 

On 15 May 2014, at 18:15, kilon alios <kilon.alios@gmail.com> wrote:
...
is the installation procedure exactly the same ? Do we still need to merge ?
this is what I use for installation
â1. You need this because otherwise Gofer merge becomes dumb :P"
MCRepositoryGroup default 
    addRepository: (MCSmalltalkhubRepository 
        owner: 'estebanlm' 
        project: 'Pharo3DarkTheme').
â2. Now we can actually MERGE the project"
Gofer it 
    smalltalkhubUser: 'estebanlm' project: 'Pharo3DarkTheme';
    package: 'Pharo3DarkTheme';
    merge.
â3. And then install it"
Pharo3DarkTheme installFullTheme.
On Thu, May 15, 2014 at 7:07 PM, Esteban Lorenzano <estebanlm@gmail.com> wrote:
Hi,
So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows).
How it works now?
- I removed tons and tons of hardcoded colors all around image
- I redirected defaults to values in theme
- I fixed some buggy places
So now it should be clean to include it in debut pharo4 (and maybe backport to pharo3, right now is not a problem).
But I would want you to test it to be sure that is not breaking anything.
thanks,
Esteban