Call for test: Dark Theme now ready (?) for integration
Hi, So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows). How it works now? - I removed tons and tons of hardcoded colors all around image - I redirected defaults to values in theme - I fixed some buggy places So now it should be clean to include it in debut pharo4 (and maybe backport to pharo3, right now is not a problem). But I would want you to test it to be sure that is not breaking anything. thanks, Esteban
So I load as I loaded the previous on Pharo 3, but this time no merge will be required? Regards! Esteban A. Maringolo 2014-05-15 13:07 GMT-03:00 Esteban Lorenzano <estebanlm@gmail.com>:
Hi,
So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows). How it works now?
- I removed tons and tons of hardcoded colors all around image - I redirected defaults to values in theme - I fixed some buggy places
So now it should be clean to include it in debut pharo4 (and maybe backport to pharo3, right now is not a problem). But I would want you to test it to be sure that is not breaking anything.
thanks, Esteban
2014-05-15 18:13 GMT+02:00 Esteban A. Maringolo <emaringolo@gmail.com>:
So I load as I loaded the previous on Pharo 3, but this time no merge will be required?
This time there weren't merge conflicts, if that's what you mean for "no merge required" Esteban, is that part of the fix? (Thanks if it is :D )
Regards! Esteban A. Maringolo
2014-05-15 13:07 GMT-03:00 Esteban Lorenzano <estebanlm@gmail.com>:
Hi,
So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows). How it works now?
- I removed tons and tons of hardcoded colors all around image - I redirected defaults to values in theme - I fixed some buggy places
So now it should be clean to include it in debut pharo4 (and maybe backport to pharo3, right now is not a problem). But I would want you to test it to be sure that is not breaking anything.
thanks, Esteban
is the installation procedure exactly the same ? Do we still need to merge ? this is what I use for installation â1. You need this because otherwise Gofer merge becomes dumb :P" MCRepositoryGroup default addRepository: (MCSmalltalkhubRepository owner: 'estebanlm' project: 'Pharo3DarkTheme'). â2. Now we can actually MERGE the project" Gofer it smalltalkhubUser: 'estebanlm' project: 'Pharo3DarkTheme'; package: 'Pharo3DarkTheme'; merge. â3. And then install it" Pharo3DarkTheme installFullTheme. On Thu, May 15, 2014 at 7:07 PM, Esteban Lorenzano <estebanlm@gmail.com>wrote:
Hi,
So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows). How it works now?
- I removed tons and tons of hardcoded colors all around image - I redirected defaults to values in theme - I fixed some buggy places
So now it should be clean to include it in debut pharo4 (and maybe backport to pharo3, right now is not a problem). But I would want you to test it to be sure that is not breaking anything.
thanks, Esteban
no, no⦠is the same. You still need to merge :) But if we have a âgood to goâ the idea is to integrate it. Esteban On 15 May 2014, at 18:15, kilon alios <kilon.alios@gmail.com> wrote:
is the installation procedure exactly the same ? Do we still need to merge ?
this is what I use for installation
â1. You need this because otherwise Gofer merge becomes dumb :P" MCRepositoryGroup default addRepository: (MCSmalltalkhubRepository owner: 'estebanlm' project: 'Pharo3DarkTheme'). â2. Now we can actually MERGE the project" Gofer it smalltalkhubUser: 'estebanlm' project: 'Pharo3DarkTheme'; package: 'Pharo3DarkTheme'; merge. â3. And then install it" Pharo3DarkTheme installFullTheme.
On Thu, May 15, 2014 at 7:07 PM, Esteban Lorenzano <estebanlm@gmail.com> wrote: Hi,
So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows). How it works now?
- I removed tons and tons of hardcoded colors all around image - I redirected defaults to values in theme - I fixed some buggy places
So now it should be clean to include it in debut pharo4 (and maybe backport to pharo3, right now is not a problem). But I would want you to test it to be sure that is not breaking anything.
thanks, Esteban
Did you fix the DiffMorph colors? The colorForType: thing. Le 15 mai 2014 18:20, "Esteban Lorenzano" <estebanlm@gmail.com> a écrit :
no, no⦠is the same. You still need to merge :) But if we have a âgood to goâ the idea is to integrate it.
Esteban
On 15 May 2014, at 18:15, kilon alios <kilon.alios@gmail.com> wrote:
is the installation procedure exactly the same ? Do we still need to merge ?
this is what I use for installation
â1. You need this because otherwise Gofer merge becomes dumb :P" MCRepositoryGroup default addRepository: (MCSmalltalkhubRepository owner: 'estebanlm' project: 'Pharo3DarkTheme'). â2. Now we can actually MERGE the project" Gofer it smalltalkhubUser: 'estebanlm' project: 'Pharo3DarkTheme'; package: 'Pharo3DarkTheme'; merge. â3. And then install it" Pharo3DarkTheme installFullTheme.
On Thu, May 15, 2014 at 7:07 PM, Esteban Lorenzano <estebanlm@gmail.com>wrote:
Hi,
So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows). How it works now?
- I removed tons and tons of hardcoded colors all around image - I redirected defaults to values in theme - I fixed some buggy places
So now it should be clean to include it in debut pharo4 (and maybe backport to pharo3, right now is not a problem). But I would want you to test it to be sure that is not breaking anything.
thanks, Esteban
On 15 May 2014, at 18:24, phil@highoctane.be wrote:
Did you fix the DiffMorph colors?
a bit⦠I think there is still a need to work there, but now at least you can see the changes :) Esteban
The colorForType: thing. Le 15 mai 2014 18:20, "Esteban Lorenzano" <estebanlm@gmail.com> a écrit : no, no⦠is the same. You still need to merge :) But if we have a âgood to goâ the idea is to integrate it.
Esteban
On 15 May 2014, at 18:15, kilon alios <kilon.alios@gmail.com> wrote:
is the installation procedure exactly the same ? Do we still need to merge ?
this is what I use for installation
â1. You need this because otherwise Gofer merge becomes dumb :P" MCRepositoryGroup default addRepository: (MCSmalltalkhubRepository owner: 'estebanlm' project: 'Pharo3DarkTheme'). â2. Now we can actually MERGE the project" Gofer it smalltalkhubUser: 'estebanlm' project: 'Pharo3DarkTheme'; package: 'Pharo3DarkTheme'; merge. â3. And then install it" Pharo3DarkTheme installFullTheme.
On Thu, May 15, 2014 at 7:07 PM, Esteban Lorenzano <estebanlm@gmail.com> wrote: Hi,
So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows). How it works now?
- I removed tons and tons of hardcoded colors all around image - I redirected defaults to values in theme - I fixed some buggy places
So now it should be clean to include it in debut pharo4 (and maybe backport to pharo3, right now is not a problem). But I would want you to test it to be sure that is not breaking anything.
thanks, Esteban
participants (5)
-
Clara Allende -
Esteban A. Maringolo -
Esteban Lorenzano -
kilon alios -
phil＠highoctane.be