On 10 Nov 2014, at 15:45, stepharo <stepharo@free.fr> wrote:
I do not understand? did you change self theme by the Smalltalk ui theme in the class? I do not see why this is an improvement.
yea⦠I wanted to normally move the whole class somewhere else, but then I stopped and just committed what I had. I did the #theme thing because it looks so ugly to have #theme implemented everywhere (we have 33 implementors! 33!!) and I just saw two senders in this class⦠All the Theme stuff is so uglyâ¦
May be changing theme UIManager default theme
by theme ^ Smalltalk ui theme
is better but not expanding all the self theme with this expression Because we do not know in the future how the theme will be implemented in the future.
Stef
On 10/11/14 14:46, Marcus Denker wrote:
On 10 Nov 2014, at 14:18, kilon alios <kilon.alios@gmail.com> wrote:
looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this
Oh, I missed call in fontSizeRow⦠I thought I tested it. I will fix it... (Hint: I always wait for people to review my changes⦠but that does not happen very often)
Marcus