Who broke my System Preferences ?
looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this GraphicFontSettings class(Object)>>doesNotUnderstand: #theme GraphicFontSettings class>>fontSizeRow [ self fontSizeRow ] in GraphicFontSettings class>>standardFontsSettingsOn: in Block: [ self fontSizeRow ] PragmaSetting>>inputWidget PragmaSetting>>inputMorphFor: SettingNode>>inputMorphFor: [ :node :cont | node perform: self rowMorphGetSelector with: self container ] in MorphTreeColumn>>rowMorphGetterBlock in Block: [ :node :cont | node perform: self rowMorphGetSele...etc... MorphTreeColumn>>rowMorphFor: [ :col | | v | v := col rowMorphFor: complexContents. controls add: v. col -> v ] in MorphTreeNodeMorph>>buildRowMorph in Block: [ :col | ... OrderedCollection>>collect: MorphTreeNodeMorph>>buildRowMorph MorphTreeNodeMorph>>initRow MorphTreeNodeMorph>>initWithContents:prior:forList:indentLevel: [ :item | priorMorph := self indentingItemClass new initWithContents: item prior: priorMorph forList: self indentLevel: parentMorph indentLevel + 1. morphList add: priorMorph. "Was this row expanded ? if true -> expand it again " priorMorph isExpanded ifTrue: [ priorMorph isExpanded: true. priorMorph addChildrenForList: self addingTo: morphList withExpandedItems: #() ] ] in MorphTreeMorph>>addMorphsAfter:fromCollection: in Block: [ :item | ... OrderedCollection>>do: MorphTreeMorph>>addMorphsAfter:fromCollection: MorphTreeNodeMorph>>expand MorphTreeNodeMorph>>toggleExpandedState MorphTreeMorph>>toggleExpandedState:event: MorphTreeMorph>>mouseDown: MorphTreeMorph(Morph)>>handleMouseDown: MouseButtonEvent>>sentTo: MorphTreeMorph(Morph)>>handleEvent: MorphicEventDispatcher>>dispatchMouseDown:with: MorphicEventDispatcher>>dispatchEvent:with: MorphTreeMorph(Morph)>>processEvent:using: MorphicEventDispatcher>>dispatchMouseDown:with: MorphicEventDispatcher>>dispatchEvent:with: StandardWindow(Morph)>>processEvent:using: MorphicEventDispatcher>>dispatchMouseDown:with:
On 10 Nov 2014, at 14:18, kilon alios <kilon.alios@gmail.com> wrote:
looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this
Oh, I missed call in fontSizeRow⦠I thought I tested it. I will fix it... (Hint: I always wait for people to review my changes⦠but that does not happen very often) Marcus
Marcus people are busy and we should let a chance to theme. What was the problem with theme in Settings. For example I was discussing with alain about the MouseOverHandler removal and it is not clear. Morphic and UI is complex so we should go slowly. Stef On 10/11/14 14:46, Marcus Denker wrote:
On 10 Nov 2014, at 14:18, kilon alios <kilon.alios@gmail.com> wrote:
looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this
Oh, I missed call in fontSizeRow⦠I thought I tested it. I will fix it... (Hint: I always wait for people to review my changes⦠but that does not happen very often)
Marcus
I do not understand? did you change self theme by the Smalltalk ui theme in the class? I do not see why this is an improvement. May be changing theme UIManager default theme by theme ^ Smalltalk ui theme is better but not expanding all the self theme with this expression Because we do not know in the future how the theme will be implemented in the future. Stef On 10/11/14 14:46, Marcus Denker wrote:
On 10 Nov 2014, at 14:18, kilon alios <kilon.alios@gmail.com> wrote:
looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this
Oh, I missed call in fontSizeRow⦠I thought I tested it. I will fix it... (Hint: I always wait for people to review my changes⦠but that does not happen very often)
Marcus
On 10 Nov 2014, at 15:45, stepharo <stepharo@free.fr> wrote:
I do not understand? did you change self theme by the Smalltalk ui theme in the class? I do not see why this is an improvement.
yea⦠I wanted to normally move the whole class somewhere else, but then I stopped and just committed what I had. I did the #theme thing because it looks so ugly to have #theme implemented everywhere (we have 33 implementors! 33!!) and I just saw two senders in this class⦠All the Theme stuff is so uglyâ¦
May be changing theme UIManager default theme
by theme ^ Smalltalk ui theme
is better but not expanding all the self theme with this expression Because we do not know in the future how the theme will be implemented in the future.
Stef
On 10/11/14 14:46, Marcus Denker wrote:
On 10 Nov 2014, at 14:18, kilon alios <kilon.alios@gmail.com> wrote:
looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this
Oh, I missed call in fontSizeRow⦠I thought I tested it. I will fix it... (Hint: I always wait for people to review my changes⦠but that does not happen very often)
Marcus
yea⦠I wanted to normally move the whole class somewhere else, but then I stopped and just committed what I had.
I did the #theme thing because it looks so ugly to have #theme implemented everywhere (we have 33 implementors! 33!!) and I just saw two senders in this classâ¦
All the Theme stuff is so uglyâ¦
Yes but let it like that for the moment. I would prefer that you push OPAL because we need a strong OPAL + slot + reflectivity for the future. Stef
May be changing theme UIManager default theme
by theme ^ Smalltalk ui theme
is better but not expanding all the self theme with this expression Because we do not know in the future how the theme will be implemented in the future.
Stef
On 10/11/14 14:46, Marcus Denker wrote:
On 10 Nov 2014, at 14:18, kilon alios <kilon.alios@gmail.com> wrote:
looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this
Oh, I missed call in fontSizeRow⦠I thought I tested it. I will fix it... (Hint: I always wait for people to review my changes⦠but that does not happen very often)
Marcus
no worries I would not even dream to blame you and yes I completely agree that you did not need to wait for a review ,after all its not that much of a big deal to ping the mailing list as I did and you fixing it at your own pace , I can always use an older build at any time. The Theme classes is kinda strange, I think that Pharo needs a standard on theme support and that standard must be deeply rooted inside Morphic so that each morph implements its own theme support. Of course for that the community will need to sit down and agree what that standard must be or else you will see theme classes popping around like mushrooms. On Mon, Nov 10, 2014 at 3:46 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
On 10 Nov 2014, at 14:18, kilon alios <kilon.alios@gmail.com> wrote:
looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this
Oh, I missed call in fontSizeRow⦠I thought I tested it. I will fix it... (Hint: I always wait for people to review my changes⦠but that does not happen very often)
Marcus
The theme design is ot good but getting a good one is difficult. I did some prototype to get a feel of the work to be done but this is still unclear to me. I want to see how we could do that with Bloc. Stef On 10/11/14 16:00, kilon alios wrote:
no worries I would not even dream to blame you and yes I completely agree that you did not need to wait for a review ,after all its not that much of a big deal to ping the mailing list as I did and you fixing it at your own pace , I can always use an older build at any time.
The Theme classes is kinda strange, I think that Pharo needs a standard on theme support and that standard must be deeply rooted inside Morphic so that each morph implements its own theme support. Of course for that the community will need to sit down and agree what that standard must be or else you will see theme classes popping around like mushrooms.
On Mon, Nov 10, 2014 at 3:46 PM, Marcus Denker <marcus.denker@inria.fr <mailto:marcus.denker@inria.fr>> wrote:
> On 10 Nov 2014, at 14:18, kilon alios <kilon.alios@gmail.com <mailto:kilon.alios@gmail.com>> wrote: > > looks like latest Pharo 4 40363 broke System Preferences clicking on Appearance gives me this >
Oh, I missed call in fontSizeRow⦠I thought I tested it. I will fix it... (Hint: I always wait for people to review my changes⦠but that does not happen very often)
Marcus
participants (3)
-
kilon alios -
Marcus Denker -
stepharo