Hi Henrik, twice you write a slip that the compiler should not allow: (map := characterToGlyphMap) ifNotNil: [:map | code := map at: code + 1]. code := (map := characterToGlyphMap) ifNil: [aCharacter charCode] ifNotNil: [:map | map at: aCharacter charCode + 1] these should read characterToGlyphMap ifNotNil: [:map | code := map at: code + 1]. code := characterToGlyphMap ifNil: [aCharacter charCode] ifNotNil: [:map | map at: aCharacter charCode + 1] HTH, Eliot also in BitBlt>>#primDisplayString:from:to:map:xTable:kern: you write ascii := glyphMap at: (aString at: charIndex) asciiValue + 1. whereas the current Squeak code reads ascii := (aString at: charIndex) asciiValue. glyphMap ifNotNil:[ascii := glyphMap at: ascii+1]. Should Squeak keep its original code (which seems equivalent) or is there a specific reason to eliminate the ifNotNil: test? TIA Eliot 2010/8/30 Henrik Sperre Johansen <henrik.s.johansen@veloxit.no>
On 30.08.2010 22:05, Nicolas Cellier wrote:
2010/8/30 Stéphane Ducasse<stephane.ducasse@inria.fr>:
On Aug 30, 2010, at 8:33 PM, Johan Brichau wrote:
so what did you do?
I see that the file got removed... I will submit a bug issue for that with the file attached.
The *real* problem is that you cannot remove it either! It does _not_ want to go away!
Oops! A bad spirit in pharo :)
Any person able to understand MultiDisplayScanner arcanes wouldn't see any magic in this. But I really wonder whether a single person can manage such complexity... Henrik ?
Nicolas
Hurr durr, I hate a challenge, can't really stop... In Pharo, the display primitive fails, and the fallback code does not deal correctly with the characterToGlyphMap used by StrikeFonts to store arrows at the normal ^_ spots, and substitute with characters at slots 128/129. In Squeak, the glyph-by-glyph rendering is encountered, and neither hasGlyphOf: nor glyphInfoInto: takes the map into account Attached is the fixed code for all three methods, should work in both Pharo and Squeak with these. (Issue 2886 on the Pharo tracker)
Cheers, Henry
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project