Marcus Denker wrote:
On 16 Nov 2014, at 16:47, Marcus Denker <marcus.denker@inria.fr <mailto:marcus.denker@inria.fr>> wrote:
On 16 Nov 2014, at 16:31, Marcus Denker <marcus.denker@inria.fr <mailto:marcus.denker@inria.fr>> wrote:
Log Message: ----------- 40371 14261 Delay refactoring (part 1) - move scheduler from class-side to instance-side of its own class https://pharo.fogbugz.com/f/cases/14261 http://files.pharo.org/image/40/40371.zip
Thanks very much for that, but it picked up the .4 slice rather than the .9 slice. Probably due to my changing the issue title half way through (sorry).
Ok, I will do a manual integration of .9.. good that it does not need a roll-back.
The result is that two tests are failing now in 372:
KernelTests.Processes.SemaphoreTest.testWaitAndWaitTimeoutTogether KernelTests.Processes.SemaphoreTest.testWaitTimeoutMSecs
And the step 3 is failing.
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-3-Minimal/223/
I give up for today.
I think we should revert both 372 and 371⦠but I will not do that today as this is sunday. (lesson learned: never ingrate if you canât spend 3 hoursâ¦)
Marcus
I can confirm those failing tests, in both slice.4 and slice.9, so strange they didn't chow up in the Validator report. Now if its less work, you can revert to the original code by doing "Delay newCodeEnabled: false", and both tests will pass. It late here, so I'll work on fixing those tests tomorrow. Thanks for your efforts. cheers -ben