[pharo-project/pharo-core] 0635d1: 40371
Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 0635d15a291debc0717b5f2711d3832e1a77f2e6 https://github.com/pharo-project/pharo-core/commit/0635d15a291debc0717b5f271... Author: Jenkins Build Server <board@pharo-project.org> Date: 2014-11-16 (Sun, 16 Nov 2014) Changed paths: M Kernel.package/Delay.class/README.md M Kernel.package/Delay.class/class/class initialization/initialize.st A Kernel.package/Delay.class/class/enable new code/newCodeEnabled.st A Kernel.package/Delay.class/class/enable new code/newCodeEnabled_.st M Kernel.package/Delay.class/class/snapshotting/restoreResumptionTimes.st M Kernel.package/Delay.class/class/snapshotting/saveResumptionTimes.st M Kernel.package/Delay.class/class/snapshotting/shutDown.st M Kernel.package/Delay.class/class/snapshotting/startUp.st M Kernel.package/Delay.class/class/testing/anyActive.st M Kernel.package/Delay.class/class/testing/nextWakeUpTime.st M Kernel.package/Delay.class/class/timer process/handleTimerEvent.st M Kernel.package/Delay.class/class/timer process/runTimerEventLoop.st M Kernel.package/Delay.class/class/timer process/scheduleDelay_.st M Kernel.package/Delay.class/class/timer process/schedulingProcess.st M Kernel.package/Delay.class/class/timer process/startTimerEventLoop.st A Kernel.package/Delay.class/class/timer process/startTimerEventLoop_.st M Kernel.package/Delay.class/class/timer process/stopTimerEventLoop.st M Kernel.package/Delay.class/class/timer process/unscheduleDelay_.st M Kernel.package/Delay.class/definition.st A Kernel.package/Delay.class/instance/enable new code/newCodeEnabled.st M Kernel.package/Delay.class/instance/private/schedule.st M Kernel.package/Delay.class/instance/private/unschedule.st A Kernel.package/DelayScheduler.class/README.md A Kernel.package/DelayScheduler.class/definition.st A Kernel.package/DelayScheduler.class/instance/class initialization/initialize.st A Kernel.package/DelayScheduler.class/instance/low priority processes/schedule_.st A Kernel.package/DelayScheduler.class/instance/low priority processes/unschedule_.st A Kernel.package/DelayScheduler.class/instance/primitives/primSignal_atMilliseconds_.st A Kernel.package/DelayScheduler.class/instance/snapshotting/restoreResumptionTimes.st A Kernel.package/DelayScheduler.class/instance/snapshotting/saveResumptionTimes.st A Kernel.package/DelayScheduler.class/instance/snapshotting/shutDown.st A Kernel.package/DelayScheduler.class/instance/snapshotting/startUp.st A Kernel.package/DelayScheduler.class/instance/testing/anyActive.st A Kernel.package/DelayScheduler.class/instance/testing/nextWakeUpTime.st A Kernel.package/DelayScheduler.class/instance/timer process/handleTimerEvent_.st A Kernel.package/DelayScheduler.class/instance/timer process/runTimerEventLoop.st A Kernel.package/DelayScheduler.class/instance/timer process/scheduleDelay_.st A Kernel.package/DelayScheduler.class/instance/timer process/schedulingProcess.st A Kernel.package/DelayScheduler.class/instance/timer process/startTimerEventLoop.st A Kernel.package/DelayScheduler.class/instance/timer process/startTimerEventLoop_.st A Kernel.package/DelayScheduler.class/instance/timer process/stopTimerEventLoop.st A Kernel.package/DelayScheduler.class/instance/timer process/unscheduleDelay_.st A KernelTests.package/DelayBenchmark.class/README.md A KernelTests.package/DelayBenchmark.class/class/action/run.st A KernelTests.package/DelayBenchmark.class/definition.st A KernelTests.package/DelayBenchmark.class/instance/action/run.st A KernelTests.package/DelayBenchmark.class/instance/support/generateDelayProcesses_priority_maxDuration_fromSeed_.st A KernelTests.package/DelayBenchmark.class/instance/support/trialConcurrent_priority_maxDuration_fromSeed_.st A KernelTests.package/DelaySchedulerTest.class/README.md A KernelTests.package/DelaySchedulerTest.class/definition.st A KernelTests.package/DelaySchedulerTest.class/instance/tests/testMaxTickLessThanDuration.st A KernelTests.package/DelaySchedulerTest.class/instance/tests/testMaxTickMoreThanDuration.st A KernelTests.package/extension/DelayScheduler/instance/testCaseSupportActiveDelay.st A KernelTests.package/extension/DelayScheduler/instance/testCaseSupportSetActiveDelayStartTime_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script371.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40371.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40371 14261 Delay refactoring (part 1) - move scheduler from class-side to instance-side of its own class https://pharo.fogbugz.com/f/cases/14261 http://files.pharo.org/image/40/40371.zip
GitHub wrote:
Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 0635d15a291debc0717b5f2711d3832e1a77f2e6 https://github.com/pharo-project/pharo-core/commit/0635d15a291debc0717b5f271... Author: Jenkins Build Server <board@pharo-project.org> Date: 2014-11-16 (Sun, 16 Nov 2014)
Changed paths: M Kernel.package/Delay.class/README.md M Kernel.package/Delay.class/class/class initialization/initialize.st A Kernel.package/Delay.class/class/enable new code/newCodeEnabled.st A Kernel.package/Delay.class/class/enable new code/newCodeEnabled_.st M Kernel.package/Delay.class/class/snapshotting/restoreResumptionTimes.st M Kernel.package/Delay.class/class/snapshotting/saveResumptionTimes.st M Kernel.package/Delay.class/class/snapshotting/shutDown.st M Kernel.package/Delay.class/class/snapshotting/startUp.st M Kernel.package/Delay.class/class/testing/anyActive.st M Kernel.package/Delay.class/class/testing/nextWakeUpTime.st M Kernel.package/Delay.class/class/timer process/handleTimerEvent.st M Kernel.package/Delay.class/class/timer process/runTimerEventLoop.st M Kernel.package/Delay.class/class/timer process/scheduleDelay_.st M Kernel.package/Delay.class/class/timer process/schedulingProcess.st M Kernel.package/Delay.class/class/timer process/startTimerEventLoop.st A Kernel.package/Delay.class/class/timer process/startTimerEventLoop_.st M Kernel.package/Delay.class/class/timer process/stopTimerEventLoop.st M Kernel.package/Delay.class/class/timer process/unscheduleDelay_.st M Kernel.package/Delay.class/definition.st A Kernel.package/Delay.class/instance/enable new code/newCodeEnabled.st M Kernel.package/Delay.class/instance/private/schedule.st M Kernel.package/Delay.class/instance/private/unschedule.st A Kernel.package/DelayScheduler.class/README.md A Kernel.package/DelayScheduler.class/definition.st A Kernel.package/DelayScheduler.class/instance/class initialization/initialize.st A Kernel.package/DelayScheduler.class/instance/low priority processes/schedule_.st A Kernel.package/DelayScheduler.class/instance/low priority processes/unschedule_.st A Kernel.package/DelayScheduler.class/instance/primitives/primSignal_atMilliseconds_.st A Kernel.package/DelayScheduler.class/instance/snapshotting/restoreResumptionTimes.st A Kernel.package/DelayScheduler.class/instance/snapshotting/saveResumptionTimes.st A Kernel.package/DelayScheduler.class/instance/snapshotting/shutDown.st A Kernel.package/DelayScheduler.class/instance/snapshotting/startUp.st A Kernel.package/DelayScheduler.class/instance/testing/anyActive.st A Kernel.package/DelayScheduler.class/instance/testing/nextWakeUpTime.st A Kernel.package/DelayScheduler.class/instance/timer process/handleTimerEvent_.st A Kernel.package/DelayScheduler.class/instance/timer process/runTimerEventLoop.st A Kernel.package/DelayScheduler.class/instance/timer process/scheduleDelay_.st A Kernel.package/DelayScheduler.class/instance/timer process/schedulingProcess.st A Kernel.package/DelayScheduler.class/instance/timer process/startTimerEventLoop.st A Kernel.package/DelayScheduler.class/instance/timer process/startTimerEventLoop_.st A Kernel.package/DelayScheduler.class/instance/timer process/stopTimerEventLoop.st A Kernel.package/DelayScheduler.class/instance/timer process/unscheduleDelay_.st A KernelTests.package/DelayBenchmark.class/README.md A KernelTests.package/DelayBenchmark.class/class/action/run.st A KernelTests.package/DelayBenchmark.class/definition.st A KernelTests.package/DelayBenchmark.class/instance/action/run.st A KernelTests.package/DelayBenchmark.class/instance/support/generateDelayProcesses_priority_maxDuration_fromSeed_.st A KernelTests.package/DelayBenchmark.class/instance/support/trialConcurrent_priority_maxDuration_fromSeed_.st A KernelTests.package/DelaySchedulerTest.class/README.md A KernelTests.package/DelaySchedulerTest.class/definition.st A KernelTests.package/DelaySchedulerTest.class/instance/tests/testMaxTickLessThanDuration.st A KernelTests.package/DelaySchedulerTest.class/instance/tests/testMaxTickMoreThanDuration.st A KernelTests.package/extension/DelayScheduler/instance/testCaseSupportActiveDelay.st A KernelTests.package/extension/DelayScheduler/instance/testCaseSupportSetActiveDelayStartTime_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script371.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40371.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
Log Message: ----------- 40371 14261 Delay refactoring (part 1) - move scheduler from class-side to instance-side of its own class https://pharo.fogbugz.com/f/cases/14261
Thanks very much for that, but it picked up the .4 slice rather than the .9 slice. Probably due to my changing the issue title half way through (sorry). -ben
Log Message: ----------- 40371 14261 Delay refactoring (part 1) - move scheduler from class-side to instance-side of its own class https://pharo.fogbugz.com/f/cases/14261 http://files.pharo.org/image/40/40371.zip
Thanks very much for that, but it picked up the .4 slice rather than the .9 slice. Probably due to my changing the issue title half way through (sorry).
Ok, I will do a manual integration of .9.. good that it does not need a roll-back. Marcus
On 16 Nov 2014, at 16:31, Marcus Denker <marcus.denker@inria.fr> wrote:
Log Message: ----------- 40371 14261 Delay refactoring (part 1) - move scheduler from class-side to instance-side of its own class https://pharo.fogbugz.com/f/cases/14261 http://files.pharo.org/image/40/40371.zip
Thanks very much for that, but it picked up the .4 slice rather than the .9 slice. Probably due to my changing the issue title half way through (sorry).
Ok, I will do a manual integration of .9.. good that it does not need a roll-back.
The result is that two tests are failing now in 372: KernelTests.Processes.SemaphoreTest.testWaitAndWaitTimeoutTogether KernelTests.Processes.SemaphoreTest.testWaitTimeoutMSecs Marcus
On 16 Nov 2014, at 16:47, Marcus Denker <marcus.denker@inria.fr> wrote:
On 16 Nov 2014, at 16:31, Marcus Denker <marcus.denker@inria.fr> wrote:
Log Message: ----------- 40371 14261 Delay refactoring (part 1) - move scheduler from class-side to instance-side of its own class https://pharo.fogbugz.com/f/cases/14261 http://files.pharo.org/image/40/40371.zip
Thanks very much for that, but it picked up the .4 slice rather than the .9 slice. Probably due to my changing the issue title half way through (sorry).
Ok, I will do a manual integration of .9.. good that it does not need a roll-back.
The result is that two tests are failing now in 372:
KernelTests.Processes.SemaphoreTest.testWaitAndWaitTimeoutTogether KernelTests.Processes.SemaphoreTest.testWaitTimeoutMSecs
And the step 3 is failing. https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-3-Minimal/223/ I give up for today. I think we should revert both 372 and 371⦠but I will not do that today as this is sunday. (lesson learned: never ingrate if you canât spend 3 hoursâ¦) Marcus
Marcus Denker wrote:
On 16 Nov 2014, at 16:47, Marcus Denker <marcus.denker@inria.fr <mailto:marcus.denker@inria.fr>> wrote:
On 16 Nov 2014, at 16:31, Marcus Denker <marcus.denker@inria.fr <mailto:marcus.denker@inria.fr>> wrote:
Log Message: ----------- 40371 14261 Delay refactoring (part 1) - move scheduler from class-side to instance-side of its own class https://pharo.fogbugz.com/f/cases/14261 http://files.pharo.org/image/40/40371.zip
Thanks very much for that, but it picked up the .4 slice rather than the .9 slice. Probably due to my changing the issue title half way through (sorry).
Ok, I will do a manual integration of .9.. good that it does not need a roll-back.
The result is that two tests are failing now in 372:
KernelTests.Processes.SemaphoreTest.testWaitAndWaitTimeoutTogether KernelTests.Processes.SemaphoreTest.testWaitTimeoutMSecs
And the step 3 is failing.
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-3-Minimal/223/
I give up for today.
I think we should revert both 372 and 371⦠but I will not do that today as this is sunday. (lesson learned: never ingrate if you canât spend 3 hoursâ¦)
Marcus
I can confirm those failing tests, in both slice.4 and slice.9, so strange they didn't chow up in the Validator report. Now if its less work, you can revert to the original code by doing "Delay newCodeEnabled: false", and both tests will pass. It late here, so I'll work on fixing those tests tomorrow. Thanks for your efforts. cheers -ben
I can confirm those failing tests, in both slice.4 and slice.9, so strange they didn't chow up in the Validator report.
Now if its less work, you can revert to the original code by doing "Delay newCodeEnabled: false", and both tests will pass. It late here, so I'll work on fixing those tests tomorrow.
The problem is that we now have a wrong version in the build while getting a correct one does not work due to the failure of the shrink pass. Maybe for now reverting is the best, and then dealing with the issue as one change and not two. Marcus
Marcus Denker wrote:
I can confirm those failing tests, in both slice.4 and slice.9, so strange they didn't show up in the Validator report.
Now if its less work, you can revert to the original code by doing "Delay newCodeEnabled: false", and both tests will pass. It late here, so I'll work on fixing those tests tomorrow.
The problem is that we now have a wrong version in the build while getting a correct one does not work due to the failure of the shrink pass.
Maybe for now reverting is the best, and then dealing with the issue as one change and not two.
Marcus
I am only guessing at possibilities without knowing all that is involved. Whatever you think is best practice / least effort. btw, slice.10 resolves those failing tests. cheers -ben
participants (3)
-
Ben Coman -
GitHub -
Marcus Denker