Hi Stef - I went back and opened that image again (I save it in that state) - it was 4.0-40162 build. And it still says no changes? Itâs possible that my changes were incorporated now - or possibly Iâve done something wrong (although Iâm not quite sure what). Possibly my .changes file would show my steps? Tim On 10 Aug 2014, at 10:56, stepharo <stepharo@free.fr> wrote:
On 9/8/14 15:07, Tim Mackinnon wrote:
Guys - Iâve incorporate the feedback from Nicolai from my previous help text submission and I thought I had the submission steps down pat - however I hit a strange problem when I was submitting my slice, and I want to check Iâm doing things right?
My changes are very simple - 1 class method (to name my help entry) and class comment changes to improve the help text.
I had been happily making changes and versioning them in my own local MC directory repo.
When I went to submit my change - I didnât have a dirty package (as I had just versioned it locally) - but I donât think thats a problem right? I just created a +Slice, entered my Fobgugz number and then selected my Package by scrolling through the list of packages.
However when I wen to compare my change against the Pharo40inbox - it kept saying that there were no changes? I donât understand that - as the inbox has my previous submission 6.mcz and something by Stefan 7.mcx - so I was expecting to see the single class method change as well as the class comment change? Did I do something wrong?
You should not compare against the inbox but again the Pharo40 repo. The comparison will show you the diffs with the current Pharo head and not a random file that somebody pushed in the inbox. Because in inbox well this is an inbox. Can you rety and let us know if this solves your problem.
To make sure, I went back - made a small text change, so that I had a dirty package, and then followed the same steps in the video - and this time it did show me a change against Pharo40Inbox, but it was just my small text change? So Iâm worried that Iâve done something funny - but I canât work out what?
Could someone just set me straight?
Tim