Submitted Improved Pharo Help (Case 13811) - but couldn't compare it?
Guys - Iâve incorporate the feedback from Nicolai from my previous help text submission and I thought I had the submission steps down pat - however I hit a strange problem when I was submitting my slice, and I want to check Iâm doing things right? My changes are very simple - 1 class method (to name my help entry) and class comment changes to improve the help text. I had been happily making changes and versioning them in my own local MC directory repo. When I went to submit my change - I didnât have a dirty package (as I had just versioned it locally) - but I donât think thats a problem right? I just created a +Slice, entered my Fobgugz number and then selected my Package by scrolling through the list of packages. However when I wen to compare my change against the Pharo40inbox - it kept saying that there were no changes? I donât understand that - as the inbox has my previous submission 6.mcz and something by Stefan 7.mcx - so I was expecting to see the single class method change as well as the class comment change? Did I do something wrong? To make sure, I went back - made a small text change, so that I had a dirty package, and then followed the same steps in the video - and this time it did show me a change against Pharo40Inbox, but it was just my small text change? So Iâm worried that Iâve done something funny - but I canât work out what? Could someone just set me straight? Tim
Tim Mackinnon wrote:
Guys - Iâve incorporate the feedback from Nicolai from my previous help text submission and I thought I had the submission steps down pat - however I hit a strange problem when I was submitting my slice, and I want to check Iâm doing things right?
My changes are very simple - 1 class method (to name my help entry) and class comment changes to improve the help text.
I had been happily making changes and versioning them in my own local MC directory repo.
When I went to submit my change - I didnât have a dirty package (as I had just versioned it locally) - but I donât think thats a problem right? I just created a +Slice, entered my Fobgugz number and then selected my Package by scrolling through the list of packages.
However when I wen to compare my change against the Pharo40inbox - it kept saying that there were no changes? I donât understand that - as the inbox has my previous submission 6.mcz and something by Stefan 7.mcx - so I was expecting to see the single class method change as well as the class comment change? Did I do something wrong?
To make sure, I went back - made a small text change, so that I had a dirty package, and then followed the same steps in the video - and this time it did show me a change against Pharo40Inbox, but it was just my small text change? So Iâm worried that Iâve done something funny - but I canât work out what?
Could someone just set me straight?
I'm not sure of the exact expected behaviour, but I wonder what happens if you clear out your package cache direct of files, and also do "MCFileBasedRepository allSubInstances do: [ :mcfbr | mcfbr flushCache] " Disclaimer: Thats just a guess from a few minutes digging. I'm not really familiar with the architecture, and #flushCache is 'private' in MCFileBasedRepository, but also is in 'actions' in MCHttpRepository. cheers -ben
Tim
I just noticed in a fresh 30852 Image that the result from "MCFileBasedRepository allSubInstances" seems strange with duplicates..... an OrderedCollection( a MCCacheRepository(C:\Users\Ben\AppData\Roaming\Pharo\PackageCache) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) ) Maybe some cleanup that needs adding to the release / CI builds ? cheers -ben
Yes probably. In Pharo40 we now systematically remove all the repos and reassign all the package to a single new one. Stef On 9/8/14 17:34, Ben Coman wrote:
I just noticed in a fresh 30852 Image that the result from "MCFileBasedRepository allSubInstances" seems strange with duplicates..... an OrderedCollection( a MCCacheRepository(C:\Users\Ben\AppData\Roaming\Pharo\PackageCache) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30/main) a MCHttpRepository(http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) )
Maybe some cleanup that needs adding to the release / CI builds ?
cheers -ben
On 9/8/14 15:07, Tim Mackinnon wrote:
Guys - Iâve incorporate the feedback from Nicolai from my previous help text submission and I thought I had the submission steps down pat - however I hit a strange problem when I was submitting my slice, and I want to check Iâm doing things right?
My changes are very simple - 1 class method (to name my help entry) and class comment changes to improve the help text.
I had been happily making changes and versioning them in my own local MC directory repo.
When I went to submit my change - I didnât have a dirty package (as I had just versioned it locally) - but I donât think thats a problem right? I just created a +Slice, entered my Fobgugz number and then selected my Package by scrolling through the list of packages.
However when I wen to compare my change against the Pharo40inbox - it kept saying that there were no changes? I donât understand that - as the inbox has my previous submission 6.mcz and something by Stefan 7.mcx - so I was expecting to see the single class method change as well as the class comment change? Did I do something wrong?
You should not compare against the inbox but again the Pharo40 repo. The comparison will show you the diffs with the current Pharo head and not a random file that somebody pushed in the inbox. Because in inbox well this is an inbox. Can you rety and let us know if this solves your problem.
To make sure, I went back - made a small text change, so that I had a dirty package, and then followed the same steps in the video - and this time it did show me a change against Pharo40Inbox, but it was just my small text change? So Iâm worried that Iâve done something funny - but I canât work out what?
Could someone just set me straight?
Tim
Hi Stef - I went back and opened that image again (I save it in that state) - it was 4.0-40162 build. And it still says no changes? Itâs possible that my changes were incorporated now - or possibly Iâve done something wrong (although Iâm not quite sure what). Possibly my .changes file would show my steps? Tim On 10 Aug 2014, at 10:56, stepharo <stepharo@free.fr> wrote:
On 9/8/14 15:07, Tim Mackinnon wrote:
Guys - Iâve incorporate the feedback from Nicolai from my previous help text submission and I thought I had the submission steps down pat - however I hit a strange problem when I was submitting my slice, and I want to check Iâm doing things right?
My changes are very simple - 1 class method (to name my help entry) and class comment changes to improve the help text.
I had been happily making changes and versioning them in my own local MC directory repo.
When I went to submit my change - I didnât have a dirty package (as I had just versioned it locally) - but I donât think thats a problem right? I just created a +Slice, entered my Fobgugz number and then selected my Package by scrolling through the list of packages.
However when I wen to compare my change against the Pharo40inbox - it kept saying that there were no changes? I donât understand that - as the inbox has my previous submission 6.mcz and something by Stefan 7.mcx - so I was expecting to see the single class method change as well as the class comment change? Did I do something wrong?
You should not compare against the inbox but again the Pharo40 repo. The comparison will show you the diffs with the current Pharo head and not a random file that somebody pushed in the inbox. Because in inbox well this is an inbox. Can you rety and let us know if this solves your problem.
To make sure, I went back - made a small text change, so that I had a dirty package, and then followed the same steps in the video - and this time it did show me a change against Pharo40Inbox, but it was just my small text change? So Iâm worried that Iâve done something funny - but I canât work out what?
Could someone just set me straight?
Tim
On 10 Aug 2014, at 23:44, Tim Mackinnon <tim@testit.works> wrote:
Hi Stef - I went back and opened that image again (I save it in that state) - it was 4.0-40162 build. And it still says no changes? Itâs possible that my changes were incorporated now - or possibly Iâve done something wrong (although Iâm not quite sure what). Possibly my .changes file would show my steps?
I think there is a bug⦠I even added an issue entry long time ago: https://pharo.fogbugz.com/f/cases/6964/Changes-in-Monticello-seems-to-compar... The problem seems to be that even if you ask for âshow me the change to *that* repositoryâ, it actually looks in the cache and finds the already changed one. Marcus
Thanks gain Marcus - I think this is what Ben or Sean were referring to. I donât think Iâve fully understood the role of the cache - again maybe another beer at Esug might set me straight. God knows - maybe I might be able to figure out how to fix it? Does clearing your cache let it then compare properly - or is it more complicated than that? At the moment - I feel blind in all my changes, and Iâm really not sure what Iâm committing to remote - repos which is worrying. It could be that its a workflow thing - and maybe someone can show me a better workflow. Tim On 14 Aug 2014, at 15:12, Marcus Denker <marcus.denker@inria.fr> wrote:
On 10 Aug 2014, at 23:44, Tim Mackinnon <tim@testit.works> wrote:
Hi Stef - I went back and opened that image again (I save it in that state) - it was 4.0-40162 build. And it still says no changes? Itâs possible that my changes were incorporated now - or possibly Iâve done something wrong (although Iâm not quite sure what). Possibly my .changes file would show my steps?
I think there is a bugâ¦
I even added an issue entry long time ago:
https://pharo.fogbugz.com/f/cases/6964/Changes-in-Monticello-seems-to-compar...
The problem seems to be that even if you ask for âshow me the change to *that* repositoryâ, it actually looks in the cache and finds the already changed one.
Marcus
On 14 Aug 2014, at 16:50, Tim Mackinnon <tim@testit.works> wrote:
Thanks gain Marcus - I think this is what Ben or Sean were referring to.
I donât think Iâve fully understood the role of the cache - again maybe another beer at Esug might set me straight. God knows - maybe I might be able to figure out how to fix it?
Yes, we can try :-)
Does clearing your cache let it then compare properly
Yes!
- or is it more complicated than thatt At the moment - I feel blind in all my changes, and Iâm really not sure what Iâm committing to remote - repos which is worrying. It could be that its a workflow thing - and maybe someone can show me a better workflow.
Marcus
participants (4)
-
Ben Coman -
Marcus Denker -
stepharo -
Tim Mackinnon