Why not something like : #aboutToClose and #closed ? ----------------- Benoit St-Jean Yahoo! Messenger: bstjean Blog: lamneth.wordpress.com A standpoint is an intellectual horizon of radius zero. (Albert Einstein) ________________________________ From: Gary Chambers <gazzaguru2@btinternet.com> To: Pharo-project@lists.gforge.inria.fr Sent: Fri, January 8, 2010 3:37:39 PM Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus If "after the fact" I'd vote for the "ed" suffix too. Make it match what is/has happening/happened. As a side note, WindowClosing is common to give a potential veto chance (i.e. deny close). Should also be a WindowClosed if it does get that far... Regards, Gary ----- Original Message ----- From: "Stéphane Ducasse" <stephane.ducasse@inria.fr> To: <Pharo-project@lists.gforge.inria.fr> Sent: Friday, January 08, 2010 8:19 PM Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus Alexandre as soon as we will got the names right publish, add a bug tracker item and this will be integrated now about the names Closing or Closed? Collapsed? WindowMoved? what is the convention? when the event happens at the end I would prefer ed when it occurs over a long action ing any english-oriented/design remarks? ?
Alexandre
<Picture 3.png>
On 8 Jan 2010, at 08:57, Henrik Johansen wrote:
On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote:
Looks ok to me.
Regards, Gary
----- Original Message ----- From: "Stéphane Ducasse" <stephane.ducasse@inria.fr> To: <Pharo-project@lists.gforge.inria.fr> Sent: Thursday, January 07, 2010 8:27 PM Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus
Hi!
In the PharoTaskForces SqueakSource repository I committed a new version of Morphic (Morphic-Alexandre_Bergel.393). This version includes the window announcement I have been working on for few months already.
Here is an example of a unit test. -=-=-=-=-=-=-=-=-=-=-=-= MorphicWindowNotificationTest>>testWindowCreationAndDeletion
| t window newWindowCreated r | t := 0. World announcer on: MorphicCreationWindowAnnouncement do: [:ann | t := t + 1. newWindowCreated := ann window]. World announcer on: MorphicClosingWindowAnnouncement do: [:ann | t := t + 10. newWindowCreated := ann window].
I don't particularly like the naming.
- Why including Announcement at the end? - Why does one contain a verb, and the other a - When are they fired? Closing implies to me it's not been closed yet, but fired somewhere after the closing has started, while CreationWindow I have no idea what means.
MorphicWindowOpen(ed/ing) MorphicWindowClos(ed/ing)
are both easier to read for me, shorter, and more in line with the naming convention for Pragma announcements already in Pharo.
Cheers, Henry _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project __________________________________________________________________ Looking for the perfect gift? Give the gift of Flickr! http://www.flickr.com/gift/