- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [Pharo5] Semantic Warnings as icons in the editor

by Tudor Girba

Very nice! Doru > On Nov 28, 2015, at 11:01 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Hi, > > One result of Fridayâs Pharo Sprint in Chile: Use the nice icons of the new text editor > to display some of the semantic errors nicely (instead of breaking flow with a intrusive dialog): > > This was done by Johan based on the prototype Miguel did in September: > > 1) unused temps: > > <unused.png> > > (the âdrag the crosshairâr is an artefact of the snapshot tool) > > 2) temps used that are not initialised: > > <uninit.png> > > > In a next step, we need to integrate that with the QA toolâ¦ no need to have this reported > twice. > > What is nice is that this simplified the Compiler: instead of having an Exception and raising > it, we now just annotate the AST: > > unusedVariable: variableNode > > variableNode propertyAt: #semanticWarning put: 'unused variableâ > > (this is very simple for now, with a node just being able to have one kind of semanticWarning). > > SemanticWarningIconStyler is what adds the icon. It has 4 methods with one line each. > > Marcus > -- www.tudorgirba.com "Value is always contextual."

Nov. 28, 2015

[Pharo5] Semantic Warnings as icons in the editor

by Marcus Denker

Hi, One result of Fridayâs Pharo Sprint in Chile: Use the nice icons of the new text editor to display some of the semantic errors nicely (instead of breaking flow with a intrusive dialog): This was done by Johan based on the prototype Miguel did in September: 1) unused temps: (the âdrag the crosshairâr is an artefact of the snapshot tool) 2) temps used that are not initialised: In a next step, we need to integrate that with the QA toolâ¦ no need to have this reported twice. What is nice is that this simplified the Compiler: instead of having an Exception and raising it, we now just annotate the AST: unusedVariable: variableNode variableNode propertyAt: #semanticWarning put: 'unused variableâ (this is very simple for now, with a node just being able to have one kind of semanticWarning). SemanticWarningIconStyler is what adds the icon. It has 4 methods with one line each. Marcus

Nov. 28, 2015

Re: [Pharo-dev] Delay>>waitOtherwise:

by stepharo

Le 25/11/15 14:07, Ben Coman a Ã©crit : > I think I made a mistake introducing Delay>>waitOtherwise: > to be used by World>>interCyclePause: . > Its requirement that #schedule: return a boolean > complicates all those methods. > > In review now, I was being too conservative while letting the > refactored delay scheduler code settle in. Would anyone mind if I > revert that? Not me :) I appreciate all the energy and concentration you put on this central point. > > cheers -ben > >

Nov. 28, 2015

Re: [Pharo-dev] Autoscrolling (in FastTable)

by Thierry Goubier

Le 28/11/2015 18:24, stepharo a Ã©crit : > We are working on Bloc so I would not invest too much improving > dramatically Morphic. Most of what is being done will port to Bloc. No improvements of Morphic are considered; just using it correctly. Thierry

Nov. 28, 2015

Re: [Pharo-dev] Autoscrolling (in FastTable)

by stepharo

We are working on Bloc so I would not invest too much improving dramatically Morphic. Le 28/11/15 17:52, Thierry Goubier a Ã©crit : > Yes, this was very interesting. Some of the things we got: > > - mouseFocus is in fact more usefull than it seems at first, > especially if you want to receive events when the mouse doesn't move. > In particular, it is usefull to know how to get mouseStillDown: events > (they are sent as soon as the mouse pointer stops moving during a > drag, but only if you have the mouse focus). > > - we should unify alarms and stepMessages. This would make some > time-based behaviors a lot easier to code, not requiring the addition > of an instance variable to hold the number of times the step message > has been sent. I think that this is like that in Bloc > > - FastTable could get an insertion point: a blue line where an item > would be inserted if dropped. > > - It is possible, and relatively easy in the current Morphic > framework, to do the following: > - auto-scrolling accelerating the longer you stay with your drag > either on top or at the bottom of the table. > - have a time-threshold to automatically expand tree items > (triangles) when you drag > - accelerate and slow down mouse wheel based scrolling on long lists > (also applies to two-finger scrolling on trackpads), like it is done > on our phones :) > > Thierry > > > Le 28/11/2015 12:09, stepharo a Ã©crit : >> This is cool to see such important widgets improving. >> >> Stef >> >> Le 26/11/15 17:28, Stephan Eggermont a Ã©crit : >>> Today we've had a design discussion on slack on autoscrolling with >>> Morphic. The idea is to start scrolling up or down when drag-holding >>> over a table. A similar approach should hold for scrolling panes. >>> >>> It started with me describing a working but not so nice approach >>> starting stepping on #mouseEnterDragging:, checking the global hand >>> position and button state in each #step:, stopping the stepping on >>> #mouseLeaveDragging: or #mouseUp:. >>> >>> Thierry noticed the #newMouseFocus: taking of FastTable on >>> #mouseEnterDragging: causes problems when dragging from one table to >>> itself without leaving the table bounds. >>> >>> Henrik then wrote the code for FastTable, removing the mouse focus >>> taking by adapting #handleMouseMove: The first results are in the >>> latest version of FastTable on estebanlm/FastTable. >>> The top and bottom parts of the table will now start scrolling the >>> table rows when drag-holding over them. >>> >>> Further possible improvements: >>> - expand/contract tree triangles when holding over them, taking >>> priority over the start of autoscrolling; >>> - adapt scrolling speed depending on distance from border >>> - check starting delay, repeat rate and smoothness of the scrolling >>> >>> Stephan >>> >>> >>> >>> >> >> >> > > >

Nov. 28, 2015

Re: [Pharo-dev] Autoscrolling (in FastTable)

by Thierry Goubier

Yes, this was very interesting. Some of the things we got: - mouseFocus is in fact more usefull than it seems at first, especially if you want to receive events when the mouse doesn't move. In particular, it is usefull to know how to get mouseStillDown: events (they are sent as soon as the mouse pointer stops moving during a drag, but only if you have the mouse focus). - we should unify alarms and stepMessages. This would make some time-based behaviors a lot easier to code, not requiring the addition of an instance variable to hold the number of times the step message has been sent. - FastTable could get an insertion point: a blue line where an item would be inserted if dropped. - It is possible, and relatively easy in the current Morphic framework, to do the following: - auto-scrolling accelerating the longer you stay with your drag either on top or at the bottom of the table. - have a time-threshold to automatically expand tree items (triangles) when you drag - accelerate and slow down mouse wheel based scrolling on long lists (also applies to two-finger scrolling on trackpads), like it is done on our phones :) Thierry Le 28/11/2015 12:09, stepharo a Ã©crit : > This is cool to see such important widgets improving. > > Stef > > Le 26/11/15 17:28, Stephan Eggermont a Ã©crit : >> Today we've had a design discussion on slack on autoscrolling with >> Morphic. The idea is to start scrolling up or down when drag-holding >> over a table. A similar approach should hold for scrolling panes. >> >> It started with me describing a working but not so nice approach >> starting stepping on #mouseEnterDragging:, checking the global hand >> position and button state in each #step:, stopping the stepping on >> #mouseLeaveDragging: or #mouseUp:. >> >> Thierry noticed the #newMouseFocus: taking of FastTable on >> #mouseEnterDragging: causes problems when dragging from one table to >> itself without leaving the table bounds. >> >> Henrik then wrote the code for FastTable, removing the mouse focus >> taking by adapting #handleMouseMove: The first results are in the >> latest version of FastTable on estebanlm/FastTable. >> The top and bottom parts of the table will now start scrolling the >> table rows when drag-holding over them. >> >> Further possible improvements: >> - expand/contract tree triangles when holding over them, taking >> priority over the start of autoscrolling; >> - adapt scrolling speed depending on distance from border >> - check starting delay, repeat rate and smoothness of the scrolling >> >> Stephan >> >> >> >> > > >

Nov. 28, 2015

Occasional random validation failures

by Ben Coman

In case 16962 [1] the question was raised why after a successful CI validation you later get a failed validation. I experience this sometimes and guess others might interested in this too. If multi-threads are involved, sometimes the failure indicates a real problem due to a race condition that only occurs sometimes. Here you will see lots of tests passing and then a problem on a particular one. In this case I find running the suspect test or class from playground wrapped in a 1000 loop can expose the problem for debugging. In the case of 16962 [1], looking at a report for success [2] you can see "CIChangeCaseValidationRule" is followed by "Loading CASE 16962" and then a long listing of tests run, and only at the end the validation report. However the report for failure [3] shows CIChangeCaseValidationRule immediately followed by the validation report. So I wonder if that means the slice did not load - maybe due to some network error or smalltalkhub error. Now thats idle speculation, but maybe useful to consider if you encounter such a scenario. cheers -ben 2015-11-28 3:56 AM SUCCESS [2] [...] Starting validation of CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… Notice: Running a CIAndRule Notice: Running a CIChangeCaseValidationRule Notice: Loading CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… [...cut many,many lines of test cases...] ========================================================== Validation Report: CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… ========================================================== Validation Success: CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… [...] 2015-11-26 10:29 PM FAILURE [3] [...] Starting validation of CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… Notice: Running a CIAndRule Notice: Running a CIChangeCaseValidationRule ========================================================== Validation Report: CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… ========================================================== Validation Errors: a CIChangeCaseValidationRule: Timeout (after 0:01:40:00) [...] [1] https://pharo.fogbugz.com/default.asp?16962 [2] https://ci.inria.fr/pharo/job/Pharo-5.0-Issue-Validator/20704//artifact/val… [3] https://ci.inria.fr/pharo/job/Pharo-5.0-Issue-Validator/20587//artifact/val…

Nov. 28, 2015

Re: [Pharo-dev] Autoscrolling (in FastTable)

by stepharo

This is cool to see such important widgets improving. Stef Le 26/11/15 17:28, Stephan Eggermont a Ã©crit : > Today we've had a design discussion on slack on autoscrolling with > Morphic. The idea is to start scrolling up or down when drag-holding > over a table. A similar approach should hold for scrolling panes. > > It started with me describing a working but not so nice approach > starting stepping on #mouseEnterDragging:, checking the global hand > position and button state in each #step:, stopping the stepping on > #mouseLeaveDragging: or #mouseUp:. > > Thierry noticed the #newMouseFocus: taking of FastTable on > #mouseEnterDragging: causes problems when dragging from one table to > itself without leaving the table bounds. > > Henrik then wrote the code for FastTable, removing the mouse focus > taking by adapting #handleMouseMove: The first results are in the > latest version of FastTable on estebanlm/FastTable. > The top and bottom parts of the table will now start scrolling the > table rows when drag-holding over them. > > Further possible improvements: > - expand/contract tree triangles when holding over them, taking > priority over the start of autoscrolling; > - adapt scrolling speed depending on distance from border > - check starting delay, repeat rate and smoothness of the scrolling > > Stephan > > > >

Nov. 28, 2015

Re: [Pharo-dev] Improving API of Date, Month....

by stepharo

> Yes, I badly need to get it localised > I added class accessors to ChronologyConstants to modify month and day > names. but this is dangerous because you do not know the assumption that the system is doing. I would go more in improving chalten > > Hilaire > > Le 24/11/2015 15:59, stepharo a Ã©crit : >> Hi >> >> I was reading the code of Date and I was expecting to get some methods >> such as >> monthNames >> dayNames >> daysInMonths >> >> Ok they are stored in ChronologyConstants but they are not accessible. >> There is no monthNames nor >> >> Do I imply something strange or silly? >> I think that it would make sense to add them. >> >> Stef >> >> >

Nov. 28, 2015

Re: [Pharo-dev] Improving API of Date, Month....

by stepharo

> I donât know chronos, but Chalten (the Aconcagua date API) is quite nice (overuse of globals, IMO, but you gain a lot of expressivity). yes it was with it in mind that I wrote the mail. So I would imrpove the date printer and key our kernel small STef > > Esteban > >> On 24 Nov 2015, at 18:34, stepharo <stepharo(a)free.fr> wrote: >> >> Hi guys >> >> I made the mistake to think that it was a good move to improve and make the core more full (and complex in the past). >> Now what I would love is the following. >> >> - keep and reduce if necessary the core date classes (only used internally by the system) >> - have nice packages that we can load to represent time / calendar >> -- chronos >> -- aconcagua >> -- or a new one >> >> That do it the right way: with locale and so on. >> Why? because it can be complex and verbose and we want to have a small core (for many different reasons). >> About the durationFormatter I think that we should definitively have more strategies to represent dates and other >> within a nice date/calendar package. >> >> I would love that someone propose something to get the nice extensible Calendar/Date package >> >> Stef >> >> Le 24/11/15 16:25, Esteban A. Maringolo a Ã©crit : >>> 2015-11-24 12:14 GMT-03:00 Skip Lentz <skip.lentz(a)inria.fr>: >>>> Hi, >>>> >>>> I also had an idea for a method which returns the most significant unit of a Duration. >>>> >>>> For example, you have a duration of 432 days, 3 hours, 21 minutes, 5 seconds, etc., and >>>> it would return you "432 days" (or just â1 yearâ). I encountered this when wanting to create >>>> a time indication on e.g. a commit or a comment. Itâs much more readable and user-friendly >>>> than a timestamp. >>>> >>>> Would this be a nice addition to the Duration API? >>> It would be nice to have. But why not something like a >>> DurationFormatter? that in turn collaborates with the Locale to ge the >>> words for "Year, Month, Week" in the current language. >>> >>> Regards! >>> >>> >> > >

Nov. 28, 2015