Very nice! Doru
On Nov 28, 2015, at 11:01 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
Hi,
One result of Fridayâs Pharo Sprint in Chile: Use the nice icons of the new text editor to display some of the semantic errors nicely (instead of breaking flow with a intrusive dialog):
This was done by Johan based on the prototype Miguel did in September:
1) unused temps:
<unused.png>
(the âdrag the crosshairâr is an artefact of the snapshot tool)
2) temps used that are not initialised:
<uninit.png>
In a next step, we need to integrate that with the QA tool⦠no need to have this reported twice.
What is nice is that this simplified the Compiler: instead of having an Exception and raising it, we now just annotate the AST:
unusedVariable: variableNode
variableNode propertyAt: #semanticWarning put: 'unused variableâ
(this is very simple for now, with a node just being able to have one kind of semanticWarning).
SemanticWarningIconStyler is what adds the icon. It has 4 methods with one line each.
Marcus
-- www.tudorgirba.com "Value is always contextual."