- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Need code review

by Alexandre Bergel

Sorry to weak up so lately, but where the source code is accessible ? I spent few minutes on looking at: - PharoInBox - list of taks on gforge - list of issues on google and I haven't found where the code to review could be... Any hint? Alexandre On 13 Jun 2008, at 11:18, StÃ©phane Ducasse wrote: > Hi guys > > I would like some other people to have a look at > > [Pharo-project] Hunting down nebraska > [Pharo-project] MVC removal step2 investigations > > Can somebody have a look? > > Stef > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

June 13, 2008

[Pharo-project] Need code review

by StÃ©phane Ducasse

Hi guys I would like some other people to have a look at [Pharo-project] Hunting down nebraska [Pharo-project] MVC removal step2 investigations Can somebody have a look? Stef

June 13, 2008

Re: [Pharo-project] Broken tests

by StÃ©phane Ducasse

On Jun 13, 2008, at 11:08 AM, Norbert Hartl wrote: > And please take into account my posting "Removing ScriptLoader > legacy" on squeak-dev. I could not find it. Can you point it to me? > Especially things in ScriptLoader are subject to > Undeclared which lets the ReleaseTest fail. I had a talk on irc and it > seems that for 3.10 that were removed (from Undeclared) manually (I > have > no other idea). I'll have look if ScriptLoader is the only suspect. >

June 13, 2008

Re: [Pharo-project] Broken tests

by StÃ©phane Ducasse

On Jun 13, 2008, at 11:08 AM, Norbert Hartl wrote: > And please take into account my posting "Removing ScriptLoader > legacy" on squeak-dev. Ok I missed it. > Especially things in ScriptLoader are subject to > Undeclared which lets the ReleaseTest fail. Yes We should clean that. > I had a talk on irc and it > seems that for 3.10 that were removed (from Undeclared) manually (I > have > no other idea). I'll have look if ScriptLoader is the only suspect. > > Norbert > > > On Fri, 2008-06-13 at 08:23 +0200, StÃ©phane Ducasse wrote: >> Excellent we are getting there. >> Today I will harvest them and the changes of damien. >> We should take into account the feedback of andreas on Nan. >> >> Stef >> >> On Jun 12, 2008, at 11:24 PM, Adrian Lienhard wrote: >> >>> I've fixed the following 7 tests (see inbox: SLICE-test-fixes.al. >>> 1.mcz): >>> >>> testRootsOfTheWorld -- test removed >>> testLocalMethodWithSameCodeInTrait -- removed duplicated method >>> ClassDescription>>fileOutCategory: >>> testFinalizationOfEquals -- test fixed >>> testHash -- remove all assertions/tests that have hardcoded hash >>> values >>> DateAndTimeEpochTest>>#testHash >>> DateAndTimeLeapTest>>#testHash >>> TimeTest>>#testHash >>> TimespanTest>>#testHash >>> >>> Now 8 tests are still failing. We are getting there... >>> >>> Cheers, >>> Adrian >>> >>> On Jun 11, 2008, at 19:07 , StÃ©phane Ducasse wrote: >>> >>>> excellent! >>>> >>>> Stef >>>> >>>> On Jun 11, 2008, at 4:04 PM, Oscar Nierstrasz wrote: >>>> >>>>> >>>>> Just for phun, I ran all the tests in the Pharo image. There are >>>>> only 13 failures, 2 expected failures, and no errors! >>>>> >>>>> I have started a page to give an overview: >>>>> >>>>> http://code.google.com/p/pharo/wiki/BrokenTests >>>>> >>>>> Please update this page with an appropriate comment if you are >>>>> working on any of these (or if you fix them). >>>>> >>>>> - on >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 13, 2008

Re: [Pharo-project] Broken tests

by Norbert Hartl

And please take into account my posting "Removing ScriptLoader legacy" on squeak-dev. Especially things in ScriptLoader are subject to Undeclared which lets the ReleaseTest fail. I had a talk on irc and it seems that for 3.10 that were removed (from Undeclared) manually (I have no other idea). I'll have look if ScriptLoader is the only suspect. Norbert On Fri, 2008-06-13 at 08:23 +0200, StÃ©phane Ducasse wrote: > Excellent we are getting there. > Today I will harvest them and the changes of damien. > We should take into account the feedback of andreas on Nan. > > Stef > > On Jun 12, 2008, at 11:24 PM, Adrian Lienhard wrote: > > > I've fixed the following 7 tests (see inbox: SLICE-test-fixes.al. > > 1.mcz): > > > > testRootsOfTheWorld -- test removed > > testLocalMethodWithSameCodeInTrait -- removed duplicated method > > ClassDescription>>fileOutCategory: > > testFinalizationOfEquals -- test fixed > > testHash -- remove all assertions/tests that have hardcoded hash > > values > > DateAndTimeEpochTest>>#testHash > > DateAndTimeLeapTest>>#testHash > > TimeTest>>#testHash > > TimespanTest>>#testHash > > > > Now 8 tests are still failing. We are getting there... > > > > Cheers, > > Adrian > > > > On Jun 11, 2008, at 19:07 , StÃ©phane Ducasse wrote: > > > >> excellent! > >> > >> Stef > >> > >> On Jun 11, 2008, at 4:04 PM, Oscar Nierstrasz wrote: > >> > >>> > >>> Just for phun, I ran all the tests in the Pharo image. There are > >>> only 13 failures, 2 expected failures, and no errors! > >>> > >>> I have started a page to give an overview: > >>> > >>> http://code.google.com/p/pharo/wiki/BrokenTests > >>> > >>> Please update this page with an appropriate comment if you are > >>> working on any of these (or if you fix them). > >>> > >>> - on > >>> > >>> _______________________________________________ > >>> Pharo-project mailing list > >>> Pharo-project(a)lists.gforge.inria.fr > >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >>> > >> > >> > >> _______________________________________________ > >> Pharo-project mailing list > >> Pharo-project(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 13, 2008

Re: [Pharo-project] Broken tests

by StÃ©phane Ducasse

Excellent we are getting there. Today I will harvest them and the changes of damien. We should take into account the feedback of andreas on Nan. Stef On Jun 12, 2008, at 11:24 PM, Adrian Lienhard wrote: > I've fixed the following 7 tests (see inbox: SLICE-test-fixes.al. > 1.mcz): > > testRootsOfTheWorld -- test removed > testLocalMethodWithSameCodeInTrait -- removed duplicated method > ClassDescription>>fileOutCategory: > testFinalizationOfEquals -- test fixed > testHash -- remove all assertions/tests that have hardcoded hash > values > DateAndTimeEpochTest>>#testHash > DateAndTimeLeapTest>>#testHash > TimeTest>>#testHash > TimespanTest>>#testHash > > Now 8 tests are still failing. We are getting there... > > Cheers, > Adrian > > On Jun 11, 2008, at 19:07 , StÃ©phane Ducasse wrote: > >> excellent! >> >> Stef >> >> On Jun 11, 2008, at 4:04 PM, Oscar Nierstrasz wrote: >> >>> >>> Just for phun, I ran all the tests in the Pharo image. There are >>> only 13 failures, 2 expected failures, and no errors! >>> >>> I have started a page to give an overview: >>> >>> http://code.google.com/p/pharo/wiki/BrokenTests >>> >>> Please update this page with an appropriate comment if you are >>> working on any of these (or if you fix them). >>> >>> - on >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 13, 2008

Re: [Pharo-project] Broken tests

by Adrian Lienhard

I've fixed the following 7 tests (see inbox: SLICE-test-fixes.al.1.mcz): testRootsOfTheWorld -- test removed testLocalMethodWithSameCodeInTrait -- removed duplicated method ClassDescription>>fileOutCategory: testFinalizationOfEquals -- test fixed testHash -- remove all assertions/tests that have hardcoded hash values DateAndTimeEpochTest>>#testHash DateAndTimeLeapTest>>#testHash TimeTest>>#testHash TimespanTest>>#testHash Now 8 tests are still failing. We are getting there... Cheers, Adrian On Jun 11, 2008, at 19:07 , StÃ©phane Ducasse wrote: > excellent! > > Stef > > On Jun 11, 2008, at 4:04 PM, Oscar Nierstrasz wrote: > >> >> Just for phun, I ran all the tests in the Pharo image. There are >> only 13 failures, 2 expected failures, and no errors! >> >> I have started a page to give an overview: >> >> http://code.google.com/p/pharo/wiki/BrokenTests >> >> Please update this page with an appropriate comment if you are >> working on any of these (or if you fix them). >> >> - on >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 12, 2008

[Pharo-project] Improving the general quality of package

by StÃ©phane Ducasse

Hi all I would really like to see if it make sense to run SmallLint on packages. Of course we should not naively apply the proposed refactoring (some blind applications of them in the past went against speed in Graphics), still identifying and building a process to produce a bit better code quality would be great. If any of you want to give a try it would be great. I'm also thinking about having a manifesto to each package or group of package so that we can attach information and metainformation to package such as documentation... So far I'm not happy with what I did (cf DrDoc but this is one step in that direction). Stef

June 12, 2008

Re: [Pharo-project] Strange bug in TraitsTest

by Adrian Lienhard

On Jun 12, 2008, at 15:49 , Norbert Hartl wrote: > On Thu, 2008-06-12 at 15:28 +0200, Adrian Lienhard wrote: >> I don't see what could testRootsOfTheWorld be useful for. Anyway, the >> reason why this fails is because for the traits tests I use test >> resources and they are set up before all tests are run and >> testRootsOfTheWorld asserts that there are exactly 3 classes in the >> system that do not have a superclass. >> > I don't think that the test does harm. And I don't really care > about the test. What I don't understand is the "side effect". The > classes are created in TraitsTestCase. The failing test is in > ClassTest. As far as I can see the created classes are removed on > tearDown time. Well, this is how the test runner works... It first sets up all test resources (which in this case creates the offending classes), then it runs all tests, and then it releases the resources. That is, resource allocation and deallocation is "global", therefore ClassTest is affected. Hope that explains it better. Adrian > > > > Norbert > >> There are two simple solutions for this. Either remove >> testRootsOfTheWorld or change the test classes created in >> TraitsRescource to inherit from Object instead of ProtoObject. I >> would >> do the former unless somebody has a convincing argument for keeping >> that test in the image. >> >> Adrian >> >> NB: I'll also fix #testLocalMethodWithSameCodeInTrait when I'm at it >> (this tests that there do not exist duplicated methods between a >> trait >> and a class using the trait) >> >> On Jun 11, 2008, at 19:24 , Norbert Hartl wrote: >> >>> If you open a test runner and select only KernelTests-ClassTest and >>> TraitsTests-TraitsTestCase you may find a failure >>> >>> ClassTest>>testRootsOfTheWorld >>> >>> But I don't understand fully why it appears. I had once >>> the chance to get a debugger on the failure (which does >>> usually not work on this failure) and so I know that the >>> rootsOfTheWorld (which is usually 3) is 6 in size containing >>> additionally classes C3 C4 and C6. The ones which are created >>> by TraitsTestCase (see my last mail "Bug for harvest"). >>> >>> They all have a superclass of nil but they aren't included >>> in the SystemNavigation. (conditions for being included in >>> the rootsOfTheWorld) >>> >>> If you press "Run selected" again the same error occurrs >>> while pressing "Run failures" gives you all green (ok, it >>> is this way in my case) >>> >>> And I can't reproduce the same in a 3.10 image. >>> >>> It seems that there is a timing problem involved. Selecting >>> only the two test cases I get the failure every time (or nearly). >>> Selecting all tests it appears only at random. >>> >>> Any hints? >>> >>> Norbert >>> >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 12, 2008

Re: [Pharo-project] Strange bug in TraitsTest

by StÃ©phane Ducasse

Hi adrian go for it :) Stef On Jun 12, 2008, at 3:28 PM, Adrian Lienhard wrote: > I don't see what could testRootsOfTheWorld be useful for. Anyway, > the reason why this fails is because for the traits tests I use test > resources and they are set up before all tests are run and > testRootsOfTheWorld asserts that there are exactly 3 classes in the > system that do not have a superclass. > > There are two simple solutions for this. Either remove > testRootsOfTheWorld or change the test classes created in > TraitsRescource to inherit from Object instead of ProtoObject. I > would do the former unless somebody has a convincing argument for > keeping that test in the image. > > Adrian > > NB: I'll also fix #testLocalMethodWithSameCodeInTrait when I'm at it > (this tests that there do not exist duplicated methods between a > trait and a class using the trait) > > On Jun 11, 2008, at 19:24 , Norbert Hartl wrote: > >> If you open a test runner and select only KernelTests-ClassTest and >> TraitsTests-TraitsTestCase you may find a failure >> >> ClassTest>>testRootsOfTheWorld >> >> But I don't understand fully why it appears. I had once >> the chance to get a debugger on the failure (which does >> usually not work on this failure) and so I know that the >> rootsOfTheWorld (which is usually 3) is 6 in size containing >> additionally classes C3 C4 and C6. The ones which are created >> by TraitsTestCase (see my last mail "Bug for harvest"). >> >> They all have a superclass of nil but they aren't included >> in the SystemNavigation. (conditions for being included in >> the rootsOfTheWorld) >> >> If you press "Run selected" again the same error occurrs >> while pressing "Run failures" gives you all green (ok, it >> is this way in my case) >> >> And I can't reproduce the same in a 3.10 image. >> >> It seems that there is a timing problem involved. Selecting >> only the two test cases I get the failure every time (or nearly). >> Selecting all tests it appears only at random. >> >> Any hints? >> >> Norbert >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 12, 2008