- Pharo-dev - lists.pharo.org

Re: [Pharo-project] [Fwd: [squeak-dev] Re: Bug in object finalization?]

by Norbert Hartl

On Wed, 2008-06-18 at 23:00 +0200, Adrian Lienhard wrote: > Thanks, Norbert, I integrated your change. > I changed the migration script to make it also work if people do > updates in an image that already has values registered for > finalization, and for all existing weak registries, not only for the > finalization registry. Like this the code and the state are in sync: > > WeakRegistry allInstancesDo: [ :each | > (each instVarNamed: 'valueDictionary') > primitiveChangeClassTo: WeakIdentityKeyDictionary basicNew; > rehash ]. > Great! I would have done something similar if I only had the knowledge :) Norbert > Cheers, > Adrian > > On Jun 18, 2008, at 21:40 , Norbert Hartl wrote: > > > On Wed, 2008-06-18 at 21:37 +0200, Adrian Lienhard wrote: > >> Hi Norbert, > >> > >> We do this kind of scripts in the ScriptLoader. Just let me know when > >> you published your slice and I will prepare the ScriptLoader update > >> script which Stef can then push into the update stream. > >> > > I published the slice 1 minute before sending the mail :) > > > > Have fun, > > > > Norbert > >> Adrian > >> > >> On Jun 18, 2008, at 19:30 , Norbert Hartl wrote: > >> > >>> So, > >>> > >>> now I'm all for fixing it and ressurect the test case. > >>> I'll upload something to PharoInbox. Afterwards it needs > >>> to be reinitialized. What is the preferred way of having > >>> doits in the update stream? > >>> > >>> Anyway I uploaded SLICE-WeakRegistryAndFinalizerTestFix > >>> to PharoInbox. > >>> > >>> afterwards a > >>> > >>> WeakRegistry default initialize: WeakRegistry default size > >>> > >>> will be necessary. > >>> > >>> Norbert > >>> > >>> From: Andreas Raab <andreas.raab(a)gmx.de> > >>> Date: June 18, 2008 7:02:11 PM GMT+02:00 > >>> To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org > >>>> > >>> Subject: [squeak-dev] Re: Bug in object finalization? > >>> Reply-To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org > >>>> > >>> > >>> > >>> Norbert Hartl wrote: > >>>> On Wed, 2008-06-18 at 09:22 -0700, Andreas Raab wrote: > >>>>> Norbert Hartl wrote: > >>>>>> There was a test in 3.9 testing this (it failed). In 3.10 > >>>>>> the test got removed but I think it is a bug. > >>>>>> > >>>>>> What do you think? > >>>>> The test itself is buggy (see http://bugs.squeak.org/view.php?id=6347) > >>>>> but once you fix the test it illustrates a problem in > >>>>> WeakRegistry which needs to use a WeakIdentityKeyDictionary > >>>>> instead of a WeakKeyDictionary. > >>>>> > >>>> Ok, what I said. Do you see an harmful side effects by exchanging > >>>> the dictionary? > >>> > >>> No - we've fixed this a long time ago in our code base. > >>> > >>> Cheers, > >>> - Andreas > >>> > >>> > >>> > >>> _______________________________________________ > >>> Pharo-project mailing list > >>> Pharo-project(a)lists.gforge.inria.fr > >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >> > >> > >> _______________________________________________ > >> Pharo-project mailing list > >> Pharo-project(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 18, 2008

Re: [Pharo-project] [Fwd: [squeak-dev] Re: Bug in object finalization?]

by Adrian Lienhard

Hi Stef, I harvested most of the remaining changes in the inbox, including Norberts fix (see other mail in this thread). - changed WeakRegistry to use WeakIdentityKeyDictionary (http://bugs.squeak.org/view.php?id=6347 ) - FinalizerTest reverted to real test case - added missing class variables to DigitalSigntureAlgorithm - Fix issue #13: TraitsTests pollutes ProtoObject subclasses (Mantis 7090) - make BitmapStreamTest clean up the file bitmapStreamTest.ref.extSeg I pushed everything into the Pharo repository, updated ScriptLoader (update10042), and moved the relevant packages from PharoInbox to PharoTreatedInbox. Cheer, Adrian On Jun 18, 2008, at 22:47 , StÃ©phane Ducasse wrote: > Hi norbert > > did you read the answer of nicolas on squeak-dev on your question. I > read the mantis entry he mentioned > but i read superficially. :) > > Stef > > On Jun 18, 2008, at 9:40 PM, Norbert Hartl wrote: > >> On Wed, 2008-06-18 at 21:37 +0200, Adrian Lienhard wrote: >>> Hi Norbert, >>> >>> We do this kind of scripts in the ScriptLoader. Just let me know >>> when >>> you published your slice and I will prepare the ScriptLoader update >>> script which Stef can then push into the update stream. >>> >> I published the slice 1 minute before sending the mail :) >> >> Have fun, >> >> Norbert >>> Adrian >>> >>> On Jun 18, 2008, at 19:30 , Norbert Hartl wrote: >>> >>>> So, >>>> >>>> now I'm all for fixing it and ressurect the test case. >>>> I'll upload something to PharoInbox. Afterwards it needs >>>> to be reinitialized. What is the preferred way of having >>>> doits in the update stream? >>>> >>>> Anyway I uploaded SLICE-WeakRegistryAndFinalizerTestFix >>>> to PharoInbox. >>>> >>>> afterwards a >>>> >>>> WeakRegistry default initialize: WeakRegistry default size >>>> >>>> will be necessary. >>>> >>>> Norbert >>>> >>>> From: Andreas Raab <andreas.raab(a)gmx.de> >>>> Date: June 18, 2008 7:02:11 PM GMT+02:00 >>>> To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org >>>>> >>>> Subject: [squeak-dev] Re: Bug in object finalization? >>>> Reply-To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org >>>>> >>>> >>>> >>>> Norbert Hartl wrote: >>>>> On Wed, 2008-06-18 at 09:22 -0700, Andreas Raab wrote: >>>>>> Norbert Hartl wrote: >>>>>>> There was a test in 3.9 testing this (it failed). In 3.10 >>>>>>> the test got removed but I think it is a bug. >>>>>>> >>>>>>> What do you think? >>>>>> The test itself is buggy (see http://bugs.squeak.org/view.php?id=6347) >>>>>> but once you fix the test it illustrates a problem in >>>>>> WeakRegistry which needs to use a WeakIdentityKeyDictionary >>>>>> instead of a WeakKeyDictionary. >>>>>> >>>>> Ok, what I said. Do you see an harmful side effects by exchanging >>>>> the dictionary? >>>> >>>> No - we've fixed this a long time ago in our code base. >>>> >>>> Cheers, >>>> - Andreas >>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 18, 2008

Re: [Pharo-project] [Fwd: [squeak-dev] Re: Bug in object finalization?]

by Adrian Lienhard

Thanks, Norbert, I integrated your change. I changed the migration script to make it also work if people do updates in an image that already has values registered for finalization, and for all existing weak registries, not only for the finalization registry. Like this the code and the state are in sync: WeakRegistry allInstancesDo: [ :each | (each instVarNamed: 'valueDictionary') primitiveChangeClassTo: WeakIdentityKeyDictionary basicNew; rehash ]. Cheers, Adrian On Jun 18, 2008, at 21:40 , Norbert Hartl wrote: > On Wed, 2008-06-18 at 21:37 +0200, Adrian Lienhard wrote: >> Hi Norbert, >> >> We do this kind of scripts in the ScriptLoader. Just let me know when >> you published your slice and I will prepare the ScriptLoader update >> script which Stef can then push into the update stream. >> > I published the slice 1 minute before sending the mail :) > > Have fun, > > Norbert >> Adrian >> >> On Jun 18, 2008, at 19:30 , Norbert Hartl wrote: >> >>> So, >>> >>> now I'm all for fixing it and ressurect the test case. >>> I'll upload something to PharoInbox. Afterwards it needs >>> to be reinitialized. What is the preferred way of having >>> doits in the update stream? >>> >>> Anyway I uploaded SLICE-WeakRegistryAndFinalizerTestFix >>> to PharoInbox. >>> >>> afterwards a >>> >>> WeakRegistry default initialize: WeakRegistry default size >>> >>> will be necessary. >>> >>> Norbert >>> >>> From: Andreas Raab <andreas.raab(a)gmx.de> >>> Date: June 18, 2008 7:02:11 PM GMT+02:00 >>> To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org >>>> >>> Subject: [squeak-dev] Re: Bug in object finalization? >>> Reply-To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org >>>> >>> >>> >>> Norbert Hartl wrote: >>>> On Wed, 2008-06-18 at 09:22 -0700, Andreas Raab wrote: >>>>> Norbert Hartl wrote: >>>>>> There was a test in 3.9 testing this (it failed). In 3.10 >>>>>> the test got removed but I think it is a bug. >>>>>> >>>>>> What do you think? >>>>> The test itself is buggy (see http://bugs.squeak.org/view.php?id=6347) >>>>> but once you fix the test it illustrates a problem in >>>>> WeakRegistry which needs to use a WeakIdentityKeyDictionary >>>>> instead of a WeakKeyDictionary. >>>>> >>>> Ok, what I said. Do you see an harmful side effects by exchanging >>>> the dictionary? >>> >>> No - we've fixed this a long time ago in our code base. >>> >>> Cheers, >>> - Andreas >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 18, 2008

Re: [Pharo-project] [Fwd: [squeak-dev] Re: Bug in object finalization?]

by StÃ©phane Ducasse

Hi norbert did you read the answer of nicolas on squeak-dev on your question. I read the mantis entry he mentioned but i read superficially. :) Stef On Jun 18, 2008, at 9:40 PM, Norbert Hartl wrote: > On Wed, 2008-06-18 at 21:37 +0200, Adrian Lienhard wrote: >> Hi Norbert, >> >> We do this kind of scripts in the ScriptLoader. Just let me know when >> you published your slice and I will prepare the ScriptLoader update >> script which Stef can then push into the update stream. >> > I published the slice 1 minute before sending the mail :) > > Have fun, > > Norbert >> Adrian >> >> On Jun 18, 2008, at 19:30 , Norbert Hartl wrote: >> >>> So, >>> >>> now I'm all for fixing it and ressurect the test case. >>> I'll upload something to PharoInbox. Afterwards it needs >>> to be reinitialized. What is the preferred way of having >>> doits in the update stream? >>> >>> Anyway I uploaded SLICE-WeakRegistryAndFinalizerTestFix >>> to PharoInbox. >>> >>> afterwards a >>> >>> WeakRegistry default initialize: WeakRegistry default size >>> >>> will be necessary. >>> >>> Norbert >>> >>> From: Andreas Raab <andreas.raab(a)gmx.de> >>> Date: June 18, 2008 7:02:11 PM GMT+02:00 >>> To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org >>>> >>> Subject: [squeak-dev] Re: Bug in object finalization? >>> Reply-To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org >>>> >>> >>> >>> Norbert Hartl wrote: >>>> On Wed, 2008-06-18 at 09:22 -0700, Andreas Raab wrote: >>>>> Norbert Hartl wrote: >>>>>> There was a test in 3.9 testing this (it failed). In 3.10 >>>>>> the test got removed but I think it is a bug. >>>>>> >>>>>> What do you think? >>>>> The test itself is buggy (see http://bugs.squeak.org/view.php?id=6347) >>>>> but once you fix the test it illustrates a problem in >>>>> WeakRegistry which needs to use a WeakIdentityKeyDictionary >>>>> instead of a WeakKeyDictionary. >>>>> >>>> Ok, what I said. Do you see an harmful side effects by exchanging >>>> the dictionary? >>> >>> No - we've fixed this a long time ago in our code base. >>> >>> Cheers, >>> - Andreas >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 18, 2008

[Pharo-project] Fwd:

by StÃ©phane Ducasse

Begin forwarded message: > From: Samuel MORELLO <samuel.morello(a)ouvanous.com> > Date: June 18, 2008 7:59:53 PM CEDT > To: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > > > StÃ©pahne, > > Peux tu me dire si cette version va mieux ? > Jai essayÃ© avec un n mais ca ne va pas des masses. > J'ai ecartÃ© l'espace entre 'l'oeil' et le base du phare. En petit > ca passe mieux. > > Qu'en pesnes tu ? > HÃ©sites pas a dire quoi > > Merci > Sam

June 18, 2008

Re: [Pharo-project] [Fwd: [squeak-dev] Re: Bug in object finalization?]

by Norbert Hartl

On Wed, 2008-06-18 at 21:37 +0200, Adrian Lienhard wrote: > Hi Norbert, > > We do this kind of scripts in the ScriptLoader. Just let me know when > you published your slice and I will prepare the ScriptLoader update > script which Stef can then push into the update stream. > I published the slice 1 minute before sending the mail :) Have fun, Norbert > Adrian > > On Jun 18, 2008, at 19:30 , Norbert Hartl wrote: > > > So, > > > > now I'm all for fixing it and ressurect the test case. > > I'll upload something to PharoInbox. Afterwards it needs > > to be reinitialized. What is the preferred way of having > > doits in the update stream? > > > > Anyway I uploaded SLICE-WeakRegistryAndFinalizerTestFix > > to PharoInbox. > > > > afterwards a > > > > WeakRegistry default initialize: WeakRegistry default size > > > > will be necessary. > > > > Norbert > > > > From: Andreas Raab <andreas.raab(a)gmx.de> > > Date: June 18, 2008 7:02:11 PM GMT+02:00 > > To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org > > > > > Subject: [squeak-dev] Re: Bug in object finalization? > > Reply-To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org > > > > > > > > > Norbert Hartl wrote: > >> On Wed, 2008-06-18 at 09:22 -0700, Andreas Raab wrote: > >>> Norbert Hartl wrote: > >>>> There was a test in 3.9 testing this (it failed). In 3.10 > >>>> the test got removed but I think it is a bug. > >>>> > >>>> What do you think? > >>> The test itself is buggy (see http://bugs.squeak.org/view.php?id=6347) > >>> but once you fix the test it illustrates a problem in > >>> WeakRegistry which needs to use a WeakIdentityKeyDictionary > >>> instead of a WeakKeyDictionary. > >>> > >> Ok, what I said. Do you see an harmful side effects by exchanging > >> the dictionary? > > > > No - we've fixed this a long time ago in our code base. > > > > Cheers, > > - Andreas > > > > > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 18, 2008

Re: [Pharo-project] [Fwd: [squeak-dev] Re: Bug in object finalization?]

by Adrian Lienhard

Hi Norbert, We do this kind of scripts in the ScriptLoader. Just let me know when you published your slice and I will prepare the ScriptLoader update script which Stef can then push into the update stream. Adrian On Jun 18, 2008, at 19:30 , Norbert Hartl wrote: > So, > > now I'm all for fixing it and ressurect the test case. > I'll upload something to PharoInbox. Afterwards it needs > to be reinitialized. What is the preferred way of having > doits in the update stream? > > Anyway I uploaded SLICE-WeakRegistryAndFinalizerTestFix > to PharoInbox. > > afterwards a > > WeakRegistry default initialize: WeakRegistry default size > > will be necessary. > > Norbert > > From: Andreas Raab <andreas.raab(a)gmx.de> > Date: June 18, 2008 7:02:11 PM GMT+02:00 > To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org > > > Subject: [squeak-dev] Re: Bug in object finalization? > Reply-To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org > > > > > Norbert Hartl wrote: >> On Wed, 2008-06-18 at 09:22 -0700, Andreas Raab wrote: >>> Norbert Hartl wrote: >>>> There was a test in 3.9 testing this (it failed). In 3.10 >>>> the test got removed but I think it is a bug. >>>> >>>> What do you think? >>> The test itself is buggy (see http://bugs.squeak.org/view.php?id=6347) >>> but once you fix the test it illustrates a problem in >>> WeakRegistry which needs to use a WeakIdentityKeyDictionary >>> instead of a WeakKeyDictionary. >>> >> Ok, what I said. Do you see an harmful side effects by exchanging >> the dictionary? > > No - we've fixed this a long time ago in our code base. > > Cheers, > - Andreas > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 18, 2008

[Pharo-project] [Fwd: [squeak-dev] Re: Bug in object finalization?]

by Norbert Hartl

So, now I'm all for fixing it and ressurect the test case. I'll upload something to PharoInbox. Afterwards it needs to be reinitialized. What is the preferred way of having doits in the update stream? Anyway I uploaded SLICE-WeakRegistryAndFinalizerTestFix to PharoInbox. afterwards a WeakRegistry default initialize: WeakRegistry default size will be necessary. Norbert

June 18, 2008

Re: [Pharo-project] Logos

by Norbert Hartl

On Wed, 2008-06-18 at 12:52 -0400, Victor Rodriguez wrote: > On Wed, Jun 18, 2008 at 12:34 PM, Michael Rueger <m.rueger(a)acm.org> wrote: > > Victor Rodriguez wrote: > >> > >> On Wed, Jun 18, 2008 at 8:05 AM, Damien Pollet <damien.pollet(a)gmail.com> > >> wrote: > >> ... > >>> > >>> Maybe make the white stripes thinner than the dark ones ? > >>> Also without the circle it misses some kind of base, maybe a wave that > >>> would suggest the curvature of the circle if it were there ? > >>> > >>> The red eye looks a little Terminator-esque, somewhat menacing :-) > >> > >> I think you mean Tolkien-esque, the eye of Sauron anyone? :-) > > > > Yes, that was the first thing I noticed. Maybe making it more a > > yellow/orange tone would help? > > I thought about yellow too, but didn't say anything since yellow might > become hard to see in lgiht backgrounds. > Which is exactly as it is. A light background could be called day light. As the light is hard to see when it is day they switch it off :) That is the main problem I think. In the day light you can see the lighthouse building but no light. At night there is only a shape of a building but light. So it is difficult to show both at the same time. Norbert > Indeed, I shouldn't say anything at all, since I don't really know > about graphical design. :-) Which is why I really appreciate Samuel > Morello's work, thanks! > > Victor. > > > Michael > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

June 18, 2008

Re: [Pharo-project] Logos

by Victor Rodriguez

On Wed, Jun 18, 2008 at 12:34 PM, Michael Rueger <m.rueger(a)acm.org> wrote: > Victor Rodriguez wrote: >> >> On Wed, Jun 18, 2008 at 8:05 AM, Damien Pollet <damien.pollet(a)gmail.com> >> wrote: >> ... >>> >>> Maybe make the white stripes thinner than the dark ones ? >>> Also without the circle it misses some kind of base, maybe a wave that >>> would suggest the curvature of the circle if it were there ? >>> >>> The red eye looks a little Terminator-esque, somewhat menacing :-) >> >> I think you mean Tolkien-esque, the eye of Sauron anyone? :-) > > Yes, that was the first thing I noticed. Maybe making it more a > yellow/orange tone would help? I thought about yellow too, but didn't say anything since yellow might become hard to see in lgiht backgrounds. Indeed, I shouldn't say anything at all, since I don't really know about graphical design. :-) Which is why I really appreciate Samuel Morello's work, thanks! Victor. > Michael > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

June 18, 2008