On Fri, 2008-06-20 at 10:40 +0200, Adrian Lienhard wrote:
hehe, I was also working on those MC tests right now. For MCWorkingCopyTest>>setUp I don't think you need..
repositoryGroup removeRepository: MCCacheRepository default.
Oops, didn't notice I left it in. That was the first approach before recognizing that it is useless :)
..as the cache repository is not stored in the group. Else I think your changes are good. Better than what they did in 3.10, which is to just remove the test ;)
I had a look afterwards, too! And that is the next test I find to be removed from 3.10. There is always more than one way to have green tests ;) Norbert
---
What do we do with #testUnimplementedNonPrimitiveCalls? It was removed in 3.10 with comment: "This is not really a unit test but a lint test. The results are interesting in that they point to possible errors, but this should be handled in a different context." [1] I suggest that we also remove it. But this method is a good source for cleanup. We should go though the list to fix stuff.
Adrian
[1] http://wiki.squeak.org/squeak/5889
On Jun 20, 2008, at 10:24 , Norbert Hartl wrote:
I uploaded
Monticello-NorbertHartl.317
to PharoInbox. That fixes two Monticello tests. After this fix I have 4 failures left.
Norbert
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project