- Pharo-dev - lists.pharo.org

[Pharo-project] Debugging with morphic

by Alexandre Bergel

Hi All (and especially the Pinesoft crew), When an error is triggered by a displayOn: method, the bottom bar is being filled with debugger windows. It then become hardly debuggable. Ideally, the system should not display a window if an error is triggered in the displayOn. Do you have any recommandation/conviention/enhancement to prevent the image to hang when an error is signaled in a displayOn. This is really annoying. Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Feb. 14, 2009

Re: [Pharo-project] methods equivalently defined in superclass

by Gary Chambers

DialogWindow>#newText: (trait oddity remnant, removed in next version). Project>>#windowActiveOnFirstClick (will disappear when Project does, probably then the whole method should go...) MCDependentsWrapper>>#item (added by Polymorph in superclass since obviously useful, MC defines it for same reason but in its own classes, same goes for all subclass implementors). UIThemeWatery2>>#controlButtonMouseOverFillStyleFor: (removed in next version) UIThemeSoftSqueak>>* (removed in next version) PSMCChangeWrapper>>#isConflict (amiguous as to whehter MC should define this in Object so will remain). PluggableTreeMorph>>#getMenuSelector: (depends on wheteher Polymorph is present or not, will remain) StandardWindow>>#preferredCornerStyle (taken via trait, trait has potentially conflicting usage so will be removed from TEasilyThemed in next version) UIThemeVistary>>#scrollbarPressedButtonFillStyleFor: (removed in next version) ExampleBuilderMorph>>#preferredCornerStyle (see StandardWindow>>#preferredCornerStyle comment) Regards, Gary ----- Original Message ----- From: "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> To: "Pharo Development" <Pharo-project(a)lists.gforge.inria.fr> Sent: Saturday, February 14, 2009 3:20 PM Subject: [Pharo-project] methods equivalently defined in superclass >I imagine that we could fix that too :) > > Check for methods that are equivalent to their superclass methods. > Such methods don't add anything to the computation and can be removed > since the superclass's method will work just fine. > > ParseNode>>#isComplex > ParseNode>>#isLiteral > Project>>#windowActiveOnFirstClick > SortedCollectionTest>>#testIfNotEmptyifEmpty > SortedCollectionTest>>#testIfNotEmptyDoifNotEmpty > SortedCollectionTest>>#testIfNotEmptyDo > SortedCollectionTest>>#testIfNotEmpty > SortedCollectionTest>>#testIsEmpty > SortedCollectionTest>>#testIsEmptyOrNil > SortedCollectionTest>>#testIfEmptyifNotEmpty > SortedCollectionTest>>#testIfEmptyifNotEmptyDo > ClockMorph>>#stepTime > SqueakInstvarInterfaceExtractor>>#popIntoTemporaryVariable: > SqueakInstvarInterfaceExtractor>>#storeIntoTemporaryVariable: > SqueakInstvarInterfaceExtractor>>#storeIntoLiteralVariable: > DialogWindow>>#newText: > MCDependentsWrapper>>#item > OBCmdRenameCat>>#group > Integer>>#printOn:base: > StringSocketStream>>#shrinkInBuf > FloatingBookControlsMorph>>#stepTime > OBCmdViewChanges>>#group > OBMonticelloClassCategoryNode>>#isDescendantOfClass: > OBMultipleSelectionColumnPanel>>#emptyColumn > PluggableListItemWrapper>>#item > DisplayObject>>#isTransparent > FreeTypeEmbeddedFileInfo>>#familyGroupName > ProgressInitiationException>>#isResumable > TableMorph>>#preferredCornerStyle > RBPseudoNode>>#isBlock > LintRule>>#initialize > SetTest>>#test0TSizeTest > SetTest>>#testSize > UIThemeStandardSqueak>>#dockingBarNormalFillStyleFor: > OBPluggableCommand>>#takesNodes > OBPluggableCommand>>#group > PluggableTreeItemNode>>#item > RBToken>>#isLiteral > UIThemeWatery2>>#controlButtonMouseOverFillStyleFor: > AbstractType>>#initialize > OBCmdCheckRecentStatus>>#group > WeakKeyDictionary>>#scanFor: > UPStable>>#changeUser:withPassword:toHavePassword:andNewEmail: > UPStable>>#addUser:withPassword:andEmail: > IslandVMTweaksTestCase>>#someObject > PostscriptCanvas>>#fillRectangle:fillStyle: > OBMonticelloPackageNode>>#isDescendantOfClass: > OBMMethodInvocationQuery>>#keyWord > FormCanvas>>#fillRectangle:fillStyle: > OBCmdSearchGroupClassRefs>>#group > FreeTypeFileInfo>>#familyGroupName > OBCmdToggleBreak>>#group > UIThemeSoftSqueak>>#tasklistFillStyleFor: > UIThemeSoftSqueak>>#buttonPanelNormalFillStyleFor: > UIThemeSoftSqueak>>#progressBarFillStyleFor: > UIThemeSoftSqueak>>#taskbarFillStyleFor: > UIThemeSoftSqueak>>#dockingBarNormalFillStyleFor: > UIThemeSoftSqueak>>#progressBarProgressFillStyleFor: > UIThemeSoftSqueak>>#scrollbarNormalFillStyleFor: > OBCollaboratorsSearchNode>>#setRawQuery: > OBCollaboratorsSearchNode>>#isDescendantOfClass: > OBCmdAddSmartCategory>>#group > OBCmdOpenMC>>#group > OBSmartGroupBrowser>>#isSearchBrowser > OBSmartGroupBrowser>>#cmdRemoveFromSmartGroup > OBSmartGroupBrowser>>#cmdBrowse > OBSmartGroupBrowser>>#cmdRenameSmartCategory > OBSmartGroupBrowser>>#cmdAddToSmartGroup > OBSmartGroupBrowser>>#cmdAddSmartCategory > MethodContext>>#cachesStack > PSMCChangeWrapper>>#isConflict > Notification>>#isResumable > OBCmdViewHistory>>#group > OBMethodInvocationSearchNode>>#setRawQuery: > ColumnMorph>>#preferredCornerStyle > PluggableTreeMorph>>#getMenuSelector: > OBMultipleDefinitionPanel>>#isDefinition > RBProgramNodeVisitor>>#postCopy > StandardWindow>>#preferredCornerStyle > UIThemeVistary>>#scrollbarPressedButtonFillStyleFor: > RefactoryChange>>#initialize > RefactoryChange>>#postCopy > OBCmdResetSearchSmartGroups>>#group > OBCollectionNode>>#isEnvironment > Refactoring>>#initialize > OBCmdSearchGroupImplementors>>#group > BagTest>>#expectedElementByDetect > OBCmdBrowsePackage>>#group > WeakSet>>#size > ExampleBuilderMorph>>#preferredCornerStyle > OBCmdAddWorkingCopy>>#group > OBCmdMethodToExtendClass>>#group > OBCmdSearchGroupSenders>>#group > OBCmdImportPackage>>#group > OBCmdUpdatePackage>>#group > RxmLink>>#initialize > PluggableMultiColumnListMorph>>#highlightSelection > PluggableMultiColumnListMorph>>#unhighlightSelection > PseudoClass>>#isTrait > RxsCharacter>>#isNullable > XMLNode>>#isText > OBCodeNode>>#annotationString > OBCodeNode>>#shouldBeStyledBy: > OBCmdFocusOnClassInHierarchy>>#isActive > RBScanner>>#flush > FT2Face>>#handle > RxsPredicate>>#isAtomic > OBCmdPublishPackage>>#group > RBSmallDictionary>>#size > BorderStyle>>#isComplex > BrowserEnvironment>>#initialize > BrowserEnvironment>>#postCopy > BrowserEnvironment>>#copy > ArrayTest>>#element > HostSystemMenus>>#initialize > RBProgramNode>>#isBlock > RBProgramNode>>#isLiteral > RBProgramNode>>#isArray > UMProtocolVers... > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Feb. 14, 2009

Re: [Pharo-project] Sends unknown message to global

by Gary Chambers

What is the unknown message for UITheme..#newColorPresenterIn:for:getColor:setColor:help: ? Looks ok here. Regards, Gary ----- Original Message ----- From: "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> To: "Pharo Development" <Pharo-project(a)lists.gforge.inria.fr> Sent: Saturday, February 14, 2009 1:23 PM Subject: [Pharo-project] Sends unknown message to global > same here: would be good to define bugfix entries for each of them. > > Stef > > TTSampleStringMorph>>#initializeToStandAlone > Character>>#storeBinaryOn: > EFontBDFFontReaderForRanges > >>#override:with:ranges:transcodingTable:additionalRange: > InstallerMonticello>>#unloadCleanUp > ServerDirectory>>#createDirectory: > ServerDirectory>>#deleteDirectory: > CompiledMethod>>#searchImageForHomeMethod > SMSimpleInstaller>>#fileIntoChangeSetNamed:fromStream: > UITheme>>#newColorPresenterIn:for:getColor:setColor:help: > SystemDictionary>>#unbindExternalPrimitives > UIMonticello>>#installFileNamed:fromURL: > TabSorterMorph>>#acceptSort > MCPackageLoader>>#useChangeSetNamed:during: > InstallerFile>>#basicView > InstallerFile>>#basicBrowse > URI>>#mimeType > StrikeFont>>#readEFontBDFFromFile:name:rangeFrom:to: > StrikeFont>>#readEFontBDFForJapaneseFromFile:name:overrideWith: > StrikeFont>>#readEFontBDFForKoreanFromFile:name:overrideWith: > StrikeFont>>#readEFontBDFFromFile:name:ranges: > Morph>>#showActions > OBTreeFanTests>>#makeTreeFanStructure > MczInstaller>>#useNewChangeSetDuring: > TranslatedReceiverFinder class>>#makeJapaneseTranslationFile > SARInstaller class>>#newChanges: > SARInstaller class>>#currentChangeSet > Transcripter class>>#startTranscriptProcess > RxParser class>>#doHandlingMessageNotUnderstood: > NaturalLanguageTranslator class>>#default > Utilities class>>#authorNamePerSe > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Feb. 14, 2009

Re: [Pharo-project] undeclared variables

by Gary Chambers

Will be fixed (#sounds/#sounds: being redundant after refactoring) in next version of Polymorph. Project>>finalEnterActions is trickier (as ProjectNavigationMorph has been removed). The Polymorph override is there to deal with some peoples (Squeak) gripes about taskbars in projects. Regards, Gary ----- Original Message ----- From: "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> To: "Pharo Development" <Pharo-project(a)lists.gforge.inria.fr> Sent: Saturday, February 14, 2009 1:16 PM Subject: [Pharo-project] undeclared variables > Hi all > > It would be good to fix such problems in their respective packages. > > Stef > > Checks for references to a variable in the Undeclared dictionary. If > you remove a variable from a class that is accessed by a method, you > will create an undeclared variable reference for those methods that > accessed the variable. > > OBEnhancementColumn>>#selection: > Project>>#finalEnterActions > OBClosableDefinitionPanel>>#commands > OBTextMorphEditorWithShout>>#correctFrom:to:with: > OBCollaboratorsSearchNode>>#classes > MCPackageManager>>#modifiedTimeStamp > UITheme>>#sounds: > UITheme>>#sounds > InstallerCruft>>#user > InstallerCruft>>#createRBforBug: > InstallerCruft>>#user: > OBEnrichedDefinitionPanel>>#selectReferencingCodeNodes: > OBEnrichedDefinitionPanel>>#accept:notifying: > OBMethodInvocationSearchNode>>#classes > PasteUpMorph>>#scriptorForTextualScript:ofPlayer: > Installer>>#installMCcs:from: > Installer>>#printOn: > OBEnrichedMethodInvocationNode>>#source > OBEnrichedMethodInvocationNode>>#modelMethod > OBEnrichedMethodInvocationNode>>#invokingClasses > OBTreeColumnTests>>#test09JumpToE2 > OBTreeColumnTests>>#test12JumpToD3 > OBTreeColumnTests>>#test10JumpToD1 > OBTreeColumnTests>>#test01AllInOneColumn > OBTreeColumnTests>>#test17JumpToG1 > OBTreeColumnTests>>#test06JumpToC2 > OBTreeColumnTests>>#test19JumpToA1 > OBTreeColumnTests>>#test02AllInOneColumn > OBTreeColumnTests>>#test04JumpToB2 > OBTreeColumnTests>>#test14JumpToF1 > OBTreeColumnTests>>#test08JumpToE1 > OBTreeColumnTests>>#test07JumpToC1 > OBTreeColumnTests>>#test11JumpToD2 > OBTreeColumnTests>>#test13JumpToD4 > OBTreeColumnTests>>#test03NodeWithBothTreeChildrenAndDefaultChildren > OBTreeColumnTests>>#test05JumpToB1 > OBTreeColumnTests>>#test18JumpToG2 > OBTreeColumnTests>>#columnPanelABCDEFGH > OBTreeColumnTests>>#test16JumpToH1 > OBTreeColumnTests>>#test15JumpToF2 > OBEnrichedMethodNode>>#source > OBEnrichedMethodNode>>#updateModelMethod > OBEnrichedClassNode>>#formatter > DictionaryTest>>#flattenOnStream > OBEnhPackageNodeTest>>#testPackage > OBEnhPackageNodeTest>>#testTemplate > OBEnhPackageNodeTest>>#setUp > OBPosition>>#asTreePosition > Refactoring class>>#initializeRefactoringOptions > OBEnrichedMessageNode class>>#on:inMethod:inClass: > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Feb. 14, 2009

Re: [Pharo-project] Fwd: A question about hardcoded class names

by Lukas Renggli

> Now we thought that replacing them with self class is not equivalent > since we could imagine > that hardcoding the class name make sure that subclass cannot redefine > methods. No, in many cases this is not equivalent. In my opinion the rule could avoid many false positives if it would only trigger if there are no subclasses. Of course we would then also get more false negatives. > But I wanted to know what was your experiment to that regards. Two typical false positives I encountered: 1. Factory or builder methods on the class side usually refer to a wide variety of classes. Sometimes such methods also refer to the receiving class, however since you want to make the method also work when called on subclasses you have to hardcode the receiving class. 2. When collecting pragmas you usually write something along: PRErrorView>>renderOptionsOn: html (Pragma allNamed: #option: from: self class to: PRErrorView) do: [ :each | ... ] Given that PRErrorView has the subclasses PRForbiddenView and PRNotFoundView, there are cases where "self class" is not equal to PRErrorView. And the point of the above code is to find all pragmas, up to PRErrorView. Cheers, Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Feb. 14, 2009

[Pharo-project] Fwd: A question about hardcoded class names

by StÃ©phane Ducasse

Hi guys some days ago with alex we wanted to identify the methods containing a reference to their class (Lint does it too). Now we thought that replacing them with self class is not equivalent since we could imagine that hardcoding the class name make sure that subclass cannot redefine methods. Now this is a bit against Smalltalk late bindinness and probably most of the time an newbie error. But I wanted to know what was your experiment to that regards. Stef

Feb. 14, 2009

[Pharo-project] Refers to class name instead of self class

by StÃ©phane Ducasse

Checks for classes that have their class name directly in the source instead of "self class". The self class variant allows you to create subclasses without needing to redefine that method. Project>>#compileAllIsolated:from: Project>>#initializeProjectPreferences Project>>#subProjects Project>>#storeToMakeRoom Project>>#armsLengthCommand:withDescription: Project>>#findProjectView: Project>>#flapsSuppressed: Project>>#fromMyServerLoad: Project>>#showWorldMainDockingBar: Project>>#assureFlapIntegrity Project>>#showSharedFlaps Project>>#decideAboutCreatingBlank: Project>>#children Project>>#versionFrom: Project>>#cleanseDisabledGlobalFlapIDsList Project>>#ensureChangeSetNameUnique Project>>#storeSomeSegment Project>>#hasBadNameForStoring Project>>#exportSegmentWithChangeSet:fileName:directory: Project>>#storeDataOn: Project>>#finalEnterActions Project>>#enter:revert:saveForRevert: Project>>#showWorldTaskbar: Project>>#okToChange Project>>#depth Parser>>#pragmaPrimitives SMDependencyAnalysis>>#installPackageReleases: MenuMorph>>#deleteIfPopUp MenuMorph>>#popUpAt:forHand:in:allowKeyboard: MenuMorph>>#addSubmenu:enabled: Integer>>#digitLogic:op:length: Integer>>#digitLshift: Integer>>#digitRshift:bytes:lookfirst: Integer>>#digitSubtract: Integer>>#digitDiv:neg: Integer>>#digitAdd: Integer>>#digitMultiply:neg: Arc>>#displayOn:transformation:clippingBox:rule:fillColor: PopUpMenu>>#startUpSegmented:withCaption:at:allowKeyboard: UUniverseMultiServer>>#initialize MorphThumbnail >>#representativeNoTallerThan:norWiderThan:thumbnailHeight: SystemDictionary>>#discardOddsAndEnds SystemDictionary>>#majorShrink MenuItemMorph>>#deselectItem Form>>#shapeFill:seedBlock: Form>>#borderFormOfWidth:sharpCorners: Form>>#pageImage:at:corner: Form>>#orderedDither32To16 Form>>#wipeImage:at:clippingBox:rectForIndex: Form>>#fadeImage:at:indexAndMaskDo: Form>>#yTallyPixelValue:orNot: Form>>#asFormOfDepth: Form>>#shapeBorder:width: Form>>#mapColors:to: Form>>#allocateForm: Form>>#replaceColor:withColor: Form>>#asGrayScale Form>>#smear:distance: Form>>#scaledIntoFormOfSize: Form>>#makeBWForm: Form>>#eraseShape: Form>>#readFromOldFormat: Form>>#copyBits:from:at:colorMap: Form>>#displayResourceFormOn: Form>>#copy: Form>>#displayScaledOn: Form>>#readResourceFrom: Form>>#rectangleEnclosingPixelsNotOfColor: Form>>#findShapeAroundSeedBlock: Form>>#xTallyPixelValue:orNot: Form>>#slideImage:at:delta: Form>>#pageWarp:at:forward: Form>>#anyShapeFill Form>>#convexShapeFill: Form>>#contentsOfArea:into: Form>>#floodFill:at:tolerance: Form>>#mapColor:to: Form>>#shapeFill:interiorPoint: Form>>#colorReduced Form>>#fromDisplay: Form>>#rotateBy:magnify:smoothing: Form>>#displayOnPort:at: Form>>#privateFloodFillValue: SketchMorph>>#wantsSimpleSketchMorphHandles SmallInteger>>#quo: SmallInteger>>#digitAt: SmallInteger>>#/ KeyedTree>>#subtrees KeyedTree>>#merge: KeyedTree>>#copy ReadWriteStream>>#hash ReadWriteStream>>#= MessageSet>>#initializeMessageList: MessageSet>>#setClassAndSelectorIn: MorphicTransform>>#inverseTransformation ChangeList>>#selectConflictsWith OBMonticelloPackageNode>>#findClass SMLoader>>#reOpen InstructionStream>>#skipBackBeforeJump Object>>#deepCopy PianoRollNoteMorph>>#mouseDown: Set>>#collect: Set>>#= AlignmentMorph>>#canHaveFillStyles OBClassNode>>#classHierarchy OBClassNode>>#packagesForClassClass Rectangle>>#roundTo: Rectangle>>#insetOriginBy:cornerBy: Rectangle>>#insetBy: Rectangle>>#expandBy: Rectangle>>#truncated Rectangle>>#intersect: Rectangle>>#compressed Rectangle>>#expandTo: Rectangle>>#truncateTo: Rectangle>>#rounded Rectangle>>#encompass: Rectangle>>#expanded Rectangle>>#scaleBy: Rectangle>>#merge: Rectangle>>#compressTo: Rectangle>>#quickMerge: Rectangle>>#isSelfEvaluating Rectangle>>#translateBy: Rectangle>>#extendBy: Rectangle>>#outsetBy: SequenceableCollection>>#hasEqualElements: FileDirectoryWrapper>>#contents SqueakPage>>#urlNoOverwrite: TextComposer>>#composeEachRectangleIn: TextComposer>>#slideOneLineDown WaveEditor>>#showFFTAtCursor WaveEditor>>#showEnvelope ColorMap>>#inverseMap ColorMap>>#mappingTo: Socket>>#receiveDataWithTimeoutInto:startingAt: Socket>>#connectTo:port: Socket>>#localPort Socket>>#waitForConnectionFor:ifTimedOut: Socket>>#accept Socket>>#waitForSendDoneFor: Socket>>#localAddress Socket>>#waitFor...

Feb. 14, 2009

[Pharo-project] Possibly unnecessary yourself message

by StÃ©phane Ducasse

Check for methods sending the yourself message when it is not necessary. SmartRefStream>>#initKnownRenames BookMorph>>#forgetURLs FontChooserMorph>>#newPointSizeList FontChooserMorph>>#newFontStyleList FontChooserMorph>>#newFontList OBButtonBar>>#initGeometry MIMEType class>>#standardMIMETypes2 MIMEType class>>#standardMIMETypes MIMEType class>>#initializeDefaultSuffixes HTTPClient class>>#examplePostArgs HTTPClient class>>#examplePostMultipart LanguageEditor class>>#initCheckMethods Locale class>>#migrateSystem Locale class>>#initializePlatformEncodings

Feb. 14, 2009

Re: [Pharo-project] about getting more SmallLint rules

by StÃ©phane Ducasse

On Feb 14, 2009, at 2:14 PM, Adrian Lienhard wrote: > > On Feb 14, 2009, at 13:54 , StÃ©phane Ducasse wrote: > >> TX!!!! >> I think that we should be more aggressive with the tools we have. >> I'm currently going over the 25000 issues raised by SmallLint and >> entering issues in the bugtracker. > > wow, great! > >> I think that we will need to add annotations so that smallLint does >> not get warning us >> when we know that this is not a problem > > yes, this is very important. We do that with pragmas (see Lukas' > mail). Lint rules are part of the conventional tests and the rule is > that these must be green. There are cases where Lint complains but you > know it is ok. If we couldn't annotate these methods as ok, the whole > thing would not work. > > In the long term, I think it would be really cool if we manage to get > the Pharo core Lint-clean! YESYESYES!!! We have great tools and an extremely powerful language and we should use them to make the code robust, nice and cool. Stef

Feb. 14, 2009

[Pharo-project] unnecessary temporary variable assignment

by StÃ©phane Ducasse

Collection>>#groupBy:having: XMLTokenizer>>#next MCFileRepositoryInspector>>#versionList ServerDirectory>>#exists

Feb. 14, 2009