- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Why is Stack extending from LinkedList?

by Levente Uzonyi

On Thu, 26 Aug 2010, Lukas Renggli wrote: > I wonder why there is the need for a stack class at all? > > OrderedCollection is the class designed to do Stacks and Queues > efficiently and portably, see #addFirst:, #addLast:, #first, #last, > #removeFirst, #removeLast. If so, then there are some problems: o := OrderedCollection new: 1000. 1 to: 1000 do: [ :each | o add: each ]. [ 100000 timesRepeat: [ o addFirst: o removeLast ] ] timeToRun. "===> 11660" Levente > > Lukas > > 2010/8/26 Bart Gauquie <bart.gauquie(a)gmail.com>: >> Hi list, >> >> is there a specific reason Stack is extending from LinkedList, instead of >> using a LinkedList internally? >> To me, it seems that the protocol that LinkedList, SequenceableCollection, >> ... provides is not the protocol you expect from a Stack? >> >> Any thoughts on this? >> >> Kind regards, >> >> Bart >> >> -- >> imagination is more important than knowledge - Albert Einstein >> Logic will get you from A to B. Imagination will take you everywhere - >> Albert Einstein >> Learn from yesterday, live for today, hope for tomorrow. The important thing >> is not to stop questioning. - Albert Einstein >> The true sign of intelligence is not knowledge but imagination. - Albert >> Einstein >> However beautiful the strategy, you should occasionally look at the results. >> - Sir Winston Churchill >> It's not enough that we do our best; sometimes we have to do what's >> required. - Sir Winston Churchill >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Aug. 27, 2010

Re: [Pharo-project] Why is Stack extending from LinkedList?

by Levente Uzonyi

On Thu, 26 Aug 2010, Bart Gauquie wrote: > Hi list, > > is there a specific reason Stack is extending from LinkedList, instead of > using a LinkedList internally? > To me, it seems that the protocol that LinkedList, SequenceableCollection, > ... provides is not the protocol you expect from a Stack? > > Any thoughts on this? Originally it used encapsulation, but for some reason it was changed to use inheritance, probably for a "cleaner" system. IMHO the changes should be reverted. Levente > > Kind regards, > > Bart > > -- > imagination is more important than knowledge - Albert Einstein > Logic will get you from A to B. Imagination will take you everywhere - > Albert Einstein > Learn from yesterday, live for today, hope for tomorrow. The important thing > is not to stop questioning. - Albert Einstein > The true sign of intelligence is not knowledge but imagination. - Albert > Einstein > However beautiful the strategy, you should occasionally look at the results. > - Sir Winston Churchill > It's not enough that we do our best; sometimes we have to do what's > required. - Sir Winston Churchill >

Aug. 27, 2010

Re: [Pharo-project] Why is Stack extending from LinkedList?

by Bart Gauquie

Good thinking, remove Stack then? On Thu, Aug 26, 2010 at 1:33 PM, Lukas Renggli <renggli(a)gmail.com> wrote: > I wonder why there is the need for a stack class at all? > > OrderedCollection is the class designed to do Stacks and Queues > efficiently and portably, see #addFirst:, #addLast:, #first, #last, > #removeFirst, #removeLast. > > Lukas > > 2010/8/26 Bart Gauquie <bart.gauquie(a)gmail.com>: > > Hi list, > > > > is there a specific reason Stack is extending from LinkedList, instead of > > using a LinkedList internally? > > To me, it seems that the protocol that LinkedList, > SequenceableCollection, > > ... provides is not the protocol you expect from a Stack? > > > > Any thoughts on this? > > > > Kind regards, > > > > Bart > > > > -- > > imagination is more important than knowledge - Albert Einstein > > Logic will get you from A to B. Imagination will take you everywhere - > > Albert Einstein > > Learn from yesterday, live for today, hope for tomorrow. The important > thing > > is not to stop questioning. - Albert Einstein > > The true sign of intelligence is not knowledge but imagination. - Albert > > Einstein > > However beautiful the strategy, you should occasionally look at the > results. > > - Sir Winston Churchill > > It's not enough that we do our best; sometimes we have to do what's > > required. - Sir Winston Churchill > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- imagination is more important than knowledge - Albert Einstein Logic will get you from A to B. Imagination will take you everywhere - Albert Einstein Learn from yesterday, live for today, hope for tomorrow. The important thing is not to stop questioning. - Albert Einstein The true sign of intelligence is not knowledge but imagination. - Albert Einstein However beautiful the strategy, you should occasionally look at the results. - Sir Winston Churchill It's not enough that we do our best; sometimes we have to do what's required. - Sir Winston Churchill

Aug. 27, 2010

Re: [Pharo-project] about ValueAdapter

by Schwab,Wilhelm K

Stef, Got it - I thought you might have meant something completely different. For example, I had a really cool #printOn: method that I had to suppress because the inspector was parsing the text and changing things as a result - arrrrggggGGGGGG!!!!! :) Re other methods in the image. My goal was to be as data driven (off of the format) as possible and to get specific things working quickly. Mostly the latter; I just needed a few types of date and time conversions to work, and to work the same way they did when the code ran in Dolphin. Even if I had looked around, there are always questions: does it work at all, does it work well, will it survive the next sprint? You are doing a wonderful job, so please don't take that as anything negative. Of course, more tests will allow you to clean freely and immediately note that something was critical to the adpaters. Another thing to note, we are under the ValueAdapter thread, but dates and times really fall under type converters. Of course, converters and adapters often work together. A model understands #bodyWeight; a text editor understands #value, and a converter can sit between them to turn the editor's (text) value into a float for the model. It is nice pluggable/serializable stuff that probably makes the most sense in the context of view resources, whether they are saved in binary or not. The 30k ft view is probably to encourage composition rather than to force inheritance. Closures help us. Doing our graphics in Smalltalk can help or hurt, because we can freely change the widgets as needed, which is both valuable freedom and a crutch that can compensate for inflexible design. Bill ________________________________________ From: pharo-project-bounces(a)lists.gforge.inria.fr [pharo-project-bounces(a)lists.gforge.inria.fr] On Behalf Of StÃ©phane Ducasse [stephane.ducasse(a)inria.fr] Sent: Friday, August 27, 2010 9:07 AM To: Pharo-project(a)lists.gforge.inria.fr Subject: Re: [Pharo-project] about ValueAdapter there are a lot of methods to print time and date as well as number and I thought that your adaptor would benefit from them. Stef On Aug 27, 2010, at 1:49 PM, Schwab,Wilhelm K wrote: > Stef, > > I generally spend most of my time trying to avoid having the RB do what you are describing, but it should be that simple, right? > > As you have noticed, the adapters are very crude, but tests are certainly a good idea. One thing that I miss is a good place to put package comments; I tend to write them more than class comments (they not only identify the important classes, but which ones to use and how, all in one place - who then need class comments?), and then relentlessly comment methods as they evolve. That said, I could probably force out a few class comments. > > What do you mean by checking padded printOn? What are they, and how (and for what) would I check them? > > Bill > > > ________________________________________ > From: pharo-project-bounces(a)lists.gforge.inria.fr [pharo-project-bounces(a)lists.gforge.inria.fr] On Behalf Of stephane ducasse [stephane.ducasse(a)free.fr] > Sent: Friday, August 27, 2010 4:28 AM > To: Pharo-project(a)lists.gforge.inria.fr Development > Subject: [Pharo-project] about ValueAdapter > > Bill > > I scanned the code. > Could you > - reformat your code? > put space after : > align on the first tab > - get some more tests? > - I could not see the class comments but if there are none then please adde something. > - did you check the padded printon methods and others? > > Stef > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Aug. 27, 2010

Re: [Pharo-project] what about putting RBengine in pharo1.2 core?

by laurent laffont

On Fri, Aug 27, 2010 at 3:06 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr > wrote: > sure > > this is just that during the unstable phase we need better tools. We want > to run SmallLint. > The problem is that generate a new image every 20 min when I integrate and > I do not want to spend my time load ob and rb. > Hudson isn't your friend for this ? Laurent > After we will unload it. > And yes I should work on a configuration of pharo and rebuild the > scriptloader infrastructure on it :( > > Stef > > On Aug 27, 2010, at 1:41 PM, Lukas Renggli wrote: > > > I wouldn't pre-load it. There is really no point for many deployed > > applications to have it in there. > > > > Lukas > > > > On 27 August 2010 13:33, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > wrote: > >> marcus like that we do not have to load it all the time. > >> I could esaily update scriptloader to make sure that we do not save > these packages. > >> > >> Stef > >> _______________________________________________ > >> Pharo-project mailing list > >> Pharo-project(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >> > > > > > > > > -- > > Lukas Renggli > > www.lukas-renggli.ch > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Aug. 27, 2010

Re: [Pharo-project] [update 1.2] #12116

by Sven Van Caekenberghe

On 27 Aug 2010, at 15:16, StÃ©phane Ducasse wrote: > > 12116 > ----- > > merging webclient pmm 73 It seems that every time I upgrade 1.2a using System>Software Update, the version of WebClient-Test reverts as well. As I told you, your (older) version gives more unit test errors ;-) Sven

Aug. 27, 2010

Re: [Pharo-project] About webclient.ppm.73

by Philippe Marschall

On 08/27/2010 10:22 AM, stephane ducasse wrote: > hi philippe > > I wanted to integrate it in 1.2 but I have 5 conflicts. Should I juste load? > Is it for 1.2? No, it's not. Do you have WebClient already in 1.2 and are trying to merge against it? If so I can have a look at it. Cheers Philippe

Aug. 27, 2010

[Pharo-project] [update 1.2] #12116

by StÃ©phane Ducasse

12116 ----- merging webclient pmm 73

Aug. 27, 2010

Re: [Pharo-project] about ValueAdapter

by StÃ©phane Ducasse

there are a lot of methods to print time and date as well as number and I thought that your adaptor would benefit from them. Stef On Aug 27, 2010, at 1:49 PM, Schwab,Wilhelm K wrote: > Stef, > > I generally spend most of my time trying to avoid having the RB do what you are describing, but it should be that simple, right? > > As you have noticed, the adapters are very crude, but tests are certainly a good idea. One thing that I miss is a good place to put package comments; I tend to write them more than class comments (they not only identify the important classes, but which ones to use and how, all in one place - who then need class comments?), and then relentlessly comment methods as they evolve. That said, I could probably force out a few class comments. > > What do you mean by checking padded printOn? What are they, and how (and for what) would I check them? > > Bill > > > ________________________________________ > From: pharo-project-bounces(a)lists.gforge.inria.fr [pharo-project-bounces(a)lists.gforge.inria.fr] On Behalf Of stephane ducasse [stephane.ducasse(a)free.fr] > Sent: Friday, August 27, 2010 4:28 AM > To: Pharo-project(a)lists.gforge.inria.fr Development > Subject: [Pharo-project] about ValueAdapter > > Bill > > I scanned the code. > Could you > - reformat your code? > put space after : > align on the first tab > - get some more tests? > - I could not see the class comments but if there are none then please adde something. > - did you check the padded printon methods and others? > > Stef > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Aug. 27, 2010

Re: [Pharo-project] what about putting RBengine in pharo1.2 core?

by StÃ©phane Ducasse

sure this is just that during the unstable phase we need better tools. We want to run SmallLint. The problem is that generate a new image every 20 min when I integrate and I do not want to spend my time load ob and rb. After we will unload it. And yes I should work on a configuration of pharo and rebuild the scriptloader infrastructure on it :( Stef On Aug 27, 2010, at 1:41 PM, Lukas Renggli wrote: > I wouldn't pre-load it. There is really no point for many deployed > applications to have it in there. > > Lukas > > On 27 August 2010 13:33, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: >> marcus like that we do not have to load it all the time. >> I could esaily update scriptloader to make sure that we do not save these packages. >> >> Stef >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Aug. 27, 2010