there are a lot of methods to print time and date as well as number and I thought that your adaptor would benefit from them. Stef On Aug 27, 2010, at 1:49 PM, Schwab,Wilhelm K wrote:
Stef,
I generally spend most of my time trying to avoid having the RB do what you are describing, but it should be that simple, right?
As you have noticed, the adapters are very crude, but tests are certainly a good idea. One thing that I miss is a good place to put package comments; I tend to write them more than class comments (they not only identify the important classes, but which ones to use and how, all in one place - who then need class comments?), and then relentlessly comment methods as they evolve. That said, I could probably force out a few class comments.
What do you mean by checking padded printOn? What are they, and how (and for what) would I check them?
Bill
________________________________________ From: pharo-project-bounces@lists.gforge.inria.fr [pharo-project-bounces@lists.gforge.inria.fr] On Behalf Of stephane ducasse [stephane.ducasse@free.fr] Sent: Friday, August 27, 2010 4:28 AM To: Pharo-project@lists.gforge.inria.fr Development Subject: [Pharo-project] about ValueAdapter
Bill
I scanned the code. Could you - reformat your code? put space after : align on the first tab - get some more tests? - I could not see the class comments but if there are none then please adde something. - did you check the padded printon methods and others?
Stef _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project