August 2016 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Moving Monkey quality checks to Renraku infrastructure

by Yuriy Tymchuk

> On 05 Aug 2016, at 10:49, Guille Polito <guillermopolito(a)gmail.com> wrote: > > Hi! > > > -------- Original Message -------- >> Hi, >> >> At the moment I am moving Pharo quality tools to Renraku model. This is a quality model that Iâve been working on and that was used so far by QualityAssistant. > Cool, I'm interested on that. Do you have some examples, docs? There are multiple places, but at the moment Iâm focusing on in-Pharo help. If you open the Help Browser there is a book called âRenraku Quality Rulesâ. Let me know if something is unclear or missing, as it is hard to write a good documentation in one shot :) >> >> At the moment Iâm stuck while trying to do changes in Monkey, as it is really hard to understand how quality checks are made there. @Guille maybe you can advise something. >> >> In the old model Rules were both checking code and storing the entities that violate them. In Renraku Rules are responsible only for checking, then for each violation they produce a critique object that is a mapping between the rule and the entity that violates the rule. Also critiques can provide plenty of additional information such as suggestion on how to fix the issue. >> >> At the moment we can skip the critiques altogether, just run the rules and store the classes and method that violate them. But at the moment I cannot how Monkey in implemented. I.e. where do the rules come from and what output should be provided. > Well, so far I did not yet investigate all that part. I'm actually experimenting on a new monkey implementation that has the following objectives: > - easy to configure and run locally > - faster. It should be able to run build validations in parallel (e.g., in my prototype tests run by 4 parallel pharo images are run in 2 minutes) > - it should enforce the same process used for issue validation and integration > - integrated with the bootstrap :) > > Are you going to ESUG? Yes >> >> Cheers. >> Uko > >

Aug. 5, 2016

Re: [Pharo-dev] Moving Monkey quality checks to Renraku infrastructure

by Guille Polito

Hi! -------- Original Message -------- > Hi, > > At the moment I am moving Pharo quality tools to Renraku model. This is a quality model that Iâve been working on and that was used so far by QualityAssistant. Cool, I'm interested on that. Do you have some examples, docs? > > At the moment Iâm stuck while trying to do changes in Monkey, as it is really hard to understand how quality checks are made there. @Guille maybe you can advise something. > > In the old model Rules were both checking code and storing the entities that violate them. In Renraku Rules are responsible only for checking, then for each violation they produce a critique object that is a mapping between the rule and the entity that violates the rule. Also critiques can provide plenty of additional information such as suggestion on how to fix the issue. > > At the moment we can skip the critiques altogether, just run the rules and store the classes and method that violate them. But at the moment I cannot how Monkey in implemented. I.e. where do the rules come from and what output should be provided. Well, so far I did not yet investigate all that part. I'm actually experimenting on a new monkey implementation that has the following objectives: - easy to configure and run locally - faster. It should be able to run build validations in parallel (e.g., in my prototype tests run by 4 parallel pharo images are run in 2 minutes) - it should enforce the same process used for issue validation and integration - integrated with the bootstrap :) Are you going to ESUG? > > Cheers. > Uko

Aug. 5, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60170 Home: https://github.com/pharo-project/pharo-core

Aug. 5, 2016

[pharo-project/pharo-core] 2e9b0a: 60170

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 2e9b0a0178db3977e9f8df789d609e509c855977 https://github.com/pharo-project/pharo-core/commit/2e9b0a0178db3977e9f8df78… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-08-05 (Fri, 05 Aug 2016) Changed paths: A Announcements-Core.package/Announcement.class/instance/initialization/prepareForDelivery.st M Announcements-Core.package/SubscriptionRegistry.class/instance/announcing/deliver_.st M Announcements-Tests-Core.package/AnnouncementMockC.class/definition.st A Announcements-Tests-Core.package/AnnouncementMockC.class/instance/accessing/announcingCounter.st A Announcements-Tests-Core.package/AnnouncementMockC.class/instance/initialization/initialize.st A Announcements-Tests-Core.package/AnnouncementMockC.class/instance/initialization/prepareForDelivery.st A Announcements-Tests-Core.package/AnnouncerTest.class/instance/testing/testPreparationAnnouncementDelivery.st A Announcements-Tests-Core.package/AnnouncerTest.class/instance/testing/testPreparationAnnouncementDeliveryWhenNoSubscriptions.st A Collections-Strings.package/Symbol.class/instance/announcements/prepareForDelivery.st A Kernel-Tests.package/DateAndTimeTest.class/instance/tests - offset/testReadFromDefaultOffsetNotSpecified.st A Kernel-Tests.package/DateAndTimeTest.class/instance/tests - offset/testReadFromDefaultOffsetSpecified.st M Kernel.package/DateAndTime.class/class/input/readFrom_.st A Kernel.package/DateAndTime.class/class/input/readFrom_defaultOffset_.st M Kernel.package/DateAndTime.class/class/input/readTimezoneOffsetFrom_.st A Kernel.package/DateAndTime.class/class/input/readTimezoneOffsetFrom_default_.st A Nautilus-Tests.package/MethodWidgetTest.class/README.md A Nautilus-Tests.package/MethodWidgetTest.class/definition.st A Nautilus-Tests.package/MethodWidgetTest.class/instance/mock/foo.st A Nautilus-Tests.package/MethodWidgetTest.class/instance/tests/testElementInCacheShouldBeNotNil.st A Nautilus.package/MethodIsScriptAction.class/instance/order/actionStateToCache.st M NautilusRefactoring.package/ChangesBrowserTest.class/instance/tests/testInitializeWidgets.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60169.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60170.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60169.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60170.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 60170 18816 Failing test: ChangesBrowserTest.testInitializeWidgets https://pharo.fogbugz.com/f/cases/18816 18846 <script:> and <script> pragmas do not always work https://pharo.fogbugz.com/f/cases/18846 18782 Add DateAndTime class>>readFrom:defaultOffset: https://pharo.fogbugz.com/f/cases/18782 18870 Delivery preparation hook for announcement https://pharo.fogbugz.com/f/cases/18870 http://files.pharo.org/image/60/60170.zip

Aug. 5, 2016

Re: [Pharo-dev] [pharo-project/pharo-core] f57843: 60163

by Martin Dias

Hi Stef, good, I take note. I improved filters in the recent releases and will continue improving. Martin On Wed, Aug 3, 2016 at 5:30 PM, stepharo <stepharo(a)free.fr> wrote: > Thanks Martin. > > We missed yesterday: show only the latest version of every entities. :) > > > Setf > > > Le 3/8/16 Ã 11:23, Marcus Denker a Ã©crit : > > On 03 Aug 2016, at 11:07, GitHub <noreply(a)github.com> wrote: >>> >>> >>> Log Message: >>> ----------- >>> 60163 >>> 18831 Integrate new Epicea version >>> https://pharo.fogbugz.com/f/cases/18831 >>> >>> ChangeLog for this: >> >> - Case 18813: Implement redo and undo of protocol addition and removal. >> >> - Case 18612: disable drag&drop until TreeModel supports it correctly. >> >> - Case 18384: Redo and undo: show on any selection (not only when all >> selected entries are code changes). >> >> - Enhancement: Improve lost changes detection; show only the events >> actually lost. >> >> - Enhancement: Pass on filters. >> >> - Clean up: Do not show the "absent entry" item anymore since it was not >> useful at all. >> >> - Clean up: Remove unused "commit tags" in log browser. >> >> - Clean up: Remove unused tests. They were good idea, we can re-introduce >> them but working and covering more cases. >> >> - Clean up: Rename #displayWidget to #asMorph in EpLogBrowserItem''s >> hierarchy. It is more meaningful. >> >> - Workaround: Hide "Open in Sorter" menu action since it is useless until >> Treemodel drag&drop is fixed. >> >> >> >> 18768 Inlined method const could be implemented by metalinks >>> https://pharo.fogbugz.com/f/cases/18768 >>> >>> 18835 Update RBParser-Nodes class comments >>> https://pharo.fogbugz.com/f/cases/18835 >>> >>> http://files.pharo.org/image/60/60163.zip >>> >>> >>> >> >> > >

Aug. 5, 2016

Re: [Pharo-dev] Moving Monkey quality checks to Renraku infrastructure

by Nicolai Hess

2016-08-04 18:39 GMT+02:00 Yuriy Tymchuk <yuriy.tymchuk(a)me.com>: > Hi, > > At the moment I am moving Pharo quality tools to Renraku model. This is a > quality model that Iâve been working on and that was used so far by > QualityAssistant. > > At the moment Iâm stuck while trying to do changes in Monkey, as it is > really hard to understand how quality checks are made there. @Guille maybe > you can advise something. > > In the old model Rules were both checking code and storing the entities > that violate them. In Renraku Rules are responsible only for checking, then > for each violation they produce a critique object that is a mapping between > the rule and the entity that violates the rule. Also critiques can provide > plenty of additional information such as suggestion on how to fix the issue. > > At the moment we can skip the critiques altogether, just run the rules and > store the classes and method that violate them. But at the moment I cannot > how Monkey in implemented. I.e. where do the rules come from and what > output should be provided. > > Cheers. > Uko > Hi Uko, as far as I know (from looking at the CICommandLineHandler), the CIValidator collects a set of rules when validating an issue. Look at CIValidator class>>#pharo60 The rules are CISUnitTestsRule and PharoCriticRules pharoIntegrationLintRule harden.

Aug. 4, 2016

Re: [Pharo-dev] [pharo-project/pharo-core] f57843: 60163

by Sean P. DeNigris

Ben Coman wrote > Thanks for the follow up post of this change log Marcus. +1!! ----- Cheers, Sean -- View this message in context: http://forum.world.st/pharo-project-pharo-core-f57843-60163-tp4909296p49096… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Aug. 4, 2016

Moving Monkey quality checks to Renraku infrastructure

by Yuriy Tymchuk

Hi, At the moment I am moving Pharo quality tools to Renraku model. This is a quality model that Iâve been working on and that was used so far by QualityAssistant. At the moment Iâm stuck while trying to do changes in Monkey, as it is really hard to understand how quality checks are made there. @Guille maybe you can advise something. In the old model Rules were both checking code and storing the entities that violate them. In Renraku Rules are responsible only for checking, then for each violation they produce a critique object that is a mapping between the rule and the entity that violates the rule. Also critiques can provide plenty of additional information such as suggestion on how to fix the issue. At the moment we can skip the critiques altogether, just run the rules and store the classes and method that violate them. But at the moment I cannot how Monkey in implemented. I.e. where do the rules come from and what output should be provided. Cheers. Uko

Aug. 4, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/60169 Home: https://github.com/pharo-project/pharo-core

Aug. 4, 2016

[pharo-project/pharo-core] d4d6aa: 60169

by GitHub

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: d4d6aa83744aa941695d19536e355de4d15b5284 https://github.com/pharo-project/pharo-core/commit/d4d6aa83744aa941695d1953… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-08-04 (Thu, 04 Aug 2016) Changed paths: A Announcements-Core.package/Announcement.class/class/public/-.st A Announcements-Core.package/AnnouncementSet.class/instance/exclusion/-.st A Announcements-Core.package/AnnouncementSetWithExclusions.class/README.md A Announcements-Core.package/AnnouncementSetWithExclusions.class/definition.st A Announcements-Core.package/AnnouncementSetWithExclusions.class/instance/initialization/initialize.st A Announcements-Core.package/AnnouncementSetWithExclusions.class/instance/initialization/initialize_.st A Announcements-Core.package/AnnouncementSetWithExclusions.class/instance/private/addExclusion_.st A Announcements-Core.package/AnnouncementSetWithExclusions.class/instance/testing/handlesAnnouncement_.st A Announcements-Tests-Core.package/AnnouncerTest.class/instance/testing/testSubscribeClassWithExclusion.st A Announcements-Tests-Core.package/AnnouncerTest.class/instance/testing/testSubscribeSetWithExclusion.st A Announcements-Tests-Core.package/AnnouncerTest.class/instance/testing/testSubscribeSetWithExclusionOfMultipleAnnouncements.st A Announcements-Tests-Core.package/AnnouncerTest.class/instance/testing/testSubscribeSetWithExclusionOfSetItem.st M Metacello-MC.package/MetacelloPackageSpec.class/instance/gofer/workingCopyNameFor_.st A Morphic-Widgets-Taskbar.package/TaskbarMorph.class/instance/drawing/clipSubmorphs.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60168.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60169.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60168.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60169.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Tool-CriticBrowser.package/CriticBrowser.class/class/instance creation/packagesMenu_.st Log Message: ----------- 60169 18861 TaskbarMorph reports damage outside its own area https://pharo.fogbugz.com/f/cases/18861 18868 Announcements subscription should supports exclusion like exceptions by minus https://pharo.fogbugz.com/f/cases/18868 18867 MetaceloPackageSpec workingCopyNameFor call name which could lead to deprecation warning when current version is array https://pharo.fogbugz.com/f/cases/18867 18865 can not open critics browser on a package from nautilus package pane menu https://pharo.fogbugz.com/f/cases/18865 http://files.pharo.org/image/60/60169.zip

Aug. 4, 2016