August 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [squeak-dev] #instSize in Squeak 5 seems to be broken for Traits

by Eliot Miranda

Hi Max, On Fri, Aug 21, 2015 at 8:57 AM, Max Leske <maxleske(a)gmail.com> wrote: > Hi folks > > Iâve been trying to load Fuel into Squeak 5 but canât because I get errors > when loading Traits (they have not instance variables). The reason for this > error seems to be that #instSize answers 2 for Traits when it should answer > 0. > > The current implementation is: > > ^format bitAnd: 16rFFFF > > The comment in the 4.6 version says: > > " > NOTE: This code supports the backward-compatible extension to 8 > bits of instSize. > When we revise the image format, it should become... > ^ ((format bitShift: -1) bitAnd: 16rFF) - 1 > Note also that every other method in this category will require > 2 bits more of right shift after the change. > â > > When I use that version in TraitBehaviour>>instSize in Squeak 5 I get 0 as > expected and I can load Fuel without problems. > So Spur has a different layout for format than V3. The above implementation (format bitAnd: 16rFFFF) is correct for Spur. In loading classes or traits via Fuel from 4.6 to 5.0 you're going to have to convert the format inst var to reflect its usage in Spur. So we need to be clear here. Is the issue that you're trying to load classes and/or traits from a Fuel file written by 4.6 or is it that as part of the Fuel load a new Trait gets created which has a format of 2? > Cheers, > Max > -- _,,,^..^,,,_ best, Eliot

Aug. 21, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50261 Home: https://github.com/pharo-project/pharo-core

Aug. 21, 2015

[pharo-project/pharo-core] a03775: 50261

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: a03775b201ce7dfc5f98124b20a5801473fe987f https://github.com/pharo-project/pharo-core/commit/a03775b201ce7dfc5f98124b… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-21 (Fri, 21 Aug 2015) Changed paths: M AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatSelectorAndArguments_firstSeparator_restSeparator_.st A Deprecated50.package/extension/TBehavior/instance/thoroughHasSelectorReferringTo_special_byte_.st A Deprecated50.package/extension/TBehavior/instance/thoroughWhichSelectorsReferTo_special_byte_.st A Deprecated50.package/extension/TBehavior/instance/whichSelectorsReferTo_special_byte_.st M Refactoring-Critics.package/RBNotEliminationRule.class/instance/initialization/initialize.st A Reflectivity.package/extension/Slot/instance/afterLinks.st A Reflectivity.package/extension/Slot/instance/beforeHooks.st A Reflectivity.package/extension/Slot/instance/beforeLinks.st A Reflectivity.package/extension/Slot/instance/hasMetalink.st A Reflectivity.package/extension/Slot/instance/hasMetalinkAfter.st A Reflectivity.package/extension/Slot/instance/hasMetalinkBefore.st A Reflectivity.package/extension/Slot/instance/hasMetalinkInstead.st A Reflectivity.package/extension/Slot/instance/insteadLinks.st A Reflectivity.package/extension/Slot/instance/preambles.st A Reflectivity.package/extension/TemporaryVariable/instance/afterLinks.st A Reflectivity.package/extension/TemporaryVariable/instance/beforeHooks.st A Reflectivity.package/extension/TemporaryVariable/instance/beforeLinks.st A Reflectivity.package/extension/TemporaryVariable/instance/clearReflectivityAnnotations.st A Reflectivity.package/extension/TemporaryVariable/instance/hasMetalink.st A Reflectivity.package/extension/TemporaryVariable/instance/hasMetalinkAfter.st A Reflectivity.package/extension/TemporaryVariable/instance/hasMetalinkBefore.st A Reflectivity.package/extension/TemporaryVariable/instance/hasMetalinkInstead.st A Reflectivity.package/extension/TemporaryVariable/instance/insteadLinks.st A Reflectivity.package/extension/TemporaryVariable/instance/link_.st A Reflectivity.package/extension/TemporaryVariable/instance/links.st A Reflectivity.package/extension/TemporaryVariable/instance/preambles.st A Reflectivity.package/extension/TemporaryVariable/instance/removeLink_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50260.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50261.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50260.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50261.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Slot-Tests.package/TemporaryVariableTest.class/instance/properties/testPropertyAtPut.st M Slot.package/ClassVariable.class/definition.st M Slot.package/GlobalVariable.class/definition.st M Slot.package/IndexedSlot.class/definition.st M Slot.package/InstanceVariableSlot.class/definition.st M Slot.package/LayoutAbstractScope.class/definition.st M Slot.package/LayoutClassScope.class/definition.st M Slot.package/LayoutEmptyScope.class/definition.st M Slot.package/LiteralVariable.class/definition.st M Slot.package/Slot.class/definition.st A Slot.package/TemporaryVariable.class/class/class initialization/initialize.st A Slot.package/TemporaryVariable.class/class/class initialization/initializeProperties.st M Slot.package/TemporaryVariable.class/definition.st A Slot.package/TemporaryVariable.class/instance/properties/ensureProperties.st A Slot.package/TemporaryVariable.class/instance/properties/hasProperty_.st A Slot.package/TemporaryVariable.class/instance/properties/properties.st A Slot.package/TemporaryVariable.class/instance/properties/propertyAt_.st A Slot.package/TemporaryVariable.class/instance/properties/propertyAt_ifAbsentPut_.st A Slot.package/TemporaryVariable.class/instance/properties/propertyAt_ifAbsent_.st A Slot.package/TemporaryVariable.class/instance/properties/propertyAt_put_.st A Slot.package/TemporaryVariable.class/instance/properties/removePropertiesIfEmpty.st A Slot.package/TemporaryVariable.class/instance/properties/removeProperty_.st A Slot.package/TemporaryVariable.class/instance/properties/removeProperty_ifAbsent_.st M Slot.package/WorkspaceVariable.class/definition.st M Tool-Finder.package/MethodFinder.class/instance/initialize/initialize.st M Traits.package/TBehavior.class/instance/testing method dictionary/thoroughHasSelectorReferringTo_.st R Traits.package/TBehavior.class/instance/testing method dictionary/thoroughHasSelectorReferringTo_special_byte_.st R Traits.package/TBehavior.class/instance/testing method dictionary/thoroughWhichSelectorsReferTo_special_byte_.st M Traits.package/TBehavior.class/instance/testing method dictionary/whichSelectorsAccess_.st M Traits.package/TBehavior.class/instance/testing method dictionary/whichSelectorsReferTo_.st R Traits.package/TBehavior.class/instance/testing method dictionary/whichSelectorsReferTo_special_byte_.st M Traits.package/TBehavior.class/instance/testing method dictionary/whichSelectorsStoreInto_.st Log Message: ----------- 50261 16338 Property API for TemporaryVariable https://pharo.fogbugz.com/f/cases/16338 16344 add basis for links to Temps and Slots https://pharo.fogbugz.com/f/cases/16344 16269 separatorBlock is not read and written in BISimpleFormatter>>#formatSelectorAndArguments:firstSeparator:restSeparator: https://pharo.fogbugz.com/f/cases/16269 16343 add isEmpty not to RBNotEliminationRule https://pharo.fogbugz.com/f/cases/16343 16342 deprecated #whichSelectorsReferTo:special:byte: and friends https://pharo.fogbugz.com/f/cases/16342 http://files.pharo.org/image/50/50261.zip

Aug. 21, 2015

Re: [Pharo-dev] Nautilus questions

by Peter UhnÃ¡k

On Wed, Aug 19, 2015 at 4:58 PM, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > > > 2015-08-19 16:46 GMT+02:00 Sean P. DeNigris <sean(a)clipperadams.com>: > >> >> kilon.alios wrote >> > I have to confess I was never and probably will never be a fan of the >> > system browser >> >> I agree. It was probably well-suited to the context in which it was >> invented, but I think we could do much better today. However: >> - IMHO there is value in having a really-great-old-thing that empowers us >> to >> create an entirely new thing >> - as mentioned, it's good to have a simple and robust fallback behind a >> revolutionary new tool >> > > Yes! > This is confusing to me. How do you guys write/read code? I was under the impression that Nautilus (System Browser) is the go-to solution. Or is there some other tool/approach I don't know about? I would like the coding area to expand a bit when a method is too long. While QA did take perhaps too much space, I think that there is benefit in having relatively small coding area (by small I mean pre-QualityAssistant) since it forces me to write smaller methods (I want to be able to see it at once). But this is just personal experience. On Thu, Aug 20, 2015 at 10:58 AM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > - groups (btw, current scoped button does not takes that into account) > I thought groups are being removed.

Aug. 21, 2015

#instSize in Squeak 5 seems to be broken for Traits

by Max Leske

Hi folks Iâve been trying to load Fuel into Squeak 5 but canât because I get errors when loading Traits (they have not instance variables). The reason for this error seems to be that #instSize answers 2 for Traits when it should answer 0. The current implementation is: ^format bitAnd: 16rFFFF The comment in the 4.6 version says: " NOTE: This code supports the backward-compatible extension to 8 bits of instSize. When we revise the image format, it should become... ^ ((format bitShift: -1) bitAnd: 16rFF) - 1 Note also that every other method in this category will require 2 bits more of right shift after the change. â When I use that version in TraitBehaviour>>instSize in Squeak 5 I get 0 as expected and I can load Fuel without problems. Cheers, Max

Aug. 21, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50260 Home: https://github.com/pharo-project/pharo-core

Aug. 21, 2015

[pharo-project/pharo-core] e7135f: 50260

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: e7135f12f819cd5cf371ac622b65b7343cf1922a https://github.com/pharo-project/pharo-core/commit/e7135f12f819cd5cf371ac62… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-21 (Fri, 21 Aug 2015) Changed paths: M Nautilus.package/MethodWidget.class/class/menu/elementsMenu_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50259.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50260.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50259.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50260.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50260 16341 Update key text for browse version since the shortcut changed https://pharo.fogbugz.com/f/cases/16341 http://files.pharo.org/image/50/50260.zip

Aug. 21, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50259 Home: https://github.com/pharo-project/pharo-core

Aug. 21, 2015

[pharo-project/pharo-core] ef9635: 50259

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: ef96352ea9c0eb5721b118b4e2764399b8aa75c4 https://github.com/pharo-project/pharo-core/commit/ef96352ea9c0eb5721b118b4… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-21 (Fri, 21 Aug 2015) Changed paths: M ConfigurationOfFastTable.package/ConfigurationOfFastTable.class/instance/symbolic versions/stable_.st A ConfigurationOfFastTable.package/ConfigurationOfFastTable.class/instance/versions/version077_.st M Morphic-Widgets-FastTable.package/FTTableMorph.class/instance/accessing selection/highlightRowIndexes_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50258.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50259.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50258.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50259.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50259 16266 Nautilus no longer highlights protocol when method is selected https://pharo.fogbugz.com/f/cases/16266 http://files.pharo.org/image/50/50259.zip

Aug. 21, 2015

Re: [Pharo-dev] New code critique rule: RBSmalltalkGlobalsRule

by Marcus Denker

another change I did is to RBNotEliminationRule a case for isEmpty: replace: '``@object isEmpty not' with: '``@object isNotEmpty'; Marcus https://pharo.fogbugz.com/f/cases/16343/add-isEmpty-not-to-RBNotElimination… > On 21 Aug 2015, at 15:13, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Hi, > > I added a new rule: RBSmalltalkGlobalsRule > > The idea is that this catches all uses of âSmalltalkâ where instead âSmalltalk globalsâ should be used. > > It is not yet complete, but has for now: > > replace: 'Smalltalk allClasses' > with: 'Smalltalk globals allClasses'; > replace: 'Smalltalk allClassesDo: `@statements' > with: 'Smalltalk globals allClassesDo: `@statements'; > replace: 'Smalltalk allTraits' > with: 'Smalltalk globals allTraits'; > replace: 'Smalltalk includes:`@statements' > with: 'Smalltalk globals includes: `@statements'; > replace: 'Smalltalk flushClassNameCache' > with: 'Smalltalk globals flushClassNameCache'; > replace: 'Smalltalk includesKey: `@statements' > with: 'Smalltalk globals includesKey: `@statementsâ. > > > > Marcus

Aug. 21, 2015