Re: [Pharo-dev] New code critique rule: RBSmalltalkGlobalsRule

Aug. 21, 2015


      another change I did is to RBNotEliminationRule a case for isEmpty:

replace: '``@object isEmpty not' with: '``@object isNotEmpty';


	Marcus

https://pharo.fogbugz.com/f/cases/16343/add-isEmpty-not-to-RBNotEliminationR...
...
On 21 Aug 2015, at 15:13, Marcus Denker <marcus.denker@inria.fr> wrote:
Hi,
I added a new rule: RBSmalltalkGlobalsRule
The idea is that this catches all uses of âSmalltalkâ where instead âSmalltalk globalsâ should be used.
It is not yet complete, but has for now:
replace: 'Smalltalk allClasses'
      	with: 'Smalltalk globals allClasses';
      replace: 'Smalltalk allClassesDo: `@statements'
      	with: 'Smalltalk globals allClassesDo: `@statements';
      replace: 'Smalltalk allTraits'
      	with: 'Smalltalk globals allTraits';
      replace: 'Smalltalk includes:`@statements'
      	with: 'Smalltalk globals includes: `@statements';
      replace: 'Smalltalk flushClassNameCache'
      	with: 'Smalltalk globals flushClassNameCache';
      replace: 'Smalltalk includesKey: `@statements'
      	with: 'Smalltalk globals includesKey: `@statementsâ.
Marcus