July 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] xmlwriter change brakes an issuetracker-image test

by Nicolai Hess

2015-07-22 20:11 GMT+02:00 Paul DeBruicker <pdebruic(a)gmail.com>: > Is there a spec for XML documents and if so what does it say is the correct > behavior? > > I don't know. > I would guess the encoding declaration is optional according to the spec > and > shouldn't be relied on in the test as being there in default. Probably > need > to add the encoding explicitly if its required by the consumer of the XML > document. > > We should change the tests. How or who can do this? And how do we make the pharo issue tracker image use that version? > > > > > > > Nicolai Hess wrote > > change in XMLWriter: > > Name: XML-Writer-Core-monty.40 > > Author: monty > > Time: 15 June 2015, 4:35:12.313879 am > > UUID: 632db1a0-b6a6-4686-924e-a9bbb2b843b4 > > Ancestors: XML-Writer-Core-monty.39 > > > > xml declaration writers no longer output "encoding=UTF-8" by default > > > > But now, CIXMLPublisherTest test fails, the test case expects a result > > with "encoding=UTF-8" > > > > > > -- > View this message in context: > http://forum.world.st/xmlwriter-change-brakes-an-issuetracker-image-test-tp… > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

July 26, 2015

Re: [Pharo-dev] [Pharo4] reviews needed: 15977 Metacello Browser should only load from the selected repo

by Nicolai Hess

2015-07-26 11:25 GMT+02:00 Marcus Denker <marcus.denker(a)inria.fr>: > Hi, > > This needs two positive reviews before we can even think about looking at > it for Pharo4: > > 15977 Metacello Browser should only load from the selected repo > https://pharo.fogbugz.com/f/cases/15977 > > > Marcus > @sean can you check if this fix is still necessary in Pharo5.0? We fixed two or three other MCCache related issues. If this issue does not occur in Pharo 5.0, we may backport the other fixes to Pharo 4.0 nicolai

July 26, 2015

Re: [Pharo-dev] About nextPutAll: $(

by Gabriel Cotelli

I also like more the HernÃ¡n proposal but I would prefer something like stream nextPutAll: self name between: $( and: $) To avoid creating an association On Jul 26, 2015 12:23 PM, "stepharo" <stepharo(a)free.fr> wrote: > I like the solution of hernan better. I think that surrounding is a common > pattern. > > Stef > > Le 25/7/15 22:02, Max Leske a Ã©crit : > >> On 25 Jul 2015, at 21:31, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>> >>> >>> On 25 Jul 2015, at 19:40, Esteban Lorenzano <estebanlm(a)gmail.com> >>>> wrote: >>>> >>>> (From my vacations) >>>> >>>> Doesn't this solves the problem? >>>> >>>> stream << $( << name << $) >>>> >>>> It is already there :) >>>> >>> Yes, indeed: >>> >>> String streamContents: [ :out | >>> out <<$( << 'test-' << 123 << $) ] >>> >>> (But it is not perfect, there is still confusion there) >>> >> I agree. Iâve never liked that operator. Apart from #// and #\\ there are >> pretty much no selectors that make you guess their meaning. The meaning is >> in all other cases transported through wording, which I feel very >> comfortable with. Yes, itâs convenient to write but, as Sven points out, I >> actually find it less readable. I like Hernanâs idea better. >> >> We are trying to reduce the String and Stream API, so any addition >>> should be really important/significant. >>> >>> Now I comeback to watch the see... >>>> >>>> >>>> >>>> >>>> >>>> On 25 Jul 2015, at 18:39, HernÃ¡n Morales Durand < >>>> hernan.morales(a)gmail.com> wrote: >>>> >>>> In BioSmalltalk I use this pattern a lot: >>>>> >>>>> aStream >>>>> nextPutAll: self name >>>>> between: $[ -> $]. >>>>> >>>>> so yes, that would be a nice inclusion for me :) >>>>> >>>>> Cheers, >>>>> >>>>> HernÃ¡n >>>>> >>>>> >>>>> >>>>> >>>>> 2015-07-24 17:48 GMT-03:00 stepharo <stepharo(a)free.fr>: >>>>> HI >>>>> >>>>> while working on a lecture I saw that we have about 75 cases like: >>>>> >>>>> aStream nextPut: $(. >>>>> .... >>>>> aStream nextPut: $). >>>>> >>>>> >>>>> >>>>> storeOn: aStream >>>>> "Store a description of the elements of the complement rather than >>>>> self." >>>>> >>>>> aStream nextPut: $(. >>>>> absent storeOn: aStream. >>>>> aStream nextPut: $); space; nextPutAll: #complement. >>>>> >>>>> >>>>> printElementsOn: aStream >>>>> aStream nextPut: $(. >>>>> self size > 100 >>>>> ifTrue: [aStream nextPutAll: 'size '. >>>>> self size printOn: aStream] >>>>> ifFalse: [self keysSortedSafely >>>>> do: [:key | aStream print: key; >>>>> nextPutAll: '->'; >>>>> print: (self at: key); >>>>> space]]. >>>>> aStream nextPut: $) >>>>> >>>>> we have surroundedBy: aString >>>>> >>>>> surroundedBy: aString >>>>> ^ self class streamContents: [ :s| >>>>> s nextPutAll: aString. >>>>> s nextPutAll: self. >>>>> s nextPutAll: aString ]. >>>>> >>>>> But only working on aString. >>>>> To me it looks like it ia class for having it on stream. >>>>> >>>>> What do you think? >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>> >> >> > >

July 26, 2015

Re: [Pharo-dev] About nextPutAll: $(

by stepharo

I like the solution of hernan better. I think that surrounding is a common pattern. Stef Le 25/7/15 22:02, Max Leske a Ã©crit : >> On 25 Jul 2015, at 21:31, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> >>> On 25 Jul 2015, at 19:40, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >>> >>> (From my vacations) >>> >>> Doesn't this solves the problem? >>> >>> stream << $( << name << $) >>> >>> It is already there :) >> Yes, indeed: >> >> String streamContents: [ :out | >> out <<$( << 'test-' << 123 << $) ] >> >> (But it is not perfect, there is still confusion there) > I agree. Iâve never liked that operator. Apart from #// and #\\ there are pretty much no selectors that make you guess their meaning. The meaning is in all other cases transported through wording, which I feel very comfortable with. Yes, itâs convenient to write but, as Sven points out, I actually find it less readable. I like Hernanâs idea better. > >> We are trying to reduce the String and Stream API, so any addition should be really important/significant. >> >>> Now I comeback to watch the see... >>> >>> >>> >>> >>> >>> On 25 Jul 2015, at 18:39, HernÃ¡n Morales Durand <hernan.morales(a)gmail.com> wrote: >>> >>>> In BioSmalltalk I use this pattern a lot: >>>> >>>> aStream >>>> nextPutAll: self name >>>> between: $[ -> $]. >>>> >>>> so yes, that would be a nice inclusion for me :) >>>> >>>> Cheers, >>>> >>>> HernÃ¡n >>>> >>>> >>>> >>>> >>>> 2015-07-24 17:48 GMT-03:00 stepharo <stepharo(a)free.fr>: >>>> HI >>>> >>>> while working on a lecture I saw that we have about 75 cases like: >>>> >>>> aStream nextPut: $(. >>>> .... >>>> aStream nextPut: $). >>>> >>>> >>>> >>>> storeOn: aStream >>>> "Store a description of the elements of the complement rather than self." >>>> >>>> aStream nextPut: $(. >>>> absent storeOn: aStream. >>>> aStream nextPut: $); space; nextPutAll: #complement. >>>> >>>> >>>> printElementsOn: aStream >>>> aStream nextPut: $(. >>>> self size > 100 >>>> ifTrue: [aStream nextPutAll: 'size '. >>>> self size printOn: aStream] >>>> ifFalse: [self keysSortedSafely >>>> do: [:key | aStream print: key; >>>> nextPutAll: '->'; >>>> print: (self at: key); >>>> space]]. >>>> aStream nextPut: $) >>>> >>>> we have surroundedBy: aString >>>> >>>> surroundedBy: aString >>>> ^ self class streamContents: [ :s| >>>> s nextPutAll: aString. >>>> s nextPutAll: self. >>>> s nextPutAll: aString ]. >>>> >>>> But only working on aString. >>>> To me it looks like it ia class for having it on stream. >>>> >>>> What do you think? >>>> >>>> >>>> >>>> >>>> >> > >

July 26, 2015

Re: [Pharo-dev] about quality assistant

by stepharo

I think that the impact of an action should be clear. From a user perspective I should not guess not even ask yourself a question. Alex with codrCritcis you can mark that a ruel should not apply to a class (ban the rule on the class). Stef Le 26/7/15 14:46, Alexandre Bergel a Ã©crit : >> I do not like useless. Because it is too violent and unclear. > +1 on this. > > For example, in the class RTRoassalExample, there are many methods. Too much for the quality assistant. Finally, I did not press âuselessâ because I still think this is a useful rule, but not for that class. > > Cheers, > Alexandre

July 26, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50193 Home: https://github.com/pharo-project/pharo-core

July 26, 2015

[pharo-project/pharo-core] a9d742: 50193

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: a9d742742bebc6f5de615bbb19284a7abacfd182 https://github.com/pharo-project/pharo-core/commit/a9d742742bebc6f5de615bbb… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-07-26 (Sun, 26 Jul 2015) Changed paths: M ConfigurationOfRubric.package/ConfigurationOfRubric.class/instance/symbolic versions/stable_.st A ConfigurationOfRubric.package/ConfigurationOfRubric.class/instance/versions/version1161_.st M Rubric.package/RubAbstractTextArea.class/class/settings/editorFont.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50192.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50193.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50192.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50193.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50193 16041 Rubric is not using source code font anymore since update 50192 https://pharo.fogbugz.com/f/cases/16041 http://files.pharo.org/image/50/50193.zip

July 26, 2015

Re: [Pharo-dev] about quality assistant

by Alexandre Bergel

> I do not like useless. Because it is too violent and unclear. +1 on this. For example, in the class RTRoassalExample, there are many methods. Too much for the quality assistant. Finally, I did not press âuselessâ because I still think this is a useful rule, but not for that class. Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

July 26, 2015

[Pharo4] reviews needed: 15977 Metacello Browser should only load from the selected repo

by Marcus Denker

Hi, This needs two positive reviews before we can even think about looking at it for Pharo4: 15977 Metacello Browser should only load from the selected repo https://pharo.fogbugz.com/f/cases/15977 Marcus

July 26, 2015

Re: [Pharo-dev] about quality assistant

by stepharo

>> I prefer >> ban this rule = do not run it >> false positive = rule is ok but wrong here > > Do you mean ban rule completely? On which level? For a developer > (machine)? in the codecritcis the scope is clear. On a class or a package. > Then again, skip works as former âfalse positiveâ. But in my opinion > âfalse positiveâ is not a good name from the logical point of view. > You have a rule that detects if you have no #yourself message in the > end of a cascade. Now do people really mark this as âfalse positiveâ > if the rule detects cascades that have #yourself message in the end? > Or they do it if they donât want to see the critic? Then itâs not > false positive, then they just want to hide or âskipâ the rule. Sorry but I do not understand your argument. For me this is simple: the rule tells me something is wrong and it is not. -> so I mark it as false positive. > This is fun part from statistics to name things as false positives. > But if we program a rule in such way, that it is fuzzy, I think that > itâs not correct to call it as false positive. Maybe itâs critics are > useless more times that they are helpful, and if the critic is > correct, the issue is not that important. Then probably we should just > remove the rule or rewrite it. > > Now with useless button, the only reason is to collect data on which > rules are actually useless to people [1], so we can take a look at > them in a first place. It doest not affect the functionality. I do not like useless. Because it is too violent and unclear. Please again have a look at the vocabulary used in the CodeCritics and the chapter that describes it. Or you should fix everything but we should not have two different vocabularies. There is enough confusing terms in Pharo so that we do not add more. Stef > > Uko > > [1]: http://renraku.inf.usi.ch/rules > > >> >> Stef >> >>> >>> Uko >>> >>>> On 23 Jul 2015, at 22:29, stepharo <stepharo(a)free.fr >>>> <mailto:stepharo@free.fr>> wrote: >>>> >>>> HI yuriy >>>> >>>> it would be good that quality assistant uses the same vocabulary >>>> than codecritics. >>>> for example >>>> skip -> ban? >>>> marks as false positif? >>>> >>>> Stef >>>> >>> >>> >> >> >

July 26, 2015