April 2015 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] sometimes Shout changes the selection during styling

by Andrei Chis

That would work for me. Styling the text if the process doing the styling did not finish or is stuck does not feel as the right thing to do. On Mon, Apr 27, 2015 at 6:25 PM, Ben Coman <btc(a)openinworld.com> wrote: > > > On Mon, Apr 27, 2015 at 8:41 PM, Andrei Chis <chisvasileandrei(a)gmail.com> > wrote: > >> Hi, >> >> In the glamour debugger that we use in moose we are now having the >> following problem: >> - the selection of a PluggableTextMorph is, quite randomly , changed >> during styling. >> >> If I revert the fix for issue 15240 >> <https://pharo.fogbugz.com/f/cases/15240> then it works ok. >> Also if I change in SHTextStyler>>#styleInBackgroundProcess: from >> >> sem waitTimeoutSeconds: 5. >> view ifNotNil: [ view stylerStyledInBackground: text ] >> >> to: >> >> (sem waitTimeoutSeconds: 5) ifFalse: [ >> view ifNotNil: [ view stylerStyledInBackground: text ] ] >> >> it works ok. In the second snippet we only do the styling if the styler >> completed. >> >> >> If I look at the senders of styleInBackgroundProcess: there is another >> strange issue. >> First PluggableTextMorph>>#setText: calls either style: >> or styleInBackgroundProcess:, depending in the size of the text. >> Then, PluggableTextMorph>>#setText: >> calls PluggableTextMorph>>#setTextBasic:, which calls >> PluggableTextMorph>>#hasUnacceptedEdits: which in turn >> calls again styleInBackgroundProcess:. >> So when you set the text if the size of the text is small Shout will try >> to style the text with and without a background process. If you call >> hasUnacceptedEdits: >> manually when initializing the morph then three processes will be started >> for doing the styling. >> >> Removing the calls to styleInBackgroundProcess: from >> PluggableTextMorph>>#hasUnacceptedEdits: and >> PluggableTextMorph>>#basicHasUnacceptedEdits:. >> also solves the problem with the changing selection. >> >> Cheers, >> Andrei >> > > Perhaps we should have... > > sem > waitTimeoutSeconds: 5 > ifSignalled: [ view ifNotNil: [ view stylerStyledInBackground: > text ] ] > ifTimedOut: [ "do nothing" ]. > > cheers -ben >

April 27, 2015

Re: [Pharo-dev] sometimes Shout changes the selection during styling

by Ben Coman

On Mon, Apr 27, 2015 at 8:41 PM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > Hi, > > In the glamour debugger that we use in moose we are now having the > following problem: > - the selection of a PluggableTextMorph is, quite randomly , changed > during styling. > > If I revert the fix for issue 15240 > <https://pharo.fogbugz.com/f/cases/15240> then it works ok. > Also if I change in SHTextStyler>>#styleInBackgroundProcess: from > > sem waitTimeoutSeconds: 5. > view ifNotNil: [ view stylerStyledInBackground: text ] > > to: > > (sem waitTimeoutSeconds: 5) ifFalse: [ > view ifNotNil: [ view stylerStyledInBackground: text ] ] > > it works ok. In the second snippet we only do the styling if the styler > completed. > > > If I look at the senders of styleInBackgroundProcess: there is another > strange issue. > First PluggableTextMorph>>#setText: calls either style: > or styleInBackgroundProcess:, depending in the size of the text. > Then, PluggableTextMorph>>#setText: > calls PluggableTextMorph>>#setTextBasic:, which calls > PluggableTextMorph>>#hasUnacceptedEdits: which in turn > calls again styleInBackgroundProcess:. > So when you set the text if the size of the text is small Shout will try > to style the text with and without a background process. If you call > hasUnacceptedEdits: > manually when initializing the morph then three processes will be started > for doing the styling. > > Removing the calls to styleInBackgroundProcess: from > PluggableTextMorph>>#hasUnacceptedEdits: and > PluggableTextMorph>>#basicHasUnacceptedEdits:. > also solves the problem with the changing selection. > > Cheers, > Andrei > Perhaps we should have... sem waitTimeoutSeconds: 5 ifSignalled: [ view ifNotNil: [ view stylerStyledInBackground: text ] ] ifTimedOut: [ "do nothing" ]. cheers -ben

April 27, 2015

Re: [Pharo-dev] Fogbugz Area

by Esteban Lorenzano

> On 27 Apr 2015, at 17:44, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > EstebanLM wrote >>> Which is the appropriate one >> None. > > Meaning a) it doesn't matter or b) we need to create a new one? meaning: we are over designing out bug tracker and it will be a pain in the not so far future. We need to apply a refactor there :) > > > EstebanLM wrote >> the monkey now can check also configurations > > Ah, I see now... Cool! > <http://forum.world.st/file/n4822212/Screenshot_2015-04-27_11.png> exactly :) > > > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/Fogbugz-Area-tp4822198p4822212.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

April 27, 2015

Re: [Pharo-dev] Fogbugz Area

by Sean P. DeNigris

EstebanLM wrote >> Which is the appropriate one > None. Meaning a) it doesn't matter or b) we need to create a new one? EstebanLM wrote > the monkey now can check also configurations Ah, I see now... Cool! <http://forum.world.st/file/n4822212/Screenshot_2015-04-27_11.png> ----- Cheers, Sean -- View this message in context: http://forum.world.st/Fogbugz-Area-tp4822198p4822212.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 27, 2015

Re: [Pharo-dev] Tx Pass

by Nicolai Hess

2015-04-27 16:49 GMT+02:00 Sean P. DeNigris <sean(a)clipperadams.com>: > Sean P. DeNigris wrote > > Issue 15414: TxText Cleanup for Pharo 5.0 #1 > > https://pharo.fogbugz.com/default.asp?15414 > > It would be great to get this into the image ASAP so I can keep working on > it :) > I created a new configuration with your fixes and put it in the inbox (issue 15414 <https://pharo.fogbugz.com/default.asp?15414>). It would be great to have some more reviewers and if other people talk about their changes as well. (There were other new version of the packages that are not included (mostly from camille teruel). As no one else actively maintained the txtext repository, I stepped in to help. But if no one talks to me about the changes, they won't be included) nicolai > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/Tx-Pass-tp4822173p4822199.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

April 27, 2015

Re: [Pharo-dev] Fogbugz Area

by Esteban Lorenzano

> On 27 Apr 2015, at 16:47, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > External projects have various "Areas" - External, Misc, Image. Which is the > appropriate one and will that automatically make the monkey skip the issue? None. Also the monkey now can check also configurations so you do not need to skip them (but in case you still want to skip them, you can use the tag ânoMonkeyâ). Esteban > > > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/Fogbugz-Area-tp4822198.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

April 27, 2015

Re: [Pharo-dev] Tx Pass

by Sean P. DeNigris

Sean P. DeNigris wrote > Design Questions... I also started https://github.com/pharo-project/pharo-workingRoadmaps/blob/master/TxTextRo… to capture the result ----- Cheers, Sean -- View this message in context: http://forum.world.st/Tx-Pass-tp4822173p4822202.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 27, 2015

Re: [Pharo-dev] Tx Pass

by Sean P. DeNigris

Sean P. DeNigris wrote > Issue 15414: TxText Cleanup for Pharo 5.0 #1 > https://pharo.fogbugz.com/default.asp?15414 It would be great to get this into the image ASAP so I can keep working on it :) ----- Cheers, Sean -- View this message in context: http://forum.world.st/Tx-Pass-tp4822173p4822199.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 27, 2015

Fogbugz Area

by Sean P. DeNigris

External projects have various "Areas" - External, Misc, Image. Which is the appropriate one and will that automatically make the monkey skip the issue? ----- Cheers, Sean -- View this message in context: http://forum.world.st/Fogbugz-Area-tp4822198.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 27, 2015

Re: [Pharo-dev] Tx Pass

by Sean P. DeNigris

Sean P. DeNigris wrote > I did a first pass I made some of the more obvious fixes/enhancements... Issue 15414: TxText Cleanup for Pharo 5.0 #1 Fixes in Tx repo: TxText-Styler-SeanDeNigris.4 - Update for TxCursorAttribute to TxMouseCursorAttribute rename TxText-Model-SeanDeNigris.52 Higher-level: - Rename TxCursorAttribute to TxMouseCursorAttribute; we must differentiate between the insertion cursor, which is already named the "Cursor" Cleanups: - Rename TxModel>>#setNewContents, which does not follow Constructor Parameter Method, to #initializeContents - Many comment enhancements - Several small refactorings - Extract TxInterval>>#normalize to return a copy with start < end; this logic was duplicated everywhere TxText-Athens-SeanDeNigris.45 Higher-level: - Initial TxBlockCursor implementation as an experiment, mostly copied from TxCaretCursor. It might be to have a pluggable drawing strategy instead of a whole separate class... Cleanups: - Many comment enhancements - Several small refactorings ----- Cheers, Sean -- View this message in context: http://forum.world.st/Tx-Pass-tp4822173p4822193.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 27, 2015