March 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Code review tools?

by Esteban A. Maringolo

2013/3/11 Frank Shearar <frank.shearar(a)gmail.com> > > On 11 March 2013 13:34, Igor Stasenko <siguctua(a)gmail.com> wrote: > > i am very happy that github exists.. and its features available only if you > > put code there.. > > but if code is not on github, then what you will do? > > To rephrase the question: what do we still need to do before we can > integrate (something like) github into a standard Smalltalk workflow? I totally agree on that. But Github is great if your project is open source or you're willing to pay for private repos. On the other hand, BitBucket.org has free private repositories. But it doesn't have code review. In my case it is not a required feature, and I'd go for the already implemented Github alternative. Every time I see smalltalkers forking away from established mainstream solutions/practices I hear a big noise inside my head. On the opposite, whenever I see stuff like the CI integrations, FileTree, standards compliance, and so on, I'm really happy. Regards, Esteban.

March 11, 2013

Re: [Pharo-project] Code review tools?

by Frank Shearar

On 11 March 2013 13:34, Igor Stasenko <siguctua(a)gmail.com> wrote: > On 11 March 2013 09:09, Frank Shearar <frank.shearar(a)gmail.com> wrote: >> On 11 March 2013 02:19, Sean P. DeNigris <sean(a)clipperadams.com> wrote: >>> Igor Stasenko wrote >>>> what would be really cool to have is to integrate some steroids into >>>> diff viewer where guy B can press "create a review report" >>>> and write his comments directly under selected change .. then post it >>>> somewhere on web (or send emal), >>>> so guy A can see directly which of his changes made guy B unhappy. >>> >>> This would be very cool. For me, this is one of github's killer features. >>> Dale and I were having conversations about particular statements right in >>> the diff for the commit. What makes it even more crazy is that there is >>> markup to hyperlink to issues/users/etc >> >> It's probably less work to get tools working with github than it is to >> re-invent an in-image github. >> > i am very happy that github exists.. and its features available only if you > put code there.. > but if code is not on github, then what you will do? To rephrase the question: what do we still need to do before we can integrate (something like) github into a standard Smalltalk workflow? frank >> frank >> >>> Sean >> > > > > -- > Best regards, > Igor Stasenko. >

March 11, 2013

Re: [Pharo-project] Code review tools?

by Igor Stasenko

On 11 March 2013 09:09, Frank Shearar <frank.shearar(a)gmail.com> wrote: > On 11 March 2013 02:19, Sean P. DeNigris <sean(a)clipperadams.com> wrote: >> Igor Stasenko wrote >>> what would be really cool to have is to integrate some steroids into >>> diff viewer where guy B can press "create a review report" >>> and write his comments directly under selected change .. then post it >>> somewhere on web (or send emal), >>> so guy A can see directly which of his changes made guy B unhappy. >> >> This would be very cool. For me, this is one of github's killer features. >> Dale and I were having conversations about particular statements right in >> the diff for the commit. What makes it even more crazy is that there is >> markup to hyperlink to issues/users/etc > > It's probably less work to get tools working with github than it is to > re-invent an in-image github. > i am very happy that github exists.. and its features available only if you put code there.. but if code is not on github, then what you will do? > frank > >> Sean > -- Best regards, Igor Stasenko.

March 11, 2013

Re: [Pharo-project] Help with MenuMorph

by jannik laval

Hi Stef, I am searching to do that too. For now, I am using something else... And I plan to create new Menu more usable. Here is what I use, for your case, just adapt it when trying: === | aMenu sz on | on := soundInput isRecording. self stop. aMenu := MenuMorph new title: ('FFT size (currently {1})' translated format:{fft n}). ((7 to: 10) collect: [:n | 2 raisedTo: n]) do: [:r | aMenu add: r printString target: FFT selector: #new argument: r ]. aMenu popUpInWorld. self resetDisplay. on ifTrue: [self start]. === Jannik 2013/3/11 stephane ducasse <stephane.ducasse(a)free.fr> > In fact I see that the problem is more into > > how can I specify a menu item which returns a value that I specify without > passing a symbol > > ((7 to: 10) collect: [:n | 2 raisedTo: n]) do: [:r | aMenu > add: r printString action: r]. > > > On Mar 11, 2013, at 1:28 PM, StÃ©phane Ducasse <Stephane.Ducasse(a)inria.fr> > wrote: > > > HI guys > > > > I'm trying to fix all the sound interface for 2.0 and I got trapped into > MenuMorph. How do I schedule a menu and get its selected value? > > I have to convert code like the following one. > > > > > > > > | aMenu sz on | > > aMenu := MenuMorph new title: ('FFT size (currently {1})' > translated format:{fft n}). > > ((7 to: 10) collect: [:n | 2 raisedTo: n]) do: [:r | aMenu add: r > printString action: r]. > > > > sz := aMenu popUpInWorld. > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > how can I get the selected value? > > > > > > sz ifNil: [^ self]. > > on := soundInput isRecording. > > self stop. > > fft := FFT new: sz. > > self resetDisplay. > > on ifTrue: [self start]. > > > > > > > -- ~~Dr. Jannik Laval~~ Ãcole des Mines de Douai Enseignant-chercheur http://www.jannik-laval.eu

March 11, 2013

Re: [Pharo-project] migration to FogBugz

by Ben Coman

Camillo Bruni wrote: > that implies that we have to migrate the PharoInbox :) > otherwise we will have a mess of higher order matching slices numbers and issue numbers on fogbugz. > > On 2013-03-10, at 18:13, Benjamin <benjamin.vanryseghem.pharo(a)gmail.com> wrote: > >> The problem is that you can not specify a id for issue while migrating. >> This might not be useful at this stage, but I would guess that starting with an empty Fogbugz tracker, you could create a blank case, then suck the matching case number from Google, after which you update the Fogbugz case title. -ben >> To prevent collision, the issues reported to fogbugz should start at id: 10000. >> >> Ben >> >> On Mar 10, 2013, at 4:34 PM, Ben Coman <btc(a)openInWorld.com> wrote: >> >> >>> I just noticed (for example) that https://code.google.com/p/pharo/issues/detail?id=6763 >>> has been migrated as https://pharo.fogbugz.com/f/cases/6700. >>> >>> Is that change of issue number a concern to break the convention of slice names matching issue numbers >>> as well as historical issue cross referencing? >>> >>> hope I'm missing something.. >>> >>> regards -ben >>> >>> >>> >>> > > > >

March 11, 2013

Re: [Pharo-project] Help with MenuMorph

by stephane ducasse

In fact I see that the problem is more into how can I specify a menu item which returns a value that I specify without passing a symbol ((7 to: 10) collect: [:n | 2 raisedTo: n]) do: [:r | aMenu add: r printString action: r]. On Mar 11, 2013, at 1:28 PM, StÃ©phane Ducasse <Stephane.Ducasse(a)inria.fr> wrote: > HI guys > > I'm trying to fix all the sound interface for 2.0 and I got trapped into MenuMorph. How do I schedule a menu and get its selected value? > I have to convert code like the following one. > > > > | aMenu sz on | > aMenu := MenuMorph new title: ('FFT size (currently {1})' translated format:{fft n}). > ((7 to: 10) collect: [:n | 2 raisedTo: n]) do: [:r | aMenu add: r printString action: r]. > > sz := aMenu popUpInWorld. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > how can I get the selected value? > > > sz ifNil: [^ self]. > on := soundInput isRecording. > self stop. > fft := FFT new: sz. > self resetDisplay. > on ifTrue: [self start]. > >

March 11, 2013

[Pharo-project] Help with MenuMorph

by StÃ©phane Ducasse

HI guys I'm trying to fix all the sound interface for 2.0 and I got trapped into MenuMorph. How do I schedule a menu and get its selected value? I have to convert code like the following one. | aMenu sz on | aMenu := MenuMorph new title: ('FFT size (currently {1})' translated format:{fft n}). ((7 to: 10) collect: [:n | 2 raisedTo: n]) do: [:r | aMenu add: r printString action: r]. sz := aMenu popUpInWorld. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ how can I get the selected value? sz ifNil: [^ self]. on := soundInput isRecording. self stop. fft := FFT new: sz. self resetDisplay. on ifTrue: [self start].

March 11, 2013

Re: [Pharo-project] Porting SmaCC from 1.4 to 2.0; doSilently: equivalent ?

by stephane ducasse

> > I can. > > I'll try to make sure I test it with a larger set of tests next, but, so far, the only change I had to do was that doSilently: thing. > > Now, would anyone has a nice configuration showing how to customize for Pharo 2.0/Pharo 1.4 ? The idea is that you have your baseline and version then you add symbolic version stable: spec <symbolicVersion: #'stable'> spec for: #'common' version: '1.1'. spec for: #'pharo1.4.x' version: '1.4' spec for: #'pharo2.0.x' version: '1.8' Have a look at the metacello chapter >>> and I'm looking for the equivalent to >>> SystemChangeNotifier>>__doSilently:. Is it >>> SystemAnnouncer>>__suspendAllWhile:? >>> >>> (doSilently: is used in SmaCC tests). >>> >>> >>> There is also a nice #valueWithoutNotifications in BlockClosure. >>> >>> BTW, does it make sense to port SmaCC? >> >> faster >> more compact >>> Which use case do you have in which you prefer SmaCC over say PetitParse? >>> I took a look few weeks ago to something done in SmaCC and it was full >>> of ugly unmaintainable class side tablesâ¦.. >> >> you do not have to read the assembly code of your Smalltalk programs. :) >> >> Smacc represents the traditional way to build parser and it is important >> to also have it around and kicking. > > It could be nice to upgrade Pharo's SmaCC to the GLR parsing which exists in SmaCC for VW and Dolphin. Yes! Definitively. Stef

March 11, 2013

Re: [Pharo-project] Porting SmaCC from 1.4 to 2.0; doSilently: equivalent ?

by Goubier Thierry

Le 08/03/2013 22:17, stephane ducasse a Ã©crit : >> >> Hi, >> >> I'm trying to port SmaCC to 2.0 > > Cool can you publish it in PharoExtras? > I would like to have it there + a wonderful set of tests automatically > triggered on a nice integration server :) I can. I'll try to make sure I test it with a larger set of tests next, but, so far, the only change I had to do was that doSilently: thing. Now, would anyone has a nice configuration showing how to customize for Pharo 2.0/Pharo 1.4 ? > >> and I'm looking for the equivalent to >> SystemChangeNotifier>>__doSilently:. Is it >> SystemAnnouncer>>__suspendAllWhile:? >> >> (doSilently: is used in SmaCC tests). >> >> >> There is also a nice #valueWithoutNotifications in BlockClosure. >> >> BTW, does it make sense to port SmaCC? > > faster > more compact >> Which use case do you have in which you prefer SmaCC over say PetitParse? >> I took a look few weeks ago to something done in SmaCC and it was full >> of ugly unmaintainable class side tablesâ¦.. > > you do not have to read the assembly code of your Smalltalk programs. :) > > Smacc represents the traditional way to build parser and it is important > to also have it around and kicking. It could be nice to upgrade Pharo's SmaCC to the GLR parsing which exists in SmaCC for VW and Dolphin. Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95

March 11, 2013

Re: [Pharo-project] Code review tools?

by Camillo Bruni

On 2013-03-11, at 09:09, Frank Shearar <frank.shearar(a)gmail.com> wrote: > On 11 March 2013 02:19, Sean P. DeNigris <sean(a)clipperadams.com> wrote: >> Igor Stasenko wrote >>> what would be really cool to have is to integrate some steroids into >>> diff viewer where guy B can press "create a review report" >>> and write his comments directly under selected change .. then post it >>> somewhere on web (or send emal), >>> so guy A can see directly which of his changes made guy B unhappy. >> >> This would be very cool. For me, this is one of github's killer features. >> Dale and I were having conversations about particular statements right in >> the diff for the commit. What makes it even more crazy is that there is >> markup to hyperlink to issues/users/etc > > It's probably less work to get tools working with github than it is to > re-invent an in-image github. there is torch http://soft.vub.ac.be/torch/Home.html by VerÃ³nica Uquillas GÃ³mez which I presume does most of the things you want. AFAIK it doesn't run on 2.0 yet, maybe I am wrong ;). Besides that we have Erwann doing and internship here working on validation of Configurations, which is also going into the same direction. The we have CodeCritics for validating code, which BTW is already in the image.

March 11, 2013